From: Chen-Yu Tsai <wens@csie.org> To: Dinghao Liu <dinghao.liu@zju.edu.cn> Cc: Kangjie Lu <kjlu@umn.edu>, linux-rtc@vger.kernel.org, Alessandro Zummo <a.zummo@towertech.it>, Alexandre Belloni <alexandre.belloni@bootlin.com>, linux-kernel <linux-kernel@vger.kernel.org>, Maxime Ripard <mripard@kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH] rtc: sun6i: Fix memleak in sun6i_rtc_clk_init Date: Tue, 25 Aug 2020 22:51:33 +0800 [thread overview] Message-ID: <CAGb2v640zTha1tzjOo3L+=T=N3hDRG+8qf2xu+bD8BMUnkhORQ@mail.gmail.com> (raw) In-Reply-To: <20200823075815.23457-1-dinghao.liu@zju.edu.cn> On Sun, Aug 23, 2020 at 3:59 PM Dinghao Liu <dinghao.liu@zju.edu.cn> wrote: > > When clk_hw_register_fixed_rate_with_accuracy() fails, > clk_data should be freed. It's the same for the subsequent > error paths. I suppose you should also unregister the already registered clocks in the latter two error paths? > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> > --- > drivers/rtc/rtc-sun6i.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c > index e2b8b150bcb4..a837c5a40508 100644 > --- a/drivers/rtc/rtc-sun6i.c > +++ b/drivers/rtc/rtc-sun6i.c > @@ -272,7 +272,7 @@ static void __init sun6i_rtc_clk_init(struct device_node *node, > 300000000); > if (IS_ERR(rtc->int_osc)) { > pr_crit("Couldn't register the internal oscillator\n"); > - return; > + goto err; > } > > parents[0] = clk_hw_get_name(rtc->int_osc); > @@ -290,7 +290,7 @@ static void __init sun6i_rtc_clk_init(struct device_node *node, > rtc->losc = clk_register(NULL, &rtc->hw); > if (IS_ERR(rtc->losc)) { > pr_crit("Couldn't register the LOSC clock\n"); > - return; > + goto err; > } > > of_property_read_string_index(node, "clock-output-names", 1, > @@ -301,7 +301,7 @@ static void __init sun6i_rtc_clk_init(struct device_node *node, > &rtc->lock); > if (IS_ERR(rtc->ext_losc)) { > pr_crit("Couldn't register the LOSC external gate\n"); > - return; > + goto err; > } > > clk_data->num = 2; > -- > 2.17.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Chen-Yu Tsai <wens@csie.org> To: Dinghao Liu <dinghao.liu@zju.edu.cn> Cc: linux-rtc@vger.kernel.org, Alessandro Zummo <a.zummo@towertech.it>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Kangjie Lu <kjlu@umn.edu>, linux-kernel <linux-kernel@vger.kernel.org>, Maxime Ripard <mripard@kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH] rtc: sun6i: Fix memleak in sun6i_rtc_clk_init Date: Tue, 25 Aug 2020 22:51:33 +0800 [thread overview] Message-ID: <CAGb2v640zTha1tzjOo3L+=T=N3hDRG+8qf2xu+bD8BMUnkhORQ@mail.gmail.com> (raw) In-Reply-To: <20200823075815.23457-1-dinghao.liu@zju.edu.cn> On Sun, Aug 23, 2020 at 3:59 PM Dinghao Liu <dinghao.liu@zju.edu.cn> wrote: > > When clk_hw_register_fixed_rate_with_accuracy() fails, > clk_data should be freed. It's the same for the subsequent > error paths. I suppose you should also unregister the already registered clocks in the latter two error paths? > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> > --- > drivers/rtc/rtc-sun6i.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/rtc/rtc-sun6i.c b/drivers/rtc/rtc-sun6i.c > index e2b8b150bcb4..a837c5a40508 100644 > --- a/drivers/rtc/rtc-sun6i.c > +++ b/drivers/rtc/rtc-sun6i.c > @@ -272,7 +272,7 @@ static void __init sun6i_rtc_clk_init(struct device_node *node, > 300000000); > if (IS_ERR(rtc->int_osc)) { > pr_crit("Couldn't register the internal oscillator\n"); > - return; > + goto err; > } > > parents[0] = clk_hw_get_name(rtc->int_osc); > @@ -290,7 +290,7 @@ static void __init sun6i_rtc_clk_init(struct device_node *node, > rtc->losc = clk_register(NULL, &rtc->hw); > if (IS_ERR(rtc->losc)) { > pr_crit("Couldn't register the LOSC clock\n"); > - return; > + goto err; > } > > of_property_read_string_index(node, "clock-output-names", 1, > @@ -301,7 +301,7 @@ static void __init sun6i_rtc_clk_init(struct device_node *node, > &rtc->lock); > if (IS_ERR(rtc->ext_losc)) { > pr_crit("Couldn't register the LOSC external gate\n"); > - return; > + goto err; > } > > clk_data->num = 2; > -- > 2.17.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-25 14:51 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-23 7:58 [PATCH] rtc: sun6i: Fix memleak in sun6i_rtc_clk_init Dinghao Liu 2020-08-23 7:58 ` Dinghao Liu 2020-08-25 14:51 ` Chen-Yu Tsai [this message] 2020-08-25 14:51 ` Chen-Yu Tsai 2020-08-26 8:55 ` dinghao.liu 2020-08-26 8:55 ` dinghao.liu 2020-10-09 20:57 ` Alexandre Belloni 2020-10-09 20:57 ` Alexandre Belloni 2020-10-18 6:00 ` dinghao.liu 2020-10-18 6:00 ` dinghao.liu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAGb2v640zTha1tzjOo3L+=T=N3hDRG+8qf2xu+bD8BMUnkhORQ@mail.gmail.com' \ --to=wens@csie.org \ --cc=a.zummo@towertech.it \ --cc=alexandre.belloni@bootlin.com \ --cc=dinghao.liu@zju.edu.cn \ --cc=kjlu@umn.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rtc@vger.kernel.org \ --cc=mripard@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.