From: Bjorn Andersson <andersson@kernel.org> To: Elliot Berman <quic_eberman@quicinc.com> Cc: Alex Elder <elder@linaro.org>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Prakruthi Deepak Heragu <quic_pheragu@quicinc.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Murali Nalajala <quic_mnalajal@quicinc.com>, Trilok Soni <quic_tsoni@quicinc.com>, Srivatsa Vaddagiri <quic_svaddagi@quicinc.com>, Carl van Schaik <quic_cvanscha@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Jonathan Corbet <corbet@lwn.net>, Bagas Sanjaya <bagasdotme@gmail.com>, Andy Gross <agross@kernel.org>, Jassi Brar <jassisinghbrar@gmail.com>, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v14 05/25] virt: gunyah: msgq: Add hypercalls to send and receive messages Date: Fri, 4 Aug 2023 20:51:17 -0700 [thread overview] Message-ID: <6uyzkx2cvfcz2vrosbj7crrzwo4emi2qitudnmzwh6t7fwqpez@lpg2yqkqgah5> (raw) In-Reply-To: <20230613172054.3959700-6-quic_eberman@quicinc.com> On Tue, Jun 13, 2023 at 10:20:33AM -0700, Elliot Berman wrote: > Add hypercalls to send and receive messages on a Gunyah message queue. > > Reviewed-by: Alex Elder <elder@linaro.org> > Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > Signed-off-by: Elliot Berman <quic_eberman@quicinc.com> > --- > arch/arm64/gunyah/gunyah_hypercall.c | 31 ++++++++++++++++++++++++++++ > include/linux/gunyah.h | 6 ++++++ > 2 files changed, 37 insertions(+) > > diff --git a/arch/arm64/gunyah/gunyah_hypercall.c b/arch/arm64/gunyah/gunyah_hypercall.c > index ef48e0b8b5448..c5bf0dd468ec9 100644 > --- a/arch/arm64/gunyah/gunyah_hypercall.c > +++ b/arch/arm64/gunyah/gunyah_hypercall.c > @@ -35,6 +35,8 @@ EXPORT_SYMBOL_GPL(arch_is_gh_guest); > fn) > > #define GH_HYPERCALL_HYP_IDENTIFY GH_HYPERCALL(0x8000) > +#define GH_HYPERCALL_MSGQ_SEND GH_HYPERCALL(0x801B) > +#define GH_HYPERCALL_MSGQ_RECV GH_HYPERCALL(0x801C) > > /** > * gh_hypercall_hyp_identify() - Returns build information and feature flags > @@ -54,5 +56,34 @@ void gh_hypercall_hyp_identify(struct gh_hypercall_hyp_identify_resp *hyp_identi > } > EXPORT_SYMBOL_GPL(gh_hypercall_hyp_identify); > > +enum gh_error gh_hypercall_msgq_send(u64 capid, size_t size, void *buff, u64 tx_flags, bool *ready) I find the name "ready" unclear, I believe it will be true to indicate that the message queue is not full (i.e. Gunyah is ready to receive another message?) Naming it "full" and reversing the values would make this immediately obvious. > +{ > + struct arm_smccc_res res; > + > + arm_smccc_1_1_hvc(GH_HYPERCALL_MSGQ_SEND, capid, size, (uintptr_t)buff, tx_flags, 0, &res); > + > + if (res.a0 == GH_ERROR_OK) > + *ready = !!res.a1; > + > + return res.a0; > +} > +EXPORT_SYMBOL_GPL(gh_hypercall_msgq_send); > + > +enum gh_error gh_hypercall_msgq_recv(u64 capid, void *buff, size_t size, size_t *recv_size, > + bool *ready) And this "ready" seems to be "more data available". Naming it "empty", and reversing the values, would make this obvious. Perhaps when working with the hypercalls on a regular basis it makes sense to not invert the value space...renaming the two "ready" would be beneficial regardless. > +{ > + struct arm_smccc_res res; > + > + arm_smccc_1_1_hvc(GH_HYPERCALL_MSGQ_RECV, capid, (uintptr_t)buff, size, 0, &res); > + > + if (res.a0 == GH_ERROR_OK) { > + *recv_size = res.a1; > + *ready = !!res.a2; > + } > + > + return res.a0; > +} > +EXPORT_SYMBOL_GPL(gh_hypercall_msgq_recv); > + > MODULE_LICENSE("GPL"); > MODULE_DESCRIPTION("Gunyah Hypervisor Hypercalls"); > diff --git a/include/linux/gunyah.h b/include/linux/gunyah.h > index 6b36cf4787efb..01a6f202d037e 100644 > --- a/include/linux/gunyah.h > +++ b/include/linux/gunyah.h > @@ -111,4 +111,10 @@ static inline u16 gh_api_version(const struct gh_hypercall_hyp_identify_resp *gh > > void gh_hypercall_hyp_identify(struct gh_hypercall_hyp_identify_resp *hyp_identity); > > +#define GH_HYPERCALL_MSGQ_TX_FLAGS_PUSH BIT(0) Unless the flags are growing, passing this as a bool push instead of a flag field seems reasonable. > + > +enum gh_error gh_hypercall_msgq_send(u64 capid, size_t size, void *buff, u64 tx_flags, bool *ready); > +enum gh_error gh_hypercall_msgq_recv(u64 capid, void *buff, size_t size, size_t *recv_size, > + bool *ready); Please wrap things to 80 characters, unless going a little bit over makes things more readable. Regards, Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <andersson@kernel.org> To: Elliot Berman <quic_eberman@quicinc.com> Cc: Alex Elder <elder@linaro.org>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Prakruthi Deepak Heragu <quic_pheragu@quicinc.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Murali Nalajala <quic_mnalajal@quicinc.com>, Trilok Soni <quic_tsoni@quicinc.com>, Srivatsa Vaddagiri <quic_svaddagi@quicinc.com>, Carl van Schaik <quic_cvanscha@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Jonathan Corbet <corbet@lwn.net>, Bagas Sanjaya <bagasdotme@gmail.com>, Andy Gross <agross@kernel.org>, Jassi Brar <jassisinghbrar@gmail.com>, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v14 05/25] virt: gunyah: msgq: Add hypercalls to send and receive messages Date: Fri, 4 Aug 2023 20:51:17 -0700 [thread overview] Message-ID: <6uyzkx2cvfcz2vrosbj7crrzwo4emi2qitudnmzwh6t7fwqpez@lpg2yqkqgah5> (raw) In-Reply-To: <20230613172054.3959700-6-quic_eberman@quicinc.com> On Tue, Jun 13, 2023 at 10:20:33AM -0700, Elliot Berman wrote: > Add hypercalls to send and receive messages on a Gunyah message queue. > > Reviewed-by: Alex Elder <elder@linaro.org> > Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > Signed-off-by: Elliot Berman <quic_eberman@quicinc.com> > --- > arch/arm64/gunyah/gunyah_hypercall.c | 31 ++++++++++++++++++++++++++++ > include/linux/gunyah.h | 6 ++++++ > 2 files changed, 37 insertions(+) > > diff --git a/arch/arm64/gunyah/gunyah_hypercall.c b/arch/arm64/gunyah/gunyah_hypercall.c > index ef48e0b8b5448..c5bf0dd468ec9 100644 > --- a/arch/arm64/gunyah/gunyah_hypercall.c > +++ b/arch/arm64/gunyah/gunyah_hypercall.c > @@ -35,6 +35,8 @@ EXPORT_SYMBOL_GPL(arch_is_gh_guest); > fn) > > #define GH_HYPERCALL_HYP_IDENTIFY GH_HYPERCALL(0x8000) > +#define GH_HYPERCALL_MSGQ_SEND GH_HYPERCALL(0x801B) > +#define GH_HYPERCALL_MSGQ_RECV GH_HYPERCALL(0x801C) > > /** > * gh_hypercall_hyp_identify() - Returns build information and feature flags > @@ -54,5 +56,34 @@ void gh_hypercall_hyp_identify(struct gh_hypercall_hyp_identify_resp *hyp_identi > } > EXPORT_SYMBOL_GPL(gh_hypercall_hyp_identify); > > +enum gh_error gh_hypercall_msgq_send(u64 capid, size_t size, void *buff, u64 tx_flags, bool *ready) I find the name "ready" unclear, I believe it will be true to indicate that the message queue is not full (i.e. Gunyah is ready to receive another message?) Naming it "full" and reversing the values would make this immediately obvious. > +{ > + struct arm_smccc_res res; > + > + arm_smccc_1_1_hvc(GH_HYPERCALL_MSGQ_SEND, capid, size, (uintptr_t)buff, tx_flags, 0, &res); > + > + if (res.a0 == GH_ERROR_OK) > + *ready = !!res.a1; > + > + return res.a0; > +} > +EXPORT_SYMBOL_GPL(gh_hypercall_msgq_send); > + > +enum gh_error gh_hypercall_msgq_recv(u64 capid, void *buff, size_t size, size_t *recv_size, > + bool *ready) And this "ready" seems to be "more data available". Naming it "empty", and reversing the values, would make this obvious. Perhaps when working with the hypercalls on a regular basis it makes sense to not invert the value space...renaming the two "ready" would be beneficial regardless. > +{ > + struct arm_smccc_res res; > + > + arm_smccc_1_1_hvc(GH_HYPERCALL_MSGQ_RECV, capid, (uintptr_t)buff, size, 0, &res); > + > + if (res.a0 == GH_ERROR_OK) { > + *recv_size = res.a1; > + *ready = !!res.a2; > + } > + > + return res.a0; > +} > +EXPORT_SYMBOL_GPL(gh_hypercall_msgq_recv); > + > MODULE_LICENSE("GPL"); > MODULE_DESCRIPTION("Gunyah Hypervisor Hypercalls"); > diff --git a/include/linux/gunyah.h b/include/linux/gunyah.h > index 6b36cf4787efb..01a6f202d037e 100644 > --- a/include/linux/gunyah.h > +++ b/include/linux/gunyah.h > @@ -111,4 +111,10 @@ static inline u16 gh_api_version(const struct gh_hypercall_hyp_identify_resp *gh > > void gh_hypercall_hyp_identify(struct gh_hypercall_hyp_identify_resp *hyp_identity); > > +#define GH_HYPERCALL_MSGQ_TX_FLAGS_PUSH BIT(0) Unless the flags are growing, passing this as a bool push instead of a flag field seems reasonable. > + > +enum gh_error gh_hypercall_msgq_send(u64 capid, size_t size, void *buff, u64 tx_flags, bool *ready); > +enum gh_error gh_hypercall_msgq_recv(u64 capid, void *buff, size_t size, size_t *recv_size, > + bool *ready); Please wrap things to 80 characters, unless going a little bit over makes things more readable. Regards, Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-05 3:48 UTC|newest] Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-06-13 17:20 [PATCH v14 00/25] Drivers for Gunyah hypervisor Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-13 17:20 ` [PATCH v14 01/25] docs: gunyah: Introduce Gunyah Hypervisor Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-16 16:32 ` Alex Elder 2023-06-16 16:32 ` Alex Elder 2023-07-03 22:41 ` Elliot Berman 2023-07-03 22:41 ` Elliot Berman 2023-07-14 13:35 ` Alex Elder 2023-07-14 13:35 ` Alex Elder 2023-08-05 17:07 ` Bjorn Andersson 2023-08-05 17:07 ` Bjorn Andersson 2023-06-13 17:20 ` [PATCH v14 02/25] dt-bindings: Add binding for gunyah hypervisor Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-16 16:32 ` Alex Elder 2023-06-16 16:32 ` Alex Elder 2023-08-05 3:34 ` Bjorn Andersson 2023-08-05 3:34 ` Bjorn Andersson 2023-06-13 17:20 ` [PATCH v14 03/25] gunyah: Common types and error codes for Gunyah hypercalls Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-08-05 3:39 ` Bjorn Andersson 2023-08-05 3:39 ` Bjorn Andersson 2023-06-13 17:20 ` [PATCH v14 04/25] virt: gunyah: Add hypercalls to identify Gunyah Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-13 17:20 ` [PATCH v14 05/25] virt: gunyah: msgq: Add hypercalls to send and receive messages Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-08-05 3:51 ` Bjorn Andersson [this message] 2023-08-05 3:51 ` Bjorn Andersson 2023-06-13 17:20 ` [PATCH v14 06/25] mailbox: Add Gunyah message queue mailbox Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-16 16:33 ` Alex Elder 2023-06-16 16:33 ` Alex Elder 2023-08-03 0:33 ` Jassi Brar 2023-08-03 0:33 ` Jassi Brar 2023-08-05 4:16 ` Bjorn Andersson 2023-08-05 4:16 ` Bjorn Andersson 2023-06-13 17:20 ` [PATCH v14 07/25] gunyah: rsc_mgr: Add resource manager RPC core Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-08-05 5:02 ` Bjorn Andersson 2023-08-05 5:02 ` Bjorn Andersson 2023-06-13 17:20 ` [PATCH v14 08/25] gunyah: rsc_mgr: Add VM lifecycle RPC Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-08-05 17:18 ` Bjorn Andersson 2023-08-05 17:18 ` Bjorn Andersson 2023-06-13 17:20 ` [PATCH v14 09/25] gunyah: vm_mgr: Introduce basic VM Manager Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-08-05 17:26 ` Bjorn Andersson 2023-08-05 17:26 ` Bjorn Andersson 2023-06-13 17:20 ` [PATCH v14 10/25] gunyah: rsc_mgr: Add RPC for sharing memory Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-08-05 17:55 ` Bjorn Andersson 2023-08-05 17:55 ` Bjorn Andersson 2023-06-13 17:20 ` [PATCH v14 11/25] gunyah: vm_mgr: Add/remove user memory regions Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-16 16:33 ` Alex Elder 2023-06-16 16:33 ` Alex Elder 2023-06-13 17:20 ` [PATCH v14 12/25] gunyah: vm_mgr: Add ioctls to support basic non-proxy VM boot Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-13 17:20 ` [PATCH v14 13/25] samples: Add sample userspace Gunyah VM Manager Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-08-05 18:03 ` Bjorn Andersson 2023-08-05 18:03 ` Bjorn Andersson 2023-06-13 17:20 ` [PATCH v14 14/25] gunyah: rsc_mgr: Add platform ops on mem_lend/mem_reclaim Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-08-05 18:07 ` Bjorn Andersson 2023-08-05 18:07 ` Bjorn Andersson 2023-06-13 17:20 ` [PATCH v14 15/25] virt: gunyah: Add Qualcomm Gunyah platform ops Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-08-05 18:11 ` Bjorn Andersson 2023-08-05 18:11 ` Bjorn Andersson 2023-06-13 17:20 ` [PATCH v14 16/25] docs: gunyah: Document Gunyah VM Manager Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-16 16:34 ` Alex Elder 2023-06-16 16:34 ` Alex Elder 2023-06-13 17:20 ` [PATCH v14 17/25] virt: gunyah: Translate gh_rm_hyp_resource into gunyah_resource Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-08-05 18:15 ` Bjorn Andersson 2023-08-05 18:15 ` Bjorn Andersson 2023-06-13 17:20 ` [PATCH v14 18/25] gunyah: vm_mgr: Add framework for VM Functions Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-16 16:34 ` Alex Elder 2023-06-16 16:34 ` Alex Elder 2023-06-13 17:20 ` [PATCH v14 19/25] virt: gunyah: Add resource tickets Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-13 17:20 ` [PATCH v14 20/25] virt: gunyah: Add IO handlers Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-13 17:20 ` [PATCH v14 21/25] virt: gunyah: Add proxy-scheduled vCPUs Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-13 17:20 ` [PATCH v14 22/25] virt: gunyah: Add hypercalls for sending doorbell Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-13 17:20 ` [PATCH v14 23/25] virt: gunyah: Add irqfd interface Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-16 16:34 ` Alex Elder 2023-06-16 16:34 ` Alex Elder 2023-06-13 17:20 ` [PATCH v14 24/25] virt: gunyah: Add ioeventfd Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-13 17:20 ` [PATCH v14 25/25] MAINTAINERS: Add Gunyah hypervisor drivers section Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-08-05 18:19 ` Bjorn Andersson 2023-08-05 18:19 ` Bjorn Andersson 2023-06-16 16:35 ` [PATCH v14 00/25] Drivers for Gunyah hypervisor Alex Elder 2023-06-16 16:35 ` Alex Elder
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6uyzkx2cvfcz2vrosbj7crrzwo4emi2qitudnmzwh6t7fwqpez@lpg2yqkqgah5 \ --to=andersson@kernel.org \ --cc=agross@kernel.org \ --cc=arnd@arndb.de \ --cc=bagasdotme@gmail.com \ --cc=catalin.marinas@arm.com \ --cc=conor+dt@kernel.org \ --cc=corbet@lwn.net \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=elder@linaro.org \ --cc=gregkh@linuxfoundation.org \ --cc=jassisinghbrar@gmail.com \ --cc=konrad.dybcio@linaro.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=quic_cvanscha@quicinc.com \ --cc=quic_eberman@quicinc.com \ --cc=quic_mnalajal@quicinc.com \ --cc=quic_pheragu@quicinc.com \ --cc=quic_svaddagi@quicinc.com \ --cc=quic_tsoni@quicinc.com \ --cc=robh+dt@kernel.org \ --cc=srinivas.kandagatla@linaro.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.