From: Bjorn Andersson <andersson@kernel.org> To: Elliot Berman <quic_eberman@quicinc.com> Cc: Alex Elder <elder@linaro.org>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Prakruthi Deepak Heragu <quic_pheragu@quicinc.com>, Murali Nalajala <quic_mnalajal@quicinc.com>, Trilok Soni <quic_tsoni@quicinc.com>, Srivatsa Vaddagiri <quic_svaddagi@quicinc.com>, Carl van Schaik <quic_cvanscha@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Jonathan Corbet <corbet@lwn.net>, Bagas Sanjaya <bagasdotme@gmail.com>, Andy Gross <agross@kernel.org>, Jassi Brar <jassisinghbrar@gmail.com>, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v14 17/25] virt: gunyah: Translate gh_rm_hyp_resource into gunyah_resource Date: Sat, 5 Aug 2023 11:15:54 -0700 [thread overview] Message-ID: <erpdi657m5cwh24ofscunqbs3ko2u2brtyiryg7ealif5n5m4i@35mf55xvv5df> (raw) In-Reply-To: <20230613172054.3959700-18-quic_eberman@quicinc.com> On Tue, Jun 13, 2023 at 10:20:45AM -0700, Elliot Berman wrote: > diff --git a/drivers/virt/gunyah/rsc_mgr.c b/drivers/virt/gunyah/rsc_mgr.c [..] > +struct gh_resource *gh_rm_alloc_resource(struct gh_rm *rm, struct gh_rm_hyp_resource *hyp_resource) > +{ > + struct gh_resource *ghrsc; > + int ret; > + > + ghrsc = kzalloc(sizeof(*ghrsc), GFP_KERNEL); > + if (!ghrsc) > + return NULL; > + > + ghrsc->type = hyp_resource->type; > + ghrsc->capid = le64_to_cpu(hyp_resource->cap_id); > + ghrsc->irq = IRQ_NOTCONNECTED; > + ghrsc->rm_label = le32_to_cpu(hyp_resource->resource_label); > + if (hyp_resource->virq) { > + struct gh_irq_chip_data irq_data = { > + .gh_virq = le32_to_cpu(hyp_resource->virq), > + }; > + > + ret = irq_domain_alloc_irqs(rm->irq_domain, 1, NUMA_NO_NODE, &irq_data); > + if (ret < 0) { > + dev_err(rm->dev, > + "Failed to allocate interrupt for resource %d label: %d: %d\n", > + ghrsc->type, ghrsc->rm_label, ret); > + kfree(ghrsc); > + return NULL; > + } else { No need for the else here, the failure case has already returned. > + ghrsc->irq = ret; > + } > + } > + > + return ghrsc; > +} [..] > diff --git a/include/linux/gunyah.h b/include/linux/gunyah.h > index 982e27d10d57f..4b398b59c2c5a 100644 > --- a/include/linux/gunyah.h > +++ b/include/linux/gunyah.h > @@ -27,6 +27,9 @@ struct gh_resource { > enum gh_resource_type type; > u64 capid; > unsigned int irq; > + > + struct list_head list; This is unused. Regards, Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <andersson@kernel.org> To: Elliot Berman <quic_eberman@quicinc.com> Cc: Alex Elder <elder@linaro.org>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Prakruthi Deepak Heragu <quic_pheragu@quicinc.com>, Murali Nalajala <quic_mnalajal@quicinc.com>, Trilok Soni <quic_tsoni@quicinc.com>, Srivatsa Vaddagiri <quic_svaddagi@quicinc.com>, Carl van Schaik <quic_cvanscha@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Jonathan Corbet <corbet@lwn.net>, Bagas Sanjaya <bagasdotme@gmail.com>, Andy Gross <agross@kernel.org>, Jassi Brar <jassisinghbrar@gmail.com>, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v14 17/25] virt: gunyah: Translate gh_rm_hyp_resource into gunyah_resource Date: Sat, 5 Aug 2023 11:15:54 -0700 [thread overview] Message-ID: <erpdi657m5cwh24ofscunqbs3ko2u2brtyiryg7ealif5n5m4i@35mf55xvv5df> (raw) In-Reply-To: <20230613172054.3959700-18-quic_eberman@quicinc.com> On Tue, Jun 13, 2023 at 10:20:45AM -0700, Elliot Berman wrote: > diff --git a/drivers/virt/gunyah/rsc_mgr.c b/drivers/virt/gunyah/rsc_mgr.c [..] > +struct gh_resource *gh_rm_alloc_resource(struct gh_rm *rm, struct gh_rm_hyp_resource *hyp_resource) > +{ > + struct gh_resource *ghrsc; > + int ret; > + > + ghrsc = kzalloc(sizeof(*ghrsc), GFP_KERNEL); > + if (!ghrsc) > + return NULL; > + > + ghrsc->type = hyp_resource->type; > + ghrsc->capid = le64_to_cpu(hyp_resource->cap_id); > + ghrsc->irq = IRQ_NOTCONNECTED; > + ghrsc->rm_label = le32_to_cpu(hyp_resource->resource_label); > + if (hyp_resource->virq) { > + struct gh_irq_chip_data irq_data = { > + .gh_virq = le32_to_cpu(hyp_resource->virq), > + }; > + > + ret = irq_domain_alloc_irqs(rm->irq_domain, 1, NUMA_NO_NODE, &irq_data); > + if (ret < 0) { > + dev_err(rm->dev, > + "Failed to allocate interrupt for resource %d label: %d: %d\n", > + ghrsc->type, ghrsc->rm_label, ret); > + kfree(ghrsc); > + return NULL; > + } else { No need for the else here, the failure case has already returned. > + ghrsc->irq = ret; > + } > + } > + > + return ghrsc; > +} [..] > diff --git a/include/linux/gunyah.h b/include/linux/gunyah.h > index 982e27d10d57f..4b398b59c2c5a 100644 > --- a/include/linux/gunyah.h > +++ b/include/linux/gunyah.h > @@ -27,6 +27,9 @@ struct gh_resource { > enum gh_resource_type type; > u64 capid; > unsigned int irq; > + > + struct list_head list; This is unused. Regards, Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-05 18:13 UTC|newest] Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-06-13 17:20 [PATCH v14 00/25] Drivers for Gunyah hypervisor Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-13 17:20 ` [PATCH v14 01/25] docs: gunyah: Introduce Gunyah Hypervisor Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-16 16:32 ` Alex Elder 2023-06-16 16:32 ` Alex Elder 2023-07-03 22:41 ` Elliot Berman 2023-07-03 22:41 ` Elliot Berman 2023-07-14 13:35 ` Alex Elder 2023-07-14 13:35 ` Alex Elder 2023-08-05 17:07 ` Bjorn Andersson 2023-08-05 17:07 ` Bjorn Andersson 2023-06-13 17:20 ` [PATCH v14 02/25] dt-bindings: Add binding for gunyah hypervisor Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-16 16:32 ` Alex Elder 2023-06-16 16:32 ` Alex Elder 2023-08-05 3:34 ` Bjorn Andersson 2023-08-05 3:34 ` Bjorn Andersson 2023-06-13 17:20 ` [PATCH v14 03/25] gunyah: Common types and error codes for Gunyah hypercalls Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-08-05 3:39 ` Bjorn Andersson 2023-08-05 3:39 ` Bjorn Andersson 2023-06-13 17:20 ` [PATCH v14 04/25] virt: gunyah: Add hypercalls to identify Gunyah Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-13 17:20 ` [PATCH v14 05/25] virt: gunyah: msgq: Add hypercalls to send and receive messages Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-08-05 3:51 ` Bjorn Andersson 2023-08-05 3:51 ` Bjorn Andersson 2023-06-13 17:20 ` [PATCH v14 06/25] mailbox: Add Gunyah message queue mailbox Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-16 16:33 ` Alex Elder 2023-06-16 16:33 ` Alex Elder 2023-08-03 0:33 ` Jassi Brar 2023-08-03 0:33 ` Jassi Brar 2023-08-05 4:16 ` Bjorn Andersson 2023-08-05 4:16 ` Bjorn Andersson 2023-06-13 17:20 ` [PATCH v14 07/25] gunyah: rsc_mgr: Add resource manager RPC core Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-08-05 5:02 ` Bjorn Andersson 2023-08-05 5:02 ` Bjorn Andersson 2023-06-13 17:20 ` [PATCH v14 08/25] gunyah: rsc_mgr: Add VM lifecycle RPC Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-08-05 17:18 ` Bjorn Andersson 2023-08-05 17:18 ` Bjorn Andersson 2023-06-13 17:20 ` [PATCH v14 09/25] gunyah: vm_mgr: Introduce basic VM Manager Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-08-05 17:26 ` Bjorn Andersson 2023-08-05 17:26 ` Bjorn Andersson 2023-06-13 17:20 ` [PATCH v14 10/25] gunyah: rsc_mgr: Add RPC for sharing memory Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-08-05 17:55 ` Bjorn Andersson 2023-08-05 17:55 ` Bjorn Andersson 2023-06-13 17:20 ` [PATCH v14 11/25] gunyah: vm_mgr: Add/remove user memory regions Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-16 16:33 ` Alex Elder 2023-06-16 16:33 ` Alex Elder 2023-06-13 17:20 ` [PATCH v14 12/25] gunyah: vm_mgr: Add ioctls to support basic non-proxy VM boot Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-13 17:20 ` [PATCH v14 13/25] samples: Add sample userspace Gunyah VM Manager Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-08-05 18:03 ` Bjorn Andersson 2023-08-05 18:03 ` Bjorn Andersson 2023-06-13 17:20 ` [PATCH v14 14/25] gunyah: rsc_mgr: Add platform ops on mem_lend/mem_reclaim Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-08-05 18:07 ` Bjorn Andersson 2023-08-05 18:07 ` Bjorn Andersson 2023-06-13 17:20 ` [PATCH v14 15/25] virt: gunyah: Add Qualcomm Gunyah platform ops Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-08-05 18:11 ` Bjorn Andersson 2023-08-05 18:11 ` Bjorn Andersson 2023-06-13 17:20 ` [PATCH v14 16/25] docs: gunyah: Document Gunyah VM Manager Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-16 16:34 ` Alex Elder 2023-06-16 16:34 ` Alex Elder 2023-06-13 17:20 ` [PATCH v14 17/25] virt: gunyah: Translate gh_rm_hyp_resource into gunyah_resource Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-08-05 18:15 ` Bjorn Andersson [this message] 2023-08-05 18:15 ` Bjorn Andersson 2023-06-13 17:20 ` [PATCH v14 18/25] gunyah: vm_mgr: Add framework for VM Functions Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-16 16:34 ` Alex Elder 2023-06-16 16:34 ` Alex Elder 2023-06-13 17:20 ` [PATCH v14 19/25] virt: gunyah: Add resource tickets Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-13 17:20 ` [PATCH v14 20/25] virt: gunyah: Add IO handlers Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-13 17:20 ` [PATCH v14 21/25] virt: gunyah: Add proxy-scheduled vCPUs Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-13 17:20 ` [PATCH v14 22/25] virt: gunyah: Add hypercalls for sending doorbell Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-13 17:20 ` [PATCH v14 23/25] virt: gunyah: Add irqfd interface Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-16 16:34 ` Alex Elder 2023-06-16 16:34 ` Alex Elder 2023-06-13 17:20 ` [PATCH v14 24/25] virt: gunyah: Add ioeventfd Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-06-13 17:20 ` [PATCH v14 25/25] MAINTAINERS: Add Gunyah hypervisor drivers section Elliot Berman 2023-06-13 17:20 ` Elliot Berman 2023-08-05 18:19 ` Bjorn Andersson 2023-08-05 18:19 ` Bjorn Andersson 2023-06-16 16:35 ` [PATCH v14 00/25] Drivers for Gunyah hypervisor Alex Elder 2023-06-16 16:35 ` Alex Elder
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=erpdi657m5cwh24ofscunqbs3ko2u2brtyiryg7ealif5n5m4i@35mf55xvv5df \ --to=andersson@kernel.org \ --cc=agross@kernel.org \ --cc=arnd@arndb.de \ --cc=bagasdotme@gmail.com \ --cc=catalin.marinas@arm.com \ --cc=conor+dt@kernel.org \ --cc=corbet@lwn.net \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=elder@linaro.org \ --cc=gregkh@linuxfoundation.org \ --cc=jassisinghbrar@gmail.com \ --cc=konrad.dybcio@linaro.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=quic_cvanscha@quicinc.com \ --cc=quic_eberman@quicinc.com \ --cc=quic_mnalajal@quicinc.com \ --cc=quic_pheragu@quicinc.com \ --cc=quic_svaddagi@quicinc.com \ --cc=quic_tsoni@quicinc.com \ --cc=robh+dt@kernel.org \ --cc=srinivas.kandagatla@linaro.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.