From: David Hildenbrand <david@redhat.com> To: Yair Podemsky <ypodemsk@redhat.com>, linux@armlinux.org.uk, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, will@kernel.org, aneesh.kumar@linux.ibm.com, akpm@linux-foundation.org, peterz@infradead.org, arnd@arndb.de, keescook@chromium.org, paulmck@kernel.org, jpoimboe@kernel.org, samitolvanen@google.com, frederic@kernel.org, ardb@kernel.org, juerg.haefliger@canonical.com, rmk+kernel@armlinux.org.uk, geert+renesas@glider.be, tony@atomide.com, linus.walleij@linaro.org, sebastian.reichel@collabora.com, nick.hawkins@hpe.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, mtosatti@redhat.com, vschneid@redhat.com, dhildenb@redhat.com Cc: alougovs@redhat.com Subject: Re: [PATCH 1/3] arch: Introduce ARCH_HAS_CPUMASK_BITS Date: Tue, 4 Apr 2023 15:47:56 +0200 [thread overview] Message-ID: <78a31392-8f9b-9705-918a-24edb650f395@redhat.com> (raw) In-Reply-To: <20230404134224.137038-2-ypodemsk@redhat.com> On 04.04.23 15:42, Yair Podemsky wrote: > Some architectures set and maintain the mm_cpumask bits when loading > or removing process from cpu. > This Kconfig will mark those to allow different behavior between > kernels that maintain the mm_cpumask and those that do not. > I was wondering if we should do something along the lines of: diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h index 0722859c3647..1f5c15d8e8ed 100644 --- a/include/linux/mm_types.h +++ b/include/linux/mm_types.h @@ -767,11 +767,13 @@ struct mm_struct { #endif /* CONFIG_LRU_GEN */ } __randomize_layout; +#ifdef CONFIG_MM_CPUMASK /* * The mm_cpumask needs to be at the end of mm_struct, because it * is dynamically sized based on nr_cpu_ids. */ unsigned long cpu_bitmap[]; +#endif }; But that would, of course, require additional changes to make it compile. What concerns me a bit is that we have in mm/rmap.c a mm_cpumask() usage. But it's glued to CONFIG_ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH ... shaky. At least if we would properly fence it, there would be no accidental abuse anymore. > Signed-off-by: Yair Podemsky <ypodemsk@redhat.com> > --- > arch/Kconfig | 8 ++++++++ > arch/arm/Kconfig | 1 + > arch/powerpc/Kconfig | 1 + > arch/s390/Kconfig | 1 + > arch/sparc/Kconfig | 1 + > arch/x86/Kconfig | 1 + As Valentin says, there are other architectures that do the same. -- Thanks, David / dhildenb
WARNING: multiple messages have this Message-ID (diff)
From: David Hildenbrand <david@redhat.com> To: Yair Podemsky <ypodemsk@redhat.com>, linux@armlinux.org.uk, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, will@kernel.org, aneesh.kumar@linux.ibm.com, akpm@linux-foundation.org, peterz@infradead.org, arnd@arndb.de, keescook@chromium.org, paulmck@kernel.org, jpoimboe@kernel.org, samitolvanen@google.com, frederic@kernel.org, ardb@kernel.org, juerg.haefliger@canonical.com, rmk+kernel@armlinux.org.uk, geert+renesas@glider.be, tony@atomide.com, linus.walleij@linaro.org, sebastian.reichel@collabora.com, nick.hawkins@hpe.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, mtosatti@redhat.com, vschneid@redhat.com, dhildenb@redhat.com Cc: alougovs@redhat.com Subject: Re: [PATCH 1/3] arch: Introduce ARCH_HAS_CPUMASK_BITS Date: Tue, 4 Apr 2023 15:47:56 +0200 [thread overview] Message-ID: <78a31392-8f9b-9705-918a-24edb650f395@redhat.com> (raw) In-Reply-To: <20230404134224.137038-2-ypodemsk@redhat.com> On 04.04.23 15:42, Yair Podemsky wrote: > Some architectures set and maintain the mm_cpumask bits when loading > or removing process from cpu. > This Kconfig will mark those to allow different behavior between > kernels that maintain the mm_cpumask and those that do not. > I was wondering if we should do something along the lines of: diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h index 0722859c3647..1f5c15d8e8ed 100644 --- a/include/linux/mm_types.h +++ b/include/linux/mm_types.h @@ -767,11 +767,13 @@ struct mm_struct { #endif /* CONFIG_LRU_GEN */ } __randomize_layout; +#ifdef CONFIG_MM_CPUMASK /* * The mm_cpumask needs to be at the end of mm_struct, because it * is dynamically sized based on nr_cpu_ids. */ unsigned long cpu_bitmap[]; +#endif }; But that would, of course, require additional changes to make it compile. What concerns me a bit is that we have in mm/rmap.c a mm_cpumask() usage. But it's glued to CONFIG_ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH ... shaky. At least if we would properly fence it, there would be no accidental abuse anymore. > Signed-off-by: Yair Podemsky <ypodemsk@redhat.com> > --- > arch/Kconfig | 8 ++++++++ > arch/arm/Kconfig | 1 + > arch/powerpc/Kconfig | 1 + > arch/s390/Kconfig | 1 + > arch/sparc/Kconfig | 1 + > arch/x86/Kconfig | 1 + As Valentin says, there are other architectures that do the same. -- Thanks, David / dhildenb _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-04-04 13:49 UTC|newest] Thread overview: 107+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-04-04 13:42 [PATCH 0/3] send tlb_remove_table_smp_sync IPI only to necessary CPUs Yair Podemsky 2023-04-04 13:42 ` Yair Podemsky 2023-04-04 13:42 ` Yair Podemsky 2023-04-04 13:42 ` [PATCH 1/3] arch: Introduce ARCH_HAS_CPUMASK_BITS Yair Podemsky 2023-04-04 13:42 ` Yair Podemsky 2023-04-04 13:42 ` Yair Podemsky 2023-04-04 13:47 ` David Hildenbrand [this message] 2023-04-04 13:47 ` David Hildenbrand 2023-04-04 13:42 ` [PATCH 2/3] mm/mmu_gather: send tlb_remove_table_smp_sync IPI only to MM CPUs Yair Podemsky 2023-04-04 13:42 ` Yair Podemsky 2023-04-04 13:42 ` Yair Podemsky 2023-04-04 14:57 ` Peter Zijlstra 2023-04-04 14:57 ` Peter Zijlstra 2023-04-04 14:57 ` Peter Zijlstra 2023-04-04 13:42 ` [PATCH 3/3] mm/mmu_gather: send tlb_remove_table_smp_sync IPI only to CPUs in kernel mode Yair Podemsky 2023-04-04 13:42 ` Yair Podemsky 2023-04-04 13:42 ` Yair Podemsky 2023-04-04 14:03 ` David Hildenbrand 2023-04-04 14:03 ` David Hildenbrand 2023-04-04 15:12 ` Peter Zijlstra 2023-04-04 15:12 ` Peter Zijlstra 2023-04-04 15:12 ` Peter Zijlstra 2023-04-04 16:00 ` Peter Zijlstra 2023-04-04 16:00 ` Peter Zijlstra 2023-04-04 16:00 ` Peter Zijlstra 2023-04-05 0:53 ` Hillf Danton 2023-04-05 10:43 ` Frederic Weisbecker 2023-04-05 10:43 ` Frederic Weisbecker 2023-04-05 10:43 ` Frederic Weisbecker 2023-04-05 11:10 ` Frederic Weisbecker 2023-04-05 11:10 ` Frederic Weisbecker 2023-04-05 11:10 ` Frederic Weisbecker 2023-04-05 11:41 ` Peter Zijlstra 2023-04-05 11:41 ` Peter Zijlstra 2023-04-05 11:41 ` Peter Zijlstra 2023-04-05 12:00 ` David Hildenbrand 2023-04-05 12:00 ` David Hildenbrand 2023-04-05 12:00 ` David Hildenbrand 2023-04-05 12:05 ` Frederic Weisbecker 2023-04-05 12:05 ` Frederic Weisbecker 2023-04-05 12:05 ` Frederic Weisbecker 2023-04-05 12:31 ` Frederic Weisbecker 2023-04-05 12:31 ` Frederic Weisbecker 2023-04-05 12:31 ` Frederic Weisbecker 2023-04-05 12:45 ` Valentin Schneider 2023-04-05 12:45 ` Valentin Schneider 2023-04-05 12:45 ` Valentin Schneider 2023-04-06 13:38 ` Peter Zijlstra 2023-04-06 13:38 ` Peter Zijlstra 2023-04-06 13:38 ` Peter Zijlstra 2023-04-06 14:11 ` Valentin Schneider 2023-04-06 14:11 ` Valentin Schneider 2023-04-06 14:11 ` Valentin Schneider 2023-04-06 14:39 ` Peter Zijlstra 2023-04-06 14:39 ` Peter Zijlstra 2023-04-06 14:39 ` Peter Zijlstra 2023-04-05 19:45 ` Marcelo Tosatti 2023-04-05 19:45 ` Marcelo Tosatti 2023-04-05 19:45 ` Marcelo Tosatti 2023-04-05 19:52 ` Peter Zijlstra 2023-04-05 19:52 ` Peter Zijlstra 2023-04-05 19:52 ` Peter Zijlstra 2023-04-06 12:38 ` Marcelo Tosatti 2023-04-06 12:38 ` Marcelo Tosatti 2023-04-06 12:38 ` Marcelo Tosatti 2023-04-06 13:29 ` Peter Zijlstra 2023-04-06 13:29 ` Peter Zijlstra 2023-04-06 13:29 ` Peter Zijlstra 2023-04-06 14:04 ` Peter Zijlstra 2023-04-06 14:04 ` Peter Zijlstra 2023-04-06 14:04 ` Peter Zijlstra 2023-04-06 14:42 ` David Hildenbrand 2023-04-06 14:42 ` David Hildenbrand 2023-04-06 14:42 ` David Hildenbrand 2023-04-06 15:06 ` Peter Zijlstra 2023-04-06 15:06 ` Peter Zijlstra 2023-04-06 15:06 ` Peter Zijlstra 2023-04-06 15:02 ` Peter Zijlstra 2023-04-06 15:02 ` Peter Zijlstra 2023-04-06 15:02 ` Peter Zijlstra 2023-04-06 15:51 ` David Hildenbrand 2023-04-06 15:51 ` David Hildenbrand 2023-04-06 15:51 ` David Hildenbrand 2023-04-06 18:27 ` Peter Zijlstra 2023-04-06 18:27 ` Peter Zijlstra 2023-04-06 18:27 ` Peter Zijlstra 2023-04-19 11:30 ` David Hildenbrand 2023-04-19 11:30 ` David Hildenbrand 2023-04-19 11:30 ` David Hildenbrand 2023-04-19 11:39 ` Marcelo Tosatti 2023-04-19 11:39 ` Marcelo Tosatti 2023-04-19 11:39 ` Marcelo Tosatti 2023-04-05 19:43 ` Marcelo Tosatti 2023-04-05 19:43 ` Marcelo Tosatti 2023-04-05 19:43 ` Marcelo Tosatti 2023-04-05 19:54 ` Peter Zijlstra 2023-04-05 19:54 ` Peter Zijlstra 2023-04-05 19:54 ` Peter Zijlstra 2023-04-06 12:49 ` Marcelo Tosatti 2023-04-06 12:49 ` Marcelo Tosatti 2023-04-06 12:49 ` Marcelo Tosatti 2023-04-06 13:32 ` Peter Zijlstra 2023-04-06 13:32 ` Peter Zijlstra 2023-04-06 13:32 ` Peter Zijlstra 2023-04-19 11:01 ` Marcelo Tosatti 2023-04-19 11:01 ` Marcelo Tosatti 2023-04-19 11:01 ` Marcelo Tosatti
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=78a31392-8f9b-9705-918a-24edb650f395@redhat.com \ --to=david@redhat.com \ --cc=agordeev@linux.ibm.com \ --cc=akpm@linux-foundation.org \ --cc=alougovs@redhat.com \ --cc=aneesh.kumar@linux.ibm.com \ --cc=ardb@kernel.org \ --cc=arnd@arndb.de \ --cc=borntraeger@linux.ibm.com \ --cc=bp@alien8.de \ --cc=christophe.leroy@csgroup.eu \ --cc=dave.hansen@linux.intel.com \ --cc=davem@davemloft.net \ --cc=dhildenb@redhat.com \ --cc=frederic@kernel.org \ --cc=geert+renesas@glider.be \ --cc=gor@linux.ibm.com \ --cc=hca@linux.ibm.com \ --cc=hpa@zytor.com \ --cc=jpoimboe@kernel.org \ --cc=juerg.haefliger@canonical.com \ --cc=keescook@chromium.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arch@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-s390@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mingo@redhat.com \ --cc=mpe@ellerman.id.au \ --cc=mtosatti@redhat.com \ --cc=nick.hawkins@hpe.com \ --cc=npiggin@gmail.com \ --cc=paulmck@kernel.org \ --cc=peterz@infradead.org \ --cc=rmk+kernel@armlinux.org.uk \ --cc=samitolvanen@google.com \ --cc=sebastian.reichel@collabora.com \ --cc=sparclinux@vger.kernel.org \ --cc=svens@linux.ibm.com \ --cc=tglx@linutronix.de \ --cc=tony@atomide.com \ --cc=vschneid@redhat.com \ --cc=will@kernel.org \ --cc=x86@kernel.org \ --cc=ypodemsk@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.