From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Oleksii Kurochko <oleksii.kurochko@gmail.com>,
xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Gianluca Guida <gianluca@rivosinc.com>,
Bob Eshleman <bobbyeshleman@gmail.com>,
Alistair Francis <alistair.francis@wdc.com>,
Connor Davis <connojdavis@gmail.com>
Subject: Re: [PATCH v2 3/3] xen/riscv: disable fpu
Date: Thu, 2 Mar 2023 14:20:06 +0000 [thread overview]
Message-ID: <7f3703a2-83a6-6fad-041c-f2b3df0253df@citrix.com> (raw)
In-Reply-To: <f9bed949656462e9eb9554dc5e0dcccdd722b9cd.1677762812.git.oleksii.kurochko@gmail.com>
On 02/03/2023 1:23 pm, Oleksii Kurochko wrote:
> Disable FPU to detect illegal usage of floating point in kernel
> space.
>
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
> ---
> Changes since v1:
> * Rebase on top of two previous patches.
> ---
Apologies - I meant to ask these on the previous series, but didn't get
around to it.
Why do we disable interrupts at the very start of start(), but only
disable the FPU at the start of C ?
To start with, doesn't OpenSBI have a starting ABI spec? What does that
say on the matter of the enablement of these features on entry into the
environment?
Either way, my gut feeling is that these disables (if necessary to begin
with) should be together, rather than split like this.
That aside, while I can see the value of checking this now, won't we
have to delete this again in order to allow for context switching a
vCPUs FPU register state?
~Andrew
next prev parent reply other threads:[~2023-03-02 14:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 13:23 [PATCH v2 0/3] Do basic initialization things Oleksii Kurochko
2023-03-02 13:23 ` [PATCH v2 1/3] xen/riscv: read/save hart_id and dtb_base passed by bootloader Oleksii Kurochko
2023-03-02 14:02 ` Andrew Cooper
2023-03-02 14:53 ` Oleksii
2023-03-02 18:58 ` Andrew Cooper
2023-03-03 8:48 ` Oleksii
2023-03-02 13:23 ` [PATCH v2 2/3] xen/riscv: initialize .bss section Oleksii Kurochko
2023-03-02 14:12 ` Andrew Cooper
2023-03-02 14:55 ` Oleksii
2023-03-02 14:22 ` Jan Beulich
2023-03-02 15:55 ` Oleksii
2023-03-02 16:01 ` Jan Beulich
2023-03-02 20:34 ` Andrew Cooper
2023-03-02 13:23 ` [PATCH v2 3/3] xen/riscv: disable fpu Oleksii Kurochko
2023-03-02 14:20 ` Andrew Cooper [this message]
2023-03-02 17:11 ` Oleksii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f3703a2-83a6-6fad-041c-f2b3df0253df@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=alistair.francis@wdc.com \
--cc=bobbyeshleman@gmail.com \
--cc=connojdavis@gmail.com \
--cc=gianluca@rivosinc.com \
--cc=jbeulich@suse.com \
--cc=oleksii.kurochko@gmail.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.