From: Jonathan Cameron <jic23@kernel.org> To: "Andrew F. Davis" <afd@ti.com>, Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>, Peter Meerwald-Stadler <pmeerw@pmeerw.net>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Lee Jones <lee.jones@linaro.org>, Dave Gerlach <d-gerlach@ti.com> Cc: linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/8] iio: adc: ti_am335x_adc: use SIMPLE_DEV_PM_OPS helper macro Date: Fri, 3 Jun 2016 13:16:25 +0100 [thread overview] Message-ID: <803110b4-997e-d8d0-dc3e-1ff6279ad202@kernel.org> (raw) In-Reply-To: <20160531170013.2649-3-afd@ti.com> On 31/05/16 18:00, Andrew F. Davis wrote: > Replace ifdefs with SIMPLE_DEV_PM_OPS helper macro. > > Signed-off-by: Andrew F. Davis <afd@ti.com> Applied to the togreg branch of iio.git - initially pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/iio/adc/ti_am335x_adc.c | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) > > diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c > index c1e0553..18af71d 100644 > --- a/drivers/iio/adc/ti_am335x_adc.c > +++ b/drivers/iio/adc/ti_am335x_adc.c > @@ -531,8 +531,7 @@ static int tiadc_remove(struct platform_device *pdev) > return 0; > } > > -#ifdef CONFIG_PM > -static int tiadc_suspend(struct device *dev) > +static int __maybe_unused tiadc_suspend(struct device *dev) > { > struct iio_dev *indio_dev = dev_get_drvdata(dev); > struct tiadc_device *adc_dev = iio_priv(indio_dev); > @@ -550,7 +549,7 @@ static int tiadc_suspend(struct device *dev) > return 0; > } > > -static int tiadc_resume(struct device *dev) > +static int __maybe_unused tiadc_resume(struct device *dev) > { > struct iio_dev *indio_dev = dev_get_drvdata(dev); > struct tiadc_device *adc_dev = iio_priv(indio_dev); > @@ -567,14 +566,7 @@ static int tiadc_resume(struct device *dev) > return 0; > } > > -static const struct dev_pm_ops tiadc_pm_ops = { > - .suspend = tiadc_suspend, > - .resume = tiadc_resume, > -}; > -#define TIADC_PM_OPS (&tiadc_pm_ops) > -#else > -#define TIADC_PM_OPS NULL > -#endif > +static SIMPLE_DEV_PM_OPS(tiadc_pm_ops, tiadc_suspend, tiadc_resume); > > static const struct of_device_id ti_adc_dt_ids[] = { > { .compatible = "ti,am3359-adc", }, > @@ -585,7 +577,7 @@ MODULE_DEVICE_TABLE(of, ti_adc_dt_ids); > static struct platform_driver tiadc_driver = { > .driver = { > .name = "TI-am335x-adc", > - .pm = TIADC_PM_OPS, > + .pm = &tiadc_pm_ops, > .of_match_table = ti_adc_dt_ids, > }, > .probe = tiadc_probe, >
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> To: "Andrew F. Davis" <afd-l0cyMroinI0@public.gmane.org>, Hartmut Knaack <knaack.h-Mmb7MZpHnFY@public.gmane.org>, Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>, Peter Meerwald-Stadler <pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>, Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, Dave Gerlach <d-gerlach-l0cyMroinI0@public.gmane.org> Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH 2/8] iio: adc: ti_am335x_adc: use SIMPLE_DEV_PM_OPS helper macro Date: Fri, 3 Jun 2016 13:16:25 +0100 [thread overview] Message-ID: <803110b4-997e-d8d0-dc3e-1ff6279ad202@kernel.org> (raw) In-Reply-To: <20160531170013.2649-3-afd-l0cyMroinI0@public.gmane.org> On 31/05/16 18:00, Andrew F. Davis wrote: > Replace ifdefs with SIMPLE_DEV_PM_OPS helper macro. > > Signed-off-by: Andrew F. Davis <afd-l0cyMroinI0@public.gmane.org> Applied to the togreg branch of iio.git - initially pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/iio/adc/ti_am335x_adc.c | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) > > diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c > index c1e0553..18af71d 100644 > --- a/drivers/iio/adc/ti_am335x_adc.c > +++ b/drivers/iio/adc/ti_am335x_adc.c > @@ -531,8 +531,7 @@ static int tiadc_remove(struct platform_device *pdev) > return 0; > } > > -#ifdef CONFIG_PM > -static int tiadc_suspend(struct device *dev) > +static int __maybe_unused tiadc_suspend(struct device *dev) > { > struct iio_dev *indio_dev = dev_get_drvdata(dev); > struct tiadc_device *adc_dev = iio_priv(indio_dev); > @@ -550,7 +549,7 @@ static int tiadc_suspend(struct device *dev) > return 0; > } > > -static int tiadc_resume(struct device *dev) > +static int __maybe_unused tiadc_resume(struct device *dev) > { > struct iio_dev *indio_dev = dev_get_drvdata(dev); > struct tiadc_device *adc_dev = iio_priv(indio_dev); > @@ -567,14 +566,7 @@ static int tiadc_resume(struct device *dev) > return 0; > } > > -static const struct dev_pm_ops tiadc_pm_ops = { > - .suspend = tiadc_suspend, > - .resume = tiadc_resume, > -}; > -#define TIADC_PM_OPS (&tiadc_pm_ops) > -#else > -#define TIADC_PM_OPS NULL > -#endif > +static SIMPLE_DEV_PM_OPS(tiadc_pm_ops, tiadc_suspend, tiadc_resume); > > static const struct of_device_id ti_adc_dt_ids[] = { > { .compatible = "ti,am3359-adc", }, > @@ -585,7 +577,7 @@ MODULE_DEVICE_TABLE(of, ti_adc_dt_ids); > static struct platform_driver tiadc_driver = { > .driver = { > .name = "TI-am335x-adc", > - .pm = TIADC_PM_OPS, > + .pm = &tiadc_pm_ops, > .of_match_table = ti_adc_dt_ids, > }, > .probe = tiadc_probe, >
next prev parent reply other threads:[~2016-06-03 12:16 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-05-31 17:00 [PATCH 0/8] TI AM335x TSC/ADC cleanup Andrew F. Davis 2016-05-31 17:00 ` Andrew F. Davis 2016-05-31 17:00 ` [PATCH 1/8] mfd: ti_am335x_tscadc: Use SIMPLE_DEV_PM_OPS helper macro Andrew F. Davis 2016-05-31 17:00 ` Andrew F. Davis 2016-06-08 15:35 ` Lee Jones 2016-06-08 15:35 ` Lee Jones 2016-05-31 17:00 ` [PATCH 2/8] iio: adc: ti_am335x_adc: use " Andrew F. Davis 2016-05-31 17:00 ` Andrew F. Davis 2016-06-03 12:16 ` Jonathan Cameron [this message] 2016-06-03 12:16 ` Jonathan Cameron 2016-05-31 17:00 ` [PATCH 3/8] mfd: ti_am335x_tscadc: Remove use of single line functions Andrew F. Davis 2016-05-31 17:00 ` Andrew F. Davis 2016-06-08 15:35 ` Lee Jones 2016-06-08 15:35 ` Lee Jones 2016-05-31 17:00 ` [PATCH 4/8] mfd: ti_am335x_tscadc: Unify variable naming when refrencing ti_tscadc_dev Andrew F. Davis 2016-05-31 17:00 ` Andrew F. Davis 2016-05-31 17:53 ` Dave Gerlach 2016-05-31 17:53 ` Dave Gerlach 2016-06-08 15:34 ` Lee Jones 2016-05-31 17:00 ` [PATCH 5/8] mfd: ti_am335x_tscadc: Rename regmap_tscadc to regmap Andrew F. Davis 2016-05-31 17:00 ` Andrew F. Davis 2016-06-08 15:33 ` Lee Jones 2016-05-31 17:00 ` [PATCH 6/8] mfd: ti_am335x_tscadc: use variable name for sizeof() operator Andrew F. Davis 2016-05-31 17:00 ` Andrew F. Davis 2016-06-08 15:35 ` Lee Jones 2016-05-31 17:00 ` [PATCH 7/8] iio: adc: ti_am335x_adc: use variable names " Andrew F. Davis 2016-05-31 17:00 ` Andrew F. Davis 2016-06-03 12:15 ` Jonathan Cameron 2016-05-31 17:00 ` [PATCH 8/8] Input: ti_am335x_tsc - use variable name " Andrew F. Davis 2016-05-31 17:00 ` Andrew F. Davis 2016-06-01 18:35 ` Dmitry Torokhov 2016-06-01 18:35 ` Dmitry Torokhov 2016-06-08 15:36 ` [PATCH 0/8] TI AM335x TSC/ADC cleanup Lee Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=803110b4-997e-d8d0-dc3e-1ff6279ad202@kernel.org \ --to=jic23@kernel.org \ --cc=afd@ti.com \ --cc=d-gerlach@ti.com \ --cc=dmitry.torokhov@gmail.com \ --cc=knaack.h@gmx.de \ --cc=lars@metafoo.de \ --cc=lee.jones@linaro.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-input@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=pmeerw@pmeerw.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.