From: Michael Schmitz <schmitzmic@gmail.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-arch <linux-arch@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>, Oleg Nesterov <oleg@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
alpha <linux-alpha@vger.kernel.org>,
linux-m68k <linux-m68k@lists.linux-m68k.org>,
Arnd Bergmann <arnd@kernel.org>, Tejun Heo <tj@kernel.org>,
Kees Cook <keescook@chromium.org>,
linux-api@vger.kernel.org
Subject: Re: [CFT][PATCH] exit/bdflush: Remove the deprecated bdflush system call
Date: Wed, 30 Jun 2021 09:45:04 +1200 [thread overview]
Message-ID: <8043e5b4-20d2-0773-44f9-cc73e083e419@gmail.com> (raw)
In-Reply-To: <87sg10quue.fsf_-_@disp2133>
On 30/06/21 8:28 am, Eric W. Biederman wrote:
> The bdflush system call has been deprecated for a very long time.
> Recently Michael Schmitz tested[1] and found that the last known
> caller of of the bdflush system call is unaffected by it's removal.
>
> Since the code is not needed delete it.
>
> [1] https://lkml.kernel.org/r/36123b5d-daa0-6c2b-f2d4-a942f069fd54@gmail.com
> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Tested-by: Michael Schmitz <schmitzmic@gmail.com>
> ---
>
> I think we have consensus that bdflush can be removed. Can folks please
> verify I have removed it correctly?
>
> Michael could you give me a Tested-by on this patch?
>
> arch/alpha/kernel/syscalls/syscall.tbl | 2 +-
> arch/arm/tools/syscall.tbl | 2 +-
> arch/arm64/include/asm/unistd32.h | 2 +-
> arch/ia64/kernel/syscalls/syscall.tbl | 2 +-
> arch/m68k/kernel/syscalls/syscall.tbl | 2 +-
> arch/microblaze/kernel/syscalls/syscall.tbl | 2 +-
> arch/mips/kernel/syscalls/syscall_o32.tbl | 2 +-
> arch/parisc/kernel/syscalls/syscall.tbl | 2 +-
> arch/powerpc/kernel/syscalls/syscall.tbl | 2 +-
> arch/s390/kernel/syscalls/syscall.tbl | 2 +-
> arch/sh/kernel/syscalls/syscall.tbl | 2 +-
> arch/sparc/kernel/syscalls/syscall.tbl | 2 +-
> arch/x86/entry/syscalls/syscall_32.tbl | 2 +-
> arch/xtensa/kernel/syscalls/syscall.tbl | 2 +-
> fs/buffer.c | 27 -------------------
> include/linux/syscalls.h | 1 -
> include/uapi/linux/capability.h | 1 -
> kernel/sys_ni.c | 1 -
> .../arch/powerpc/entry/syscalls/syscall.tbl | 2 +-
> .../perf/arch/s390/entry/syscalls/syscall.tbl | 2 +-
> 20 files changed, 16 insertions(+), 46 deletions(-)
>
> diff --git a/arch/alpha/kernel/syscalls/syscall.tbl b/arch/alpha/kernel/syscalls/syscall.tbl
> index 3000a2e8ee21..85d2bcd9cf36 100644
> --- a/arch/alpha/kernel/syscalls/syscall.tbl
> +++ b/arch/alpha/kernel/syscalls/syscall.tbl
> @@ -230,7 +230,7 @@
> 259 common osf_swapctl sys_ni_syscall
> 260 common osf_memcntl sys_ni_syscall
> 261 common osf_fdatasync sys_ni_syscall
> -300 common bdflush sys_bdflush
> +300 common bdflush sys_ni_syscall
> 301 common sethae sys_sethae
> 302 common mount sys_mount
> 303 common old_adjtimex sys_old_adjtimex
> diff --git a/arch/arm/tools/syscall.tbl b/arch/arm/tools/syscall.tbl
> index 28e03b5fec00..241988512648 100644
> --- a/arch/arm/tools/syscall.tbl
> +++ b/arch/arm/tools/syscall.tbl
> @@ -147,7 +147,7 @@
> 131 common quotactl sys_quotactl
> 132 common getpgid sys_getpgid
> 133 common fchdir sys_fchdir
> -134 common bdflush sys_bdflush
> +134 common bdflush sys_ni_syscall
> 135 common sysfs sys_sysfs
> 136 common personality sys_personality
> # 137 was sys_afs_syscall
> diff --git a/arch/arm64/include/asm/unistd32.h b/arch/arm64/include/asm/unistd32.h
> index 5dab69d2c22b..a35cd6c4909c 100644
> --- a/arch/arm64/include/asm/unistd32.h
> +++ b/arch/arm64/include/asm/unistd32.h
> @@ -279,7 +279,7 @@ __SYSCALL(__NR_getpgid, sys_getpgid)
> #define __NR_fchdir 133
> __SYSCALL(__NR_fchdir, sys_fchdir)
> #define __NR_bdflush 134
> -__SYSCALL(__NR_bdflush, sys_bdflush)
> +__SYSCALL(__NR_bdflush, sys_ni_syscall)
> #define __NR_sysfs 135
> __SYSCALL(__NR_sysfs, sys_sysfs)
> #define __NR_personality 136
> diff --git a/arch/ia64/kernel/syscalls/syscall.tbl b/arch/ia64/kernel/syscalls/syscall.tbl
> index bb11fe4c875a..7de53a9a2972 100644
> --- a/arch/ia64/kernel/syscalls/syscall.tbl
> +++ b/arch/ia64/kernel/syscalls/syscall.tbl
> @@ -123,7 +123,7 @@
> # 1135 was get_kernel_syms
> # 1136 was query_module
> 113 common quotactl sys_quotactl
> -114 common bdflush sys_bdflush
> +114 common bdflush sys_ni_syscall
> 115 common sysfs sys_sysfs
> 116 common personality sys_personality
> 117 common afs_syscall sys_ni_syscall
> diff --git a/arch/m68k/kernel/syscalls/syscall.tbl b/arch/m68k/kernel/syscalls/syscall.tbl
> index 79c2d24c89dd..be5abd9c8c07 100644
> --- a/arch/m68k/kernel/syscalls/syscall.tbl
> +++ b/arch/m68k/kernel/syscalls/syscall.tbl
> @@ -141,7 +141,7 @@
> 131 common quotactl sys_quotactl
> 132 common getpgid sys_getpgid
> 133 common fchdir sys_fchdir
> -134 common bdflush sys_bdflush
> +134 common bdflush sys_ni_syscall
> 135 common sysfs sys_sysfs
> 136 common personality sys_personality
> # 137 was afs_syscall
> diff --git a/arch/microblaze/kernel/syscalls/syscall.tbl b/arch/microblaze/kernel/syscalls/syscall.tbl
> index b11395a20c20..555fd987f4ab 100644
> --- a/arch/microblaze/kernel/syscalls/syscall.tbl
> +++ b/arch/microblaze/kernel/syscalls/syscall.tbl
> @@ -141,7 +141,7 @@
> 131 common quotactl sys_quotactl
> 132 common getpgid sys_getpgid
> 133 common fchdir sys_fchdir
> -134 common bdflush sys_bdflush
> +134 common bdflush sys_ni_syscall
> 135 common sysfs sys_sysfs
> 136 common personality sys_personality
> 137 common afs_syscall sys_ni_syscall
> diff --git a/arch/mips/kernel/syscalls/syscall_o32.tbl b/arch/mips/kernel/syscalls/syscall_o32.tbl
> index d560c467a8c6..2c6b10db3bd5 100644
> --- a/arch/mips/kernel/syscalls/syscall_o32.tbl
> +++ b/arch/mips/kernel/syscalls/syscall_o32.tbl
> @@ -145,7 +145,7 @@
> 131 o32 quotactl sys_quotactl
> 132 o32 getpgid sys_getpgid
> 133 o32 fchdir sys_fchdir
> -134 o32 bdflush sys_bdflush
> +134 o32 bdflush sys_ni_syscall
> 135 o32 sysfs sys_sysfs
> 136 o32 personality sys_personality sys_32_personality
> 137 o32 afs_syscall sys_ni_syscall
> diff --git a/arch/parisc/kernel/syscalls/syscall.tbl b/arch/parisc/kernel/syscalls/syscall.tbl
> index aabc37f8cae3..51c156cb00f1 100644
> --- a/arch/parisc/kernel/syscalls/syscall.tbl
> +++ b/arch/parisc/kernel/syscalls/syscall.tbl
> @@ -147,7 +147,7 @@
> 131 common quotactl sys_quotactl
> 132 common getpgid sys_getpgid
> 133 common fchdir sys_fchdir
> -134 common bdflush sys_bdflush
> +134 common bdflush sys_ni_syscall
> 135 common sysfs sys_sysfs
> 136 32 personality parisc_personality
> 136 64 personality sys_personality
> diff --git a/arch/powerpc/kernel/syscalls/syscall.tbl b/arch/powerpc/kernel/syscalls/syscall.tbl
> index 8f052ff4058c..2518e4e6dccf 100644
> --- a/arch/powerpc/kernel/syscalls/syscall.tbl
> +++ b/arch/powerpc/kernel/syscalls/syscall.tbl
> @@ -176,7 +176,7 @@
> 131 nospu quotactl sys_quotactl
> 132 common getpgid sys_getpgid
> 133 common fchdir sys_fchdir
> -134 common bdflush sys_bdflush
> +134 common bdflush sys_ni_syscall
> 135 common sysfs sys_sysfs
> 136 32 personality sys_personality ppc64_personality
> 136 64 personality ppc64_personality
> diff --git a/arch/s390/kernel/syscalls/syscall.tbl b/arch/s390/kernel/syscalls/syscall.tbl
> index 0690263df1dd..ffcf03714f12 100644
> --- a/arch/s390/kernel/syscalls/syscall.tbl
> +++ b/arch/s390/kernel/syscalls/syscall.tbl
> @@ -122,7 +122,7 @@
> 131 common quotactl sys_quotactl sys_quotactl
> 132 common getpgid sys_getpgid sys_getpgid
> 133 common fchdir sys_fchdir sys_fchdir
> -134 common bdflush sys_bdflush sys_bdflush
> +134 common bdflush sys_ni_syscall sys_ni_syscall
> 135 common sysfs sys_sysfs sys_sysfs
> 136 common personality sys_s390_personality sys_s390_personality
> 137 common afs_syscall - -
> diff --git a/arch/sh/kernel/syscalls/syscall.tbl b/arch/sh/kernel/syscalls/syscall.tbl
> index 0b91499ebdcf..6e7305066a70 100644
> --- a/arch/sh/kernel/syscalls/syscall.tbl
> +++ b/arch/sh/kernel/syscalls/syscall.tbl
> @@ -141,7 +141,7 @@
> 131 common quotactl sys_quotactl
> 132 common getpgid sys_getpgid
> 133 common fchdir sys_fchdir
> -134 common bdflush sys_bdflush
> +134 common bdflush sys_ni_syscall
> 135 common sysfs sys_sysfs
> 136 common personality sys_personality
> # 137 was afs_syscall
> diff --git a/arch/sparc/kernel/syscalls/syscall.tbl b/arch/sparc/kernel/syscalls/syscall.tbl
> index e34cc30ef22c..bf330dda7c61 100644
> --- a/arch/sparc/kernel/syscalls/syscall.tbl
> +++ b/arch/sparc/kernel/syscalls/syscall.tbl
> @@ -270,7 +270,7 @@
> 222 common delete_module sys_delete_module
> 223 common get_kernel_syms sys_ni_syscall
> 224 common getpgid sys_getpgid
> -225 common bdflush sys_bdflush
> +225 common bdflush sys_ni_syscall
> 226 common sysfs sys_sysfs
> 227 common afs_syscall sys_nis_syscall
> 228 common setfsuid sys_setfsuid16
> diff --git a/arch/x86/entry/syscalls/syscall_32.tbl b/arch/x86/entry/syscalls/syscall_32.tbl
> index 4bbc267fb36b..a21a72763d58 100644
> --- a/arch/x86/entry/syscalls/syscall_32.tbl
> +++ b/arch/x86/entry/syscalls/syscall_32.tbl
> @@ -145,7 +145,7 @@
> 131 i386 quotactl sys_quotactl
> 132 i386 getpgid sys_getpgid
> 133 i386 fchdir sys_fchdir
> -134 i386 bdflush sys_bdflush
> +134 i386 bdflush sys_ni_syscall
> 135 i386 sysfs sys_sysfs
> 136 i386 personality sys_personality
> 137 i386 afs_syscall
> diff --git a/arch/xtensa/kernel/syscalls/syscall.tbl b/arch/xtensa/kernel/syscalls/syscall.tbl
> index fd2f30227d96..db4e3d09b249 100644
> --- a/arch/xtensa/kernel/syscalls/syscall.tbl
> +++ b/arch/xtensa/kernel/syscalls/syscall.tbl
> @@ -223,7 +223,7 @@
> # 205 was old nfsservctl
> 205 common nfsservctl sys_ni_syscall
> 206 common _sysctl sys_ni_syscall
> -207 common bdflush sys_bdflush
> +207 common bdflush sys_ni_syscall
> 208 common uname sys_newuname
> 209 common sysinfo sys_sysinfo
> 210 common init_module sys_init_module
> diff --git a/fs/buffer.c b/fs/buffer.c
> index ea48c01fb76b..04ddff76c860 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -3292,33 +3292,6 @@ int try_to_free_buffers(struct page *page)
> }
> EXPORT_SYMBOL(try_to_free_buffers);
>
> -/*
> - * There are no bdflush tunables left. But distributions are
> - * still running obsolete flush daemons, so we terminate them here.
> - *
> - * Use of bdflush() is deprecated and will be removed in a future kernel.
> - * The `flush-X' kernel threads fully replace bdflush daemons and this call.
> - */
> -SYSCALL_DEFINE2(bdflush, int, func, long, data)
> -{
> - static int msg_count;
> -
> - if (!capable(CAP_SYS_ADMIN))
> - return -EPERM;
> -
> - if (msg_count < 5) {
> - msg_count++;
> - printk(KERN_INFO
> - "warning: process `%s' used the obsolete bdflush"
> - " system call\n", current->comm);
> - printk(KERN_INFO "Fix your initscripts?\n");
> - }
> -
> - if (func == 1)
> - do_exit(0);
> - return 0;
> -}
> -
> /*
> * Buffer-head allocation
> */
> diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h
> index 050511e8f1f8..1bd6e05ea116 100644
> --- a/include/linux/syscalls.h
> +++ b/include/linux/syscalls.h
> @@ -1157,7 +1157,6 @@ asmlinkage long sys_ustat(unsigned dev, struct ustat __user *ubuf);
> asmlinkage long sys_vfork(void);
> asmlinkage long sys_recv(int, void __user *, size_t, unsigned);
> asmlinkage long sys_send(int, void __user *, size_t, unsigned);
> -asmlinkage long sys_bdflush(int func, long data);
> asmlinkage long sys_oldumount(char __user *name);
> asmlinkage long sys_uselib(const char __user *library);
> asmlinkage long sys_sysfs(int option,
> diff --git a/include/uapi/linux/capability.h b/include/uapi/linux/capability.h
> index 2ddb4226cd23..463d1ba2232a 100644
> --- a/include/uapi/linux/capability.h
> +++ b/include/uapi/linux/capability.h
> @@ -243,7 +243,6 @@ struct vfs_ns_cap_data {
> /* Allow examination and configuration of disk quotas */
> /* Allow setting the domainname */
> /* Allow setting the hostname */
> -/* Allow calling bdflush() */
> /* Allow mount() and umount(), setting up new smb connection */
> /* Allow some autofs root ioctls */
> /* Allow nfsservctl */
> diff --git a/kernel/sys_ni.c b/kernel/sys_ni.c
> index 0ea8128468c3..adf4d66ffae2 100644
> --- a/kernel/sys_ni.c
> +++ b/kernel/sys_ni.c
> @@ -414,7 +414,6 @@ COND_SYSCALL(epoll_wait);
> COND_SYSCALL(recv);
> COND_SYSCALL_COMPAT(recv);
> COND_SYSCALL(send);
> -COND_SYSCALL(bdflush);
> COND_SYSCALL(uselib);
>
> /* optional: time32 */
> diff --git a/tools/perf/arch/powerpc/entry/syscalls/syscall.tbl b/tools/perf/arch/powerpc/entry/syscalls/syscall.tbl
> index 2e68fbb57cc6..ab72dec9dadb 100644
> --- a/tools/perf/arch/powerpc/entry/syscalls/syscall.tbl
> +++ b/tools/perf/arch/powerpc/entry/syscalls/syscall.tbl
> @@ -176,7 +176,7 @@
> 131 nospu quotactl sys_quotactl
> 132 common getpgid sys_getpgid
> 133 common fchdir sys_fchdir
> -134 common bdflush sys_bdflush
> +134 common bdflush sys_ni_syscall
> 135 common sysfs sys_sysfs
> 136 32 personality sys_personality ppc64_personality
> 136 64 personality ppc64_personality
> diff --git a/tools/perf/arch/s390/entry/syscalls/syscall.tbl b/tools/perf/arch/s390/entry/syscalls/syscall.tbl
> index 7e4a2aba366d..f2eba775e676 100644
> --- a/tools/perf/arch/s390/entry/syscalls/syscall.tbl
> +++ b/tools/perf/arch/s390/entry/syscalls/syscall.tbl
> @@ -122,7 +122,7 @@
> 131 common quotactl sys_quotactl sys_quotactl
> 132 common getpgid sys_getpgid sys_getpgid
> 133 common fchdir sys_fchdir sys_fchdir
> -134 common bdflush sys_bdflush sys_bdflush
> +134 common bdflush - -
> 135 common sysfs sys_sysfs sys_sysfs
> 136 common personality sys_s390_personality sys_s390_personality
> 137 common afs_syscall - -
WARNING: multiple messages have this Message-ID (diff)
From: Michael Schmitz <schmitzmic-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Eric W. Biederman" <ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
Cc: Geert Uytterhoeven
<geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>,
Al Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>,
Linus Torvalds
<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
linux-arch <linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>,
Oleg Nesterov <oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Richard Henderson <rth-hL46jP5Bxq7R7s880joybQ@public.gmane.org>,
Ivan Kokshaysky
<ink-biIs/Y0ymYJMZLIVYojuPNP0rXTJTi09@public.gmane.org>,
Matt Turner <mattst88-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
alpha <linux-alpha-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-m68k
<linux-m68k-cunTk1MwBs8S/qaLPR03pWD2FQJk+8+b@public.gmane.org>,
Arnd Bergmann <arnd-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Kees Cook <keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [CFT][PATCH] exit/bdflush: Remove the deprecated bdflush system call
Date: Wed, 30 Jun 2021 09:45:04 +1200 [thread overview]
Message-ID: <8043e5b4-20d2-0773-44f9-cc73e083e419@gmail.com> (raw)
In-Reply-To: <87sg10quue.fsf_-_@disp2133>
On 30/06/21 8:28 am, Eric W. Biederman wrote:
> The bdflush system call has been deprecated for a very long time.
> Recently Michael Schmitz tested[1] and found that the last known
> caller of of the bdflush system call is unaffected by it's removal.
>
> Since the code is not needed delete it.
>
> [1] https://lkml.kernel.org/r/36123b5d-daa0-6c2b-f2d4-a942f069fd54-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
> Signed-off-by: "Eric W. Biederman" <ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
Tested-by: Michael Schmitz <schmitzmic-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>
> I think we have consensus that bdflush can be removed. Can folks please
> verify I have removed it correctly?
>
> Michael could you give me a Tested-by on this patch?
>
> arch/alpha/kernel/syscalls/syscall.tbl | 2 +-
> arch/arm/tools/syscall.tbl | 2 +-
> arch/arm64/include/asm/unistd32.h | 2 +-
> arch/ia64/kernel/syscalls/syscall.tbl | 2 +-
> arch/m68k/kernel/syscalls/syscall.tbl | 2 +-
> arch/microblaze/kernel/syscalls/syscall.tbl | 2 +-
> arch/mips/kernel/syscalls/syscall_o32.tbl | 2 +-
> arch/parisc/kernel/syscalls/syscall.tbl | 2 +-
> arch/powerpc/kernel/syscalls/syscall.tbl | 2 +-
> arch/s390/kernel/syscalls/syscall.tbl | 2 +-
> arch/sh/kernel/syscalls/syscall.tbl | 2 +-
> arch/sparc/kernel/syscalls/syscall.tbl | 2 +-
> arch/x86/entry/syscalls/syscall_32.tbl | 2 +-
> arch/xtensa/kernel/syscalls/syscall.tbl | 2 +-
> fs/buffer.c | 27 -------------------
> include/linux/syscalls.h | 1 -
> include/uapi/linux/capability.h | 1 -
> kernel/sys_ni.c | 1 -
> .../arch/powerpc/entry/syscalls/syscall.tbl | 2 +-
> .../perf/arch/s390/entry/syscalls/syscall.tbl | 2 +-
> 20 files changed, 16 insertions(+), 46 deletions(-)
>
> diff --git a/arch/alpha/kernel/syscalls/syscall.tbl b/arch/alpha/kernel/syscalls/syscall.tbl
> index 3000a2e8ee21..85d2bcd9cf36 100644
> --- a/arch/alpha/kernel/syscalls/syscall.tbl
> +++ b/arch/alpha/kernel/syscalls/syscall.tbl
> @@ -230,7 +230,7 @@
> 259 common osf_swapctl sys_ni_syscall
> 260 common osf_memcntl sys_ni_syscall
> 261 common osf_fdatasync sys_ni_syscall
> -300 common bdflush sys_bdflush
> +300 common bdflush sys_ni_syscall
> 301 common sethae sys_sethae
> 302 common mount sys_mount
> 303 common old_adjtimex sys_old_adjtimex
> diff --git a/arch/arm/tools/syscall.tbl b/arch/arm/tools/syscall.tbl
> index 28e03b5fec00..241988512648 100644
> --- a/arch/arm/tools/syscall.tbl
> +++ b/arch/arm/tools/syscall.tbl
> @@ -147,7 +147,7 @@
> 131 common quotactl sys_quotactl
> 132 common getpgid sys_getpgid
> 133 common fchdir sys_fchdir
> -134 common bdflush sys_bdflush
> +134 common bdflush sys_ni_syscall
> 135 common sysfs sys_sysfs
> 136 common personality sys_personality
> # 137 was sys_afs_syscall
> diff --git a/arch/arm64/include/asm/unistd32.h b/arch/arm64/include/asm/unistd32.h
> index 5dab69d2c22b..a35cd6c4909c 100644
> --- a/arch/arm64/include/asm/unistd32.h
> +++ b/arch/arm64/include/asm/unistd32.h
> @@ -279,7 +279,7 @@ __SYSCALL(__NR_getpgid, sys_getpgid)
> #define __NR_fchdir 133
> __SYSCALL(__NR_fchdir, sys_fchdir)
> #define __NR_bdflush 134
> -__SYSCALL(__NR_bdflush, sys_bdflush)
> +__SYSCALL(__NR_bdflush, sys_ni_syscall)
> #define __NR_sysfs 135
> __SYSCALL(__NR_sysfs, sys_sysfs)
> #define __NR_personality 136
> diff --git a/arch/ia64/kernel/syscalls/syscall.tbl b/arch/ia64/kernel/syscalls/syscall.tbl
> index bb11fe4c875a..7de53a9a2972 100644
> --- a/arch/ia64/kernel/syscalls/syscall.tbl
> +++ b/arch/ia64/kernel/syscalls/syscall.tbl
> @@ -123,7 +123,7 @@
> # 1135 was get_kernel_syms
> # 1136 was query_module
> 113 common quotactl sys_quotactl
> -114 common bdflush sys_bdflush
> +114 common bdflush sys_ni_syscall
> 115 common sysfs sys_sysfs
> 116 common personality sys_personality
> 117 common afs_syscall sys_ni_syscall
> diff --git a/arch/m68k/kernel/syscalls/syscall.tbl b/arch/m68k/kernel/syscalls/syscall.tbl
> index 79c2d24c89dd..be5abd9c8c07 100644
> --- a/arch/m68k/kernel/syscalls/syscall.tbl
> +++ b/arch/m68k/kernel/syscalls/syscall.tbl
> @@ -141,7 +141,7 @@
> 131 common quotactl sys_quotactl
> 132 common getpgid sys_getpgid
> 133 common fchdir sys_fchdir
> -134 common bdflush sys_bdflush
> +134 common bdflush sys_ni_syscall
> 135 common sysfs sys_sysfs
> 136 common personality sys_personality
> # 137 was afs_syscall
> diff --git a/arch/microblaze/kernel/syscalls/syscall.tbl b/arch/microblaze/kernel/syscalls/syscall.tbl
> index b11395a20c20..555fd987f4ab 100644
> --- a/arch/microblaze/kernel/syscalls/syscall.tbl
> +++ b/arch/microblaze/kernel/syscalls/syscall.tbl
> @@ -141,7 +141,7 @@
> 131 common quotactl sys_quotactl
> 132 common getpgid sys_getpgid
> 133 common fchdir sys_fchdir
> -134 common bdflush sys_bdflush
> +134 common bdflush sys_ni_syscall
> 135 common sysfs sys_sysfs
> 136 common personality sys_personality
> 137 common afs_syscall sys_ni_syscall
> diff --git a/arch/mips/kernel/syscalls/syscall_o32.tbl b/arch/mips/kernel/syscalls/syscall_o32.tbl
> index d560c467a8c6..2c6b10db3bd5 100644
> --- a/arch/mips/kernel/syscalls/syscall_o32.tbl
> +++ b/arch/mips/kernel/syscalls/syscall_o32.tbl
> @@ -145,7 +145,7 @@
> 131 o32 quotactl sys_quotactl
> 132 o32 getpgid sys_getpgid
> 133 o32 fchdir sys_fchdir
> -134 o32 bdflush sys_bdflush
> +134 o32 bdflush sys_ni_syscall
> 135 o32 sysfs sys_sysfs
> 136 o32 personality sys_personality sys_32_personality
> 137 o32 afs_syscall sys_ni_syscall
> diff --git a/arch/parisc/kernel/syscalls/syscall.tbl b/arch/parisc/kernel/syscalls/syscall.tbl
> index aabc37f8cae3..51c156cb00f1 100644
> --- a/arch/parisc/kernel/syscalls/syscall.tbl
> +++ b/arch/parisc/kernel/syscalls/syscall.tbl
> @@ -147,7 +147,7 @@
> 131 common quotactl sys_quotactl
> 132 common getpgid sys_getpgid
> 133 common fchdir sys_fchdir
> -134 common bdflush sys_bdflush
> +134 common bdflush sys_ni_syscall
> 135 common sysfs sys_sysfs
> 136 32 personality parisc_personality
> 136 64 personality sys_personality
> diff --git a/arch/powerpc/kernel/syscalls/syscall.tbl b/arch/powerpc/kernel/syscalls/syscall.tbl
> index 8f052ff4058c..2518e4e6dccf 100644
> --- a/arch/powerpc/kernel/syscalls/syscall.tbl
> +++ b/arch/powerpc/kernel/syscalls/syscall.tbl
> @@ -176,7 +176,7 @@
> 131 nospu quotactl sys_quotactl
> 132 common getpgid sys_getpgid
> 133 common fchdir sys_fchdir
> -134 common bdflush sys_bdflush
> +134 common bdflush sys_ni_syscall
> 135 common sysfs sys_sysfs
> 136 32 personality sys_personality ppc64_personality
> 136 64 personality ppc64_personality
> diff --git a/arch/s390/kernel/syscalls/syscall.tbl b/arch/s390/kernel/syscalls/syscall.tbl
> index 0690263df1dd..ffcf03714f12 100644
> --- a/arch/s390/kernel/syscalls/syscall.tbl
> +++ b/arch/s390/kernel/syscalls/syscall.tbl
> @@ -122,7 +122,7 @@
> 131 common quotactl sys_quotactl sys_quotactl
> 132 common getpgid sys_getpgid sys_getpgid
> 133 common fchdir sys_fchdir sys_fchdir
> -134 common bdflush sys_bdflush sys_bdflush
> +134 common bdflush sys_ni_syscall sys_ni_syscall
> 135 common sysfs sys_sysfs sys_sysfs
> 136 common personality sys_s390_personality sys_s390_personality
> 137 common afs_syscall - -
> diff --git a/arch/sh/kernel/syscalls/syscall.tbl b/arch/sh/kernel/syscalls/syscall.tbl
> index 0b91499ebdcf..6e7305066a70 100644
> --- a/arch/sh/kernel/syscalls/syscall.tbl
> +++ b/arch/sh/kernel/syscalls/syscall.tbl
> @@ -141,7 +141,7 @@
> 131 common quotactl sys_quotactl
> 132 common getpgid sys_getpgid
> 133 common fchdir sys_fchdir
> -134 common bdflush sys_bdflush
> +134 common bdflush sys_ni_syscall
> 135 common sysfs sys_sysfs
> 136 common personality sys_personality
> # 137 was afs_syscall
> diff --git a/arch/sparc/kernel/syscalls/syscall.tbl b/arch/sparc/kernel/syscalls/syscall.tbl
> index e34cc30ef22c..bf330dda7c61 100644
> --- a/arch/sparc/kernel/syscalls/syscall.tbl
> +++ b/arch/sparc/kernel/syscalls/syscall.tbl
> @@ -270,7 +270,7 @@
> 222 common delete_module sys_delete_module
> 223 common get_kernel_syms sys_ni_syscall
> 224 common getpgid sys_getpgid
> -225 common bdflush sys_bdflush
> +225 common bdflush sys_ni_syscall
> 226 common sysfs sys_sysfs
> 227 common afs_syscall sys_nis_syscall
> 228 common setfsuid sys_setfsuid16
> diff --git a/arch/x86/entry/syscalls/syscall_32.tbl b/arch/x86/entry/syscalls/syscall_32.tbl
> index 4bbc267fb36b..a21a72763d58 100644
> --- a/arch/x86/entry/syscalls/syscall_32.tbl
> +++ b/arch/x86/entry/syscalls/syscall_32.tbl
> @@ -145,7 +145,7 @@
> 131 i386 quotactl sys_quotactl
> 132 i386 getpgid sys_getpgid
> 133 i386 fchdir sys_fchdir
> -134 i386 bdflush sys_bdflush
> +134 i386 bdflush sys_ni_syscall
> 135 i386 sysfs sys_sysfs
> 136 i386 personality sys_personality
> 137 i386 afs_syscall
> diff --git a/arch/xtensa/kernel/syscalls/syscall.tbl b/arch/xtensa/kernel/syscalls/syscall.tbl
> index fd2f30227d96..db4e3d09b249 100644
> --- a/arch/xtensa/kernel/syscalls/syscall.tbl
> +++ b/arch/xtensa/kernel/syscalls/syscall.tbl
> @@ -223,7 +223,7 @@
> # 205 was old nfsservctl
> 205 common nfsservctl sys_ni_syscall
> 206 common _sysctl sys_ni_syscall
> -207 common bdflush sys_bdflush
> +207 common bdflush sys_ni_syscall
> 208 common uname sys_newuname
> 209 common sysinfo sys_sysinfo
> 210 common init_module sys_init_module
> diff --git a/fs/buffer.c b/fs/buffer.c
> index ea48c01fb76b..04ddff76c860 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -3292,33 +3292,6 @@ int try_to_free_buffers(struct page *page)
> }
> EXPORT_SYMBOL(try_to_free_buffers);
>
> -/*
> - * There are no bdflush tunables left. But distributions are
> - * still running obsolete flush daemons, so we terminate them here.
> - *
> - * Use of bdflush() is deprecated and will be removed in a future kernel.
> - * The `flush-X' kernel threads fully replace bdflush daemons and this call.
> - */
> -SYSCALL_DEFINE2(bdflush, int, func, long, data)
> -{
> - static int msg_count;
> -
> - if (!capable(CAP_SYS_ADMIN))
> - return -EPERM;
> -
> - if (msg_count < 5) {
> - msg_count++;
> - printk(KERN_INFO
> - "warning: process `%s' used the obsolete bdflush"
> - " system call\n", current->comm);
> - printk(KERN_INFO "Fix your initscripts?\n");
> - }
> -
> - if (func == 1)
> - do_exit(0);
> - return 0;
> -}
> -
> /*
> * Buffer-head allocation
> */
> diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h
> index 050511e8f1f8..1bd6e05ea116 100644
> --- a/include/linux/syscalls.h
> +++ b/include/linux/syscalls.h
> @@ -1157,7 +1157,6 @@ asmlinkage long sys_ustat(unsigned dev, struct ustat __user *ubuf);
> asmlinkage long sys_vfork(void);
> asmlinkage long sys_recv(int, void __user *, size_t, unsigned);
> asmlinkage long sys_send(int, void __user *, size_t, unsigned);
> -asmlinkage long sys_bdflush(int func, long data);
> asmlinkage long sys_oldumount(char __user *name);
> asmlinkage long sys_uselib(const char __user *library);
> asmlinkage long sys_sysfs(int option,
> diff --git a/include/uapi/linux/capability.h b/include/uapi/linux/capability.h
> index 2ddb4226cd23..463d1ba2232a 100644
> --- a/include/uapi/linux/capability.h
> +++ b/include/uapi/linux/capability.h
> @@ -243,7 +243,6 @@ struct vfs_ns_cap_data {
> /* Allow examination and configuration of disk quotas */
> /* Allow setting the domainname */
> /* Allow setting the hostname */
> -/* Allow calling bdflush() */
> /* Allow mount() and umount(), setting up new smb connection */
> /* Allow some autofs root ioctls */
> /* Allow nfsservctl */
> diff --git a/kernel/sys_ni.c b/kernel/sys_ni.c
> index 0ea8128468c3..adf4d66ffae2 100644
> --- a/kernel/sys_ni.c
> +++ b/kernel/sys_ni.c
> @@ -414,7 +414,6 @@ COND_SYSCALL(epoll_wait);
> COND_SYSCALL(recv);
> COND_SYSCALL_COMPAT(recv);
> COND_SYSCALL(send);
> -COND_SYSCALL(bdflush);
> COND_SYSCALL(uselib);
>
> /* optional: time32 */
> diff --git a/tools/perf/arch/powerpc/entry/syscalls/syscall.tbl b/tools/perf/arch/powerpc/entry/syscalls/syscall.tbl
> index 2e68fbb57cc6..ab72dec9dadb 100644
> --- a/tools/perf/arch/powerpc/entry/syscalls/syscall.tbl
> +++ b/tools/perf/arch/powerpc/entry/syscalls/syscall.tbl
> @@ -176,7 +176,7 @@
> 131 nospu quotactl sys_quotactl
> 132 common getpgid sys_getpgid
> 133 common fchdir sys_fchdir
> -134 common bdflush sys_bdflush
> +134 common bdflush sys_ni_syscall
> 135 common sysfs sys_sysfs
> 136 32 personality sys_personality ppc64_personality
> 136 64 personality ppc64_personality
> diff --git a/tools/perf/arch/s390/entry/syscalls/syscall.tbl b/tools/perf/arch/s390/entry/syscalls/syscall.tbl
> index 7e4a2aba366d..f2eba775e676 100644
> --- a/tools/perf/arch/s390/entry/syscalls/syscall.tbl
> +++ b/tools/perf/arch/s390/entry/syscalls/syscall.tbl
> @@ -122,7 +122,7 @@
> 131 common quotactl sys_quotactl sys_quotactl
> 132 common getpgid sys_getpgid sys_getpgid
> 133 common fchdir sys_fchdir sys_fchdir
> -134 common bdflush sys_bdflush sys_bdflush
> +134 common bdflush - -
> 135 common sysfs sys_sysfs sys_sysfs
> 136 common personality sys_s390_personality sys_s390_personality
> 137 common afs_syscall - -
next prev parent reply other threads:[~2021-06-29 21:45 UTC|newest]
Thread overview: 127+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 20:57 Kernel stack read with PTRACE_EVENT_EXIT and io_uring threads Eric W. Biederman
2021-06-10 20:57 ` Eric W. Biederman
2021-06-10 22:04 ` Linus Torvalds
2021-06-11 21:39 ` Eric W. Biederman
2021-06-11 23:26 ` Linus Torvalds
2021-06-13 21:54 ` Eric W. Biederman
2021-06-13 22:18 ` Linus Torvalds
2021-06-14 2:05 ` Michael Schmitz
2021-06-14 5:03 ` Michael Schmitz
2021-06-14 16:26 ` Eric W. Biederman
2021-06-14 22:26 ` Michael Schmitz
2021-06-15 19:30 ` Eric W. Biederman
2021-06-15 19:36 ` [PATCH] alpha: Add extra switch_stack frames in exit, exec, and kernel threads Eric W. Biederman
2021-06-15 22:02 ` Linus Torvalds
2021-06-16 16:32 ` Eric W. Biederman
2021-06-16 18:29 ` [PATCH 0/2] alpha/ptrace: Improved switch_stack handling Eric W. Biederman
2021-06-16 18:31 ` [PATCH 1/2] alpha/ptrace: Record and handle the absence of switch_stack Eric W. Biederman
2021-06-16 20:00 ` Linus Torvalds
2021-06-16 20:37 ` Linus Torvalds
2021-06-16 20:57 ` Eric W. Biederman
2021-06-16 21:02 ` Al Viro
2021-06-16 21:08 ` Linus Torvalds
2021-06-16 20:42 ` Eric W. Biederman
2021-06-16 20:17 ` Al Viro
2021-06-21 2:01 ` Michael Schmitz
2021-06-21 2:17 ` Linus Torvalds
2021-06-21 3:18 ` Michael Schmitz
2021-06-21 3:37 ` Linus Torvalds
2021-06-21 4:08 ` Michael Schmitz
2021-06-21 3:44 ` Al Viro
2021-06-21 5:31 ` Michael Schmitz
2021-06-21 2:27 ` Al Viro
2021-06-21 3:36 ` Michael Schmitz
2021-06-16 18:32 ` [PATCH 2/2] alpha/ptrace: Add missing switch_stack frames Eric W. Biederman
2021-06-16 20:25 ` Al Viro
2021-06-16 20:28 ` Al Viro
2021-06-16 20:49 ` Eric W. Biederman
2021-06-16 20:54 ` Al Viro
2021-06-16 20:47 ` Eric W. Biederman
2021-06-16 20:55 ` Al Viro
2021-06-16 20:50 ` [PATCH] alpha: Add extra switch_stack frames in exit, exec, and kernel threads Al Viro
2021-06-15 20:56 ` Kernel stack read with PTRACE_EVENT_EXIT and io_uring threads Michael Schmitz
2021-06-16 0:23 ` Finn Thain
2021-06-15 21:58 ` Linus Torvalds
2021-06-16 15:06 ` Eric W. Biederman
2021-06-21 13:54 ` Al Viro
2021-06-21 14:16 ` Al Viro
2021-06-21 16:50 ` Eric W. Biederman
2021-06-21 23:05 ` Al Viro
2021-06-22 16:39 ` Eric W. Biederman
2021-06-21 15:38 ` Linus Torvalds
2021-06-21 18:59 ` Al Viro
2021-06-21 19:22 ` Linus Torvalds
2021-06-21 19:45 ` Al Viro
2021-06-21 23:14 ` Linus Torvalds
2021-06-21 23:23 ` Al Viro
2021-06-21 23:36 ` Linus Torvalds
2021-06-22 21:02 ` Eric W. Biederman
2021-06-22 21:48 ` Michael Schmitz
2021-06-23 5:26 ` Michael Schmitz
2021-06-23 14:36 ` Eric W. Biederman
2021-06-22 0:01 ` Michael Schmitz
2021-06-22 20:04 ` Michael Schmitz
2021-06-22 20:18 ` Al Viro
2021-06-22 21:57 ` Michael Schmitz
2021-06-21 20:03 ` Eric W. Biederman
2021-06-21 23:15 ` Linus Torvalds
2021-06-22 20:52 ` Eric W. Biederman
2021-06-23 0:41 ` Linus Torvalds
2021-06-23 14:33 ` Eric W. Biederman
2021-06-24 18:57 ` [PATCH 0/9] Refactoring exit Eric W. Biederman
2021-06-24 18:59 ` [PATCH 1/9] signal/sh: Use force_sig(SIGKILL) instead of do_group_exit(SIGKILL) Eric W. Biederman
2021-06-24 18:59 ` [PATCH 2/9] signal/seccomp: Refactor seccomp signal and coredump generation Eric W. Biederman
2021-06-26 3:17 ` Kees Cook
2021-06-28 19:21 ` Eric W. Biederman
2021-06-28 14:34 ` [signal/seccomp] 3fdd8c68c2: kernel-selftests.seccomp.seccomp_bpf.fail kernel test robot
2021-06-28 14:34 ` kernel test robot
2021-06-24 19:00 ` [PATCH 3/9] signal/seccomp: Dump core when there is only one live thread Eric W. Biederman
2021-06-26 3:20 ` Kees Cook
2021-06-24 19:01 ` [PATCH 4/9] signal: Factor start_group_exit out of complete_signal Eric W. Biederman
2021-06-24 20:04 ` Linus Torvalds
2021-06-25 8:47 ` kernel test robot
2021-06-25 8:47 ` kernel test robot
2021-06-26 3:24 ` Kees Cook
2021-06-24 19:01 ` [PATCH 5/9] signal/group_exit: Use start_group_exit in place of do_group_exit Eric W. Biederman
2021-06-26 3:35 ` Kees Cook
2021-06-24 19:02 ` [PATCH 6/9] signal: Fold do_group_exit into get_signal fixing io_uring threads Eric W. Biederman
2021-06-26 3:42 ` Kees Cook
2021-06-28 19:25 ` Eric W. Biederman
2021-06-24 19:02 ` [PATCH 7/9] signal: Make individual tasks exiting a first class concept Eric W. Biederman
2021-06-24 20:11 ` Linus Torvalds
2021-06-24 21:37 ` Eric W. Biederman
2021-06-24 19:03 ` [PATCH 8/9] signal/task_exit: Use start_task_exit in place of do_exit Eric W. Biederman
2021-06-26 5:56 ` Kees Cook
2021-06-24 19:03 ` [PATCH 9/9] signal: Move PTRACE_EVENT_EXIT into get_signal Eric W. Biederman
2021-06-24 22:45 ` [PATCH 0/9] Refactoring exit Al Viro
2021-06-27 22:13 ` Al Viro
2021-06-27 22:59 ` Michael Schmitz
2021-06-28 7:31 ` Geert Uytterhoeven
2021-06-28 16:20 ` Eric W. Biederman
2021-06-28 17:14 ` Michael Schmitz
2021-06-28 19:17 ` Geert Uytterhoeven
2021-06-28 20:13 ` Michael Schmitz
2021-06-28 21:18 ` Geert Uytterhoeven
2021-06-28 23:42 ` Michael Schmitz
2021-06-29 20:28 ` [CFT][PATCH] exit/bdflush: Remove the deprecated bdflush system call Eric W. Biederman
2021-06-29 20:28 ` Eric W. Biederman
2021-06-29 21:45 ` Michael Schmitz [this message]
2021-06-29 21:45 ` Michael Schmitz
2021-06-30 8:24 ` Geert Uytterhoeven
2021-06-30 8:37 ` Arnd Bergmann
2021-06-30 12:30 ` Cyril Hrubis
2021-06-28 19:02 ` [PATCH 0/9] Refactoring exit Eric W. Biederman
2021-06-21 19:24 ` Kernel stack read with PTRACE_EVENT_EXIT and io_uring threads Al Viro
2021-06-21 23:24 ` Michael Schmitz
2021-06-16 7:38 ` Geert Uytterhoeven
2021-06-16 19:40 ` Michael Schmitz
2021-06-12 23:38 ` [PATCH v1] m68k: save extra registers on sys_exit and sys_exit_group syscall entry Michael Schmitz
2021-06-13 19:59 ` Linus Torvalds
2021-06-13 20:07 ` Michael Schmitz
2021-06-13 20:26 ` Linus Torvalds
2021-06-13 20:33 ` Linus Torvalds
2021-06-13 20:47 ` Linus Torvalds
2021-06-14 7:13 ` Michael Schmitz
2021-06-14 7:40 ` Andreas Schwab
2021-06-14 8:19 ` Michael Schmitz
2021-06-29 21:55 [CFT][PATCH] exit/bdflush: Remove the deprecated bdflush system call kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8043e5b4-20d2-0773-44f9-cc73e083e419@gmail.com \
--to=schmitzmic@gmail.com \
--cc=arnd@kernel.org \
--cc=axboe@kernel.dk \
--cc=ebiederm@xmission.com \
--cc=geert@linux-m68k.org \
--cc=ink@jurassic.park.msu.ru \
--cc=keescook@chromium.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=mattst88@gmail.com \
--cc=oleg@redhat.com \
--cc=rth@twiddle.net \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.