All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
	"Hauke Mehrtens" <hauke@hauke-m.de>, "Michael Buesch" <m@bues.ch>,
	linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ssb: host_soc depends on sprom
Date: Wed, 13 Jan 2016 23:51:43 +0100	[thread overview]
Message-ID: <8128014.DbbgBtKY3z@wuerfel> (raw)

Drivers that use the SSB sprom functionality typically 'select SSB_SPROM'
from Kconfig, but CONFIG_SSB_HOST_SOC misses this, which results in
a build failure unless at least one of the other drivers that selects
it is enabled:

drivers/built-in.o: In function `ssb_host_soc_get_invariants':
(.text+0x459494): undefined reference to `ssb_fill_sprom_with_fallback'

This adds the same select statement that is used elsewhere.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 541c9a84cd85 ("ssb: pick SoC invariants code from MIPS BCM47xx arch")
---
I'm not sure who the right person is to pick up the fix. The patch that
introduced the problem was merged by Kalle through the iwlwifi tree.

diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
index 0c675861623f..d8e4219c2324 100644
--- a/drivers/ssb/Kconfig
+++ b/drivers/ssb/Kconfig
@@ -83,6 +83,7 @@ config SSB_SDIOHOST
 config SSB_HOST_SOC
 	bool "Support for SSB bus on SoC"
 	depends on SSB && BCM47XX_NVRAM
+	select SSB_SPROM
 	help
 	  Host interface for a SSB directly mapped into memory. This is
 	  for some Broadcom SoCs from the BCM47xx and BCM53xx lines.

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ssb: host_soc depends on sprom
Date: Wed, 13 Jan 2016 23:51:43 +0100	[thread overview]
Message-ID: <8128014.DbbgBtKY3z@wuerfel> (raw)

Drivers that use the SSB sprom functionality typically 'select SSB_SPROM'
from Kconfig, but CONFIG_SSB_HOST_SOC misses this, which results in
a build failure unless at least one of the other drivers that selects
it is enabled:

drivers/built-in.o: In function `ssb_host_soc_get_invariants':
(.text+0x459494): undefined reference to `ssb_fill_sprom_with_fallback'

This adds the same select statement that is used elsewhere.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 541c9a84cd85 ("ssb: pick SoC invariants code from MIPS BCM47xx arch")
---
I'm not sure who the right person is to pick up the fix. The patch that
introduced the problem was merged by Kalle through the iwlwifi tree.

diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig
index 0c675861623f..d8e4219c2324 100644
--- a/drivers/ssb/Kconfig
+++ b/drivers/ssb/Kconfig
@@ -83,6 +83,7 @@ config SSB_SDIOHOST
 config SSB_HOST_SOC
 	bool "Support for SSB bus on SoC"
 	depends on SSB && BCM47XX_NVRAM
+	select SSB_SPROM
 	help
 	  Host interface for a SSB directly mapped into memory. This is
 	  for some Broadcom SoCs from the BCM47xx and BCM53xx lines.

             reply	other threads:[~2016-01-13 22:52 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-13 22:51 Arnd Bergmann [this message]
2016-01-13 22:51 ` [PATCH] ssb: host_soc depends on sprom Arnd Bergmann
2016-01-14  6:46 ` Kalle Valo
2016-01-14  6:46   ` Kalle Valo
2016-01-14 21:46   ` David Miller
2016-01-14 21:46     ` David Miller
2016-01-14 23:13   ` [PATCH, RESEND] ssb: mark ssb_bus_register as __maybe_unused Arnd Bergmann
2016-01-14 23:13     ` Arnd Bergmann
2016-01-16 12:10     ` Kalle Valo
2016-01-16 12:10       ` Kalle Valo
2016-01-16 14:44       ` Rafał Miłecki
2016-01-16 14:44         ` Rafał Miłecki
2016-01-16 14:44         ` Rafał Miłecki
2016-01-18  8:26         ` Kalle Valo
2016-01-18  8:26           ` Kalle Valo
2016-01-18  8:26           ` Kalle Valo
2016-01-18  8:26           ` Kalle Valo
2016-01-18 16:53           ` ssb: Set linux-wireless as MAINTAINERS list Michael Büsch
2016-01-18 19:09             ` Rafał Miłecki
2016-01-18 19:09               ` Rafał Miłecki
2016-01-18 19:09               ` Rafał Miłecki
2016-01-19 13:04               ` Kalle Valo
2016-01-19 13:04                 ` Kalle Valo
2016-01-19 19:25             ` Kalle Valo
2016-01-19 19:25               ` Kalle Valo
2016-01-19 19:25             ` Kalle Valo
2016-01-19 19:25             ` Kalle Valo
2016-01-18 19:39   ` [PATCH, RESEND^2] ssb: mark ssb_bus_register as __maybe_unused Arnd Bergmann
2016-01-18 19:39     ` Arnd Bergmann
2016-01-19 13:03     ` Kalle Valo
2016-01-19 13:03       ` Kalle Valo
2016-01-19 13:03       ` Kalle Valo
2016-01-19 19:26     ` [RESEND^2] " Kalle Valo
2016-01-19 19:26       ` Kalle Valo
2016-01-19 19:26     ` Kalle Valo
2016-01-19 19:26     ` Kalle Valo
2016-01-14  8:45 ` [PATCH] ssb: host_soc depends on sprom Rafał Miłecki
2016-01-14  8:45   ` Rafał Miłecki
2016-01-14  8:45   ` Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8128014.DbbgBtKY3z@wuerfel \
    --to=arnd@arndb.de \
    --cc=hauke@hauke-m.de \
    --cc=kvalo@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=m@bues.ch \
    --cc=netdev@vger.kernel.org \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.