All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafał Miłecki" <zajec5@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Kalle Valo <kvalo@codeaurora.org>,
	Hauke Mehrtens <hauke@hauke-m.de>, Michael Buesch <m@bues.ch>,
	"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Network Development <netdev@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ssb: host_soc depends on sprom
Date: Thu, 14 Jan 2016 09:45:44 +0100	[thread overview]
Message-ID: <CACna6rwAUh+LTBAepMTy1ZT7QhRYFPFmP5wPxyyQVb29gFwQYg@mail.gmail.com> (raw)
In-Reply-To: <8128014.DbbgBtKY3z@wuerfel>

On 13 January 2016 at 23:51, Arnd Bergmann <arnd@arndb.de> wrote:
> Drivers that use the SSB sprom functionality typically 'select SSB_SPROM'
> from Kconfig, but CONFIG_SSB_HOST_SOC misses this, which results in
> a build failure unless at least one of the other drivers that selects
> it is enabled:
>
> drivers/built-in.o: In function `ssb_host_soc_get_invariants':
> (.text+0x459494): undefined reference to `ssb_fill_sprom_with_fallback'
>
> This adds the same select statement that is used elsewhere.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 541c9a84cd85 ("ssb: pick SoC invariants code from MIPS BCM47xx arch")

I missed this dependency, thanks, patch looks OK.

WARNING: multiple messages have this Message-ID (diff)
From: zajec5@gmail.com (Rafał Miłecki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ssb: host_soc depends on sprom
Date: Thu, 14 Jan 2016 09:45:44 +0100	[thread overview]
Message-ID: <CACna6rwAUh+LTBAepMTy1ZT7QhRYFPFmP5wPxyyQVb29gFwQYg@mail.gmail.com> (raw)
In-Reply-To: <8128014.DbbgBtKY3z@wuerfel>

On 13 January 2016 at 23:51, Arnd Bergmann <arnd@arndb.de> wrote:
> Drivers that use the SSB sprom functionality typically 'select SSB_SPROM'
> from Kconfig, but CONFIG_SSB_HOST_SOC misses this, which results in
> a build failure unless at least one of the other drivers that selects
> it is enabled:
>
> drivers/built-in.o: In function `ssb_host_soc_get_invariants':
> (.text+0x459494): undefined reference to `ssb_fill_sprom_with_fallback'
>
> This adds the same select statement that is used elsewhere.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 541c9a84cd85 ("ssb: pick SoC invariants code from MIPS BCM47xx arch")

I missed this dependency, thanks, patch looks OK.

  parent reply	other threads:[~2016-01-14  8:45 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-13 22:51 [PATCH] ssb: host_soc depends on sprom Arnd Bergmann
2016-01-13 22:51 ` Arnd Bergmann
2016-01-14  6:46 ` Kalle Valo
2016-01-14  6:46   ` Kalle Valo
2016-01-14 21:46   ` David Miller
2016-01-14 21:46     ` David Miller
2016-01-14 23:13   ` [PATCH, RESEND] ssb: mark ssb_bus_register as __maybe_unused Arnd Bergmann
2016-01-14 23:13     ` Arnd Bergmann
2016-01-16 12:10     ` Kalle Valo
2016-01-16 12:10       ` Kalle Valo
2016-01-16 14:44       ` Rafał Miłecki
2016-01-16 14:44         ` Rafał Miłecki
2016-01-16 14:44         ` Rafał Miłecki
2016-01-18  8:26         ` Kalle Valo
2016-01-18  8:26           ` Kalle Valo
2016-01-18  8:26           ` Kalle Valo
2016-01-18  8:26           ` Kalle Valo
2016-01-18 16:53           ` ssb: Set linux-wireless as MAINTAINERS list Michael Büsch
2016-01-18 19:09             ` Rafał Miłecki
2016-01-18 19:09               ` Rafał Miłecki
2016-01-18 19:09               ` Rafał Miłecki
2016-01-19 13:04               ` Kalle Valo
2016-01-19 13:04                 ` Kalle Valo
2016-01-19 19:25             ` Kalle Valo
2016-01-19 19:25               ` Kalle Valo
2016-01-19 19:25             ` Kalle Valo
2016-01-19 19:25             ` Kalle Valo
2016-01-18 19:39   ` [PATCH, RESEND^2] ssb: mark ssb_bus_register as __maybe_unused Arnd Bergmann
2016-01-18 19:39     ` Arnd Bergmann
2016-01-19 13:03     ` Kalle Valo
2016-01-19 13:03       ` Kalle Valo
2016-01-19 13:03       ` Kalle Valo
2016-01-19 19:26     ` [RESEND^2] " Kalle Valo
2016-01-19 19:26       ` Kalle Valo
2016-01-19 19:26     ` Kalle Valo
2016-01-19 19:26     ` Kalle Valo
2016-01-14  8:45 ` Rafał Miłecki [this message]
2016-01-14  8:45   ` [PATCH] ssb: host_soc depends on sprom Rafał Miłecki
2016-01-14  8:45   ` Rafał Miłecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACna6rwAUh+LTBAepMTy1ZT7QhRYFPFmP5wPxyyQVb29gFwQYg@mail.gmail.com \
    --to=zajec5@gmail.com \
    --cc=arnd@arndb.de \
    --cc=hauke@hauke-m.de \
    --cc=kvalo@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=m@bues.ch \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.