From: Amit Daniel Kachhap <amit.kachhap@arm.com> To: Dave Martin <Dave.Martin@arm.com> Cc: Kristina Martsenko <kristina.martsenko@arm.com>, Marc Zyngier <marc.zyngier@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, linux-kernel@vger.kernel.org, Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v7 9/10] KVM: arm64: docs: document KVM support of pointer authentication Date: Thu, 28 Mar 2019 15:43:07 +0530 [thread overview] Message-ID: <82d60b1e-d08b-a8f8-457a-c9ead0378e0e@arm.com> (raw) In-Reply-To: <20190327135058.GW3567@e103592.cambridge.arm.com> Hi Dave, On 3/27/19 7:20 PM, Dave Martin wrote: > On Wed, Mar 27, 2019 at 05:19:28PM +0530, Amit Daniel Kachhap wrote: >> Hi, >> >> On 3/27/19 4:14 PM, Dave Martin wrote: >>> On Mon, Mar 25, 2019 at 08:05:49PM +0000, Kristina Martsenko wrote: >>>> On 19/03/2019 08:30, Amit Daniel Kachhap wrote: >>>>> This adds sections for KVM API extension for pointer authentication. >>>>> A brief description about usage of pointer authentication for KVM guests >>>>> is added in the arm64 documentations. >>>>> >>>>> Signed-off-by: Amit Daniel Kachhap <amit.kachhap@arm.com> >>>>> Cc: Mark Rutland <mark.rutland@arm.com> >>>>> Cc: Christoffer Dall <christoffer.dall@arm.com> >>>>> Cc: Marc Zyngier <marc.zyngier@arm.com> >>>>> Cc: kvmarm@lists.cs.columbia.edu >>>> >>>> I think it makes sense to also update the Kconfig symbol description for >>>> CONFIG_ARM64_PTR_AUTH, since it currently only mentions userspace >>>> support, but now the option also enables KVM guest support. >>>> >>>> It's also worth mentioning that CONFIG_ARM64_VHE=y is required for guest >>>> support. >>> >>> Is it worth making this dependency explicit in Kconfig? >> Currently there is discrepancy that userspace supports ptrauth in both >> nVHE/VHE mode and KVM guest only in VHE mode. I suppose adding explicit >> dependency flag here makes both of them similar. > > Looking at the history, for SVE this Kconfig restriction has always been > present. Since ptrauth initially upstreamed without an equivalent > restriction in Kconfig, adding it now could be seen as a regression. ok it makes sense to keep it this way. > > So, maybe it's not worth it here. > > You could add a separate option, say > > config ARM64_PTR_AUTH_KVM > bool "Pointer authentication support for KVM guests" > default y > depends on ARM64_PTR_AUTH && ARM64_VHE && KVM > > ...but that may be overkill. I was thinking for adding some details for this in virtualization section in Documentation/arm64/pointer-authentication.txt along with brief comment in arch/arm64/Kconfig. Thanks, Amit D > > Cheers, > ---Dave >
WARNING: multiple messages have this Message-ID (diff)
From: Amit Daniel Kachhap <amit.kachhap@arm.com> To: Dave Martin <Dave.Martin@arm.com> Cc: Marc Zyngier <marc.zyngier@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, linux-kernel@vger.kernel.org, Kristina Martsenko <kristina.martsenko@arm.com>, Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v7 9/10] KVM: arm64: docs: document KVM support of pointer authentication Date: Thu, 28 Mar 2019 15:43:07 +0530 [thread overview] Message-ID: <82d60b1e-d08b-a8f8-457a-c9ead0378e0e@arm.com> (raw) In-Reply-To: <20190327135058.GW3567@e103592.cambridge.arm.com> Hi Dave, On 3/27/19 7:20 PM, Dave Martin wrote: > On Wed, Mar 27, 2019 at 05:19:28PM +0530, Amit Daniel Kachhap wrote: >> Hi, >> >> On 3/27/19 4:14 PM, Dave Martin wrote: >>> On Mon, Mar 25, 2019 at 08:05:49PM +0000, Kristina Martsenko wrote: >>>> On 19/03/2019 08:30, Amit Daniel Kachhap wrote: >>>>> This adds sections for KVM API extension for pointer authentication. >>>>> A brief description about usage of pointer authentication for KVM guests >>>>> is added in the arm64 documentations. >>>>> >>>>> Signed-off-by: Amit Daniel Kachhap <amit.kachhap@arm.com> >>>>> Cc: Mark Rutland <mark.rutland@arm.com> >>>>> Cc: Christoffer Dall <christoffer.dall@arm.com> >>>>> Cc: Marc Zyngier <marc.zyngier@arm.com> >>>>> Cc: kvmarm@lists.cs.columbia.edu >>>> >>>> I think it makes sense to also update the Kconfig symbol description for >>>> CONFIG_ARM64_PTR_AUTH, since it currently only mentions userspace >>>> support, but now the option also enables KVM guest support. >>>> >>>> It's also worth mentioning that CONFIG_ARM64_VHE=y is required for guest >>>> support. >>> >>> Is it worth making this dependency explicit in Kconfig? >> Currently there is discrepancy that userspace supports ptrauth in both >> nVHE/VHE mode and KVM guest only in VHE mode. I suppose adding explicit >> dependency flag here makes both of them similar. > > Looking at the history, for SVE this Kconfig restriction has always been > present. Since ptrauth initially upstreamed without an equivalent > restriction in Kconfig, adding it now could be seen as a regression. ok it makes sense to keep it this way. > > So, maybe it's not worth it here. > > You could add a separate option, say > > config ARM64_PTR_AUTH_KVM > bool "Pointer authentication support for KVM guests" > default y > depends on ARM64_PTR_AUTH && ARM64_VHE && KVM > > ...but that may be overkill. I was thinking for adding some details for this in virtualization section in Documentation/arm64/pointer-authentication.txt along with brief comment in arch/arm64/Kconfig. Thanks, Amit D > > Cheers, > ---Dave > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-28 10:13 UTC|newest] Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-19 8:30 [PATCH v7 0/10] Add ARMv8.3 pointer authentication for kvm guest Amit Daniel Kachhap 2019-03-19 8:30 ` Amit Daniel Kachhap 2019-03-19 8:30 ` [PATCH v7 1/10] KVM: arm64: Propagate vcpu into read_id_reg() Amit Daniel Kachhap 2019-03-19 8:30 ` Amit Daniel Kachhap 2019-03-19 8:30 ` [PATCH v7 2/10] KVM: arm64: Support runtime sysreg visibility filtering Amit Daniel Kachhap 2019-03-19 8:30 ` Amit Daniel Kachhap 2019-03-19 8:30 ` [PATCH v7 3/10] KVM: arm64: Move hyp_symbol_addr to fix dependency Amit Daniel Kachhap 2019-03-19 8:30 ` Amit Daniel Kachhap 2019-03-20 8:49 ` Julien Thierry 2019-03-20 8:49 ` Julien Thierry 2019-03-21 5:29 ` Amit Daniel Kachhap 2019-03-21 5:29 ` Amit Daniel Kachhap 2019-03-21 5:29 ` Amit Daniel Kachhap 2019-03-19 8:30 ` [PATCH v7 4/10] KVM: arm/arm64: preserve host HCR_EL2 value Amit Daniel Kachhap 2019-03-19 8:30 ` Amit Daniel Kachhap 2019-03-19 8:30 ` [PATCH v7 5/10] KVM: arm/arm64: preserve host MDCR_EL2 value Amit Daniel Kachhap 2019-03-19 8:30 ` Amit Daniel Kachhap 2019-03-25 20:04 ` Kristina Martsenko 2019-03-25 20:04 ` Kristina Martsenko 2019-03-26 3:55 ` Amit Daniel Kachhap 2019-03-26 3:55 ` Amit Daniel Kachhap 2019-03-19 8:30 ` [PATCH v7 6/10] KVM: arm64: Add vcpu feature flags to control ptrauth accessibility Amit Daniel Kachhap 2019-03-19 8:30 ` Amit Daniel Kachhap 2019-03-19 8:30 ` [PATCH v7 7/10] KVM: arm/arm64: context-switch ptrauth registers Amit Daniel Kachhap 2019-03-19 8:30 ` Amit Daniel Kachhap 2019-03-20 12:13 ` Julien Thierry 2019-03-20 12:13 ` Julien Thierry 2019-03-21 6:08 ` Amit Daniel Kachhap 2019-03-21 6:08 ` Amit Daniel Kachhap 2019-03-21 8:29 ` Julien Thierry 2019-03-21 8:29 ` Julien Thierry 2019-03-25 20:04 ` Kristina Martsenko 2019-03-25 20:04 ` Kristina Martsenko 2019-03-26 4:03 ` Amit Daniel Kachhap 2019-03-26 4:03 ` Amit Daniel Kachhap 2019-03-26 18:01 ` Kristina Martsenko 2019-03-26 18:01 ` Kristina Martsenko 2019-03-27 3:21 ` Amit Daniel Kachhap 2019-03-27 3:21 ` Amit Daniel Kachhap 2019-03-27 3:21 ` Amit Daniel Kachhap 2019-03-27 18:16 ` James Morse 2019-03-27 18:16 ` James Morse 2019-03-27 18:16 ` James Morse 2019-03-28 11:29 ` Amit Daniel Kachhap 2019-03-28 11:29 ` Amit Daniel Kachhap 2019-03-28 18:51 ` James Morse 2019-03-28 18:51 ` James Morse 2019-03-29 5:54 ` Amit Daniel Kachhap 2019-03-29 5:54 ` Amit Daniel Kachhap 2019-03-29 5:54 ` Amit Daniel Kachhap 2019-03-19 8:30 ` [PATCH v7 8/10] KVM: arm64: Add capability to advertise ptrauth for guest Amit Daniel Kachhap 2019-03-19 8:30 ` Amit Daniel Kachhap 2019-03-19 8:30 ` Amit Daniel Kachhap 2019-03-25 20:05 ` Kristina Martsenko 2019-03-25 20:05 ` Kristina Martsenko 2019-03-26 4:12 ` Amit Daniel Kachhap 2019-03-26 4:12 ` Amit Daniel Kachhap 2019-03-26 4:12 ` Amit Daniel Kachhap 2019-03-19 8:30 ` [PATCH v7 9/10] KVM: arm64: docs: document KVM support of pointer authentication Amit Daniel Kachhap 2019-03-19 8:30 ` Amit Daniel Kachhap 2019-03-20 13:37 ` Julien Thierry 2019-03-20 13:37 ` Julien Thierry 2019-03-20 15:04 ` Kristina Martsenko 2019-03-20 15:04 ` Kristina Martsenko 2019-03-20 18:06 ` Julien Thierry 2019-03-20 18:06 ` Julien Thierry 2019-03-20 20:56 ` Kristina Martsenko 2019-03-20 20:56 ` Kristina Martsenko 2019-03-21 6:41 ` Amit Daniel Kachhap 2019-03-21 6:41 ` Amit Daniel Kachhap 2019-03-25 20:05 ` Kristina Martsenko 2019-03-25 20:05 ` Kristina Martsenko 2019-03-27 10:44 ` Dave Martin 2019-03-27 10:44 ` Dave Martin 2019-03-27 11:49 ` Amit Daniel Kachhap 2019-03-27 11:49 ` Amit Daniel Kachhap 2019-03-27 13:50 ` Dave Martin 2019-03-27 13:50 ` Dave Martin 2019-03-28 10:13 ` Amit Daniel Kachhap [this message] 2019-03-28 10:13 ` Amit Daniel Kachhap 2019-03-19 8:30 ` [kvmtool PATCH v7 10/10] KVM: arm/arm64: Add a vcpu feature for " Amit Daniel Kachhap 2019-03-19 8:30 ` Amit Daniel Kachhap
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=82d60b1e-d08b-a8f8-457a-c9ead0378e0e@arm.com \ --to=amit.kachhap@arm.com \ --cc=Dave.Martin@arm.com \ --cc=catalin.marinas@arm.com \ --cc=kristina.martsenko@arm.com \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=ramana.radhakrishnan@arm.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.