From: Amit Daniel Kachhap <amit.kachhap@arm.com> To: Kristina Martsenko <kristina.martsenko@arm.com>, linux-arm-kernel@lists.infradead.org Cc: Christoffer Dall <christoffer.dall@arm.com>, Marc Zyngier <marc.zyngier@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Andrew Jones <drjones@redhat.com>, Dave Martin <Dave.Martin@arm.com>, Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>, James Morse <james.morse@arm.com>, Julien Thierry <julien.thierry@arm.com> Subject: Re: [PATCH v7 5/10] KVM: arm/arm64: preserve host MDCR_EL2 value Date: Tue, 26 Mar 2019 09:25:36 +0530 [thread overview] Message-ID: <bce98120-b844-f4a2-cd44-a0e8418dfd13@arm.com> (raw) In-Reply-To: <19c2bdb3-6917-286e-3f2a-35fd71f69f51@arm.com> Hi, On 3/26/19 1:34 AM, Kristina Martsenko wrote: > On 19/03/2019 08:30, Amit Daniel Kachhap wrote: >> Save host MDCR_EL2 value during kvm HYP initialisation and restore >> after every switch from host to guest. There should not be any >> change in functionality due to this. >> >> The value of mdcr_el2 is now stored in struct kvm_cpu_context as >> both host and guest can now use this field in a common way. >> >> Signed-off-by: Amit Daniel Kachhap <amit.kachhap@arm.com> >> Acked-by: Mark Rutland <mark.rutland@arm.com> >> Cc: Marc Zyngier <marc.zyngier@arm.com> >> Cc: Mark Rutland <mark.rutland@arm.com> >> Cc: Christoffer Dall <christoffer.dall@arm.com> >> Cc: kvmarm@lists.cs.columbia.edu > > [...] > >> /** >> - * kvm_arm_init_debug - grab what we need for debug >> - * >> - * Currently the sole task of this function is to retrieve the initial >> - * value of mdcr_el2 so we can preserve MDCR_EL2.HPMN which has >> - * presumably been set-up by some knowledgeable bootcode. >> - * >> - * It is called once per-cpu during CPU hyp initialisation. >> - */ >> - >> -void kvm_arm_init_debug(void) >> -{ >> - __this_cpu_write(mdcr_el2, kvm_call_hyp_ret(__kvm_get_mdcr_el2)); >> -} > > The __kvm_get_mdcr_el2 function is no longer used anywhere, so can also > be removed. Nice catch. Will do. Thanks, Amit D > > Thanks, > Kristina >
WARNING: multiple messages have this Message-ID (diff)
From: Amit Daniel Kachhap <amit.kachhap@arm.com> To: Kristina Martsenko <kristina.martsenko@arm.com>, linux-arm-kernel@lists.infradead.org Cc: Mark Rutland <mark.rutland@arm.com>, Andrew Jones <drjones@redhat.com>, Julien Thierry <julien.thierry@arm.com>, Marc Zyngier <marc.zyngier@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Christoffer Dall <christoffer.dall@arm.com>, kvmarm@lists.cs.columbia.edu, James Morse <james.morse@arm.com>, Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>, Dave Martin <Dave.Martin@arm.com>, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 5/10] KVM: arm/arm64: preserve host MDCR_EL2 value Date: Tue, 26 Mar 2019 09:25:36 +0530 [thread overview] Message-ID: <bce98120-b844-f4a2-cd44-a0e8418dfd13@arm.com> (raw) In-Reply-To: <19c2bdb3-6917-286e-3f2a-35fd71f69f51@arm.com> Hi, On 3/26/19 1:34 AM, Kristina Martsenko wrote: > On 19/03/2019 08:30, Amit Daniel Kachhap wrote: >> Save host MDCR_EL2 value during kvm HYP initialisation and restore >> after every switch from host to guest. There should not be any >> change in functionality due to this. >> >> The value of mdcr_el2 is now stored in struct kvm_cpu_context as >> both host and guest can now use this field in a common way. >> >> Signed-off-by: Amit Daniel Kachhap <amit.kachhap@arm.com> >> Acked-by: Mark Rutland <mark.rutland@arm.com> >> Cc: Marc Zyngier <marc.zyngier@arm.com> >> Cc: Mark Rutland <mark.rutland@arm.com> >> Cc: Christoffer Dall <christoffer.dall@arm.com> >> Cc: kvmarm@lists.cs.columbia.edu > > [...] > >> /** >> - * kvm_arm_init_debug - grab what we need for debug >> - * >> - * Currently the sole task of this function is to retrieve the initial >> - * value of mdcr_el2 so we can preserve MDCR_EL2.HPMN which has >> - * presumably been set-up by some knowledgeable bootcode. >> - * >> - * It is called once per-cpu during CPU hyp initialisation. >> - */ >> - >> -void kvm_arm_init_debug(void) >> -{ >> - __this_cpu_write(mdcr_el2, kvm_call_hyp_ret(__kvm_get_mdcr_el2)); >> -} > > The __kvm_get_mdcr_el2 function is no longer used anywhere, so can also > be removed. Nice catch. Will do. Thanks, Amit D > > Thanks, > Kristina > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-26 3:55 UTC|newest] Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-19 8:30 [PATCH v7 0/10] Add ARMv8.3 pointer authentication for kvm guest Amit Daniel Kachhap 2019-03-19 8:30 ` Amit Daniel Kachhap 2019-03-19 8:30 ` [PATCH v7 1/10] KVM: arm64: Propagate vcpu into read_id_reg() Amit Daniel Kachhap 2019-03-19 8:30 ` Amit Daniel Kachhap 2019-03-19 8:30 ` [PATCH v7 2/10] KVM: arm64: Support runtime sysreg visibility filtering Amit Daniel Kachhap 2019-03-19 8:30 ` Amit Daniel Kachhap 2019-03-19 8:30 ` [PATCH v7 3/10] KVM: arm64: Move hyp_symbol_addr to fix dependency Amit Daniel Kachhap 2019-03-19 8:30 ` Amit Daniel Kachhap 2019-03-20 8:49 ` Julien Thierry 2019-03-20 8:49 ` Julien Thierry 2019-03-21 5:29 ` Amit Daniel Kachhap 2019-03-21 5:29 ` Amit Daniel Kachhap 2019-03-21 5:29 ` Amit Daniel Kachhap 2019-03-19 8:30 ` [PATCH v7 4/10] KVM: arm/arm64: preserve host HCR_EL2 value Amit Daniel Kachhap 2019-03-19 8:30 ` Amit Daniel Kachhap 2019-03-19 8:30 ` [PATCH v7 5/10] KVM: arm/arm64: preserve host MDCR_EL2 value Amit Daniel Kachhap 2019-03-19 8:30 ` Amit Daniel Kachhap 2019-03-25 20:04 ` Kristina Martsenko 2019-03-25 20:04 ` Kristina Martsenko 2019-03-26 3:55 ` Amit Daniel Kachhap [this message] 2019-03-26 3:55 ` Amit Daniel Kachhap 2019-03-19 8:30 ` [PATCH v7 6/10] KVM: arm64: Add vcpu feature flags to control ptrauth accessibility Amit Daniel Kachhap 2019-03-19 8:30 ` Amit Daniel Kachhap 2019-03-19 8:30 ` [PATCH v7 7/10] KVM: arm/arm64: context-switch ptrauth registers Amit Daniel Kachhap 2019-03-19 8:30 ` Amit Daniel Kachhap 2019-03-20 12:13 ` Julien Thierry 2019-03-20 12:13 ` Julien Thierry 2019-03-21 6:08 ` Amit Daniel Kachhap 2019-03-21 6:08 ` Amit Daniel Kachhap 2019-03-21 8:29 ` Julien Thierry 2019-03-21 8:29 ` Julien Thierry 2019-03-25 20:04 ` Kristina Martsenko 2019-03-25 20:04 ` Kristina Martsenko 2019-03-26 4:03 ` Amit Daniel Kachhap 2019-03-26 4:03 ` Amit Daniel Kachhap 2019-03-26 18:01 ` Kristina Martsenko 2019-03-26 18:01 ` Kristina Martsenko 2019-03-27 3:21 ` Amit Daniel Kachhap 2019-03-27 3:21 ` Amit Daniel Kachhap 2019-03-27 3:21 ` Amit Daniel Kachhap 2019-03-27 18:16 ` James Morse 2019-03-27 18:16 ` James Morse 2019-03-27 18:16 ` James Morse 2019-03-28 11:29 ` Amit Daniel Kachhap 2019-03-28 11:29 ` Amit Daniel Kachhap 2019-03-28 18:51 ` James Morse 2019-03-28 18:51 ` James Morse 2019-03-29 5:54 ` Amit Daniel Kachhap 2019-03-29 5:54 ` Amit Daniel Kachhap 2019-03-29 5:54 ` Amit Daniel Kachhap 2019-03-19 8:30 ` [PATCH v7 8/10] KVM: arm64: Add capability to advertise ptrauth for guest Amit Daniel Kachhap 2019-03-19 8:30 ` Amit Daniel Kachhap 2019-03-19 8:30 ` Amit Daniel Kachhap 2019-03-25 20:05 ` Kristina Martsenko 2019-03-25 20:05 ` Kristina Martsenko 2019-03-26 4:12 ` Amit Daniel Kachhap 2019-03-26 4:12 ` Amit Daniel Kachhap 2019-03-26 4:12 ` Amit Daniel Kachhap 2019-03-19 8:30 ` [PATCH v7 9/10] KVM: arm64: docs: document KVM support of pointer authentication Amit Daniel Kachhap 2019-03-19 8:30 ` Amit Daniel Kachhap 2019-03-20 13:37 ` Julien Thierry 2019-03-20 13:37 ` Julien Thierry 2019-03-20 15:04 ` Kristina Martsenko 2019-03-20 15:04 ` Kristina Martsenko 2019-03-20 18:06 ` Julien Thierry 2019-03-20 18:06 ` Julien Thierry 2019-03-20 20:56 ` Kristina Martsenko 2019-03-20 20:56 ` Kristina Martsenko 2019-03-21 6:41 ` Amit Daniel Kachhap 2019-03-21 6:41 ` Amit Daniel Kachhap 2019-03-25 20:05 ` Kristina Martsenko 2019-03-25 20:05 ` Kristina Martsenko 2019-03-27 10:44 ` Dave Martin 2019-03-27 10:44 ` Dave Martin 2019-03-27 11:49 ` Amit Daniel Kachhap 2019-03-27 11:49 ` Amit Daniel Kachhap 2019-03-27 13:50 ` Dave Martin 2019-03-27 13:50 ` Dave Martin 2019-03-28 10:13 ` Amit Daniel Kachhap 2019-03-28 10:13 ` Amit Daniel Kachhap 2019-03-19 8:30 ` [kvmtool PATCH v7 10/10] KVM: arm/arm64: Add a vcpu feature for " Amit Daniel Kachhap 2019-03-19 8:30 ` Amit Daniel Kachhap
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bce98120-b844-f4a2-cd44-a0e8418dfd13@arm.com \ --to=amit.kachhap@arm.com \ --cc=Dave.Martin@arm.com \ --cc=catalin.marinas@arm.com \ --cc=christoffer.dall@arm.com \ --cc=drjones@redhat.com \ --cc=james.morse@arm.com \ --cc=julien.thierry@arm.com \ --cc=kristina.martsenko@arm.com \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=mark.rutland@arm.com \ --cc=ramana.radhakrishnan@arm.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.