* [Buildroot] [PATCH 1/1] package/fontconfig: fix per-package build with NLS
@ 2021-08-13 21:16 Fabrice Fontaine
2021-08-15 7:25 ` Thomas Petazzoni
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Fabrice Fontaine @ 2021-08-13 21:16 UTC (permalink / raw)
To: buildroot; +Cc: Fabrice Fontaine
Add TARGET_NLS_DEPENDENCIES and host-gettext dependency to avoid the
following build failure with host-cairo raised because fontconfig
installs its ITS files in the wrong directory (i.e. outside of
gettext-tiny symlink):
mkdir -p /tmp/instance-0/output-1/per-package/host-cairo/host
rsync -a --link-dest=/tmp/instance-0/output-1/per-package/host-fontconfig/host/ /tmp/instance-0/output-1/per-package/host-fontconfig/host/ /tmp/instance-0/output-1/per-package/host-cairo/host
rsync -a --link-dest=/tmp/instance-0/output-1/per-package/host-freetype/host/ /tmp/instance-0/output-1/per-package/host-freetype/host/ /tmp/instance-0/output-1/per-package/host-cairo/host
rsync -a --link-dest=/tmp/instance-0/output-1/per-package/host-libglib2/host/ /tmp/instance-0/output-1/per-package/host-libglib2/host/ /tmp/instance-0/output-1/per-package/host-cairo/host
cannot delete non-empty directory: share/gettext
could not make way for new symlink: share/gettext
Fixes:
- http://autobuild.buildroot.org/results/00e29958cecfffa4e994ab549637117dd8f55c30
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/fontconfig/fontconfig.mk | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/package/fontconfig/fontconfig.mk b/package/fontconfig/fontconfig.mk
index d59e893d4d..e34acde534 100644
--- a/package/fontconfig/fontconfig.mk
+++ b/package/fontconfig/fontconfig.mk
@@ -11,9 +11,11 @@ FONTCONFIG_SOURCE = fontconfig-$(FONTCONFIG_VERSION).tar.bz2
FONTCONFIG_AUTORECONF = YES
FONTCONFIG_INSTALL_STAGING = YES
FONTCONFIG_DEPENDENCIES = freetype expat host-pkgconf host-gperf \
- $(if $(BR2_PACKAGE_UTIL_LINUX_LIBS),util-linux-libs,util-linux)
+ $(if $(BR2_PACKAGE_UTIL_LINUX_LIBS),util-linux-libs,util-linux) \
+ $(TARGET_NLS_DEPENDENCIES)
HOST_FONTCONFIG_DEPENDENCIES = \
- host-freetype host-expat host-pkgconf host-gperf host-util-linux
+ host-freetype host-expat host-pkgconf host-gperf host-util-linux \
+ host-gettext
FONTCONFIG_LICENSE = fontconfig license
FONTCONFIG_LICENSE_FILES = COPYING
FONTCONFIG_CPE_ID_VENDOR = fontconfig_project
--
2.30.2
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Buildroot] [PATCH 1/1] package/fontconfig: fix per-package build with NLS
2021-08-13 21:16 [Buildroot] [PATCH 1/1] package/fontconfig: fix per-package build with NLS Fabrice Fontaine
@ 2021-08-15 7:25 ` Thomas Petazzoni
2021-08-15 7:38 ` Fabrice Fontaine
2021-08-17 19:48 ` Arnout Vandecappelle
2021-09-04 21:36 ` Peter Korsgaard
2 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2021-08-15 7:25 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
On Fri, 13 Aug 2021 23:16:48 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Add TARGET_NLS_DEPENDENCIES and host-gettext dependency to avoid the
> following build failure with host-cairo raised because fontconfig
> installs its ITS files in the wrong directory (i.e. outside of
> gettext-tiny symlink):
>
> mkdir -p /tmp/instance-0/output-1/per-package/host-cairo/host
> rsync -a --link-dest=/tmp/instance-0/output-1/per-package/host-fontconfig/host/ /tmp/instance-0/output-1/per-package/host-fontconfig/host/ /tmp/instance-0/output-1/per-package/host-cairo/host
> rsync -a --link-dest=/tmp/instance-0/output-1/per-package/host-freetype/host/ /tmp/instance-0/output-1/per-package/host-freetype/host/ /tmp/instance-0/output-1/per-package/host-cairo/host
> rsync -a --link-dest=/tmp/instance-0/output-1/per-package/host-libglib2/host/ /tmp/instance-0/output-1/per-package/host-libglib2/host/ /tmp/instance-0/output-1/per-package/host-cairo/host
> cannot delete non-empty directory: share/gettext
> could not make way for new symlink: share/gettext
>
> Fixes:
> - http://autobuild.buildroot.org/results/00e29958cecfffa4e994ab549637117dd8f55c30
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/fontconfig/fontconfig.mk | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Do you have some more details as to why this is specific to per-package
builds?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/fontconfig: fix per-package build with NLS
2021-08-15 7:25 ` Thomas Petazzoni
@ 2021-08-15 7:38 ` Fabrice Fontaine
0 siblings, 0 replies; 5+ messages in thread
From: Fabrice Fontaine @ 2021-08-15 7:38 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: Buildroot Mailing List
Le dim. 15 août 2021 à 09:25, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a écrit :
>
> On Fri, 13 Aug 2021 23:16:48 +0200
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>
> > Add TARGET_NLS_DEPENDENCIES and host-gettext dependency to avoid the
> > following build failure with host-cairo raised because fontconfig
> > installs its ITS files in the wrong directory (i.e. outside of
> > gettext-tiny symlink):
> >
> > mkdir -p /tmp/instance-0/output-1/per-package/host-cairo/host
> > rsync -a --link-dest=/tmp/instance-0/output-1/per-package/host-fontconfig/host/ /tmp/instance-0/output-1/per-package/host-fontconfig/host/ /tmp/instance-0/output-1/per-package/host-cairo/host
> > rsync -a --link-dest=/tmp/instance-0/output-1/per-package/host-freetype/host/ /tmp/instance-0/output-1/per-package/host-freetype/host/ /tmp/instance-0/output-1/per-package/host-cairo/host
> > rsync -a --link-dest=/tmp/instance-0/output-1/per-package/host-libglib2/host/ /tmp/instance-0/output-1/per-package/host-libglib2/host/ /tmp/instance-0/output-1/per-package/host-cairo/host
> > cannot delete non-empty directory: share/gettext
> > could not make way for new symlink: share/gettext
> >
> > Fixes:
> > - http://autobuild.buildroot.org/results/00e29958cecfffa4e994ab549637117dd8f55c30
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> > package/fontconfig/fontconfig.mk | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
>
> Do you have some more details as to why this is specific to per-package
> builds?
The build failure is only raised with per-package build because
per-package-rsync function in pkg-utils.mk is not able to rsync
share/gettext as gettext is a "standard" directory for fontconfig and
a symlink for other packages (e.g. libglib2).
However, even if we don't have build failures, the missing
dependencies could probably raise unexpected runtime issues with
"normal" builds.
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,
Fabrice
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/fontconfig: fix per-package build with NLS
2021-08-13 21:16 [Buildroot] [PATCH 1/1] package/fontconfig: fix per-package build with NLS Fabrice Fontaine
2021-08-15 7:25 ` Thomas Petazzoni
@ 2021-08-17 19:48 ` Arnout Vandecappelle
2021-09-04 21:36 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Arnout Vandecappelle @ 2021-08-17 19:48 UTC (permalink / raw)
To: Fabrice Fontaine, buildroot
On 13/08/2021 23:16, Fabrice Fontaine wrote:
> Add TARGET_NLS_DEPENDENCIES and host-gettext dependency to avoid the
> following build failure with host-cairo raised because fontconfig
> installs its ITS files in the wrong directory (i.e. outside of
> gettext-tiny symlink):
>
> mkdir -p /tmp/instance-0/output-1/per-package/host-cairo/host
> rsync -a --link-dest=/tmp/instance-0/output-1/per-package/host-fontconfig/host/ /tmp/instance-0/output-1/per-package/host-fontconfig/host/ /tmp/instance-0/output-1/per-package/host-cairo/host
> rsync -a --link-dest=/tmp/instance-0/output-1/per-package/host-freetype/host/ /tmp/instance-0/output-1/per-package/host-freetype/host/ /tmp/instance-0/output-1/per-package/host-cairo/host
> rsync -a --link-dest=/tmp/instance-0/output-1/per-package/host-libglib2/host/ /tmp/instance-0/output-1/per-package/host-libglib2/host/ /tmp/instance-0/output-1/per-package/host-cairo/host
> cannot delete non-empty directory: share/gettext
> could not make way for new symlink: share/gettext
>
> Fixes:
> - http://autobuild.buildroot.org/results/00e29958cecfffa4e994ab549637117dd8f55c30
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
I've extended the commit message a bit to explain why it only happens with PPD.
Regards,
Arnout
> ---
> package/fontconfig/fontconfig.mk | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/package/fontconfig/fontconfig.mk b/package/fontconfig/fontconfig.mk
> index d59e893d4d..e34acde534 100644
> --- a/package/fontconfig/fontconfig.mk
> +++ b/package/fontconfig/fontconfig.mk
> @@ -11,9 +11,11 @@ FONTCONFIG_SOURCE = fontconfig-$(FONTCONFIG_VERSION).tar.bz2
> FONTCONFIG_AUTORECONF = YES
> FONTCONFIG_INSTALL_STAGING = YES
> FONTCONFIG_DEPENDENCIES = freetype expat host-pkgconf host-gperf \
> - $(if $(BR2_PACKAGE_UTIL_LINUX_LIBS),util-linux-libs,util-linux)
> + $(if $(BR2_PACKAGE_UTIL_LINUX_LIBS),util-linux-libs,util-linux) \
> + $(TARGET_NLS_DEPENDENCIES)
> HOST_FONTCONFIG_DEPENDENCIES = \
> - host-freetype host-expat host-pkgconf host-gperf host-util-linux
> + host-freetype host-expat host-pkgconf host-gperf host-util-linux \
> + host-gettext
> FONTCONFIG_LICENSE = fontconfig license
> FONTCONFIG_LICENSE_FILES = COPYING
> FONTCONFIG_CPE_ID_VENDOR = fontconfig_project
>
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/fontconfig: fix per-package build with NLS
2021-08-13 21:16 [Buildroot] [PATCH 1/1] package/fontconfig: fix per-package build with NLS Fabrice Fontaine
2021-08-15 7:25 ` Thomas Petazzoni
2021-08-17 19:48 ` Arnout Vandecappelle
@ 2021-09-04 21:36 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2021-09-04 21:36 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Add TARGET_NLS_DEPENDENCIES and host-gettext dependency to avoid the
> following build failure with host-cairo raised because fontconfig
> installs its ITS files in the wrong directory (i.e. outside of
> gettext-tiny symlink):
> mkdir -p /tmp/instance-0/output-1/per-package/host-cairo/host
> rsync -a
> --link-dest=/tmp/instance-0/output-1/per-package/host-fontconfig/host/
> /tmp/instance-0/output-1/per-package/host-fontconfig/host/
> /tmp/instance-0/output-1/per-package/host-cairo/host
> rsync -a
> --link-dest=/tmp/instance-0/output-1/per-package/host-freetype/host/
> /tmp/instance-0/output-1/per-package/host-freetype/host/
> /tmp/instance-0/output-1/per-package/host-cairo/host
> rsync -a
> --link-dest=/tmp/instance-0/output-1/per-package/host-libglib2/host/
> /tmp/instance-0/output-1/per-package/host-libglib2/host/
> /tmp/instance-0/output-1/per-package/host-cairo/host
> cannot delete non-empty directory: share/gettext
> could not make way for new symlink: share/gettext
> Fixes:
> - http://autobuild.buildroot.org/results/00e29958cecfffa4e994ab549637117dd8f55c30
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2021.02.x and 2021.05.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-09-04 21:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-13 21:16 [Buildroot] [PATCH 1/1] package/fontconfig: fix per-package build with NLS Fabrice Fontaine
2021-08-15 7:25 ` Thomas Petazzoni
2021-08-15 7:38 ` Fabrice Fontaine
2021-08-17 19:48 ` Arnout Vandecappelle
2021-09-04 21:36 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.