* [Qemu-devel] [PATCH 1/1] vl: fix tracing initialization
@ 2016-02-09 16:49 Denis V. Lunev
2016-02-09 22:20 ` Alex Bennée
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Denis V. Lunev @ 2016-02-09 16:49 UTC (permalink / raw)
Cc: Denis V. Lunev, Alex Bennée, qemu-devel, Stefan Hajnoczi,
Paolo Bonzini
we should call trace_init_backends() before trace_init_file() for
CONFIG_TRACE_SIMPLE There is no difference for other cases.
This problem was introduced by the commit
commit 41fc57e44ed64cd4ab5393d83624afd897dabd4f
Author: Paolo Bonzini <pbonzini@redhat.com>
Date: Thu Jan 7 16:55:24 2016 +0300
trace: split trace_init_file out of trace_init_backends
'make check' was failed as a result if configured with
--enable-trace-backends=simple
Spotted by Alex Bennée.
Signed-off-by: Denis V. Lunev <den@openvz.org>
CC: Alex Bennée <alex.bennee@linaro.org>
CC: Paolo Bonzini <pbonzini@redhat.com>
CC: Stefan Hajnoczi <stefanha@redhat.com>
---
vl.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/vl.c b/vl.c
index c581e39..ffaf8b7 100644
--- a/vl.c
+++ b/vl.c
@@ -4098,6 +4098,9 @@ int main(int argc, char **argv, char **envp)
exit(0);
}
+ if (!trace_init_backends()) {
+ exit(1);
+ }
trace_init_file(trace_file);
/* Open the logfile at this point and set the log mask if necessary.
@@ -4118,10 +4121,6 @@ int main(int argc, char **argv, char **envp)
qemu_set_log(0);
}
- if (!trace_init_backends()) {
- exit(1);
- }
-
/* If no data_dir is specified then try to find it relative to the
executable path. */
if (data_dir_idx < ARRAY_SIZE(data_dir)) {
--
2.5.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH 1/1] vl: fix tracing initialization
2016-02-09 16:49 [Qemu-devel] [PATCH 1/1] vl: fix tracing initialization Denis V. Lunev
@ 2016-02-09 22:20 ` Alex Bennée
2016-02-10 9:32 ` Christian Borntraeger
2016-02-11 15:45 ` Stefan Hajnoczi
2 siblings, 0 replies; 6+ messages in thread
From: Alex Bennée @ 2016-02-09 22:20 UTC (permalink / raw)
To: Denis V. Lunev; +Cc: Paolo Bonzini, qemu-devel, Stefan Hajnoczi
Denis V. Lunev <den@openvz.org> writes:
> we should call trace_init_backends() before trace_init_file() for
> CONFIG_TRACE_SIMPLE There is no difference for other cases.
>
> This problem was introduced by the commit
> commit 41fc57e44ed64cd4ab5393d83624afd897dabd4f
> Author: Paolo Bonzini <pbonzini@redhat.com>
> Date: Thu Jan 7 16:55:24 2016 +0300
>
> trace: split trace_init_file out of trace_init_backends
>
> 'make check' was failed as a result if configured with
> --enable-trace-backends=simple
>
> Spotted by Alex Bennée.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Alex Bennée <alex.bennee@linaro.org>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Alex Bennée <alex.bennee@linaro.org>
https://travis-ci.org/stsquad/qemu/builds/108114393
> ---
> vl.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index c581e39..ffaf8b7 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4098,6 +4098,9 @@ int main(int argc, char **argv, char **envp)
> exit(0);
> }
>
> + if (!trace_init_backends()) {
> + exit(1);
> + }
> trace_init_file(trace_file);
>
> /* Open the logfile at this point and set the log mask if necessary.
> @@ -4118,10 +4121,6 @@ int main(int argc, char **argv, char **envp)
> qemu_set_log(0);
> }
>
> - if (!trace_init_backends()) {
> - exit(1);
> - }
> -
> /* If no data_dir is specified then try to find it relative to the
> executable path. */
> if (data_dir_idx < ARRAY_SIZE(data_dir)) {
--
Alex Bennée
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH 1/1] vl: fix tracing initialization
2016-02-09 16:49 [Qemu-devel] [PATCH 1/1] vl: fix tracing initialization Denis V. Lunev
2016-02-09 22:20 ` Alex Bennée
@ 2016-02-10 9:32 ` Christian Borntraeger
2016-02-11 15:45 ` Stefan Hajnoczi
2 siblings, 0 replies; 6+ messages in thread
From: Christian Borntraeger @ 2016-02-10 9:32 UTC (permalink / raw)
To: Denis V. Lunev
Cc: Paolo Bonzini, Alex Bennée, qemu-devel, Stefan Hajnoczi
On 02/09/2016 05:49 PM, Denis V. Lunev wrote:
> we should call trace_init_backends() before trace_init_file() for
> CONFIG_TRACE_SIMPLE There is no difference for other cases.
>
> This problem was introduced by the commit
> commit 41fc57e44ed64cd4ab5393d83624afd897dabd4f
> Author: Paolo Bonzini <pbonzini@redhat.com>
> Date: Thu Jan 7 16:55:24 2016 +0300
>
> trace: split trace_init_file out of trace_init_backends
>
> 'make check' was failed as a result if configured with
> --enable-trace-backends=simple
>
> Spotted by Alex Bennée.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Alex Bennée <alex.bennee@linaro.org>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Stefan Hajnoczi <stefanha@redhat.com>
Tested-by: Christian Borntraeger <borntraeger@de.ibm.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH 1/1] vl: fix tracing initialization
2016-02-09 16:49 [Qemu-devel] [PATCH 1/1] vl: fix tracing initialization Denis V. Lunev
2016-02-09 22:20 ` Alex Bennée
2016-02-10 9:32 ` Christian Borntraeger
@ 2016-02-11 15:45 ` Stefan Hajnoczi
2016-03-01 12:00 ` Christian Borntraeger
2 siblings, 1 reply; 6+ messages in thread
From: Stefan Hajnoczi @ 2016-02-11 15:45 UTC (permalink / raw)
To: Denis V. Lunev; +Cc: Paolo Bonzini, Alex Bennée, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 958 bytes --]
On Tue, Feb 09, 2016 at 07:49:05PM +0300, Denis V. Lunev wrote:
> we should call trace_init_backends() before trace_init_file() for
> CONFIG_TRACE_SIMPLE There is no difference for other cases.
>
> This problem was introduced by the commit
> commit 41fc57e44ed64cd4ab5393d83624afd897dabd4f
> Author: Paolo Bonzini <pbonzini@redhat.com>
> Date: Thu Jan 7 16:55:24 2016 +0300
>
> trace: split trace_init_file out of trace_init_backends
>
> 'make check' was failed as a result if configured with
> --enable-trace-backends=simple
>
> Spotted by Alex Bennée.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Alex Bennée <alex.bennee@linaro.org>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> vl.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH 1/1] vl: fix tracing initialization
2016-02-11 15:45 ` Stefan Hajnoczi
@ 2016-03-01 12:00 ` Christian Borntraeger
2016-03-01 13:36 ` Stefan Hajnoczi
0 siblings, 1 reply; 6+ messages in thread
From: Christian Borntraeger @ 2016-03-01 12:00 UTC (permalink / raw)
To: Stefan Hajnoczi, Denis V. Lunev
Cc: Paolo Bonzini, Alex Bennée, qemu-devel, Peter Maydell
On 02/11/2016 04:45 PM, Stefan Hajnoczi wrote:
> On Tue, Feb 09, 2016 at 07:49:05PM +0300, Denis V. Lunev wrote:
>> we should call trace_init_backends() before trace_init_file() for
>> CONFIG_TRACE_SIMPLE There is no difference for other cases.
>>
>> This problem was introduced by the commit
>> commit 41fc57e44ed64cd4ab5393d83624afd897dabd4f
>> Author: Paolo Bonzini <pbonzini@redhat.com>
>> Date: Thu Jan 7 16:55:24 2016 +0300
>>
>> trace: split trace_init_file out of trace_init_backends
>>
>> 'make check' was failed as a result if configured with
>> --enable-trace-backends=simple
>>
>> Spotted by Alex Bennée.
>>
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> CC: Alex Bennée <alex.bennee@linaro.org>
>> CC: Paolo Bonzini <pbonzini@redhat.com>
>> CC: Stefan Hajnoczi <stefanha@redhat.com>
>> ---
>> vl.c | 7 +++----
>> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> Thanks, applied to my tracing tree:
> https://github.com/stefanha/qemu/commits/tracing
>
> Stefan
When is this scheduled for integration? Without that patch not
only make check is broken, libvirt will also hang if qemu was
build with --enable-trace-backends=simple during capability
detection.
Christian
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH 1/1] vl: fix tracing initialization
2016-03-01 12:00 ` Christian Borntraeger
@ 2016-03-01 13:36 ` Stefan Hajnoczi
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Hajnoczi @ 2016-03-01 13:36 UTC (permalink / raw)
To: Christian Borntraeger
Cc: Peter Maydell, qemu-devel, Stefan Hajnoczi, Paolo Bonzini,
Denis V. Lunev, Alex Bennée
[-- Attachment #1: Type: text/plain, Size: 1450 bytes --]
On Tue, Mar 01, 2016 at 01:00:21PM +0100, Christian Borntraeger wrote:
> On 02/11/2016 04:45 PM, Stefan Hajnoczi wrote:
> > On Tue, Feb 09, 2016 at 07:49:05PM +0300, Denis V. Lunev wrote:
> >> we should call trace_init_backends() before trace_init_file() for
> >> CONFIG_TRACE_SIMPLE There is no difference for other cases.
> >>
> >> This problem was introduced by the commit
> >> commit 41fc57e44ed64cd4ab5393d83624afd897dabd4f
> >> Author: Paolo Bonzini <pbonzini@redhat.com>
> >> Date: Thu Jan 7 16:55:24 2016 +0300
> >>
> >> trace: split trace_init_file out of trace_init_backends
> >>
> >> 'make check' was failed as a result if configured with
> >> --enable-trace-backends=simple
> >>
> >> Spotted by Alex Bennée.
> >>
> >> Signed-off-by: Denis V. Lunev <den@openvz.org>
> >> CC: Alex Bennée <alex.bennee@linaro.org>
> >> CC: Paolo Bonzini <pbonzini@redhat.com>
> >> CC: Stefan Hajnoczi <stefanha@redhat.com>
> >> ---
> >> vl.c | 7 +++----
> >> 1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > Thanks, applied to my tracing tree:
> > https://github.com/stefanha/qemu/commits/tracing
> >
> > Stefan
>
> When is this scheduled for integration? Without that patch not
> only make check is broken, libvirt will also hang if qemu was
> build with --enable-trace-backends=simple during capability
> detection.
I am sending a tracing pull request with this patch today.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-03-01 13:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-09 16:49 [Qemu-devel] [PATCH 1/1] vl: fix tracing initialization Denis V. Lunev
2016-02-09 22:20 ` Alex Bennée
2016-02-10 9:32 ` Christian Borntraeger
2016-02-11 15:45 ` Stefan Hajnoczi
2016-03-01 12:00 ` Christian Borntraeger
2016-03-01 13:36 ` Stefan Hajnoczi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.