[Buildroot] [PATCH v2 00/12] Fix GCC BUG 85180 per-package

[Buildroot] [PATCH v2 00/12] Fix GCC BUG 85180 per-package

[Giulio Benetti]

This patchset aims to build packages when building with Gcc affected by
Bug 85180 instead of not bulding them at all.
Bug 85180:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
is present in Gcc version < 8.x
The basic solution is to force compiling without optimization, so forcing
-O0 appending it to CFLAGS or CXXFLAGS according to programming language
used in package.

Giulio Benetti (12):
  toolchain: specify GCC_BUG_85180 is true only if GCC version < 8.x
  package/atop: fix BUG_85180 build timeout
  package/chocolate-doom: fix BUG_85180 build timeout
  package/ddrescue: fix BUG_85180 build timeout
  package/flare-engine: fix BUG_85180 build timeout
  package/glibmm: fix BUG_85180 build timeout
  package/gst-ffmpeg: re-enable package if BUG_85180 is present
  package/jasper: fix BUG_85180 build timeout
  package/kismet: fix BUG_85180 build timeout
  package/libcpprestsdk: fix BUG_85180 build timeout
  package/opus: fix BUG_85180 build timeout
  package/postgresql: fix BUG_85180 build timeout

 package/atop/atop.mk                       | 7 ++++++-
 package/chocolate-doom/chocolate-doom.mk   | 4 ++++
 package/ddrescue/ddrescue.mk               | 6 +++++-
 package/flare-engine/Config.in             | 4 ----
 package/flare-engine/flare-engine.mk       | 6 ++++++
 package/glibmm/glibmm.mk                   | 4 ++++
 package/gstreamer/gst-ffmpeg/Config.in     | 4 ----
 package/gstreamer/gst-ffmpeg/gst-ffmpeg.mk | 5 +++++
 package/jasper/jasper.mk                   | 4 ++++
 package/kismet/kismet.mk                   | 4 ++++
 package/libcpprestsdk/libcpprestsdk.mk     | 4 ++++
 package/opus/opus.mk                       | 4 ++++
 package/postgresql/postgresql.mk           | 4 ++++
 toolchain/Config.in                        | 1 +
 14 files changed, 51 insertions(+), 10 deletions(-)

-- 
2.17.1

[Buildroot] [PATCH v2 01/12] toolchain: specify GCC_BUG_85180 is true only if GCC version < 8.x

[Giulio Benetti]

Bug 85180:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
has been fixed on Gcc version >= 8.x

So:
- add 'depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8' to 'config
  BR2_TOOLCHAIN_HAS_GCC_BUG_85180'.

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
---
 toolchain/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/toolchain/Config.in b/toolchain/Config.in
index 467d6bd84f..d05ad88af4 100644
--- a/toolchain/Config.in
+++ b/toolchain/Config.in
@@ -129,6 +129,7 @@ config BR2_TOOLCHAIN_HAS_GCC_BUG_64735
 config BR2_TOOLCHAIN_HAS_GCC_BUG_85180
 	bool
 	default y if BR2_microblaze
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8
 
 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85862
 # An infinite loop exists in the find_base_term() logic of 6.x
-- 
2.17.1

[Buildroot] [PATCH v2 01/12] toolchain: specify GCC_BUG_85180 is true only if GCC version < 8.x

[Thomas Petazzoni]

On Tue, 21 May 2019 15:39:21 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:

> Bug 85180:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
> has been fixed on Gcc version >= 8.x
> 
> So:
> - add 'depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8' to 'config
>   BR2_TOOLCHAIN_HAS_GCC_BUG_85180'.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
> ---
>  toolchain/Config.in | 1 +
>  1 file changed, 1 insertion(+)

Applied to master with a tweaked commit log/title. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v2 01/12] toolchain: specify GCC_BUG_85180 is true only if GCC version < 8.x

[Giulio Benetti]

Hello,

Il 22/05/2019 22:52, Thomas Petazzoni ha scritto:
> On Tue, 21 May 2019 15:39:21 +0200
> Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:
> 
>> Bug 85180:
>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
>> has been fixed on Gcc version >= 8.x
>>
>> So:
>> - add 'depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8' to 'config
>>    BR2_TOOLCHAIN_HAS_GCC_BUG_85180'.
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
>> Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
>> ---
>>   toolchain/Config.in | 1 +
>>   1 file changed, 1 insertion(+)
> 
> Applied to master with a tweaked commit log/title. Thanks!

Thank you for rewording. Need to improve commit logs in general...

Kind regards
-- 
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642

> Thomas
> 

[Buildroot] [PATCH v2 01/12] toolchain: specify GCC_BUG_85180 is true only if GCC version < 8.x

[Peter Korsgaard]

>>>>> "Giulio" == Giulio Benetti <giulio.benetti@micronovasrl.com> writes:

 > Bug 85180:
 > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
 > has been fixed on Gcc version >= 8.x

 > So:
 > - add 'depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_8' to 'config
 >   BR2_TOOLCHAIN_HAS_GCC_BUG_85180'.

 > Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
 > Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

Committed to 2019.02.x, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v2 02/12] package/atop: fix BUG_85180 build timeout

[Giulio Benetti]

With Microblaze Gcc version < 8.x build hangs on compiling last files
before linking. This is due to bug 85180:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
Bug shows up building atop with optimization but not when building with
-O0.

If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
CFLAGS.

Fixes:
http://autobuild.buildroot.net/results/94a/94aa00f776b8a3491ac0b3212c95f5e666c5a29a/

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
V1 -> V2:
* use -O0 instead of -g1

 package/atop/atop.mk | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/package/atop/atop.mk b/package/atop/atop.mk
index aaf02908c4..afce71f6cb 100644
--- a/package/atop/atop.mk
+++ b/package/atop/atop.mk
@@ -10,8 +10,13 @@ ATOP_LICENSE = GPL-2.0+
 ATOP_LICENSE_FILES = COPYING
 ATOP_DEPENDENCIES = ncurses zlib
 
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
+ATOP_CFLAGS += $(TARGET_CFLAGS) -O0
+endif
+
 define ATOP_BUILD_CMDS
-	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)
+	$(MAKE) $(TARGET_CONFIGURE_OPTS) CFLAGS="$(ATOP_CFLAGS)" \
+	-C $(@D)
 endef
 
 define ATOP_INSTALL_TARGET_CMDS
-- 
2.17.1

[Buildroot] [PATCH v2 02/12] package/atop: fix BUG_85180 build timeout

[Thomas Petazzoni]

Hello Giulio,

On Tue, 21 May 2019 15:39:22 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:

> With Microblaze Gcc version < 8.x build hangs on compiling last files
> before linking. This is due to bug 85180:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
> Bug shows up building atop with optimization but not when building with
> -O0.
> 
> If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
> CFLAGS.
> 
> Fixes:
> http://autobuild.buildroot.net/results/94a/94aa00f776b8a3491ac0b3212c95f5e666c5a29a/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>

I have applied to master after reworking the commit title and commit
log, and also adjusting the code a bit (see below).

> diff --git a/package/atop/atop.mk b/package/atop/atop.mk
> index aaf02908c4..afce71f6cb 100644
> --- a/package/atop/atop.mk
> +++ b/package/atop/atop.mk
> @@ -10,8 +10,13 @@ ATOP_LICENSE = GPL-2.0+
>  ATOP_LICENSE_FILES = COPYING
>  ATOP_DEPENDENCIES = ncurses zlib
>  
> +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
> +ATOP_CFLAGS += $(TARGET_CFLAGS) -O0
> +endif

I believe:

ATOP_CFLAGS = $(TARGET_CFLAGS)

ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
ATOP_CFLAGS += -O0
endif

is more correct, otherwise you pass an empty CFLAGS when
BR2_TOOLCHAIN_HAS_GCC_BUG_85180 is false.


> +
>  define ATOP_BUILD_CMDS
> -	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)
> +	$(MAKE) $(TARGET_CONFIGURE_OPTS) CFLAGS="$(ATOP_CFLAGS)" \
> +	-C $(@D)

The second line is typically indented with one more tab.

As I said, I've applied to master after fixing those issues.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v2 02/12] package/atop: fix BUG_85180 build timeout

[Giulio Benetti]

Hello,

Il 22/05/2019 23:07, Thomas Petazzoni ha scritto:
> Hello Giulio,
> 
> On Tue, 21 May 2019 15:39:22 +0200
> Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:
> 
>> With Microblaze Gcc version < 8.x build hangs on compiling last files
>> before linking. This is due to bug 85180:
>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
>> Bug shows up building atop with optimization but not when building with
>> -O0.
>>
>> If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
>> CFLAGS.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/94a/94aa00f776b8a3491ac0b3212c95f5e666c5a29a/
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> 
> I have applied to master after reworking the commit title and commit
> log,

Again... Need to improve commit logs.

> and also adjusting the code a bit (see below).
> 
>> diff --git a/package/atop/atop.mk b/package/atop/atop.mk
>> index aaf02908c4..afce71f6cb 100644
>> --- a/package/atop/atop.mk
>> +++ b/package/atop/atop.mk
>> @@ -10,8 +10,13 @@ ATOP_LICENSE = GPL-2.0+
>>   ATOP_LICENSE_FILES = COPYING
>>   ATOP_DEPENDENCIES = ncurses zlib
>>   
>> +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
>> +ATOP_CFLAGS += $(TARGET_CFLAGS) -O0
>> +endif
> 
> I believe:
> 
> ATOP_CFLAGS = $(TARGET_CFLAGS)
> 
> ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
> ATOP_CFLAGS += -O0
> endif
> 
> is more correct, otherwise you pass an empty CFLAGS when
> BR2_TOOLCHAIN_HAS_GCC_BUG_85180 is false.

Yes totally right. Then I need to modify other patches for 
$(generic-package) packages as well as their commit logs at this point.

> 
>> +
>>   define ATOP_BUILD_CMDS
>> -	$(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D)
>> +	$(MAKE) $(TARGET_CONFIGURE_OPTS) CFLAGS="$(ATOP_CFLAGS)" \
>> +	-C $(@D)
> 
> The second line is typically indented with one more tab.

Ok. I've never noticed it. Thanks for pointing.

Best regards!
-- 
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642

> As I said, I've applied to master after fixing those issues.
> 
> Thanks!
> 
> Thomas
> 

[Buildroot] [PATCH v2 02/12] package/atop: fix BUG_85180 build timeout

[Peter Korsgaard]

>>>>> "Giulio" == Giulio Benetti <giulio.benetti@micronovasrl.com> writes:

 > With Microblaze Gcc version < 8.x build hangs on compiling last files
 > before linking. This is due to bug 85180:
 > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
 > Bug shows up building atop with optimization but not when building with
 > -O0.

 > If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
 > CFLAGS.

 > Fixes:
 > http://autobuild.buildroot.net/results/94a/94aa00f776b8a3491ac0b3212c95f5e666c5a29a/

 > Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
 > ---
 > V1 -> V2:
 > * use -O0 instead of -g1

Committed to 2019.02.x, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v2 03/12] package/chocolate-doom: fix BUG_85180 build timeout

[Giulio Benetti]

With Microblaze Gcc version < 8.x build hangs on compiling last files
before linking.
This is due to bug 85180:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
Bug shows up building chocolate-doom with optimization but not when
building with -O0.

If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
CFLAGS.

Fixes:
http://autobuild.buildroot.net/results/e57/e570839576be8963dc6bd36342e2f857da3c6146/

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
 package/chocolate-doom/chocolate-doom.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/chocolate-doom/chocolate-doom.mk b/package/chocolate-doom/chocolate-doom.mk
index 54121c43aa..5f2c28cdd9 100644
--- a/package/chocolate-doom/chocolate-doom.mk
+++ b/package/chocolate-doom/chocolate-doom.mk
@@ -21,6 +21,10 @@ CHOCOLATE_DOOM_CONF_OPTS = \
 	--with-sdl-prefix=$(STAGING_DIR)/usr \
 	--with-sdl-exec-prefix=$(STAGING_DIR)/usr
 
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
+CHOCOLATE_DOOM_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -O0"
+endif
+
 ifeq ($(BR2_PACKAGE_LIBPNG),y)
 CHOCOLATE_DOOM_DEPENDENCIES += libpng
 CHOCOLATE_DOOM_CONF_OPTS += --with-libpng
-- 
2.17.1

[Buildroot] [PATCH v2 03/12] package/chocolate-doom: fix BUG_85180 build timeout

[Thomas Petazzoni]

On Tue, 21 May 2019 15:39:23 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:

> With Microblaze Gcc version < 8.x build hangs on compiling last files
> before linking.
> This is due to bug 85180:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
> Bug shows up building chocolate-doom with optimization but not when
> building with -O0.
> 
> If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
> CFLAGS.
> 
> Fixes:
> http://autobuild.buildroot.net/results/e57/e570839576be8963dc6bd36342e2f857da3c6146/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
>  package/chocolate-doom/chocolate-doom.mk | 4 ++++
>  1 file changed, 4 insertions(+)

Applied to master after tweaking the CFLAGS logic and the commit log.
Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v2 03/12] package/chocolate-doom: fix BUG_85180 build timeout

[Peter Korsgaard]

>>>>> "Giulio" == Giulio Benetti <giulio.benetti@micronovasrl.com> writes:

 > With Microblaze Gcc version < 8.x build hangs on compiling last files
 > before linking.
 > This is due to bug 85180:
 > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
 > Bug shows up building chocolate-doom with optimization but not when
 > building with -O0.

 > If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
 > CFLAGS.

 > Fixes:
 > http://autobuild.buildroot.net/results/e57/e570839576be8963dc6bd36342e2f857da3c6146/

 > Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>

Committed to 2019.02.x, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v2 04/12] package/ddrescue: fix BUG_85180 build timeout

[Giulio Benetti]

With Microblaze Gcc version < 8.x build hangs on compiling first files.
This is due to bug 85180:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
Bug shows up building ddrescue with optimization but not when building
with -O0.

If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
CXXFLAGS.

Fixes:
http://autobuild.buildroot.net/results/2af/2af69401acb76be3d3fd427d1c58fed3af33bf9b/

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
 package/ddrescue/ddrescue.mk | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/package/ddrescue/ddrescue.mk b/package/ddrescue/ddrescue.mk
index 9432e7a16d..b746e4a416 100644
--- a/package/ddrescue/ddrescue.mk
+++ b/package/ddrescue/ddrescue.mk
@@ -18,8 +18,12 @@ define DDRESCUE_CONFIGURE_CMDS
 	)
 endef
 
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
+DDRESCUE_CXXFLAGS += $(TARGET_CXXFLAGS) -O0
+endif
+
 define DDRESCUE_BUILD_CMDS
-	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
+	$(TARGET_MAKE_ENV) $(MAKE) CXXFLAGS="$(DDRESCUE_CXXFLAGS)" -C $(@D)
 endef
 
 define DDRESCUE_INSTALL_TARGET_CMDS
-- 
2.17.1

[Buildroot] [PATCH v2 04/12] package/ddrescue: fix BUG_85180 build timeout

[Thomas Petazzoni]

On Tue, 21 May 2019 15:39:24 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:

> With Microblaze Gcc version < 8.x build hangs on compiling first files.
> This is due to bug 85180:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
> Bug shows up building ddrescue with optimization but not when building
> with -O0.
> 
> If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
> CXXFLAGS.
> 
> Fixes:
> http://autobuild.buildroot.net/results/2af/2af69401acb76be3d3fd427d1c58fed3af33bf9b/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
>  package/ddrescue/ddrescue.mk | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Applied to master after tweaking the CFLAGS logic and the commit log.
Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v2 04/12] package/ddrescue: fix BUG_85180 build timeout

[Peter Korsgaard]

>>>>> "Giulio" == Giulio Benetti <giulio.benetti@micronovasrl.com> writes:

 > With Microblaze Gcc version < 8.x build hangs on compiling first files.
 > This is due to bug 85180:
 > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
 > Bug shows up building ddrescue with optimization but not when building
 > with -O0.

 > If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
 > CXXFLAGS.

 > Fixes:
 > http://autobuild.buildroot.net/results/2af/2af69401acb76be3d3fd427d1c58fed3af33bf9b/

 > Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>

Committed to 2019.02.x, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v2 05/12] package/flare-engine: fix BUG_85180 build timeout

[Giulio Benetti]

With Microblaze Gcc version < 8.x build hangs on compiling last files.
This is due to bug 85180:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
Bug shows up building flare-engine with optimization but not when
building with -O0.

If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 by:
- setting CMAKE_BUILD_TYPE to Dummy to avoid CMakeLists.txt to impose
  -O* and -g* flags
- pass -O0 to CXXFLAGS to override previous -O flags
Then remove 'depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85180' and its
comment if not available in Config.in

Fixes:
http://autobuild.buildroot.net/results/706/7065e14917a8bbc0faf21b29183ac55b6c800ee3/

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
 package/flare-engine/Config.in       | 4 ----
 package/flare-engine/flare-engine.mk | 6 ++++++
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/package/flare-engine/Config.in b/package/flare-engine/Config.in
index e299a6b7de..cdcb018948 100644
--- a/package/flare-engine/Config.in
+++ b/package/flare-engine/Config.in
@@ -2,7 +2,6 @@ config BR2_PACKAGE_FLARE_ENGINE
 	bool "flare-engine"
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on !BR2_STATIC_LIBS # SDL2
-	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85180
 	select BR2_PACKAGE_SDL2
 	select BR2_PACKAGE_SDL2_IMAGE
 	select BR2_PACKAGE_SDL2_MIXER
@@ -18,6 +17,3 @@ config BR2_PACKAGE_FLARE_ENGINE
 
 comment "flare-engine needs a toolchain w/ C++, dynamic library"
 	depends on !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS
-
-comment "flare-engine needs a toolchain not affected by GCC bug 85180"
-	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_85180
diff --git a/package/flare-engine/flare-engine.mk b/package/flare-engine/flare-engine.mk
index 2f36602348..a9d506e220 100644
--- a/package/flare-engine/flare-engine.mk
+++ b/package/flare-engine/flare-engine.mk
@@ -19,4 +19,10 @@ ifeq ($(BR2_ENABLE_DEBUG),y)
 FLARE_ENGINE_CONF_OPTS += -DCMAKE_BUILD_TYPE=RelWithDebInfo
 endif
 
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
+# Avoid CMakeLists.txt to impose "-O* -g*" flags
+FLARE_ENGINE_CONF_OPTS += -DCMAKE_BUILD_TYPE=Dummy
+FLARE_ENGINE_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(TARGET_CXXFLAGS) -O0"
+endif
+
 $(eval $(cmake-package))
-- 
2.17.1

[Buildroot] [PATCH v2 05/12] package/flare-engine: fix BUG_85180 build timeout

[Thomas Petazzoni]

On Tue, 21 May 2019 15:39:25 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:

> With Microblaze Gcc version < 8.x build hangs on compiling last files.
> This is due to bug 85180:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
> Bug shows up building flare-engine with optimization but not when
> building with -O0.
> 
> If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 by:
> - setting CMAKE_BUILD_TYPE to Dummy to avoid CMakeLists.txt to impose
>   -O* and -g* flags

Why does flare-engine need this, but not jasper, which is also a
CMake-based package ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v2 05/12] package/flare-engine: fix BUG_85180 build timeout

[Giulio Benetti]

Hello Thomas,

Il 24/05/2019 21:58, Thomas Petazzoni ha scritto:
> On Tue, 21 May 2019 15:39:25 +0200
> Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:
> 
>> With Microblaze Gcc version < 8.x build hangs on compiling last files.
>> This is due to bug 85180:
>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
>> Bug shows up building flare-engine with optimization but not when
>> building with -O0.
>>
>> If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 by:
>> - setting CMAKE_BUILD_TYPE to Dummy to avoid CMakeLists.txt to impose
>>    -O* and -g* flags
> 
> Why does flare-engine need this, but not jasper, which is also a
> CMake-based package ?

Because in flare-engine CMakeLists.txt there is no fallback to -O0, so 
that was the only decent way to force CMake to generate Makefiles 
without optimizations. I don't like it very much but it was the only way 
I've found.

Thank you for reviewing and improving all commit logs!

-- 
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642

> Thanks,
> 
> Thomas
> 

[Buildroot] [PATCH v2 05/12] package/flare-engine: fix BUG_85180 build timeout

[Thomas Petazzoni]

On Fri, 24 May 2019 22:05:12 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:

> > Why does flare-engine need this, but not jasper, which is also a
> > CMake-based package ?  
> 
> Because in flare-engine CMakeLists.txt there is no fallback to -O0, so 
> that was the only decent way to force CMake to generate Makefiles 
> without optimizations.

Could you be more specific ? How does it work for jasper and
libcpprestsdk, which are also based on CMake ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v2 05/12] package/flare-engine: fix BUG_85180 build timeout

[Giulio Benetti]

Hello Thomas,

Il 24/05/2019 22:30, Thomas Petazzoni ha scritto:
> On Fri, 24 May 2019 22:05:12 +0200
> Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:
> 
>>> Why does flare-engine need this, but not jasper, which is also a
>>> CMake-based package ?
>>
>> Because in flare-engine CMakeLists.txt there is no fallback to -O0, so
>> that was the only decent way to force CMake to generate Makefiles
>> without optimizations.
> 
> Could you be more specific ? How does it work for jasper and
> libcpprestsdk, which are also based on CMake ?

Yes, the problem here is that even if there's the way to append 
something to CMAKE_CXX_FLAGS, then any other CMAKE_CXX_FLAGS_* will be 
appended, so if I set CMAKE_CXX_FLAGS to -O0, I will obtain "-O0 -O2 -g".

This is due to the fact that we fall into one of the cases of the next 
if-elseif statements(in CMakeLists.txt):
"
if(CMAKE_BUILD_TYPE STREQUAL "Release")
   set(CMAKE_CXX_FLAGS_RELEASE "-O2 -g0")
   if(MINGW)
     set(CMAKE_CXX_FLAGS_RELEASE "-Wl,-subsystem,windows 
${CMAKE_CXX_FLAGS_RELEASE}")
   endif()
elseif(CMAKE_BUILD_TYPE STREQUAL "RelWithDebInfo")
   set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-O2 -g")
elseif(CMAKE_BUILD_TYPE STREQUAL "MinSizeRel")
   set(CMAKE_CXX_FLAGS_MINSIZEREL "-Os -g0")
elseif(CMAKE_BUILD_TYPE STREQUAL "Debug")
   set(CMAKE_CXX_FLAGS_DEBUG "-O0 -g3 -pg")
   set(CMAKE_EXE_LINKER_FLAGS_DEBUG "-pg")
   set(CMAKE_SHARED_LINKER_FLAGS_DEBUG "-pg")
   set(CMAKE_MODULE_LINKER_FLAGS_DEBUG "-pg")
endif()
"
where Release is the default and if BR2_ENABLE_DEBUG=y 
CMAKE_BUILD_TYPE=RelWithDebInfo according to flare-engine.mk
So I thought to set CMAKE_BUILD_TYPE to "Dummy" to jump over that 
if-elseif. But just right now I've realized that's enough to give 
-DCMAKE_BUILD_TYPE=
Empty is enough to jump over if-elseif.
Another way would be to patch CMakeLists.txt adding a fallback "else" to 
those if-elseif

What do you think?

Best regards
-- 
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642

[Buildroot] [PATCH v2 05/12] package/flare-engine: fix BUG_85180 build timeout

[Arnout Vandecappelle]

On 27/05/2019 19:20, Giulio Benetti wrote:
> Hello Thomas,
> 
> Il 24/05/2019 22:30, Thomas Petazzoni ha scritto:
>> On Fri, 24 May 2019 22:05:12 +0200
>> Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:
>>
>>>> Why does flare-engine need this, but not jasper, which is also a
>>>> CMake-based package ?
>>>
>>> Because in flare-engine CMakeLists.txt there is no fallback to -O0, so
>>> that was the only decent way to force CMake to generate Makefiles
>>> without optimizations.
>>
>> Could you be more specific ? How does it work for jasper and
>> libcpprestsdk, which are also based on CMake ?
> 
> Yes, the problem here is that even if there's the way to append something to
> CMAKE_CXX_FLAGS, then any other CMAKE_CXX_FLAGS_* will be appended, so if I set
> CMAKE_CXX_FLAGS to -O0, I will obtain "-O0 -O2 -g".
> 
> This is due to the fact that we fall into one of the cases of the next if-elseif
> statements(in CMakeLists.txt):
> "
> if(CMAKE_BUILD_TYPE STREQUAL "Release")
> ? set(CMAKE_CXX_FLAGS_RELEASE "-O2 -g0")

 Note that you could also get away without overriding CMAKE_BUILD_TYPE, and just
setting CMAKE_CXX_FLAGS_RELEASE. Definitions passed on the command line will
override the ones in CMakeFiles.txt (at least, I think so...).

 However, since we now still set CMAKE_BUILD_TYPE based on BR2_ENABLE_DEBUG,
that won't work :-(


> ? if(MINGW)
> ??? set(CMAKE_CXX_FLAGS_RELEASE "-Wl,-subsystem,windows
> ${CMAKE_CXX_FLAGS_RELEASE}")
> ? endif()
> elseif(CMAKE_BUILD_TYPE STREQUAL "RelWithDebInfo")
> ? set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-O2 -g")
> elseif(CMAKE_BUILD_TYPE STREQUAL "MinSizeRel")
> ? set(CMAKE_CXX_FLAGS_MINSIZEREL "-Os -g0")
> elseif(CMAKE_BUILD_TYPE STREQUAL "Debug")
> ? set(CMAKE_CXX_FLAGS_DEBUG "-O0 -g3 -pg")
> ? set(CMAKE_EXE_LINKER_FLAGS_DEBUG "-pg")
> ? set(CMAKE_SHARED_LINKER_FLAGS_DEBUG "-pg")
> ? set(CMAKE_MODULE_LINKER_FLAGS_DEBUG "-pg")
> endif()
> "
> where Release is the default and if BR2_ENABLE_DEBUG=y
> CMAKE_BUILD_TYPE=RelWithDebInfo according to flare-engine.mk
> So I thought to set CMAKE_BUILD_TYPE to "Dummy" to jump over that if-elseif. But
> just right now I've realized that's enough to give -DCMAKE_BUILD_TYPE=
> Empty is enough to jump over if-elseif.
> Another way would be to patch CMakeLists.txt adding a fallback "else" to those
> if-elseif

 Another interesting example to consider how we should handle the
CMAKE_BUILD_TYPE...

 We could just always set CMAKE_BUILD_TYPE to Dummy or empty or whatever.
However, I'm not sure if that's the right thing to do. For other package infras,
we pass the optimisation options in CFLAGS, which still gives packages the
opportunity to change or override them. Looking at a few autotools packages,
they seem to generally append stuff to CFLAGS, but not really override it - and
autoconf itself takes care of not overriding user-passed CFLAGS. CMake packages,
on the other hand, seem to mess a lot more with optimisation flags (like the
example above). Also, I have the impression that CMake packages tend to also
override CMAKE_C_FLAGS (rather than append to it or override CMAKE_C_FLAGS_RELEASE).

 My feeling *at this time* is that the best option would be to set:

CMAKE_BUILD_TYPE=Buildroot
CMAKE_C_FLAGS_BUILDROOT=@TARGET_CFLAGS@

and not set CMAKE_C_FLAGS at all. For packages that do something sensible and
necessary under a BUILD_TYPE == Release condition, we can still do
package-specific override of BUILD_TYPE. And for packages that need something
extra, we can pass -DCMAKE_C_FLAGS_BUILDROOT="$(TARGET_CFLAGS) -O0"

 But it's very hard to be sure what is the best way, and what will cause the
least amount of breakage... So, to have the least amount of breakage, it would
be better to stick to CMAKE_BUILD_TYPE=Release and live with the fact that many
packages will override the optimisation flags...

 Bwerk, difficult to decide...

 Let's add Yann to the already huge Cc list :-)

 Regards,
 Arnout

[Buildroot] [PATCH v2 05/12] package/flare-engine: fix BUG_85180 build timeout

[Arnout Vandecappelle]

On 27/05/2019 23:03, Arnout Vandecappelle wrote:
> 
> 
> On 27/05/2019 19:20, Giulio Benetti wrote:
>> Hello Thomas,
>>
>> Il 24/05/2019 22:30, Thomas Petazzoni ha scritto:
>>> On Fri, 24 May 2019 22:05:12 +0200
>>> Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:
>>>
>>>>> Why does flare-engine need this, but not jasper, which is also a
>>>>> CMake-based package ?
>>>>
>>>> Because in flare-engine CMakeLists.txt there is no fallback to -O0, so
>>>> that was the only decent way to force CMake to generate Makefiles
>>>> without optimizations.
>>>
>>> Could you be more specific ? How does it work for jasper and
>>> libcpprestsdk, which are also based on CMake ?
>>
>> Yes, the problem here is that even if there's the way to append something to
>> CMAKE_CXX_FLAGS, then any other CMAKE_CXX_FLAGS_* will be appended, so if I set
>> CMAKE_CXX_FLAGS to -O0, I will obtain "-O0 -O2 -g".
>>
>> This is due to the fact that we fall into one of the cases of the next if-elseif
>> statements(in CMakeLists.txt):
>> "
>> if(CMAKE_BUILD_TYPE STREQUAL "Release")
>> ? set(CMAKE_CXX_FLAGS_RELEASE "-O2 -g0")
> 
>  Note that you could also get away without overriding CMAKE_BUILD_TYPE, and just
> setting CMAKE_CXX_FLAGS_RELEASE. Definitions passed on the command line will
> override the ones in CMakeFiles.txt (at least, I think so...).
> 
>  However, since we now still set CMAKE_BUILD_TYPE based on BR2_ENABLE_DEBUG,
> that won't work :-(

 Because of this (and because we can't wait for CMake refactoring), I've
improved the comment in the .mk file a little and also rewrote the commit log
based on what Thomas wrote for the other commits, and applied to master, thanks.

 Regards,
 Arnout


[snip]

[Buildroot] [PATCH v2 05/12] package/flare-engine: fix BUG_85180 build timeout

[Giulio Benetti]

Il 27/05/2019 23:44, Arnout Vandecappelle ha scritto:
> 
> 
> On 27/05/2019 23:03, Arnout Vandecappelle wrote:
>>
>>
>> On 27/05/2019 19:20, Giulio Benetti wrote:
>>> Hello Thomas,
>>>
>>> Il 24/05/2019 22:30, Thomas Petazzoni ha scritto:
>>>> On Fri, 24 May 2019 22:05:12 +0200
>>>> Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:
>>>>
>>>>>> Why does flare-engine need this, but not jasper, which is also a
>>>>>> CMake-based package ?
>>>>>
>>>>> Because in flare-engine CMakeLists.txt there is no fallback to -O0, so
>>>>> that was the only decent way to force CMake to generate Makefiles
>>>>> without optimizations.
>>>>
>>>> Could you be more specific ? How does it work for jasper and
>>>> libcpprestsdk, which are also based on CMake ?
>>>
>>> Yes, the problem here is that even if there's the way to append something to
>>> CMAKE_CXX_FLAGS, then any other CMAKE_CXX_FLAGS_* will be appended, so if I set
>>> CMAKE_CXX_FLAGS to -O0, I will obtain "-O0 -O2 -g".
>>>
>>> This is due to the fact that we fall into one of the cases of the next if-elseif
>>> statements(in CMakeLists.txt):
>>> "
>>> if(CMAKE_BUILD_TYPE STREQUAL "Release")
>>>  ? set(CMAKE_CXX_FLAGS_RELEASE "-O2 -g0")
>>
>>   Note that you could also get away without overriding CMAKE_BUILD_TYPE, and just
>> setting CMAKE_CXX_FLAGS_RELEASE. Definitions passed on the command line will
>> override the ones in CMakeFiles.txt (at least, I think so...).
>>
>>   However, since we now still set CMAKE_BUILD_TYPE based on BR2_ENABLE_DEBUG,
>> that won't work :-(
> 
>   Because of this (and because we can't wait for CMake refactoring), I've
> improved the comment in the .mk file a little and also rewrote the commit log
> based on what Thomas wrote for the other commits, and applied to master, thanks.

Thank you instead!

Best regards
-- 
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642

[Buildroot] [PATCH v2 06/12] package/glibmm: fix BUG_85180 build timeout

[Giulio Benetti]

With Microblaze Gcc version < 8.x build hangs on compiling first files.
This is due to bug 85180:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
Bug shows up building glibmm with optimization but not when building
with -O0.

If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
CXXFLAGS.

Fixes:
http://autobuild.buildroot.net/results/e19/e196d77626b877dc3454d21febe20a04877c02a9/

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
 package/glibmm/glibmm.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/glibmm/glibmm.mk b/package/glibmm/glibmm.mk
index 71f1dfd36f..06dc9f92e2 100644
--- a/package/glibmm/glibmm.mk
+++ b/package/glibmm/glibmm.mk
@@ -13,4 +13,8 @@ GLIBMM_SITE = http://ftp.gnome.org/pub/gnome/sources/glibmm/$(GLIBMM_VERSION_MAJ
 GLIBMM_INSTALL_STAGING = YES
 GLIBMM_DEPENDENCIES = libglib2 libsigc host-pkgconf
 
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
+GLIBMM_CONF_ENV += CXXFLAGS="$(TARGET_CXXFLAGS) -O0"
+endif
+
 $(eval $(autotools-package))
-- 
2.17.1

[Buildroot] [PATCH v2 06/12] package/glibmm: fix BUG_85180 build timeout

[Thomas Petazzoni]

On Tue, 21 May 2019 15:39:26 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:

> With Microblaze Gcc version < 8.x build hangs on compiling first files.
> This is due to bug 85180:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
> Bug shows up building glibmm with optimization but not when building
> with -O0.
> 
> If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
> CXXFLAGS.
> 
> Fixes:
> http://autobuild.buildroot.net/results/e19/e196d77626b877dc3454d21febe20a04877c02a9/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
>  package/glibmm/glibmm.mk | 4 ++++
>  1 file changed, 4 insertions(+)

Applied to master after tweaking the CFLAGS logic and the commit log.
Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v2 06/12] package/glibmm: fix BUG_85180 build timeout

[Peter Korsgaard]

>>>>> "Giulio" == Giulio Benetti <giulio.benetti@micronovasrl.com> writes:

 > With Microblaze Gcc version < 8.x build hangs on compiling first files.
 > This is due to bug 85180:
 > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
 > Bug shows up building glibmm with optimization but not when building
 > with -O0.

 > If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
 > CXXFLAGS.

 > Fixes:
 > http://autobuild.buildroot.net/results/e19/e196d77626b877dc3454d21febe20a04877c02a9/

 > Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>

Committed to 2019.02.x, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v2 07/12] package/gst-ffmpeg: re-enable package if BUG_85180 is present

[Giulio Benetti]

With Microblaze Gcc version < 8.x build hangs on compiling first files.
This is due to bug 85180:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
This package has been excluded from building if BUG_85180 is present.
Bug shows up building gst-ffmpeg with optimization but not when building
with -O0.

In config.mk if BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 by:
- add --disable-optimizations to EXTRA_OPTS
- passing -O0 to CFLAGS in CONF_ENV
Then remove 'depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85180' and its
comment if not available from Config.in

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
 package/gstreamer/gst-ffmpeg/Config.in     | 4 ----
 package/gstreamer/gst-ffmpeg/gst-ffmpeg.mk | 5 +++++
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/package/gstreamer/gst-ffmpeg/Config.in b/package/gstreamer/gst-ffmpeg/Config.in
index 1e95d016f6..32bfdd53c6 100644
--- a/package/gstreamer/gst-ffmpeg/Config.in
+++ b/package/gstreamer/gst-ffmpeg/Config.in
@@ -5,7 +5,6 @@ config BR2_PACKAGE_GST_FFMPEG
 	depends on !BR2_MIPS_CPU_MIPS32R6 && !BR2_MIPS_CPU_MIPS64R6
 	# triggers https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65151 on sh
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 || !BR2_sh
-	depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85180
 	select BR2_PACKAGE_GST_PLUGINS_BASE
 	help
 	  GStreamer plugin containing one plugin with a set of
@@ -29,6 +28,3 @@ endif
 
 comment "gst-ffmpeg needs a toolchain w/ gcc >= 5"
 	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_5 && BR2_sh
-
-comment "gst-ffmpeg needs a toolchain not affected by GCC bug 85180"
-	depends on BR2_TOOLCHAIN_HAS_GCC_BUG_85180
diff --git a/package/gstreamer/gst-ffmpeg/gst-ffmpeg.mk b/package/gstreamer/gst-ffmpeg/gst-ffmpeg.mk
index 6f41efb0a5..3a29c776c3 100644
--- a/package/gstreamer/gst-ffmpeg/gst-ffmpeg.mk
+++ b/package/gstreamer/gst-ffmpeg/gst-ffmpeg.mk
@@ -90,6 +90,11 @@ ifeq ($(BR2_STATIC_LIBS),)
 GST_FFMPEG_CONF_EXTRA_OPTS += --enable-pic
 endif
 
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
+GST_FFMPEG_CONF_EXTRA_OPTS += --disable-optimizations
+GST_FFMPEG_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -O0"
+endif
+
 GST_FFMPEG_CONF_OPTS += --with-ffmpeg-extra-configure="$(GST_FFMPEG_CONF_EXTRA_OPTS)"
 
 $(eval $(autotools-package))
-- 
2.17.1

[Buildroot] [PATCH v2 07/12] package/gst-ffmpeg: re-enable package if BUG_85180 is present

[Thomas Petazzoni]

On Tue, 21 May 2019 15:39:27 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:

> With Microblaze Gcc version < 8.x build hangs on compiling first files.
> This is due to bug 85180:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
> This package has been excluded from building if BUG_85180 is present.
> Bug shows up building gst-ffmpeg with optimization but not when building
> with -O0.
> 
> In config.mk if BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 by:
> - add --disable-optimizations to EXTRA_OPTS
> - passing -O0 to CFLAGS in CONF_ENV
> Then remove 'depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85180' and its
> comment if not available from Config.in
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
>  package/gstreamer/gst-ffmpeg/Config.in     | 4 ----
>  package/gstreamer/gst-ffmpeg/gst-ffmpeg.mk | 5 +++++
>  2 files changed, 5 insertions(+), 4 deletions(-)

Applied to master after tweaking the CFLAGS logic and improving the
commit log. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v2 07/12] package/gst-ffmpeg: re-enable package if BUG_85180 is present

[Peter Korsgaard]

>>>>> "Giulio" == Giulio Benetti <giulio.benetti@micronovasrl.com> writes:

 > With Microblaze Gcc version < 8.x build hangs on compiling first files.
 > This is due to bug 85180:
 > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
 > This package has been excluded from building if BUG_85180 is present.
 > Bug shows up building gst-ffmpeg with optimization but not when building
 > with -O0.

 > In config.mk if BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 by:
 > - add --disable-optimizations to EXTRA_OPTS
 > - passing -O0 to CFLAGS in CONF_ENV
 > Then remove 'depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85180' and its
 > comment if not available from Config.in

 > Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>

Committed to 2019.02.x, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v2 08/12] package/jasper: fix BUG_85180 build timeout

[Giulio Benetti]

With Microblaze Gcc version < 8.x build hangs on compiling last files
before linking.
This is due to bug 85180:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
Bug shows up building jasper with optimization but not when building
with -O0.

If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
CFLAGS.

Fixes:
http://autobuild.buildroot.net/results/554/5546087cdf684099525dc5824ed428cd0fd74283/

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
 package/jasper/jasper.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/jasper/jasper.mk b/package/jasper/jasper.mk
index b544a7c1c6..360df563fb 100644
--- a/package/jasper/jasper.mk
+++ b/package/jasper/jasper.mk
@@ -25,4 +25,8 @@ else
 JASPER_CONF_OPTS += -DJAS_ENABLE_LIBJPEG=OFF
 endif
 
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
+JASPER_CONF_OPTS += -DCMAKE_C_FLAGS="$(TARGET_CFLAGS) -O0"
+endif
+
 $(eval $(cmake-package))
-- 
2.17.1

[Buildroot] [PATCH v2 08/12] package/jasper: fix BUG_85180 build timeout

[Thomas Petazzoni]

On Tue, 21 May 2019 15:39:28 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:

> With Microblaze Gcc version < 8.x build hangs on compiling last files
> before linking.
> This is due to bug 85180:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
> Bug shows up building jasper with optimization but not when building
> with -O0.
> 
> If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
> CFLAGS.
> 
> Fixes:
> http://autobuild.buildroot.net/results/554/5546087cdf684099525dc5824ed428cd0fd74283/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
>  package/jasper/jasper.mk | 4 ++++
>  1 file changed, 4 insertions(+)

Applied to master after tweaking the CFLAGS logic and the commit log.
Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v2 08/12] package/jasper: fix BUG_85180 build timeout

[Peter Korsgaard]

>>>>> "Giulio" == Giulio Benetti <giulio.benetti@micronovasrl.com> writes:

 > With Microblaze Gcc version < 8.x build hangs on compiling last files
 > before linking.
 > This is due to bug 85180:
 > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
 > Bug shows up building jasper with optimization but not when building
 > with -O0.

 > If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
 > CFLAGS.

 > Fixes:
 > http://autobuild.buildroot.net/results/554/5546087cdf684099525dc5824ed428cd0fd74283/

 > Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>

Committed to 2019.02.x, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v2 09/12] package/kismet: fix BUG_85180 build timeout

[Giulio Benetti]

With Microblaze Gcc version < 8.x build hangs on compiling first files.
This is due to bug 85180:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
Bug shows up building kismet with optimization but not when building
with -O0.

If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
CXXFLAGS.

Fixes:
http://autobuild.buildroot.net/results/02f/02f6e616631f05a4f15f31f2b2e67d65ba7afcb0/

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
 package/kismet/kismet.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/kismet/kismet.mk b/package/kismet/kismet.mk
index cee814b52b..b06106f58b 100644
--- a/package/kismet/kismet.mk
+++ b/package/kismet/kismet.mk
@@ -15,6 +15,10 @@ KISMET_LICENSE_FILES = debian/copyright
 # We touch configure.in:
 KISMET_AUTORECONF = YES
 
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
+KISMET_CONF_ENV += CXXFLAGS="$(TARGET_CXXFLAGS) -O0"
+endif
+
 ifeq ($(BR2_PACKAGE_LIBCAP),y)
 KISMET_DEPENDENCIES += libcap
 endif
-- 
2.17.1

[Buildroot] [PATCH v2 09/12] package/kismet: fix BUG_85180 build timeout

[Thomas Petazzoni]

On Tue, 21 May 2019 15:39:29 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:

> With Microblaze Gcc version < 8.x build hangs on compiling first files.
> This is due to bug 85180:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
> Bug shows up building kismet with optimization but not when building
> with -O0.
> 
> If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
> CXXFLAGS.
> 
> Fixes:
> http://autobuild.buildroot.net/results/02f/02f6e616631f05a4f15f31f2b2e67d65ba7afcb0/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
>  package/kismet/kismet.mk | 4 ++++
>  1 file changed, 4 insertions(+)

Applied to master after tweaking the CFLAGS logic and the commit log.
Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v2 09/12] package/kismet: fix BUG_85180 build timeout

[Peter Korsgaard]

>>>>> "Giulio" == Giulio Benetti <giulio.benetti@micronovasrl.com> writes:

 > With Microblaze Gcc version < 8.x build hangs on compiling first files.
 > This is due to bug 85180:
 > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
 > Bug shows up building kismet with optimization but not when building
 > with -O0.

 > If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
 > CXXFLAGS.

 > Fixes:
 > http://autobuild.buildroot.net/results/02f/02f6e616631f05a4f15f31f2b2e67d65ba7afcb0/

 > Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>

Committed to 2019.02.x, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v2 10/12] package/libcpprestsdk: fix BUG_85180 build timeout

[Giulio Benetti]

With Microblaze Gcc version < 8.x build hangs on compiling first files.
This is due to bug 85180:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
Bug shows up building libcpprestsdk with optimization but not when
building with -O0.

If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
CXXFLAGS.

Fixes:
http://autobuild.buildroot.net/results/706/7065e14917a8bbc0faf21b29183ac55b6c800ee3/

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
 package/libcpprestsdk/libcpprestsdk.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/libcpprestsdk/libcpprestsdk.mk b/package/libcpprestsdk/libcpprestsdk.mk
index e8dddeddd7..4be2cb20fb 100644
--- a/package/libcpprestsdk/libcpprestsdk.mk
+++ b/package/libcpprestsdk/libcpprestsdk.mk
@@ -36,4 +36,8 @@ else
 LIBCPPRESTSDK_CONF_OPTS += -DCPPREST_EXCLUDE_WEBSOCKETS=ON
 endif
 
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
+LIBCPPRESTSDK_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(TARGET_CXXFLAGS) -O0"
+endif
+
 $(eval $(cmake-package))
-- 
2.17.1

[Buildroot] [PATCH v2 10/12] package/libcpprestsdk: fix BUG_85180 build timeout

[Thomas Petazzoni]

On Tue, 21 May 2019 15:39:30 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:

> With Microblaze Gcc version < 8.x build hangs on compiling first files.
> This is due to bug 85180:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
> Bug shows up building libcpprestsdk with optimization but not when
> building with -O0.
> 
> If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
> CXXFLAGS.
> 
> Fixes:
> http://autobuild.buildroot.net/results/706/7065e14917a8bbc0faf21b29183ac55b6c800ee3/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
>  package/libcpprestsdk/libcpprestsdk.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/libcpprestsdk/libcpprestsdk.mk b/package/libcpprestsdk/libcpprestsdk.mk
> index e8dddeddd7..4be2cb20fb 100644
> --- a/package/libcpprestsdk/libcpprestsdk.mk
> +++ b/package/libcpprestsdk/libcpprestsdk.mk
> @@ -36,4 +36,8 @@ else
>  LIBCPPRESTSDK_CONF_OPTS += -DCPPREST_EXCLUDE_WEBSOCKETS=ON
>  endif
>  
> +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
> +LIBCPPRESTSDK_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(TARGET_CXXFLAGS) -O0"
> +endif

This package is another example why this approach to override CXXFLAGS
is not good. Indeed, after your commit, the package contained this:

ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
LIBCPPRESTSDK_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(TARGET_CXXFLAGS) -latomic"
endif

ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
LIBCPPRESTSDK_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(TARGET_CXXFLAGS) -O0"
endif

Guess what happens when BR2_TOOLCHAIN_HAS_LIBATOMIC=y *and*
BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y ? You loose the -latomic flag. That's
why I really prefer that we define an intermediate <pkg>_CXXFLAGS
variable.

I fixed that up, improved the commit log and applied to master. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v2 10/12] package/libcpprestsdk: fix BUG_85180 build timeout

[Giulio Benetti]

Il 24/05/2019 22:03, Thomas Petazzoni ha scritto:
> On Tue, 21 May 2019 15:39:30 +0200
> Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:
> 
>> With Microblaze Gcc version < 8.x build hangs on compiling first files.
>> This is due to bug 85180:
>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
>> Bug shows up building libcpprestsdk with optimization but not when
>> building with -O0.
>>
>> If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
>> CXXFLAGS.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/706/7065e14917a8bbc0faf21b29183ac55b6c800ee3/
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
>> ---
>>   package/libcpprestsdk/libcpprestsdk.mk | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/package/libcpprestsdk/libcpprestsdk.mk b/package/libcpprestsdk/libcpprestsdk.mk
>> index e8dddeddd7..4be2cb20fb 100644
>> --- a/package/libcpprestsdk/libcpprestsdk.mk
>> +++ b/package/libcpprestsdk/libcpprestsdk.mk
>> @@ -36,4 +36,8 @@ else
>>   LIBCPPRESTSDK_CONF_OPTS += -DCPPREST_EXCLUDE_WEBSOCKETS=ON
>>   endif
>>   
>> +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
>> +LIBCPPRESTSDK_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(TARGET_CXXFLAGS) -O0"
>> +endif
> 
> This package is another example why this approach to override CXXFLAGS
> is not good. Indeed, after your commit, the package contained this:
> 
> ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
> LIBCPPRESTSDK_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(TARGET_CXXFLAGS) -latomic"
> endif
> 
> ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
> LIBCPPRESTSDK_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(TARGET_CXXFLAGS) -O0"
> endif
> 
> Guess what happens when BR2_TOOLCHAIN_HAS_LIBATOMIC=y *and*
> BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y ? You loose the -latomic flag. That's
> why I really prefer that we define an intermediate <pkg>_CXXFLAGS
> variable.

Yes, I will take that into account on next patches.
Thanks for fixing and explaining!

-- 
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642

> I fixed that up, improved the commit log and applied to master. Thanks!
> 
> Thomas
> 

[Buildroot] [PATCH v2 11/12] package/opus: fix BUG_85180 build timeout

[Giulio Benetti]

With Microblaze Gcc version < 8.x build hangs on compiling last files
before linking.
This is due to bug 85180:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
Bug shows up building opus with optimization but not when building with
-O0.

If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
CFLAGS.

Fixes:
http://autobuild.buildroot.net/results/73d/73dc9610a13d6e14eec58d529617210d93d5dec4/

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
 package/opus/opus.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/opus/opus.mk b/package/opus/opus.mk
index f23461a3af..4b127aa187 100644
--- a/package/opus/opus.mk
+++ b/package/opus/opus.mk
@@ -10,6 +10,10 @@ OPUS_LICENSE = BSD-3-Clause
 OPUS_LICENSE_FILES = COPYING
 OPUS_INSTALL_STAGING = YES
 
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
+OPUS_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -O0"
+endif
+
 ifeq ($(BR2_PACKAGE_OPUS_FIXED_POINT),y)
 OPUS_CONF_OPTS += --enable-fixed-point
 endif
-- 
2.17.1

[Buildroot] [PATCH v2 11/12] package/opus: fix BUG_85180 build timeout

[Thomas Petazzoni]

On Tue, 21 May 2019 15:39:31 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:

> With Microblaze Gcc version < 8.x build hangs on compiling last files
> before linking.
> This is due to bug 85180:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
> Bug shows up building opus with optimization but not when building with
> -O0.
> 
> If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
> CFLAGS.
> 
> Fixes:
> http://autobuild.buildroot.net/results/73d/73dc9610a13d6e14eec58d529617210d93d5dec4/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
>  package/opus/opus.mk | 4 ++++
>  1 file changed, 4 insertions(+)

Applied to master after tweaking the CFLAGS logic and improving the
commit log. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v2 11/12] package/opus: fix BUG_85180 build timeout

[Peter Korsgaard]

>>>>> "Giulio" == Giulio Benetti <giulio.benetti@micronovasrl.com> writes:

 > With Microblaze Gcc version < 8.x build hangs on compiling last files
 > before linking.
 > This is due to bug 85180:
 > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
 > Bug shows up building opus with optimization but not when building with
 > -O0.

 > If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
 > CFLAGS.

 > Fixes:
 > http://autobuild.buildroot.net/results/73d/73dc9610a13d6e14eec58d529617210d93d5dec4/

 > Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>

Committed to 2019.02.x, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v2 12/12] package/postgresql: fix BUG_85180 build timeout

[Giulio Benetti]

With Microblaze Gcc version < 8.x build hangs on compiling last files
before linking.
This is due to bug 85180:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
Bug shows up building postgresql with optimization but not when building
with -O0.

If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
CFLAGS.

Fixes:
http://autobuild.buildroot.net/results/53c/53c270c696ee999d541da0b09bf6a215e5335e9a/

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
 package/postgresql/postgresql.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/postgresql/postgresql.mk b/package/postgresql/postgresql.mk
index 067679bcbd..da49ca755e 100644
--- a/package/postgresql/postgresql.mk
+++ b/package/postgresql/postgresql.mk
@@ -93,6 +93,10 @@ else
 POSTGRESQL_CONF_OPTS += --without-systemd
 endif
 
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
+POSTGRESQL_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -O0"
+endif
+
 define POSTGRESQL_USERS
 	postgres -1 postgres -1 * /var/lib/pgsql /bin/sh - PostgreSQL Server
 endef
-- 
2.17.1

[Buildroot] [PATCH v2 12/12] package/postgresql: fix BUG_85180 build timeout

[Thomas Petazzoni]

On Tue, 21 May 2019 15:39:32 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:

> With Microblaze Gcc version < 8.x build hangs on compiling last files
> before linking.
> This is due to bug 85180:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
> Bug shows up building postgresql with optimization but not when building
> with -O0.
> 
> If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
> CFLAGS.
> 
> Fixes:
> http://autobuild.buildroot.net/results/53c/53c270c696ee999d541da0b09bf6a215e5335e9a/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
>  package/postgresql/postgresql.mk | 4 ++++
>  1 file changed, 4 insertions(+)

Applied to master after tweaking the CFLAGS logic and improving the
commit log. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v2 12/12] package/postgresql: fix BUG_85180 build timeout

[Peter Korsgaard]

>>>>> "Giulio" == Giulio Benetti <giulio.benetti@micronovasrl.com> writes:

 > With Microblaze Gcc version < 8.x build hangs on compiling last files
 > before linking.
 > This is due to bug 85180:
 > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180
 > Bug shows up building postgresql with optimization but not when building
 > with -O0.

 > If BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y force using -O0 passing it to
 > CFLAGS.

 > Fixes:
 > http://autobuild.buildroot.net/results/53c/53c270c696ee999d541da0b09bf6a215e5335e9a/

 > Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>

Committed to 2019.02.x, thanks.

-- 
Bye, Peter Korsgaard