From: Kalle Valo <kvalo@kernel.org> To: Manikanta Pubbisetty <quic_mpubbise@quicinc.com> Cc: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>, <devicetree@vger.kernel.org>, <robh@kernel.org> Subject: Re: [PATCH v2 02/19] ath11k: Refactor PCI code to support hybrid bus devices Date: Fri, 28 Jan 2022 14:13:55 +0200 [thread overview] Message-ID: <87h79of470.fsf@kernel.org> (raw) In-Reply-To: <1642337235-8618-3-git-send-email-quic_mpubbise@quicinc.com> (Manikanta Pubbisetty's message of "Sun, 16 Jan 2022 18:16:58 +0530") Manikanta Pubbisetty <quic_mpubbise@quicinc.com> writes: > Unlike other ATH11K PCIe devices which are enumerated by APSS > processor (Application Processor SubSystem), WCN6750 gets > enumerated by the WPSS Q6 processor (Wireless Processor SubSystem); > In simple terms, though WCN6750 is PCIe device, it is not attached > to the APSS processor, APSS will not know of such a device being > present in the system and therefore WCN6750 will be registered as > a platform device to the kernel core like other supported AHB > devices. > > WCN6750 uses both AHB and PCI APIs for it's operation, it uses > AHB APIs for device probe/boot and PCI APIs for device setup > and register accesses; Because of this nature, it is referred > as a hybrid bus device. > > Refactor PCI code to support hybrid bus devices like WCN6750. > > Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00573-QCAMSLSWPLZ-1 > Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1 > Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.5.0.1-01100-QCAHKSWPL_SILICONZ-1 > Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-00192-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com> [...] > --- /dev/null > +++ b/drivers/net/wireless/ath/ath11k/pci_cmn.c [...] > +static inline void ath11k_pci_select_window(struct ath11k_pci *ab_pci, u32 offset) > +{ > + struct ath11k_base *ab = ab_pci->ab; > + > + u32 window = FIELD_GET(ATH11K_PCI_WINDOW_VALUE_MASK, offset); > + > + lockdep_assert_held(&ab_pci->window_lock); > + > + if (window != ab_pci->register_window) { > + iowrite32(ATH11K_PCI_WINDOW_ENABLE_BIT | window, > + ab->mem + ATH11K_PCI_WINDOW_REG_ADDRESS); > + ioread32(ab->mem + ATH11K_PCI_WINDOW_REG_ADDRESS); > + ab_pci->register_window = window; > + } > +} So the style used in ath11k is ath11k_<filename>_foo, so that a function ath11k_pci_foo() should be in pci.c. This patch is now breaking that style. Maybe pci_cmn.c should renamed to cpci.c, pcic.c or something like that? Then the function prefix could be ath11k_cpci_, ath11k_pcic_ or similar. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org> To: Manikanta Pubbisetty <quic_mpubbise@quicinc.com> Cc: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>, <devicetree@vger.kernel.org>, <robh@kernel.org> Subject: Re: [PATCH v2 02/19] ath11k: Refactor PCI code to support hybrid bus devices Date: Fri, 28 Jan 2022 14:13:55 +0200 [thread overview] Message-ID: <87h79of470.fsf@kernel.org> (raw) In-Reply-To: <1642337235-8618-3-git-send-email-quic_mpubbise@quicinc.com> (Manikanta Pubbisetty's message of "Sun, 16 Jan 2022 18:16:58 +0530") Manikanta Pubbisetty <quic_mpubbise@quicinc.com> writes: > Unlike other ATH11K PCIe devices which are enumerated by APSS > processor (Application Processor SubSystem), WCN6750 gets > enumerated by the WPSS Q6 processor (Wireless Processor SubSystem); > In simple terms, though WCN6750 is PCIe device, it is not attached > to the APSS processor, APSS will not know of such a device being > present in the system and therefore WCN6750 will be registered as > a platform device to the kernel core like other supported AHB > devices. > > WCN6750 uses both AHB and PCI APIs for it's operation, it uses > AHB APIs for device probe/boot and PCI APIs for device setup > and register accesses; Because of this nature, it is referred > as a hybrid bus device. > > Refactor PCI code to support hybrid bus devices like WCN6750. > > Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00573-QCAMSLSWPLZ-1 > Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1 > Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.5.0.1-01100-QCAHKSWPL_SILICONZ-1 > Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-00192-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com> [...] > --- /dev/null > +++ b/drivers/net/wireless/ath/ath11k/pci_cmn.c [...] > +static inline void ath11k_pci_select_window(struct ath11k_pci *ab_pci, u32 offset) > +{ > + struct ath11k_base *ab = ab_pci->ab; > + > + u32 window = FIELD_GET(ATH11K_PCI_WINDOW_VALUE_MASK, offset); > + > + lockdep_assert_held(&ab_pci->window_lock); > + > + if (window != ab_pci->register_window) { > + iowrite32(ATH11K_PCI_WINDOW_ENABLE_BIT | window, > + ab->mem + ATH11K_PCI_WINDOW_REG_ADDRESS); > + ioread32(ab->mem + ATH11K_PCI_WINDOW_REG_ADDRESS); > + ab_pci->register_window = window; > + } > +} So the style used in ath11k is ath11k_<filename>_foo, so that a function ath11k_pci_foo() should be in pci.c. This patch is now breaking that style. Maybe pci_cmn.c should renamed to cpci.c, pcic.c or something like that? Then the function prefix could be ath11k_cpci_, ath11k_pcic_ or similar. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2022-01-28 12:14 UTC|newest] Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-16 12:46 [PATCH v2 00/19] add support for WCN6750 Manikanta Pubbisetty 2022-01-16 12:46 ` Manikanta Pubbisetty 2022-01-16 12:46 ` [PATCH v2 01/19] ath11k: PCI changes to support WCN6750 Manikanta Pubbisetty 2022-01-16 12:46 ` Manikanta Pubbisetty 2022-01-16 12:46 ` [PATCH v2 02/19] ath11k: Refactor PCI code to support hybrid bus devices Manikanta Pubbisetty 2022-01-16 12:46 ` Manikanta Pubbisetty 2022-01-28 10:16 ` Kalle Valo 2022-01-28 10:16 ` Kalle Valo 2022-02-25 5:50 ` Manikanta Pubbisetty 2022-02-25 5:50 ` Manikanta Pubbisetty 2022-03-08 6:00 ` Manikanta Pubbisetty 2022-03-08 6:00 ` Manikanta Pubbisetty 2022-01-28 12:13 ` Kalle Valo [this message] 2022-01-28 12:13 ` Kalle Valo 2022-02-21 8:04 ` Manikanta Pubbisetty 2022-02-21 8:04 ` Manikanta Pubbisetty 2022-02-21 9:19 ` Kalle Valo 2022-02-21 9:19 ` Kalle Valo 2022-02-21 10:19 ` Manikanta Pubbisetty 2022-02-21 10:19 ` Manikanta Pubbisetty 2022-01-16 12:46 ` [PATCH v2 03/19] ath11k: Choose MSI config based on HW revision Manikanta Pubbisetty 2022-01-16 12:46 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 04/19] ath11k: Refactor MSI logic Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 05/19] ath11k: Remove core PCI references from PCI common code Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-28 10:20 ` Kalle Valo 2022-01-28 10:20 ` Kalle Valo 2022-01-28 10:37 ` Kalle Valo 2022-01-28 10:37 ` Kalle Valo 2022-02-21 7:07 ` Manikanta Pubbisetty 2022-02-21 7:07 ` Manikanta Pubbisetty 2022-02-21 9:21 ` Kalle Valo 2022-02-21 9:21 ` Kalle Valo 2022-02-21 6:55 ` Manikanta Pubbisetty 2022-02-21 6:55 ` Manikanta Pubbisetty 2022-02-21 9:17 ` Kalle Valo 2022-02-21 9:17 ` Kalle Valo 2022-02-21 10:08 ` Manikanta Pubbisetty 2022-02-21 10:08 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 06/19] ath11k: Add HW params for WCN6750 Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 07/19] ath11k: Add bus " Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 08/19] ath11k: Add register access logic " Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 09/19] ath11k: Fetch device information via QMI " Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 10/19] ath11k: Add QMI changes " Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-28 10:50 ` Kalle Valo 2022-01-28 10:50 ` Kalle Valo 2022-02-21 8:02 ` Manikanta Pubbisetty 2022-02-21 8:02 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 11/19] ath11k: HAL changes to support WCN6750 Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 12/19] ath11k: Datapath " Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-04-27 5:32 ` Kalle Valo 2022-04-27 5:32 ` Kalle Valo 2022-04-27 5:37 ` Manikanta Pubbisetty 2022-04-27 5:37 ` Manikanta Pubbisetty 2022-04-27 5:48 ` Kalle Valo 2022-04-27 5:48 ` Kalle Valo 2022-04-27 5:56 ` Manikanta Pubbisetty 2022-04-27 5:56 ` Manikanta Pubbisetty 2022-04-29 8:56 ` Kalle Valo 2022-04-29 8:56 ` Kalle Valo 2022-01-16 12:47 ` [PATCH v2 13/19] ath11k: Fix RX de-fragmentation issue on WCN6750 Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 14/19] ath11k: Do not put HW in DBS mode for WCN6750 Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 15/19] ath11k: WMI changes to support WCN6750 Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 16/19] ath11k: Update WBM idle ring HP after FW mode on Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 17/19] ath11k: Add support for WCN6750 device Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 18/19] ath11k: Add support for targets without trustzone Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-28 10:42 ` Kalle Valo 2022-01-28 10:42 ` Kalle Valo 2022-02-21 8:00 ` Manikanta Pubbisetty 2022-02-21 8:00 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 19/19] dt: bindings: net: add bindings of WCN6750 for ath11k Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-28 10:39 ` Kalle Valo 2022-01-28 10:39 ` Kalle Valo 2022-02-21 7:08 ` Manikanta Pubbisetty 2022-02-21 7:08 ` Manikanta Pubbisetty 2022-02-07 22:13 ` Rob Herring 2022-02-07 22:13 ` Rob Herring 2022-02-25 11:34 ` Manikanta Pubbisetty 2022-02-25 11:34 ` Manikanta Pubbisetty 2022-01-28 10:07 ` [PATCH v2 00/19] add support for WCN6750 Kalle Valo 2022-01-28 10:07 ` Kalle Valo 2022-02-21 6:29 ` Manikanta Pubbisetty 2022-02-21 6:29 ` Manikanta Pubbisetty
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87h79of470.fsf@kernel.org \ --to=kvalo@kernel.org \ --cc=ath11k@lists.infradead.org \ --cc=devicetree@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=quic_mpubbise@quicinc.com \ --cc=robh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.