From: Kalle Valo <kvalo@kernel.org> To: Manikanta Pubbisetty <quic_mpubbise@quicinc.com> Cc: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>, <devicetree@vger.kernel.org>, <robh@kernel.org> Subject: Re: [PATCH v2 10/19] ath11k: Add QMI changes for WCN6750 Date: Fri, 28 Jan 2022 12:50:30 +0200 [thread overview] Message-ID: <87o83wf821.fsf@kernel.org> (raw) In-Reply-To: <1642337235-8618-11-git-send-email-quic_mpubbise@quicinc.com> (Manikanta Pubbisetty's message of "Sun, 16 Jan 2022 18:17:06 +0530") Manikanta Pubbisetty <quic_mpubbise@quicinc.com> writes: > In the case of WCN6750, FW doesn't request for DDR memory > via QMI, instead it uses a fixed 12MB reserved Memory region > in the DDR which is called as MSA region. As a result, QMI > message sequence is not same as other ath11k supported devices. > > Also, M3 firmware will be bundled into the FW and will be > downloaded to the target as part of Q6 boot. > > This is the QMI flow in the case of WCN6750, > > 1) QMI firmware indication REQ/RESP > 2) QMI host capability REQ/RESP > 3) QMI target capability REQ/RESP > 4) QMI device info REQ/RESP > 5) QMI BDF download > 6) QMI FW ready > > Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00573-QCAMSLSWPLZ-1 > Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1 > Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.5.0.1-01100-QCAHKSWPL_SILICONZ-1 > Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-00192-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com> [...] > @@ -2490,6 +2497,13 @@ static int ath11k_qmi_wlanfw_m3_info_send(struct ath11k_base *ab) > struct qmi_txn txn; > int ret = 0; > > + /* In the case of WCN6750, M3 is bundled into the FW > + * binary, and will be downloaded as part of Q6 boot. > + */ > + if (!ab->bus_params.m3_fw_support && > + ab->bus_params.hybrid_bus_type) > + return 0; A check like this makes me think if it's just better to m3_fw_support to ath11k_hw_params. That way you could disable m3 for WCN6750 via hw_params. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org> To: Manikanta Pubbisetty <quic_mpubbise@quicinc.com> Cc: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>, <devicetree@vger.kernel.org>, <robh@kernel.org> Subject: Re: [PATCH v2 10/19] ath11k: Add QMI changes for WCN6750 Date: Fri, 28 Jan 2022 12:50:30 +0200 [thread overview] Message-ID: <87o83wf821.fsf@kernel.org> (raw) In-Reply-To: <1642337235-8618-11-git-send-email-quic_mpubbise@quicinc.com> (Manikanta Pubbisetty's message of "Sun, 16 Jan 2022 18:17:06 +0530") Manikanta Pubbisetty <quic_mpubbise@quicinc.com> writes: > In the case of WCN6750, FW doesn't request for DDR memory > via QMI, instead it uses a fixed 12MB reserved Memory region > in the DDR which is called as MSA region. As a result, QMI > message sequence is not same as other ath11k supported devices. > > Also, M3 firmware will be bundled into the FW and will be > downloaded to the target as part of Q6 boot. > > This is the QMI flow in the case of WCN6750, > > 1) QMI firmware indication REQ/RESP > 2) QMI host capability REQ/RESP > 3) QMI target capability REQ/RESP > 4) QMI device info REQ/RESP > 5) QMI BDF download > 6) QMI FW ready > > Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00573-QCAMSLSWPLZ-1 > Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1 > Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.5.0.1-01100-QCAHKSWPL_SILICONZ-1 > Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-00192-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com> [...] > @@ -2490,6 +2497,13 @@ static int ath11k_qmi_wlanfw_m3_info_send(struct ath11k_base *ab) > struct qmi_txn txn; > int ret = 0; > > + /* In the case of WCN6750, M3 is bundled into the FW > + * binary, and will be downloaded as part of Q6 boot. > + */ > + if (!ab->bus_params.m3_fw_support && > + ab->bus_params.hybrid_bus_type) > + return 0; A check like this makes me think if it's just better to m3_fw_support to ath11k_hw_params. That way you could disable m3 for WCN6750 via hw_params. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2022-01-28 10:50 UTC|newest] Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-16 12:46 [PATCH v2 00/19] add support for WCN6750 Manikanta Pubbisetty 2022-01-16 12:46 ` Manikanta Pubbisetty 2022-01-16 12:46 ` [PATCH v2 01/19] ath11k: PCI changes to support WCN6750 Manikanta Pubbisetty 2022-01-16 12:46 ` Manikanta Pubbisetty 2022-01-16 12:46 ` [PATCH v2 02/19] ath11k: Refactor PCI code to support hybrid bus devices Manikanta Pubbisetty 2022-01-16 12:46 ` Manikanta Pubbisetty 2022-01-28 10:16 ` Kalle Valo 2022-01-28 10:16 ` Kalle Valo 2022-02-25 5:50 ` Manikanta Pubbisetty 2022-02-25 5:50 ` Manikanta Pubbisetty 2022-03-08 6:00 ` Manikanta Pubbisetty 2022-03-08 6:00 ` Manikanta Pubbisetty 2022-01-28 12:13 ` Kalle Valo 2022-01-28 12:13 ` Kalle Valo 2022-02-21 8:04 ` Manikanta Pubbisetty 2022-02-21 8:04 ` Manikanta Pubbisetty 2022-02-21 9:19 ` Kalle Valo 2022-02-21 9:19 ` Kalle Valo 2022-02-21 10:19 ` Manikanta Pubbisetty 2022-02-21 10:19 ` Manikanta Pubbisetty 2022-01-16 12:46 ` [PATCH v2 03/19] ath11k: Choose MSI config based on HW revision Manikanta Pubbisetty 2022-01-16 12:46 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 04/19] ath11k: Refactor MSI logic Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 05/19] ath11k: Remove core PCI references from PCI common code Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-28 10:20 ` Kalle Valo 2022-01-28 10:20 ` Kalle Valo 2022-01-28 10:37 ` Kalle Valo 2022-01-28 10:37 ` Kalle Valo 2022-02-21 7:07 ` Manikanta Pubbisetty 2022-02-21 7:07 ` Manikanta Pubbisetty 2022-02-21 9:21 ` Kalle Valo 2022-02-21 9:21 ` Kalle Valo 2022-02-21 6:55 ` Manikanta Pubbisetty 2022-02-21 6:55 ` Manikanta Pubbisetty 2022-02-21 9:17 ` Kalle Valo 2022-02-21 9:17 ` Kalle Valo 2022-02-21 10:08 ` Manikanta Pubbisetty 2022-02-21 10:08 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 06/19] ath11k: Add HW params for WCN6750 Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 07/19] ath11k: Add bus " Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 08/19] ath11k: Add register access logic " Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 09/19] ath11k: Fetch device information via QMI " Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 10/19] ath11k: Add QMI changes " Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-28 10:50 ` Kalle Valo [this message] 2022-01-28 10:50 ` Kalle Valo 2022-02-21 8:02 ` Manikanta Pubbisetty 2022-02-21 8:02 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 11/19] ath11k: HAL changes to support WCN6750 Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 12/19] ath11k: Datapath " Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-04-27 5:32 ` Kalle Valo 2022-04-27 5:32 ` Kalle Valo 2022-04-27 5:37 ` Manikanta Pubbisetty 2022-04-27 5:37 ` Manikanta Pubbisetty 2022-04-27 5:48 ` Kalle Valo 2022-04-27 5:48 ` Kalle Valo 2022-04-27 5:56 ` Manikanta Pubbisetty 2022-04-27 5:56 ` Manikanta Pubbisetty 2022-04-29 8:56 ` Kalle Valo 2022-04-29 8:56 ` Kalle Valo 2022-01-16 12:47 ` [PATCH v2 13/19] ath11k: Fix RX de-fragmentation issue on WCN6750 Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 14/19] ath11k: Do not put HW in DBS mode for WCN6750 Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 15/19] ath11k: WMI changes to support WCN6750 Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 16/19] ath11k: Update WBM idle ring HP after FW mode on Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 17/19] ath11k: Add support for WCN6750 device Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 18/19] ath11k: Add support for targets without trustzone Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-28 10:42 ` Kalle Valo 2022-01-28 10:42 ` Kalle Valo 2022-02-21 8:00 ` Manikanta Pubbisetty 2022-02-21 8:00 ` Manikanta Pubbisetty 2022-01-16 12:47 ` [PATCH v2 19/19] dt: bindings: net: add bindings of WCN6750 for ath11k Manikanta Pubbisetty 2022-01-16 12:47 ` Manikanta Pubbisetty 2022-01-28 10:39 ` Kalle Valo 2022-01-28 10:39 ` Kalle Valo 2022-02-21 7:08 ` Manikanta Pubbisetty 2022-02-21 7:08 ` Manikanta Pubbisetty 2022-02-07 22:13 ` Rob Herring 2022-02-07 22:13 ` Rob Herring 2022-02-25 11:34 ` Manikanta Pubbisetty 2022-02-25 11:34 ` Manikanta Pubbisetty 2022-01-28 10:07 ` [PATCH v2 00/19] add support for WCN6750 Kalle Valo 2022-01-28 10:07 ` Kalle Valo 2022-02-21 6:29 ` Manikanta Pubbisetty 2022-02-21 6:29 ` Manikanta Pubbisetty
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87o83wf821.fsf@kernel.org \ --to=kvalo@kernel.org \ --cc=ath11k@lists.infradead.org \ --cc=devicetree@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=quic_mpubbise@quicinc.com \ --cc=robh@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.