overlap of devices in rtl8xxxu and rtl8192cu

overlap of devices in rtl8xxxu and rtl8192cu

[Xose Vazquez Perez]

Kalle Valo wrote:

>> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>> 
>> This is an alternate driver for a number of Realtek WiFi USB devices,
>> including RTL8723AU, RTL8188CU, RTL8188RU, RTL8191CU, and RTL8192CU.
>> It was written from scratch utilizing the Linux mac80211 stack.
>> 
>> After spending months cleaning up the vendor provided rtl8723au
>> driver, which comes with it's own 802.11 stack included, I decided to
>> rewrite this driver from the bottom up.
>> 
>> Many thanks to Johannes Berg for 802.11 insights and help and Larry
>> Finger for help with the vendor driver.
>> 
>> The full git log for the development of this driver can be found here:
>> git git://git.kernel.org/pub/scm/linux/kernel/git/jes/linux.git
>>     branch rtl8723au-mac80211
>> 
>> This driver is still under development, but has proven to be very
>> stable for me. It currently supports station mode only. It has support
>> for OFDM and CCK rates. It does lack certain features found in the
>> staging driver, such as power management, AMPDU, and 40MHz channel
>> support. In addition it does not support AD-HOC, AP, and monitor mode
>> support at this point.
>> 
>> The driver is known to work with the following devices:
>> Lenovo Yoga (rtl8723au)
>> TP-Link TL-WN823N (rtl8192cu)
>> Etekcity 6R (rtl8188cu)
>> Daffodil LAN03 (rtl8188cu)
>> Alfa AWUS036NHR (rtl8188ru)
>> 
>> Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
> 
> Thanks, applied to wireless-drivers-next.git.

There is overlap of devices between rtl8xxxu and rtl8192cu:
USB_VENDER_ID_REALTEK, 0x8176
USB_VENDER_ID_REALTEK, 0x8178
USB_VENDER_ID_REALTEK, 0x817f
0x7392, 0x7811

Re: overlap of devices in rtl8xxxu and rtl8192cu

[Jes Sorensen]

Xose Vazquez Perez <xose.vazquez@gmail.com> writes:
> Kalle Valo wrote:
>
>>> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>>> 
>>> This is an alternate driver for a number of Realtek WiFi USB devices,
>>> including RTL8723AU, RTL8188CU, RTL8188RU, RTL8191CU, and RTL8192CU.
>>> It was written from scratch utilizing the Linux mac80211 stack.
>>> 
>>> After spending months cleaning up the vendor provided rtl8723au
>>> driver, which comes with it's own 802.11 stack included, I decided to
>>> rewrite this driver from the bottom up.
>>> 
>>> Many thanks to Johannes Berg for 802.11 insights and help and Larry
>>> Finger for help with the vendor driver.
>>> 
>>> The full git log for the development of this driver can be found here:
>>> git git://git.kernel.org/pub/scm/linux/kernel/git/jes/linux.git
>>>     branch rtl8723au-mac80211
>>> 
>>> This driver is still under development, but has proven to be very
>>> stable for me. It currently supports station mode only. It has support
>>> for OFDM and CCK rates. It does lack certain features found in the
>>> staging driver, such as power management, AMPDU, and 40MHz channel
>>> support. In addition it does not support AD-HOC, AP, and monitor mode
>>> support at this point.
>>> 
>>> The driver is known to work with the following devices:
>>> Lenovo Yoga (rtl8723au)
>>> TP-Link TL-WN823N (rtl8192cu)
>>> Etekcity 6R (rtl8188cu)
>>> Daffodil LAN03 (rtl8188cu)
>>> Alfa AWUS036NHR (rtl8188ru)
>>> 
>>> Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
>> 
>> Thanks, applied to wireless-drivers-next.git.
>
> There is overlap of devices between rtl8xxxu and rtl8192cu:
> USB_VENDER_ID_REALTEK, 0x8176
> USB_VENDER_ID_REALTEK, 0x8178
> USB_VENDER_ID_REALTEK, 0x817f
> 0x7392, 0x7811

Yes, and there is also a clash with USB IDs between
drivers/staging/rtl8192u and drivers/net/wireless/realtek/rtlwifi - this
is nothing new.

Jes

Re: overlap of devices in rtl8xxxu and rtl8192cu

[Kalle Valo]

Jes Sorensen <Jes.Sorensen@redhat.com> writes:

> Xose Vazquez Perez <xose.vazquez@gmail.com> writes:
>>
>> There is overlap of devices between rtl8xxxu and rtl8192cu:
>> USB_VENDER_ID_REALTEK, 0x8176
>> USB_VENDER_ID_REALTEK, 0x8178
>> USB_VENDER_ID_REALTEK, 0x817f
>> 0x7392, 0x7811
>
> Yes

What, are you saying that you didn't fix that? I did say in the last
review round that we should not have duplicated device entries within
drivers/net/wireless and I assumed you took care of that.

> and there is also a clash with USB IDs between
> drivers/staging/rtl8192u and drivers/net/wireless/realtek/rtlwifi -
> this is nothing new.

We should do things properly in under drivers/, I don't care what
happens in staging and that's no excuse to do things badly.

-- 
Kalle Valo

Re: overlap of devices in rtl8xxxu and rtl8192cu

[Jes Sorensen]

Kalle Valo <kvalo@codeaurora.org> writes:
> Jes Sorensen <Jes.Sorensen@redhat.com> writes:
>
>> Xose Vazquez Perez <xose.vazquez@gmail.com> writes:
>>>
>>> There is overlap of devices between rtl8xxxu and rtl8192cu:
>>> USB_VENDER_ID_REALTEK, 0x8176
>>> USB_VENDER_ID_REALTEK, 0x8178
>>> USB_VENDER_ID_REALTEK, 0x817f
>>> 0x7392, 0x7811
>>
>> Yes
>
> What, are you saying that you didn't fix that? I did say in the last
> review round that we should not have duplicated device entries within
> drivers/net/wireless and I assumed you took care of that.
>
>> and there is also a clash with USB IDs between
>> drivers/staging/rtl8192u and drivers/net/wireless/realtek/rtlwifi -
>> this is nothing new.
>
> We should do things properly in under drivers/, I don't care what
> happens in staging and that's no excuse to do things badly.

As I explained earlier, there is no way I can do that unless we remove
rtlwifi's rtl8192cu driver and that cannot happen due to the feature
differences. There are plenty of other conflicts and this is not a bug.

In other words I *have* done things correctly here, and Xose's complaint
is bogus.

Jes

Re: overlap of devices in rtl8xxxu and rtl8192cu

[Kalle Valo]

Jes Sorensen <Jes.Sorensen@redhat.com> writes:

> Kalle Valo <kvalo@codeaurora.org> writes:
>> Jes Sorensen <Jes.Sorensen@redhat.com> writes:
>>
>>> Xose Vazquez Perez <xose.vazquez@gmail.com> writes:
>>>>
>>>> There is overlap of devices between rtl8xxxu and rtl8192cu:
>>>> USB_VENDER_ID_REALTEK, 0x8176
>>>> USB_VENDER_ID_REALTEK, 0x8178
>>>> USB_VENDER_ID_REALTEK, 0x817f
>>>> 0x7392, 0x7811
>>>
>>> Yes
>>
>> What, are you saying that you didn't fix that? I did say in the last
>> review round that we should not have duplicated device entries within
>> drivers/net/wireless and I assumed you took care of that.
>>
>>> and there is also a clash with USB IDs between
>>> drivers/staging/rtl8192u and drivers/net/wireless/realtek/rtlwifi -
>>> this is nothing new.
>>
>> We should do things properly in under drivers/, I don't care what
>> happens in staging and that's no excuse to do things badly.
>
> As I explained earlier, there is no way I can do that unless we remove
> rtlwifi's rtl8192cu driver and that cannot happen due to the feature
> differences. There are plenty of other conflicts and this is not a bug.

Like I said earlier in rtl8xxxu review, I don't want to have two drivers
supporting the same device. So either rtl8xxxu or rtlwifi supports the
devices above, not both. And to my knowledge rtl8xxxu is still lacking
in features, and it's a new driver, so it's best that rtlwifi continues
to support these for the time being. Once rtl8xxxu catches up and we
have a clear consensus we can make the switch.

I'll send a patch in a jiffy, merge window is getting closer so we don't
have any extra time.

-- 
Kalle Valo

Re: overlap of devices in rtl8xxxu and rtl8192cu

[Kalle Valo]

Kalle Valo <kvalo@codeaurora.org> writes:

> Like I said earlier in rtl8xxxu review, I don't want to have two drivers
> supporting the same device. So either rtl8xxxu or rtlwifi supports the
> devices above, not both. And to my knowledge rtl8xxxu is still lacking
> in features, and it's a new driver, so it's best that rtlwifi continues
> to support these for the time being. Once rtl8xxxu catches up and we
> have a clear consensus we can make the switch.
>
> I'll send a patch in a jiffy, merge window is getting closer so we don't
> have any extra time.

Heh, having hilarious problems with my patch:

<linux-wireless@vger.kernel.org>: host vger.kernel.org[209.132.180.67] said:
    550 5.7.1 Content-Policy reject msg: The capital Triple-X in subject is way
    too often associated with junk email, please rephrase.

The subject was:

Subject: [PATCH] rtl8xxxu: move devices supported by rtlwifi under
 CONFIG_RTL8XXXU_UNTESTED

-- 
Kalle Valo

Re: overlap of devices in rtl8xxxu and rtl8192cu

[Jes Sorensen]

Kalle Valo <kvalo@codeaurora.org> writes:
> Kalle Valo <kvalo@codeaurora.org> writes:
>
>> Like I said earlier in rtl8xxxu review, I don't want to have two drivers
>> supporting the same device. So either rtl8xxxu or rtlwifi supports the
>> devices above, not both. And to my knowledge rtl8xxxu is still lacking
>> in features, and it's a new driver, so it's best that rtlwifi continues
>> to support these for the time being. Once rtl8xxxu catches up and we
>> have a clear consensus we can make the switch.
>>
>> I'll send a patch in a jiffy, merge window is getting closer so we don't
>> have any extra time.
>
> Heh, having hilarious problems with my patch:
>
> <linux-wireless@vger.kernel.org>: host vger.kernel.org[209.132.180.67] said:
>     550 5.7.1 Content-Policy reject msg: The capital Triple-X in subject is way
>     too often associated with junk email, please rephrase.
>
> The subject was:
>
> Subject: [PATCH] rtl8xxxu: move devices supported by rtlwifi under
>  CONFIG_RTL8XXXU_UNTESTED

This seems a reasonable workaround for now.

Next time just add some extra buzzwords to the subject line and I am
sure it will go through :)

Jes

Re: overlap of devices in rtl8xxxu and rtl8192cu

[Larry Finger]

On 10/23/2015 12:53 PM, Jes Sorensen wrote:
> Kalle Valo <kvalo@codeaurora.org> writes:
>> Kalle Valo <kvalo@codeaurora.org> writes:
>>
>>> Like I said earlier in rtl8xxxu review, I don't want to have two drivers
>>> supporting the same device. So either rtl8xxxu or rtlwifi supports the
>>> devices above, not both. And to my knowledge rtl8xxxu is still lacking
>>> in features, and it's a new driver, so it's best that rtlwifi continues
>>> to support these for the time being. Once rtl8xxxu catches up and we
>>> have a clear consensus we can make the switch.
>>>
>>> I'll send a patch in a jiffy, merge window is getting closer so we don't
>>> have any extra time.
>>
>> Heh, having hilarious problems with my patch:
>>
>> <linux-wireless@vger.kernel.org>: host vger.kernel.org[209.132.180.67] said:
>>      550 5.7.1 Content-Policy reject msg: The capital Triple-X in subject is way
>>      too often associated with junk email, please rephrase.
>>
>> The subject was:
>>
>> Subject: [PATCH] rtl8xxxu: move devices supported by rtlwifi under
>>   CONFIG_RTL8XXXU_UNTESTED
>
> This seems a reasonable workaround for now.
>
> Next time just add some extra buzzwords to the subject line and I am
> sure it will go through :)

Well, when you try to send porn, the system will complain. :)

I agree that this is a sensible workaround.

Larry