[PATCH] tests/iotests: drop test 312 from auto group

[PATCH] tests/iotests: drop test 312 from auto group

[Alex Bennée]

The "auto" documentation states:

  That means they should run with every QEMU binary (also non-x86)

which is not the case as the check-system-fedora build which only
includes a rag tag group of rare and deprecated targets doesn't
support the virtio device required.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/qemu-iotests/group | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
index e4fb6327ae..bc5bc324fe 100644
--- a/tests/qemu-iotests/group
+++ b/tests/qemu-iotests/group
@@ -318,4 +318,4 @@
 307 rw quick export
 308 rw
 309 rw auto quick
-312 rw auto quick
+312 rw quick
-- 
2.20.1

Re: [PATCH] tests/iotests: drop test 312 from auto group

[Philippe Mathieu-Daudé]

On 1/5/21 11:04 AM, Alex Bennée wrote:
> The "auto" documentation states:
> 
>   That means they should run with every QEMU binary (also non-x86)
> 
> which is not the case as the check-system-fedora build which only
> includes a rag tag group of rare and deprecated targets doesn't
> support the virtio device required.
> 

Fixes: ef9bba1484b ("quorum: Implement bdrv_co_block_status()")
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  tests/qemu-iotests/group | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
> index e4fb6327ae..bc5bc324fe 100644
> --- a/tests/qemu-iotests/group
> +++ b/tests/qemu-iotests/group
> @@ -318,4 +318,4 @@
>  307 rw quick export
>  308 rw
>  309 rw auto quick
> -312 rw auto quick
> +312 rw quick
> 

Re: [PATCH] tests/iotests: drop test 312 from auto group

[Philippe Mathieu-Daudé]

On 1/5/21 11:12 AM, Philippe Mathieu-Daudé wrote:
> On 1/5/21 11:04 AM, Alex Bennée wrote:
>> The "auto" documentation states:
>>
>>   That means they should run with every QEMU binary (also non-x86)
>>
>> which is not the case as the check-system-fedora build which only
>> includes a rag tag group of rare and deprecated targets doesn't
>> support the virtio device required.
>>
> 
> Fixes: ef9bba1484b ("quorum: Implement bdrv_co_block_status()")
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Re: [PATCH] tests/iotests: drop test 312 from auto group

[Max Reitz]

On 05.01.21 11:04, Alex Bennée wrote:
> The "auto" documentation states:
> 
>    That means they should run with every QEMU binary (also non-x86)
> 
> which is not the case as the check-system-fedora build which only
> includes a rag tag group of rare and deprecated targets doesn't
> support the virtio device required.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   tests/qemu-iotests/group | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied to my block branch:

https://git.xanclic.moe/XanClic/qemu/commits/branch/block

Re: [PATCH] tests/iotests: drop test 312 from auto group

[Kevin Wolf]

Am 05.01.2021 um 11:04 hat Alex Bennée geschrieben:
> The "auto" documentation states:
> 
>   That means they should run with every QEMU binary (also non-x86)
> 
> which is not the case as the check-system-fedora build which only
> includes a rag tag group of rare and deprecated targets doesn't
> support the virtio device required.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

I think the better solution would be to do something like in 192 so that
the test is still run at least for one binary:

if [ "$QEMU_DEFAULT_MACHINE" != "pc" ]; then
    _notrun "Requires a PC machine"
fi

Kevin

Re: [PATCH] tests/iotests: drop test 312 from auto group

[Alex Bennée]

Kevin Wolf <kwolf@redhat.com> writes:

> Am 05.01.2021 um 11:04 hat Alex Bennée geschrieben:
>> The "auto" documentation states:
>> 
>>   That means they should run with every QEMU binary (also non-x86)
>> 
>> which is not the case as the check-system-fedora build which only
>> includes a rag tag group of rare and deprecated targets doesn't
>> support the virtio device required.
>> 
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>
> I think the better solution would be to do something like in 192 so that
> the test is still run at least for one binary:
>
> if [ "$QEMU_DEFAULT_MACHINE" != "pc" ]; then
>     _notrun "Requires a PC machine"
> fi

The fix is already in so feel free to revert and fix up properly. I
wasn't quite able to follow the logic of how the qemu-system binary is
chosen it seemed a little too much to chance.

>
> Kevin


-- 
Alex Bennée