* [PATCH] tests/iotests: drop test 312 from auto group
@ 2021-01-05 10:04 Alex Bennée
2021-01-05 10:12 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Alex Bennée @ 2021-01-05 10:04 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, Alex Bennée, open list:Block layer core, Max Reitz
The "auto" documentation states:
That means they should run with every QEMU binary (also non-x86)
which is not the case as the check-system-fedora build which only
includes a rag tag group of rare and deprecated targets doesn't
support the virtio device required.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
tests/qemu-iotests/group | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
index e4fb6327ae..bc5bc324fe 100644
--- a/tests/qemu-iotests/group
+++ b/tests/qemu-iotests/group
@@ -318,4 +318,4 @@
307 rw quick export
308 rw
309 rw auto quick
-312 rw auto quick
+312 rw quick
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] tests/iotests: drop test 312 from auto group
2021-01-05 10:04 [PATCH] tests/iotests: drop test 312 from auto group Alex Bennée
@ 2021-01-05 10:12 ` Philippe Mathieu-Daudé
2021-01-05 11:51 ` Philippe Mathieu-Daudé
2021-01-05 17:37 ` Max Reitz
2021-01-12 11:25 ` Kevin Wolf
2 siblings, 1 reply; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-01-05 10:12 UTC (permalink / raw)
To: Alex Bennée, qemu-devel
Cc: Kevin Wolf, open list:Block layer core, Max Reitz
On 1/5/21 11:04 AM, Alex Bennée wrote:
> The "auto" documentation states:
>
> That means they should run with every QEMU binary (also non-x86)
>
> which is not the case as the check-system-fedora build which only
> includes a rag tag group of rare and deprecated targets doesn't
> support the virtio device required.
>
Fixes: ef9bba1484b ("quorum: Implement bdrv_co_block_status()")
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/qemu-iotests/group | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
> index e4fb6327ae..bc5bc324fe 100644
> --- a/tests/qemu-iotests/group
> +++ b/tests/qemu-iotests/group
> @@ -318,4 +318,4 @@
> 307 rw quick export
> 308 rw
> 309 rw auto quick
> -312 rw auto quick
> +312 rw quick
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tests/iotests: drop test 312 from auto group
2021-01-05 10:12 ` Philippe Mathieu-Daudé
@ 2021-01-05 11:51 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 6+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-01-05 11:51 UTC (permalink / raw)
To: Alex Bennée, qemu-devel
Cc: Kevin Wolf, open list:Block layer core, Max Reitz
On 1/5/21 11:12 AM, Philippe Mathieu-Daudé wrote:
> On 1/5/21 11:04 AM, Alex Bennée wrote:
>> The "auto" documentation states:
>>
>> That means they should run with every QEMU binary (also non-x86)
>>
>> which is not the case as the check-system-fedora build which only
>> includes a rag tag group of rare and deprecated targets doesn't
>> support the virtio device required.
>>
>
> Fixes: ef9bba1484b ("quorum: Implement bdrv_co_block_status()")
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tests/iotests: drop test 312 from auto group
2021-01-05 10:04 [PATCH] tests/iotests: drop test 312 from auto group Alex Bennée
2021-01-05 10:12 ` Philippe Mathieu-Daudé
@ 2021-01-05 17:37 ` Max Reitz
2021-01-12 11:25 ` Kevin Wolf
2 siblings, 0 replies; 6+ messages in thread
From: Max Reitz @ 2021-01-05 17:37 UTC (permalink / raw)
To: Alex Bennée, qemu-devel; +Cc: Kevin Wolf, open list:Block layer core
On 05.01.21 11:04, Alex Bennée wrote:
> The "auto" documentation states:
>
> That means they should run with every QEMU binary (also non-x86)
>
> which is not the case as the check-system-fedora build which only
> includes a rag tag group of rare and deprecated targets doesn't
> support the virtio device required.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/qemu-iotests/group | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tests/iotests: drop test 312 from auto group
2021-01-05 10:04 [PATCH] tests/iotests: drop test 312 from auto group Alex Bennée
2021-01-05 10:12 ` Philippe Mathieu-Daudé
2021-01-05 17:37 ` Max Reitz
@ 2021-01-12 11:25 ` Kevin Wolf
2021-01-12 14:16 ` Alex Bennée
2 siblings, 1 reply; 6+ messages in thread
From: Kevin Wolf @ 2021-01-12 11:25 UTC (permalink / raw)
To: Alex Bennée; +Cc: qemu-devel, open list:Block layer core, Max Reitz
Am 05.01.2021 um 11:04 hat Alex Bennée geschrieben:
> The "auto" documentation states:
>
> That means they should run with every QEMU binary (also non-x86)
>
> which is not the case as the check-system-fedora build which only
> includes a rag tag group of rare and deprecated targets doesn't
> support the virtio device required.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
I think the better solution would be to do something like in 192 so that
the test is still run at least for one binary:
if [ "$QEMU_DEFAULT_MACHINE" != "pc" ]; then
_notrun "Requires a PC machine"
fi
Kevin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tests/iotests: drop test 312 from auto group
2021-01-12 11:25 ` Kevin Wolf
@ 2021-01-12 14:16 ` Alex Bennée
0 siblings, 0 replies; 6+ messages in thread
From: Alex Bennée @ 2021-01-12 14:16 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-devel, open list:Block layer core, Max Reitz
Kevin Wolf <kwolf@redhat.com> writes:
> Am 05.01.2021 um 11:04 hat Alex Bennée geschrieben:
>> The "auto" documentation states:
>>
>> That means they should run with every QEMU binary (also non-x86)
>>
>> which is not the case as the check-system-fedora build which only
>> includes a rag tag group of rare and deprecated targets doesn't
>> support the virtio device required.
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>
> I think the better solution would be to do something like in 192 so that
> the test is still run at least for one binary:
>
> if [ "$QEMU_DEFAULT_MACHINE" != "pc" ]; then
> _notrun "Requires a PC machine"
> fi
The fix is already in so feel free to revert and fix up properly. I
wasn't quite able to follow the logic of how the qemu-system binary is
chosen it seemed a little too much to chance.
>
> Kevin
--
Alex Bennée
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-12 14:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-05 10:04 [PATCH] tests/iotests: drop test 312 from auto group Alex Bennée
2021-01-05 10:12 ` Philippe Mathieu-Daudé
2021-01-05 11:51 ` Philippe Mathieu-Daudé
2021-01-05 17:37 ` Max Reitz
2021-01-12 11:25 ` Kevin Wolf
2021-01-12 14:16 ` Alex Bennée
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.