All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Yipeng Zou <zouyipeng@huawei.com>, Marc Zyngier <maz@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, hewenliang4@huawei.com,
	chris.zjh@huawei.com, liaochang1@huawei.com
Subject: Re: [RFC PATCH] irqchip/gic-v3: wait irq done to set affinity
Date: Tue, 17 Jan 2023 10:38:41 +0100	[thread overview]
Message-ID: <87tu0plcv2.ffs@tglx> (raw)
In-Reply-To: <89553b60-c5dc-76ad-67a4-594858ebedee@huawei.com>

On Mon, Jan 09 2023 at 20:26, Yipeng Zou wrote:
> 在 2023/1/6 19:55, Marc Zyngier 写道:
> index 973ede0197e3..fad08ccb7fd9 100644
> --- a/drivers/irqchip/irq-gic-v3-its.c
> +++ b/drivers/irqchip/irq-gic-v3-its.c
> @@ -1667,6 +1667,9 @@ static int its_set_affinity(struct irq_data *d, 
> const struct cpumask *mask_val,
>
>          /* don't set the affinity when the target cpu is same as 
> current one */
>          if (cpu != prev_cpu) {
> +
> +               // wait irq done on all cpus
> +

There is no way to wait here. The caller holds the interrupt descriptor
lock.

If this is really an issue for LPI, then the only way to deal with that
is CONFIG_GENERIC_PENDING_IRQ, which delays the affinity change to
interrupt context

Why on earth must all the known hardware mistakes be repeated over and
over?

Thanks,

        tglx

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: Yipeng Zou <zouyipeng@huawei.com>, Marc Zyngier <maz@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, hewenliang4@huawei.com,
	chris.zjh@huawei.com, liaochang1@huawei.com
Subject: Re: [RFC PATCH] irqchip/gic-v3: wait irq done to set affinity
Date: Tue, 17 Jan 2023 10:38:41 +0100	[thread overview]
Message-ID: <87tu0plcv2.ffs@tglx> (raw)
In-Reply-To: <89553b60-c5dc-76ad-67a4-594858ebedee@huawei.com>

On Mon, Jan 09 2023 at 20:26, Yipeng Zou wrote:
> 在 2023/1/6 19:55, Marc Zyngier 写道:
> index 973ede0197e3..fad08ccb7fd9 100644
> --- a/drivers/irqchip/irq-gic-v3-its.c
> +++ b/drivers/irqchip/irq-gic-v3-its.c
> @@ -1667,6 +1667,9 @@ static int its_set_affinity(struct irq_data *d, 
> const struct cpumask *mask_val,
>
>          /* don't set the affinity when the target cpu is same as 
> current one */
>          if (cpu != prev_cpu) {
> +
> +               // wait irq done on all cpus
> +

There is no way to wait here. The caller holds the interrupt descriptor
lock.

If this is really an issue for LPI, then the only way to deal with that
is CONFIG_GENERIC_PENDING_IRQ, which delays the affinity change to
interrupt context

Why on earth must all the known hardware mistakes be repeated over and
over?

Thanks,

        tglx

  reply	other threads:[~2023-01-17  9:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-06  8:21 [RFC PATCH] irqchip/gic-v3: wait irq done to set affinity Yipeng Zou
2023-01-06  8:21 ` Yipeng Zou
2023-01-06 11:55 ` Marc Zyngier
2023-01-06 11:55   ` Marc Zyngier
2023-01-09 12:26   ` Yipeng Zou
2023-01-09 12:26     ` Yipeng Zou
2023-01-17  9:38     ` Thomas Gleixner [this message]
2023-01-17  9:38       ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tu0plcv2.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=chris.zjh@huawei.com \
    --cc=hewenliang4@huawei.com \
    --cc=liaochang1@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=zouyipeng@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.