From: Markus Armbruster <armbru@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: marcandre.lureau@gmail.com, qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH v6 00/12] monitor: Optionally run handlers in coroutines
Date: Wed, 05 Aug 2020 13:34:12 +0200 [thread overview]
Message-ID: <87y2mtpbrf.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <87d046d5k1.fsf@dusky.pond.sub.org> (Markus Armbruster's message of "Tue, 04 Aug 2020 13:16:46 +0200")
Markus Armbruster <armbru@redhat.com> writes:
> I let this series slide to get my Error API rework done, along with much
> else. My sincere apologies!
>
> Unsurprisingly, it needs a rebase now. I suggest to let me review it as
> is first.
I'm done with v6. Summary:
* A few trivial things to correct here and there.
* A few ideas to improve things in relatively minor ways.
* PATCH 03 looks "why bother" to me until PATCH 09 makes me suspect you
did the former to enable the latter. If you had captured that in your
commit message back then, like you did for the similar PATCH 05, I
wouldn't be scratching my head now :)
* I dislike PATCH 06, and would like to explore an alternative idea.
* PATCH 08 makes hairy monitor code even hairier, but I don't have
better ideas.
* I don't feel comfortable as a sole reviewer of the AIO magic in PATCH
10-12. Let's ask Stefan for an eye-over.
I'd like to proceed as follows. You rebase, and address "easy" review
comments (you decide what's easy). Post as v7, cc'ing Stefan for the
AIO magic and David Gilbert for HMP. While they review (hopefully), I
explore a replacement for PATCH 06. And then we touch bases and decide
how to get this thing wrapped.
Okay?
next prev parent reply other threads:[~2020-08-05 11:35 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 15:37 [PATCH v6 00/12] monitor: Optionally run handlers in coroutines Kevin Wolf
2020-05-28 15:37 ` [PATCH v6 01/12] monitor: Add Monitor parameter to monitor_set_cpu() Kevin Wolf
2020-05-28 18:24 ` Eric Blake
2020-08-04 11:19 ` Markus Armbruster
2020-05-28 15:37 ` [PATCH v6 02/12] monitor: Use getter/setter functions for cur_mon Kevin Wolf
2020-05-28 18:31 ` Eric Blake
2020-06-02 13:36 ` Kevin Wolf
2020-05-28 18:36 ` Eric Blake
2020-08-04 12:46 ` Markus Armbruster
2020-08-04 16:16 ` Kevin Wolf
2020-08-05 7:19 ` Markus Armbruster
2020-08-05 8:25 ` Kevin Wolf
2020-08-05 4:45 ` Markus Armbruster
2020-05-28 15:37 ` [PATCH v6 03/12] hmp: Set cur_mon only in handle_hmp_command() Kevin Wolf
2020-05-28 18:37 ` Eric Blake
2020-08-04 12:54 ` Markus Armbruster
2020-05-28 15:37 ` [PATCH v6 04/12] qmp: Assert that no other monitor is active Kevin Wolf
2020-05-28 18:38 ` Eric Blake
2020-08-04 12:57 ` Markus Armbruster
2020-05-28 15:37 ` [PATCH v6 05/12] qmp: Call monitor_set_cur() only in qmp_dispatch() Kevin Wolf
2020-05-28 18:42 ` Eric Blake
2020-08-04 13:17 ` Markus Armbruster
2020-05-28 15:37 ` [PATCH v6 06/12] monitor: Make current monitor a per-coroutine property Kevin Wolf
2020-05-28 18:44 ` Eric Blake
2020-08-04 13:50 ` Markus Armbruster
2020-08-04 16:06 ` Kevin Wolf
2020-08-05 7:28 ` Markus Armbruster
2020-08-05 8:32 ` Kevin Wolf
2020-08-07 13:09 ` Ways to do per-coroutine properties (was: [PATCH v6 06/12] monitor: Make current monitor a per-coroutine property) Markus Armbruster
2020-08-07 13:27 ` [PATCH] Simple & stupid coroutine-aware monitor_cur() Markus Armbruster
2020-08-10 12:19 ` Kevin Wolf
2020-08-26 12:37 ` Markus Armbruster
2020-08-07 13:29 ` [PATCH] Coroutine-aware monitor_cur() with coroutine-specific data Markus Armbruster
2020-08-10 12:58 ` Kevin Wolf
2020-08-26 12:40 ` Markus Armbruster
2020-08-26 13:49 ` Kevin Wolf
2020-08-04 16:14 ` [PATCH v6 06/12] monitor: Make current monitor a per-coroutine property Daniel P. Berrangé
2020-05-28 15:37 ` [PATCH v6 07/12] qapi: Add a 'coroutine' flag for commands Kevin Wolf
2020-05-28 15:37 ` [PATCH v6 08/12] qmp: Move dispatcher to a coroutine Kevin Wolf
2020-08-05 10:03 ` Markus Armbruster
2020-05-28 15:37 ` [PATCH v6 09/12] hmp: Add support for coroutine command handlers Kevin Wolf
2020-08-05 10:33 ` Markus Armbruster
2020-05-28 15:37 ` [PATCH v6 10/12] util/async: Add aio_co_reschedule_self() Kevin Wolf
2020-05-28 15:37 ` [PATCH v6 11/12] block: Add bdrv_co_move_to_aio_context() Kevin Wolf
2020-05-28 15:37 ` [PATCH v6 12/12] block: Convert 'block_resize' to coroutine Kevin Wolf
2020-08-04 11:16 ` [PATCH v6 00/12] monitor: Optionally run handlers in coroutines Markus Armbruster
2020-08-05 11:34 ` Markus Armbruster [this message]
2020-09-03 10:49 ` Markus Armbruster
2020-09-03 12:45 ` Kevin Wolf
2020-09-03 14:17 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2mtpbrf.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.