From: "Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com> To: Marek Szyprowski <m.szyprowski@samsung.com>, Paul Cercueil <paul@crapouillou.net> Cc: Krzysztof Kozlowski <krzk@kernel.org>, Kukjin Kim <kgene@kernel.org>, Rob Herring <robh+dt@kernel.org>, mark.rutland@arm.com, Stenkin Evgeniy <stenkinevgeniy@gmail.com>, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ARM: DTS: Add devicetree file for the Galaxy S2 Date: Tue, 31 Mar 2020 21:50:19 +0200 [thread overview] Message-ID: <8a77ca985214cb0058e4defe4dcaa27a79eafacc.camel@gmail.com> (raw) In-Reply-To: <da888000-52b6-b0c6-76ac-8fc535d07a5d@samsung.com> On Tue, 2020-03-31 at 21:29 +0200, Marek Szyprowski wrote: > Hi > > On 2020-03-31 17:29, Paweł Chmiel wrote: > > On Tue, 2020-03-31 at 15:55 +0200, Marek Szyprowski wrote: > > > Hi Paul, > > > > > > On 2020-03-31 15:09, Paul Cercueil wrote: > > > > Cc: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> > > > > > > > > Hi Marek, > > > > > > > > Le mar. 31 mars 2020 à 7:36, Marek Szyprowski > > > > <m.szyprowski@samsung.com> a écrit : > > > > > Hi Paul, > > > > > > > > > > On 2020-03-18 15:25, Paul Cercueil wrote: > > > > > > > > + }; > > > > > > > > + > > > > > > > > + tsp_reg: regulator-1 { > > > > > > > > + compatible = "regulator-fixed"; > > > > > > > > + regulator-name = "TSP_FIXED_VOLTAGES"; > > > > > > > > + regulator-min-microvolt = <3300000>; > > > > > > > > + regulator-max-microvolt = <3300000>; > > > > > > > > + gpio = <&gpl0 3 GPIO_ACTIVE_HIGH>; > > > > > > > > + startup-delay-us = <70000>; > > > > > > > > + enable-active-high; > > > > > > > > + regulator-boot-on; > > > > > > > > + regulator-always-on; > > > > > > > always-on and boot-on should not be needed. You have a consumer > > > > > > > for this > > > > > > > regulator. > > > > > > About this: the touchscreen driver does not use a regulator, so I > > > > > > believe that's why these properties were here. > > > > > > > > > > > > I sent patches upstream to address the issue: > > > > > > https://protect2.fireeye.com/url?k=e8aedc29-b53072b3-e8af5766-0cc47a336fae-759579fd576d8382&u=https://lkml.org/lkml/2020/3/15/94 > > > > > > > > > > > > > > > > > > I believe this means I cannot merge the i9100 devicetree until it is > > > > > > acked. > > > > > One more information - similar change has been already posted, but it > > > > > looks it got lost then: https://patchwork.kernel.org/patch/10550903/ > > > > I was aware of this patch, but didn't know it was sent upstream. > > > > > > > > This other patch uses two regulators, vdd/avdd but doesn't give any > > > > reason why. > > > > > > > I've checked the UniversalC210 schematic, which uses the same > > > touchscreen chip. There are 2 supplies to the touchscreen chip: 2.8V VDD > > > and 3.3V AVDD. Both are enabled by the same GPIO pin though. There is > > > however no reset GPIO pin there. > > Hi > > Don't remember now how it worked on Galaxy S1, but it looks like it has > > the same setup - two regulators enabled by one GPIO pin. > > It is quite common for the regulators to share the enable GPIO line, so > this is not an issue. Regulator framework supports such configuration > for ages. I'm curious about the reset GPIO line, which were made > mandatory for the regulators control in your patch. I didn't find it on > any schematic of the devices with this touch screen, but I don't have a > schematic of the Galaxy S1. IMHO the reset signal is simply derived from > the supply regulators with some simple circuit, but I don't have > schematic of that part. Hi Regarding this change - it was suggested during review of v1 version of those patches. It's first reply here https://patchwork.kernel.org/patch/10524007/ > > Best regards
WARNING: multiple messages have this Message-ID (diff)
From: "Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com> To: Marek Szyprowski <m.szyprowski@samsung.com>, Paul Cercueil <paul@crapouillou.net> Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, Stenkin Evgeniy <stenkinevgeniy@gmail.com>, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski <krzk@kernel.org>, Rob Herring <robh+dt@kernel.org>, Kukjin Kim <kgene@kernel.org>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] ARM: DTS: Add devicetree file for the Galaxy S2 Date: Tue, 31 Mar 2020 21:50:19 +0200 [thread overview] Message-ID: <8a77ca985214cb0058e4defe4dcaa27a79eafacc.camel@gmail.com> (raw) In-Reply-To: <da888000-52b6-b0c6-76ac-8fc535d07a5d@samsung.com> On Tue, 2020-03-31 at 21:29 +0200, Marek Szyprowski wrote: > Hi > > On 2020-03-31 17:29, Paweł Chmiel wrote: > > On Tue, 2020-03-31 at 15:55 +0200, Marek Szyprowski wrote: > > > Hi Paul, > > > > > > On 2020-03-31 15:09, Paul Cercueil wrote: > > > > Cc: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> > > > > > > > > Hi Marek, > > > > > > > > Le mar. 31 mars 2020 à 7:36, Marek Szyprowski > > > > <m.szyprowski@samsung.com> a écrit : > > > > > Hi Paul, > > > > > > > > > > On 2020-03-18 15:25, Paul Cercueil wrote: > > > > > > > > + }; > > > > > > > > + > > > > > > > > + tsp_reg: regulator-1 { > > > > > > > > + compatible = "regulator-fixed"; > > > > > > > > + regulator-name = "TSP_FIXED_VOLTAGES"; > > > > > > > > + regulator-min-microvolt = <3300000>; > > > > > > > > + regulator-max-microvolt = <3300000>; > > > > > > > > + gpio = <&gpl0 3 GPIO_ACTIVE_HIGH>; > > > > > > > > + startup-delay-us = <70000>; > > > > > > > > + enable-active-high; > > > > > > > > + regulator-boot-on; > > > > > > > > + regulator-always-on; > > > > > > > always-on and boot-on should not be needed. You have a consumer > > > > > > > for this > > > > > > > regulator. > > > > > > About this: the touchscreen driver does not use a regulator, so I > > > > > > believe that's why these properties were here. > > > > > > > > > > > > I sent patches upstream to address the issue: > > > > > > https://protect2.fireeye.com/url?k=e8aedc29-b53072b3-e8af5766-0cc47a336fae-759579fd576d8382&u=https://lkml.org/lkml/2020/3/15/94 > > > > > > > > > > > > > > > > > > I believe this means I cannot merge the i9100 devicetree until it is > > > > > > acked. > > > > > One more information - similar change has been already posted, but it > > > > > looks it got lost then: https://patchwork.kernel.org/patch/10550903/ > > > > I was aware of this patch, but didn't know it was sent upstream. > > > > > > > > This other patch uses two regulators, vdd/avdd but doesn't give any > > > > reason why. > > > > > > > I've checked the UniversalC210 schematic, which uses the same > > > touchscreen chip. There are 2 supplies to the touchscreen chip: 2.8V VDD > > > and 3.3V AVDD. Both are enabled by the same GPIO pin though. There is > > > however no reset GPIO pin there. > > Hi > > Don't remember now how it worked on Galaxy S1, but it looks like it has > > the same setup - two regulators enabled by one GPIO pin. > > It is quite common for the regulators to share the enable GPIO line, so > this is not an issue. Regulator framework supports such configuration > for ages. I'm curious about the reset GPIO line, which were made > mandatory for the regulators control in your patch. I didn't find it on > any schematic of the devices with this touch screen, but I don't have a > schematic of the Galaxy S1. IMHO the reset signal is simply derived from > the supply regulators with some simple circuit, but I don't have > schematic of that part. Hi Regarding this change - it was suggested during review of v1 version of those patches. It's first reply here https://patchwork.kernel.org/patch/10524007/ > > Best regards _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-31 19:50 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-12 15:34 [PATCH 1/2] dt-bindings: arm/samsung: Add compatible string for the Galaxy S2 Paul Cercueil 2020-03-12 15:34 ` Paul Cercueil 2020-03-12 15:34 ` [PATCH 2/2] ARM: DTS: Add devicetree file " Paul Cercueil 2020-03-12 15:34 ` Paul Cercueil 2020-03-13 8:03 ` Marek Szyprowski 2020-03-13 8:03 ` Marek Szyprowski 2020-03-13 14:29 ` Paul Cercueil 2020-03-13 14:29 ` Paul Cercueil 2020-03-13 14:36 ` Paul Cercueil 2020-03-13 14:36 ` Paul Cercueil 2020-03-13 9:00 ` Krzysztof Kozlowski 2020-03-13 9:00 ` Krzysztof Kozlowski 2020-03-13 14:33 ` Paul Cercueil 2020-03-13 14:33 ` Paul Cercueil 2020-03-13 15:24 ` Marek Szyprowski 2020-03-13 15:24 ` Marek Szyprowski 2020-03-18 14:25 ` Paul Cercueil [not found] ` <20200318142543.C167520772@mail.kernel.org> 2020-03-18 15:23 ` Krzysztof Kozlowski 2020-03-18 15:23 ` Krzysztof Kozlowski [not found] ` <CGME20200318142549eucas1p1793027850923ebad20b4691cba676671@eucas1p1.samsung.com> [not found] ` <D6.31.03891.A6F227E5@epmailinsp8.samsung.com> 2020-03-31 5:36 ` Marek Szyprowski 2020-03-31 5:36 ` Marek Szyprowski 2020-03-31 13:09 ` Paul Cercueil 2020-03-31 13:09 ` Paul Cercueil 2020-03-31 13:55 ` Marek Szyprowski 2020-03-31 13:55 ` Marek Szyprowski 2020-03-31 15:29 ` Paweł Chmiel 2020-03-31 15:29 ` Paweł Chmiel 2020-03-31 19:29 ` Marek Szyprowski 2020-03-31 19:29 ` Marek Szyprowski 2020-03-31 19:50 ` Paweł Chmiel [this message] 2020-03-31 19:50 ` Paweł Chmiel 2020-04-01 10:42 ` Marek Szyprowski 2020-04-01 10:42 ` Marek Szyprowski 2020-03-13 8:29 ` [PATCH 1/2] dt-bindings: arm/samsung: Add compatible string " Krzysztof Kozlowski 2020-03-13 8:29 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8a77ca985214cb0058e4defe4dcaa27a79eafacc.camel@gmail.com \ --to=pawel.mikolaj.chmiel@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=kgene@kernel.org \ --cc=krzk@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=m.szyprowski@samsung.com \ --cc=mark.rutland@arm.com \ --cc=paul@crapouillou.net \ --cc=robh+dt@kernel.org \ --cc=stenkinevgeniy@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.