From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Paul Cercueil <paul@crapouillou.net>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: Kukjin Kim <kgene@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Stenkin Evgeniy <stenkinevgeniy@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: DTS: Add devicetree file for the Galaxy S2
Date: Fri, 13 Mar 2020 16:24:12 +0100 [thread overview]
Message-ID: <fbc3b48c-9f99-5ce2-0a7b-3d879588ab4c@samsung.com> (raw)
In-Reply-To: <1584110014.3.1@crapouillou.net>
Hi Paul,
On 13.03.2020 15:33, Paul Cercueil wrote:
> Hi Krzysztof,
>
>
> Le ven., mars 13, 2020 at 10:00, Krzysztof Kozlowski <krzk@kernel.org>
> a écrit :
>> On Thu, Mar 12, 2020 at 04:34:11PM +0100, Paul Cercueil wrote:
>>> From: Stenkin Evgeniy <stenkinevgeniy@gmail.com>
>>>
>>> Add devicetree file for the Exynos 4210 based Galaxy S2 (i9100
>>> version).
> [...]
> +
>>> +
>>> + memory@40000000 {
>>> + device_type = "memory";
>>> + reg = <0x40000000 0x40000000>;
>>> + };
>>> +
>>
>> You do not have a chosen node, at least for stdout serial selection.
>> Probably you should have one... bootargs I guess could come from
>> bootloader.
>
> Problem is, I have no idea which UART is available via the USB jig :)
See exynos4210-trats.dts and exynos4210-universal_c210.dts, they are
similar to i9100 and share a lots. They all use serial2 for debug UART
via USB jig.
>>> + vemmc_reg: regulator-0 {
>>> + compatible = "regulator-fixed";
>>> + regulator-name = "VMEM_VDD_2.8V";
>>> + regulator-min-microvolt = <2800000>;
>>> + regulator-max-microvolt = <2800000>;
>>> + gpio = <&gpk0 2 GPIO_ACTIVE_HIGH>;
>>> + enable-active-high;
>>
>> This looks like a stub/fake regulator. Probably it shoould be replaced
>> with proper regulator coming from PMIC (few seems to be missing there).
>>
>> I don't have the schematics so I cannot judge... I see Trats has the
>> same.
>>
>> Marek, mayybe you know, is it really a separate regulator?
Trats has the same regulator and according to the schematic it is
supplied from VBAT and controlled via eMMC_EN GPIO pin.
> > [...]
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
WARNING: multiple messages have this Message-ID (diff)
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Paul Cercueil <paul@crapouillou.net>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Stenkin Evgeniy <stenkinevgeniy@gmail.com>,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>, Kukjin Kim <kgene@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: DTS: Add devicetree file for the Galaxy S2
Date: Fri, 13 Mar 2020 16:24:12 +0100 [thread overview]
Message-ID: <fbc3b48c-9f99-5ce2-0a7b-3d879588ab4c@samsung.com> (raw)
In-Reply-To: <1584110014.3.1@crapouillou.net>
Hi Paul,
On 13.03.2020 15:33, Paul Cercueil wrote:
> Hi Krzysztof,
>
>
> Le ven., mars 13, 2020 at 10:00, Krzysztof Kozlowski <krzk@kernel.org>
> a écrit :
>> On Thu, Mar 12, 2020 at 04:34:11PM +0100, Paul Cercueil wrote:
>>> From: Stenkin Evgeniy <stenkinevgeniy@gmail.com>
>>>
>>> Add devicetree file for the Exynos 4210 based Galaxy S2 (i9100
>>> version).
> [...]
> +
>>> +
>>> + memory@40000000 {
>>> + device_type = "memory";
>>> + reg = <0x40000000 0x40000000>;
>>> + };
>>> +
>>
>> You do not have a chosen node, at least for stdout serial selection.
>> Probably you should have one... bootargs I guess could come from
>> bootloader.
>
> Problem is, I have no idea which UART is available via the USB jig :)
See exynos4210-trats.dts and exynos4210-universal_c210.dts, they are
similar to i9100 and share a lots. They all use serial2 for debug UART
via USB jig.
>>> + vemmc_reg: regulator-0 {
>>> + compatible = "regulator-fixed";
>>> + regulator-name = "VMEM_VDD_2.8V";
>>> + regulator-min-microvolt = <2800000>;
>>> + regulator-max-microvolt = <2800000>;
>>> + gpio = <&gpk0 2 GPIO_ACTIVE_HIGH>;
>>> + enable-active-high;
>>
>> This looks like a stub/fake regulator. Probably it shoould be replaced
>> with proper regulator coming from PMIC (few seems to be missing there).
>>
>> I don't have the schematics so I cannot judge... I see Trats has the
>> same.
>>
>> Marek, mayybe you know, is it really a separate regulator?
Trats has the same regulator and according to the schematic it is
supplied from VBAT and controlled via eMMC_EN GPIO pin.
> > [...]
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-13 15:24 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 15:34 [PATCH 1/2] dt-bindings: arm/samsung: Add compatible string for the Galaxy S2 Paul Cercueil
2020-03-12 15:34 ` Paul Cercueil
2020-03-12 15:34 ` [PATCH 2/2] ARM: DTS: Add devicetree file " Paul Cercueil
2020-03-12 15:34 ` Paul Cercueil
2020-03-13 8:03 ` Marek Szyprowski
2020-03-13 8:03 ` Marek Szyprowski
2020-03-13 14:29 ` Paul Cercueil
2020-03-13 14:29 ` Paul Cercueil
2020-03-13 14:36 ` Paul Cercueil
2020-03-13 14:36 ` Paul Cercueil
2020-03-13 9:00 ` Krzysztof Kozlowski
2020-03-13 9:00 ` Krzysztof Kozlowski
2020-03-13 14:33 ` Paul Cercueil
2020-03-13 14:33 ` Paul Cercueil
2020-03-13 15:24 ` Marek Szyprowski [this message]
2020-03-13 15:24 ` Marek Szyprowski
2020-03-18 14:25 ` Paul Cercueil
[not found] ` <20200318142543.C167520772@mail.kernel.org>
2020-03-18 15:23 ` Krzysztof Kozlowski
2020-03-18 15:23 ` Krzysztof Kozlowski
[not found] ` <CGME20200318142549eucas1p1793027850923ebad20b4691cba676671@eucas1p1.samsung.com>
[not found] ` <D6.31.03891.A6F227E5@epmailinsp8.samsung.com>
2020-03-31 5:36 ` Marek Szyprowski
2020-03-31 5:36 ` Marek Szyprowski
2020-03-31 13:09 ` Paul Cercueil
2020-03-31 13:09 ` Paul Cercueil
2020-03-31 13:55 ` Marek Szyprowski
2020-03-31 13:55 ` Marek Szyprowski
2020-03-31 15:29 ` Paweł Chmiel
2020-03-31 15:29 ` Paweł Chmiel
2020-03-31 19:29 ` Marek Szyprowski
2020-03-31 19:29 ` Marek Szyprowski
2020-03-31 19:50 ` Paweł Chmiel
2020-03-31 19:50 ` Paweł Chmiel
2020-04-01 10:42 ` Marek Szyprowski
2020-04-01 10:42 ` Marek Szyprowski
2020-03-13 8:29 ` [PATCH 1/2] dt-bindings: arm/samsung: Add compatible string " Krzysztof Kozlowski
2020-03-13 8:29 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbc3b48c-9f99-5ce2-0a7b-3d879588ab4c@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
--cc=stenkinevgeniy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.