From: Boris Ostrovsky <boris.ostrovsky@oracle.com> To: Juergen Gross <jgross@suse.com>, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH 1/3] xen: clean up xenbus internal headers Date: Fri, 6 Jan 2017 15:52:32 -0500 [thread overview] Message-ID: <8c36bfb8-066f-1373-9558-54c2a1fb28d0@oracle.com> (raw) In-Reply-To: <20170106150544.10836-2-jgross@suse.com> On 01/06/2017 10:05 AM, Juergen Gross wrote: > The xenbus driver has an awful mixture of internal and global visible > headers: some of the internal used only stuff is defined in the > global header include/xen/xenbus.h while some stuff defined in internal > headers is used by other drivers, too. > > Clean this up by moving the external used symbols to > include/xen/xenbus.h and the symbols used internal only to a new I think s/external/externally/ s/internal/internally/ > header drivers/xen/xenbus/xenbus.h ... and remove xenbus_comms.h > > Signed-off-by: Juergen Gross <jgross@suse.com> > --- > drivers/xen/xenbus/{xenbus_probe.h => xenbus.h} | 64 ++++++++++++++----------- > drivers/xen/xenbus/xenbus_client.c | 2 +- > drivers/xen/xenbus/xenbus_comms.c | 2 +- > drivers/xen/xenbus/xenbus_comms.h | 51 -------------------- > drivers/xen/xenbus/xenbus_dev_backend.c | 2 +- > drivers/xen/xenbus/xenbus_dev_frontend.c | 4 +- > drivers/xen/xenbus/xenbus_probe.c | 3 +- > drivers/xen/xenbus/xenbus_probe_backend.c | 3 +- > drivers/xen/xenbus/xenbus_probe_frontend.c | 3 +- > drivers/xen/xenbus/xenbus_xs.c | 3 +- > drivers/xen/xenfs/super.c | 2 +- > drivers/xen/xenfs/xenstored.c | 2 +- > include/xen/xenbus.h | 12 ++--- > 13 files changed, 52 insertions(+), 101 deletions(-) > rename drivers/xen/xenbus/{xenbus_probe.h => xenbus.h} (58%) > delete mode 100644 drivers/xen/xenbus/xenbus_comms.h > > diff --git a/drivers/xen/xenbus/xenbus_probe.h b/drivers/xen/xenbus/xenbus.h > similarity index 58% > rename from drivers/xen/xenbus/xenbus_probe.h > rename to drivers/xen/xenbus/xenbus.h > index c9ec7ca..6a80c1e 100644 > --- a/drivers/xen/xenbus/xenbus_probe.h > +++ b/drivers/xen/xenbus/xenbus.h > @@ -1,10 +1,7 @@ > -/****************************************************************************** > - * xenbus_probe.h > - * > - * Talks to Xen Store to figure out what devices we have. > +/* > + * Private include for xenbus communications. > * > * Copyright (C) 2005 Rusty Russell, IBM Corporation > - * Copyright (C) 2005 XenSource Ltd. Why is this? -boris
WARNING: multiple messages have this Message-ID (diff)
From: Boris Ostrovsky <boris.ostrovsky@oracle.com> To: Juergen Gross <jgross@suse.com>, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH 1/3] xen: clean up xenbus internal headers Date: Fri, 6 Jan 2017 15:52:32 -0500 [thread overview] Message-ID: <8c36bfb8-066f-1373-9558-54c2a1fb28d0@oracle.com> (raw) In-Reply-To: <20170106150544.10836-2-jgross@suse.com> On 01/06/2017 10:05 AM, Juergen Gross wrote: > The xenbus driver has an awful mixture of internal and global visible > headers: some of the internal used only stuff is defined in the > global header include/xen/xenbus.h while some stuff defined in internal > headers is used by other drivers, too. > > Clean this up by moving the external used symbols to > include/xen/xenbus.h and the symbols used internal only to a new I think s/external/externally/ s/internal/internally/ > header drivers/xen/xenbus/xenbus.h ... and remove xenbus_comms.h > > Signed-off-by: Juergen Gross <jgross@suse.com> > --- > drivers/xen/xenbus/{xenbus_probe.h => xenbus.h} | 64 ++++++++++++++----------- > drivers/xen/xenbus/xenbus_client.c | 2 +- > drivers/xen/xenbus/xenbus_comms.c | 2 +- > drivers/xen/xenbus/xenbus_comms.h | 51 -------------------- > drivers/xen/xenbus/xenbus_dev_backend.c | 2 +- > drivers/xen/xenbus/xenbus_dev_frontend.c | 4 +- > drivers/xen/xenbus/xenbus_probe.c | 3 +- > drivers/xen/xenbus/xenbus_probe_backend.c | 3 +- > drivers/xen/xenbus/xenbus_probe_frontend.c | 3 +- > drivers/xen/xenbus/xenbus_xs.c | 3 +- > drivers/xen/xenfs/super.c | 2 +- > drivers/xen/xenfs/xenstored.c | 2 +- > include/xen/xenbus.h | 12 ++--- > 13 files changed, 52 insertions(+), 101 deletions(-) > rename drivers/xen/xenbus/{xenbus_probe.h => xenbus.h} (58%) > delete mode 100644 drivers/xen/xenbus/xenbus_comms.h > > diff --git a/drivers/xen/xenbus/xenbus_probe.h b/drivers/xen/xenbus/xenbus.h > similarity index 58% > rename from drivers/xen/xenbus/xenbus_probe.h > rename to drivers/xen/xenbus/xenbus.h > index c9ec7ca..6a80c1e 100644 > --- a/drivers/xen/xenbus/xenbus_probe.h > +++ b/drivers/xen/xenbus/xenbus.h > @@ -1,10 +1,7 @@ > -/****************************************************************************** > - * xenbus_probe.h > - * > - * Talks to Xen Store to figure out what devices we have. > +/* > + * Private include for xenbus communications. > * > * Copyright (C) 2005 Rusty Russell, IBM Corporation > - * Copyright (C) 2005 XenSource Ltd. Why is this? -boris _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-01-06 20:53 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-01-06 15:05 [PATCH 0/3] xen: optimize xenbus performance Juergen Gross 2017-01-06 15:05 ` Juergen Gross 2017-01-06 15:05 ` [PATCH 1/3] xen: clean up xenbus internal headers Juergen Gross 2017-01-06 15:05 ` Juergen Gross 2017-01-06 20:52 ` Boris Ostrovsky [this message] 2017-01-06 20:52 ` Boris Ostrovsky 2017-01-09 7:07 ` Juergen Gross 2017-01-09 7:07 ` Juergen Gross 2017-01-06 15:05 ` [PATCH 2/3] xen: modify xenstore watch event interface Juergen Gross 2017-01-06 15:05 ` Juergen Gross 2017-01-06 15:38 ` Paul Durrant 2017-01-06 15:38 ` Paul Durrant 2017-01-06 16:29 ` Wei Liu 2017-01-06 16:29 ` Wei Liu 2017-01-06 16:37 ` Roger Pau Monné 2017-01-06 16:37 ` Roger Pau Monné 2017-01-06 21:57 ` Boris Ostrovsky 2017-01-06 21:57 ` Boris Ostrovsky 2017-01-09 7:12 ` Juergen Gross 2017-01-09 7:12 ` Juergen Gross 2017-01-06 15:05 ` [PATCH 3/3] xen: optimize xenbus driver for multiple concurrent xenstore accesses Juergen Gross 2017-01-06 15:05 ` Juergen Gross 2017-01-09 21:17 ` Boris Ostrovsky 2017-01-10 6:18 ` Juergen Gross 2017-01-10 6:18 ` Juergen Gross 2017-01-10 16:36 ` Boris Ostrovsky 2017-01-10 16:38 ` Boris Ostrovsky 2017-01-10 16:38 ` Boris Ostrovsky 2017-01-10 16:46 ` Juergen Gross 2017-01-10 16:46 ` Juergen Gross 2017-01-10 16:36 ` Boris Ostrovsky 2017-01-09 21:17 ` Boris Ostrovsky 2017-01-10 19:17 ` Boris Ostrovsky 2017-01-10 19:17 ` Boris Ostrovsky 2017-01-10 22:56 ` Boris Ostrovsky 2017-01-10 22:56 ` Boris Ostrovsky 2017-01-11 5:26 ` Juergen Gross 2017-01-11 5:26 ` Juergen Gross 2017-01-11 15:29 ` Boris Ostrovsky 2017-01-11 15:29 ` Boris Ostrovsky 2017-01-11 16:50 ` Juergen Gross 2017-01-11 16:50 ` Juergen Gross
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8c36bfb8-066f-1373-9558-54c2a1fb28d0@oracle.com \ --to=boris.ostrovsky@oracle.com \ --cc=jgross@suse.com \ --cc=linux-kernel@vger.kernel.org \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.