* [PATCH v2,0/2] Add mt8186 dpi compatiable
@ 2022-03-31 11:58 ` xinlei.lee
0 siblings, 0 replies; 42+ messages in thread
From: xinlei.lee @ 2022-03-31 11:58 UTC (permalink / raw)
To: chunkuang.hu, p.zabel, airlied, daniel, robh+dt, matthias.bgg
Cc: devicetree, jitao.shi, Xinlei Lee, linux-kernel, dri-devel,
Project_Global_Chrome_Upstream_Group, linux-mediatek,
rex-bc.chen, linux-arm-kernel
From: Xinlei Lee <xinlei.lee@mediatek.com>
Base on Linux-next
change since v1:
1. Put switch dpi Topckgen MUX action in mt8186.dtsi.
Xinlei Lee (2):
dt-bindings: display: mediatek: dpi: Add compatible for MediaTek
MT8186
drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
.../bindings/display/mediatek/mediatek,dpi.yaml | 1 +
drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
2 files changed, 12 insertions(+)
--
2.18.0
^ permalink raw reply [flat|nested] 42+ messages in thread
* [PATCH v2,0/2] Add mt8186 dpi compatiable
@ 2022-03-31 11:58 ` xinlei.lee
0 siblings, 0 replies; 42+ messages in thread
From: xinlei.lee @ 2022-03-31 11:58 UTC (permalink / raw)
To: chunkuang.hu, p.zabel, airlied, daniel, robh+dt, matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
rex-bc.chen, jitao.shi, Xinlei Lee
From: Xinlei Lee <xinlei.lee@mediatek.com>
Base on Linux-next
change since v1:
1. Put switch dpi Topckgen MUX action in mt8186.dtsi.
Xinlei Lee (2):
dt-bindings: display: mediatek: dpi: Add compatible for MediaTek
MT8186
drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
.../bindings/display/mediatek/mediatek,dpi.yaml | 1 +
drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
2 files changed, 12 insertions(+)
--
2.18.0
^ permalink raw reply [flat|nested] 42+ messages in thread
* [PATCH v2,0/2] Add mt8186 dpi compatiable
@ 2022-03-31 11:58 ` xinlei.lee
0 siblings, 0 replies; 42+ messages in thread
From: xinlei.lee @ 2022-03-31 11:58 UTC (permalink / raw)
To: chunkuang.hu, p.zabel, airlied, daniel, robh+dt, matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
rex-bc.chen, jitao.shi, Xinlei Lee
From: Xinlei Lee <xinlei.lee@mediatek.com>
Base on Linux-next
change since v1:
1. Put switch dpi Topckgen MUX action in mt8186.dtsi.
Xinlei Lee (2):
dt-bindings: display: mediatek: dpi: Add compatible for MediaTek
MT8186
drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
.../bindings/display/mediatek/mediatek,dpi.yaml | 1 +
drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
2 files changed, 12 insertions(+)
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 42+ messages in thread
* [PATCH v2,0/2] Add mt8186 dpi compatiable
@ 2022-03-31 11:58 ` xinlei.lee
0 siblings, 0 replies; 42+ messages in thread
From: xinlei.lee @ 2022-03-31 11:58 UTC (permalink / raw)
To: chunkuang.hu, p.zabel, airlied, daniel, robh+dt, matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
rex-bc.chen, jitao.shi, Xinlei Lee
From: Xinlei Lee <xinlei.lee@mediatek.com>
Base on Linux-next
change since v1:
1. Put switch dpi Topckgen MUX action in mt8186.dtsi.
Xinlei Lee (2):
dt-bindings: display: mediatek: dpi: Add compatible for MediaTek
MT8186
drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
.../bindings/display/mediatek/mediatek,dpi.yaml | 1 +
drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
2 files changed, 12 insertions(+)
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 42+ messages in thread
* [PATCH v2, 1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
2022-03-31 11:58 ` xinlei.lee
(?)
(?)
@ 2022-03-31 11:58 ` xinlei.lee
-1 siblings, 0 replies; 42+ messages in thread
From: xinlei.lee @ 2022-03-31 11:58 UTC (permalink / raw)
To: chunkuang.hu, p.zabel, airlied, daniel, robh+dt, matthias.bgg
Cc: devicetree, jitao.shi, Xinlei Lee, linux-kernel, dri-devel,
Project_Global_Chrome_Upstream_Group, linux-mediatek,
rex-bc.chen, linux-arm-kernel
From: Xinlei Lee <xinlei.lee@mediatek.com>
Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
---
.../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
index dd2896a40ff0..a73044c50b5f 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
@@ -22,6 +22,7 @@ properties:
- mediatek,mt7623-dpi
- mediatek,mt8173-dpi
- mediatek,mt8183-dpi
+ - mediatek,mt8186-dpi
- mediatek,mt8192-dpi
reg:
--
2.18.0
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-03-31 11:58 ` xinlei.lee
0 siblings, 0 replies; 42+ messages in thread
From: xinlei.lee @ 2022-03-31 11:58 UTC (permalink / raw)
To: chunkuang.hu, p.zabel, airlied, daniel, robh+dt, matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
rex-bc.chen, jitao.shi, Xinlei Lee
From: Xinlei Lee <xinlei.lee@mediatek.com>
Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
---
.../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
index dd2896a40ff0..a73044c50b5f 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
@@ -22,6 +22,7 @@ properties:
- mediatek,mt7623-dpi
- mediatek,mt8173-dpi
- mediatek,mt8183-dpi
+ - mediatek,mt8186-dpi
- mediatek,mt8192-dpi
reg:
--
2.18.0
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH v2, 1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-03-31 11:58 ` xinlei.lee
0 siblings, 0 replies; 42+ messages in thread
From: xinlei.lee @ 2022-03-31 11:58 UTC (permalink / raw)
To: chunkuang.hu, p.zabel, airlied, daniel, robh+dt, matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
rex-bc.chen, jitao.shi, Xinlei Lee
From: Xinlei Lee <xinlei.lee@mediatek.com>
Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
---
.../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
index dd2896a40ff0..a73044c50b5f 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
@@ -22,6 +22,7 @@ properties:
- mediatek,mt7623-dpi
- mediatek,mt8173-dpi
- mediatek,mt8183-dpi
+ - mediatek,mt8186-dpi
- mediatek,mt8192-dpi
reg:
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH v2, 1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-03-31 11:58 ` xinlei.lee
0 siblings, 0 replies; 42+ messages in thread
From: xinlei.lee @ 2022-03-31 11:58 UTC (permalink / raw)
To: chunkuang.hu, p.zabel, airlied, daniel, robh+dt, matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
rex-bc.chen, jitao.shi, Xinlei Lee
From: Xinlei Lee <xinlei.lee@mediatek.com>
Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
---
.../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
index dd2896a40ff0..a73044c50b5f 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
@@ -22,6 +22,7 @@ properties:
- mediatek,mt7623-dpi
- mediatek,mt8173-dpi
- mediatek,mt8183-dpi
+ - mediatek,mt8186-dpi
- mediatek,mt8192-dpi
reg:
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH v2,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
2022-03-31 11:58 ` xinlei.lee
(?)
(?)
@ 2022-03-31 11:58 ` xinlei.lee
-1 siblings, 0 replies; 42+ messages in thread
From: xinlei.lee @ 2022-03-31 11:58 UTC (permalink / raw)
To: chunkuang.hu, p.zabel, airlied, daniel, robh+dt, matthias.bgg
Cc: devicetree, jitao.shi, Xinlei Lee, linux-kernel, dri-devel,
Project_Global_Chrome_Upstream_Group, linux-mediatek,
rex-bc.chen, linux-arm-kernel
From: Xinlei Lee <xinlei.lee@mediatek.com>
Add the compatible because use different .data in mt8186.
Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
index 4554e2de1430..6fac146cf1fb 100644
--- a/drivers/gpu/drm/mediatek/mtk_dpi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
@@ -823,6 +823,14 @@ static const struct mtk_dpi_conf mt8192_conf = {
.num_output_fmts = ARRAY_SIZE(mt8173_output_fmts),
};
+static const struct mtk_dpi_conf mt8186_conf = {
+ .cal_factor = mt8183_calculate_factor,
+ .reg_h_fre_con = 0xe0,
+ .max_clock_khz = 150000,
+ .output_fmts = mt8183_output_fmts,
+ .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
+};
+
static int mtk_dpi_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
@@ -945,6 +953,9 @@ static const struct of_device_id mtk_dpi_of_ids[] = {
{ .compatible = "mediatek,mt8192-dpi",
.data = &mt8192_conf,
},
+ { .compatible = "mediatek,mt8186-dpi",
+ .data = &mt8186_conf,
+ },
{ },
};
MODULE_DEVICE_TABLE(of, mtk_dpi_of_ids);
--
2.18.0
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH v2,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
@ 2022-03-31 11:58 ` xinlei.lee
0 siblings, 0 replies; 42+ messages in thread
From: xinlei.lee @ 2022-03-31 11:58 UTC (permalink / raw)
To: chunkuang.hu, p.zabel, airlied, daniel, robh+dt, matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
rex-bc.chen, jitao.shi, Xinlei Lee
From: Xinlei Lee <xinlei.lee@mediatek.com>
Add the compatible because use different .data in mt8186.
Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
index 4554e2de1430..6fac146cf1fb 100644
--- a/drivers/gpu/drm/mediatek/mtk_dpi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
@@ -823,6 +823,14 @@ static const struct mtk_dpi_conf mt8192_conf = {
.num_output_fmts = ARRAY_SIZE(mt8173_output_fmts),
};
+static const struct mtk_dpi_conf mt8186_conf = {
+ .cal_factor = mt8183_calculate_factor,
+ .reg_h_fre_con = 0xe0,
+ .max_clock_khz = 150000,
+ .output_fmts = mt8183_output_fmts,
+ .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
+};
+
static int mtk_dpi_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
@@ -945,6 +953,9 @@ static const struct of_device_id mtk_dpi_of_ids[] = {
{ .compatible = "mediatek,mt8192-dpi",
.data = &mt8192_conf,
},
+ { .compatible = "mediatek,mt8186-dpi",
+ .data = &mt8186_conf,
+ },
{ },
};
MODULE_DEVICE_TABLE(of, mtk_dpi_of_ids);
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH v2,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
@ 2022-03-31 11:58 ` xinlei.lee
0 siblings, 0 replies; 42+ messages in thread
From: xinlei.lee @ 2022-03-31 11:58 UTC (permalink / raw)
To: chunkuang.hu, p.zabel, airlied, daniel, robh+dt, matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
rex-bc.chen, jitao.shi, Xinlei Lee
From: Xinlei Lee <xinlei.lee@mediatek.com>
Add the compatible because use different .data in mt8186.
Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
index 4554e2de1430..6fac146cf1fb 100644
--- a/drivers/gpu/drm/mediatek/mtk_dpi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
@@ -823,6 +823,14 @@ static const struct mtk_dpi_conf mt8192_conf = {
.num_output_fmts = ARRAY_SIZE(mt8173_output_fmts),
};
+static const struct mtk_dpi_conf mt8186_conf = {
+ .cal_factor = mt8183_calculate_factor,
+ .reg_h_fre_con = 0xe0,
+ .max_clock_khz = 150000,
+ .output_fmts = mt8183_output_fmts,
+ .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
+};
+
static int mtk_dpi_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
@@ -945,6 +953,9 @@ static const struct of_device_id mtk_dpi_of_ids[] = {
{ .compatible = "mediatek,mt8192-dpi",
.data = &mt8192_conf,
},
+ { .compatible = "mediatek,mt8186-dpi",
+ .data = &mt8186_conf,
+ },
{ },
};
MODULE_DEVICE_TABLE(of, mtk_dpi_of_ids);
--
2.18.0
^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH v2,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
@ 2022-03-31 11:58 ` xinlei.lee
0 siblings, 0 replies; 42+ messages in thread
From: xinlei.lee @ 2022-03-31 11:58 UTC (permalink / raw)
To: chunkuang.hu, p.zabel, airlied, daniel, robh+dt, matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
rex-bc.chen, jitao.shi, Xinlei Lee
From: Xinlei Lee <xinlei.lee@mediatek.com>
Add the compatible because use different .data in mt8186.
Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
---
drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
index 4554e2de1430..6fac146cf1fb 100644
--- a/drivers/gpu/drm/mediatek/mtk_dpi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
@@ -823,6 +823,14 @@ static const struct mtk_dpi_conf mt8192_conf = {
.num_output_fmts = ARRAY_SIZE(mt8173_output_fmts),
};
+static const struct mtk_dpi_conf mt8186_conf = {
+ .cal_factor = mt8183_calculate_factor,
+ .reg_h_fre_con = 0xe0,
+ .max_clock_khz = 150000,
+ .output_fmts = mt8183_output_fmts,
+ .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
+};
+
static int mtk_dpi_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
@@ -945,6 +953,9 @@ static const struct of_device_id mtk_dpi_of_ids[] = {
{ .compatible = "mediatek,mt8192-dpi",
.data = &mt8192_conf,
},
+ { .compatible = "mediatek,mt8186-dpi",
+ .data = &mt8186_conf,
+ },
{ },
};
MODULE_DEVICE_TABLE(of, mtk_dpi_of_ids);
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
2022-03-31 11:58 ` [PATCH v2,1/2] " xinlei.lee
(?)
(?)
@ 2022-04-01 1:38 ` Rex-BC Chen
-1 siblings, 0 replies; 42+ messages in thread
From: Rex-BC Chen @ 2022-04-01 1:38 UTC (permalink / raw)
To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, robh+dt,
matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
jitao.shi
On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1
> +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> l
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> l
> index dd2896a40ff0..a73044c50b5f 100644
> ---
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> l
> +++
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> l
> @@ -22,6 +22,7 @@ properties:
> - mediatek,mt7623-dpi
> - mediatek,mt8173-dpi
> - mediatek,mt8183-dpi
> + - mediatek,mt8186-dpi
> - mediatek,mt8192-dpi
>
> reg:
Hello Xinlei,
From the dts we use, the dpi node needs other properties for MT8186.
Please send another patch and add these properties to binding.
assigned-clocks = <&topckgen CLK_TOP_DPI>;
assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
Thanks
BRs,
Rex
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-01 1:38 ` Rex-BC Chen
0 siblings, 0 replies; 42+ messages in thread
From: Rex-BC Chen @ 2022-04-01 1:38 UTC (permalink / raw)
To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, robh+dt,
matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
jitao.shi
On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1
> +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> l
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> l
> index dd2896a40ff0..a73044c50b5f 100644
> ---
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> l
> +++
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> l
> @@ -22,6 +22,7 @@ properties:
> - mediatek,mt7623-dpi
> - mediatek,mt8173-dpi
> - mediatek,mt8183-dpi
> + - mediatek,mt8186-dpi
> - mediatek,mt8192-dpi
>
> reg:
Hello Xinlei,
From the dts we use, the dpi node needs other properties for MT8186.
Please send another patch and add these properties to binding.
assigned-clocks = <&topckgen CLK_TOP_DPI>;
assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
Thanks
BRs,
Rex
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-01 1:38 ` Rex-BC Chen
0 siblings, 0 replies; 42+ messages in thread
From: Rex-BC Chen @ 2022-04-01 1:38 UTC (permalink / raw)
To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, robh+dt,
matthias.bgg
Cc: devicetree, jitao.shi, linux-kernel, dri-devel,
Project_Global_Chrome_Upstream_Group, linux-mediatek,
linux-arm-kernel
On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1
> +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> l
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> l
> index dd2896a40ff0..a73044c50b5f 100644
> ---
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> l
> +++
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> l
> @@ -22,6 +22,7 @@ properties:
> - mediatek,mt7623-dpi
> - mediatek,mt8173-dpi
> - mediatek,mt8183-dpi
> + - mediatek,mt8186-dpi
> - mediatek,mt8192-dpi
>
> reg:
Hello Xinlei,
From the dts we use, the dpi node needs other properties for MT8186.
Please send another patch and add these properties to binding.
assigned-clocks = <&topckgen CLK_TOP_DPI>;
assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
Thanks
BRs,
Rex
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-01 1:38 ` Rex-BC Chen
0 siblings, 0 replies; 42+ messages in thread
From: Rex-BC Chen @ 2022-04-01 1:38 UTC (permalink / raw)
To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, robh+dt,
matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
jitao.shi
On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1
> +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> l
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> l
> index dd2896a40ff0..a73044c50b5f 100644
> ---
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> l
> +++
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> l
> @@ -22,6 +22,7 @@ properties:
> - mediatek,mt7623-dpi
> - mediatek,mt8173-dpi
> - mediatek,mt8183-dpi
> + - mediatek,mt8186-dpi
> - mediatek,mt8192-dpi
>
> reg:
Hello Xinlei,
From the dts we use, the dpi node needs other properties for MT8186.
Please send another patch and add these properties to binding.
assigned-clocks = <&topckgen CLK_TOP_DPI>;
assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
Thanks
BRs,
Rex
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
2022-04-01 1:38 ` Rex-BC Chen
(?)
(?)
@ 2022-04-06 6:38 ` CK Hu
-1 siblings, 0 replies; 42+ messages in thread
From: CK Hu @ 2022-04-06 6:38 UTC (permalink / raw)
To: Rex-BC Chen, xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel,
robh+dt, matthias.bgg
Cc: devicetree, jitao.shi, linux-kernel, dri-devel,
Project_Global_Chrome_Upstream_Group, linux-mediatek,
linux-arm-kernel
Hi,
On Fri, 2022-04-01 at 09:38 +0800, Rex-BC Chen wrote:
> On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > From: Xinlei Lee <xinlei.lee@mediatek.com>
> >
> > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> >
> > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml |
> > 1
> > +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > index dd2896a40ff0..a73044c50b5f 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > @@ -22,6 +22,7 @@ properties:
> > - mediatek,mt7623-dpi
> > - mediatek,mt8173-dpi
> > - mediatek,mt8183-dpi
> > + - mediatek,mt8186-dpi
> > - mediatek,mt8192-dpi
> >
> > reg:
>
> Hello Xinlei,
>
> From the dts we use, the dpi node needs other properties for MT8186.
> Please send another patch and add these properties to binding.
>
> assigned-clocks = <&topckgen CLK_TOP_DPI>;
> assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
According to [1], the assigned-clocks is initial value. Without this
initial value, I think driver would set this clock again, wouldn't it?
[1]
https://www.kernel.org/doc/Documentation/devicetree/bindings/clock/clock-bindings.txt
Regards,
CK
>
> Thanks
>
> BRs,
> Rex
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
>
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!wtF15QZZTCzWfRpxNLjZ1VQQ54i40D8STuOo0h18dtz3es-ksLfYQGTEFlb7lg$
>
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-06 6:38 ` CK Hu
0 siblings, 0 replies; 42+ messages in thread
From: CK Hu @ 2022-04-06 6:38 UTC (permalink / raw)
To: Rex-BC Chen, xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel,
robh+dt, matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
jitao.shi
Hi,
On Fri, 2022-04-01 at 09:38 +0800, Rex-BC Chen wrote:
> On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > From: Xinlei Lee <xinlei.lee@mediatek.com>
> >
> > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> >
> > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml |
> > 1
> > +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > index dd2896a40ff0..a73044c50b5f 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > @@ -22,6 +22,7 @@ properties:
> > - mediatek,mt7623-dpi
> > - mediatek,mt8173-dpi
> > - mediatek,mt8183-dpi
> > + - mediatek,mt8186-dpi
> > - mediatek,mt8192-dpi
> >
> > reg:
>
> Hello Xinlei,
>
> From the dts we use, the dpi node needs other properties for MT8186.
> Please send another patch and add these properties to binding.
>
> assigned-clocks = <&topckgen CLK_TOP_DPI>;
> assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
According to [1], the assigned-clocks is initial value. Without this
initial value, I think driver would set this clock again, wouldn't it?
[1]
https://www.kernel.org/doc/Documentation/devicetree/bindings/clock/clock-bindings.txt
Regards,
CK
>
> Thanks
>
> BRs,
> Rex
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
>
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!wtF15QZZTCzWfRpxNLjZ1VQQ54i40D8STuOo0h18dtz3es-ksLfYQGTEFlb7lg$
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-06 6:38 ` CK Hu
0 siblings, 0 replies; 42+ messages in thread
From: CK Hu @ 2022-04-06 6:38 UTC (permalink / raw)
To: Rex-BC Chen, xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel,
robh+dt, matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
jitao.shi
Hi,
On Fri, 2022-04-01 at 09:38 +0800, Rex-BC Chen wrote:
> On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > From: Xinlei Lee <xinlei.lee@mediatek.com>
> >
> > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> >
> > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml |
> > 1
> > +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > index dd2896a40ff0..a73044c50b5f 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > @@ -22,6 +22,7 @@ properties:
> > - mediatek,mt7623-dpi
> > - mediatek,mt8173-dpi
> > - mediatek,mt8183-dpi
> > + - mediatek,mt8186-dpi
> > - mediatek,mt8192-dpi
> >
> > reg:
>
> Hello Xinlei,
>
> From the dts we use, the dpi node needs other properties for MT8186.
> Please send another patch and add these properties to binding.
>
> assigned-clocks = <&topckgen CLK_TOP_DPI>;
> assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
According to [1], the assigned-clocks is initial value. Without this
initial value, I think driver would set this clock again, wouldn't it?
[1]
https://www.kernel.org/doc/Documentation/devicetree/bindings/clock/clock-bindings.txt
Regards,
CK
>
> Thanks
>
> BRs,
> Rex
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
>
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!wtF15QZZTCzWfRpxNLjZ1VQQ54i40D8STuOo0h18dtz3es-ksLfYQGTEFlb7lg$
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-06 6:38 ` CK Hu
0 siblings, 0 replies; 42+ messages in thread
From: CK Hu @ 2022-04-06 6:38 UTC (permalink / raw)
To: Rex-BC Chen, xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel,
robh+dt, matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
jitao.shi
Hi,
On Fri, 2022-04-01 at 09:38 +0800, Rex-BC Chen wrote:
> On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > From: Xinlei Lee <xinlei.lee@mediatek.com>
> >
> > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> >
> > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml |
> > 1
> > +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > index dd2896a40ff0..a73044c50b5f 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > @@ -22,6 +22,7 @@ properties:
> > - mediatek,mt7623-dpi
> > - mediatek,mt8173-dpi
> > - mediatek,mt8183-dpi
> > + - mediatek,mt8186-dpi
> > - mediatek,mt8192-dpi
> >
> > reg:
>
> Hello Xinlei,
>
> From the dts we use, the dpi node needs other properties for MT8186.
> Please send another patch and add these properties to binding.
>
> assigned-clocks = <&topckgen CLK_TOP_DPI>;
> assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
According to [1], the assigned-clocks is initial value. Without this
initial value, I think driver would set this clock again, wouldn't it?
[1]
https://www.kernel.org/doc/Documentation/devicetree/bindings/clock/clock-bindings.txt
Regards,
CK
>
> Thanks
>
> BRs,
> Rex
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
>
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!wtF15QZZTCzWfRpxNLjZ1VQQ54i40D8STuOo0h18dtz3es-ksLfYQGTEFlb7lg$
>
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
2022-04-06 6:38 ` CK Hu
(?)
(?)
@ 2022-04-06 7:08 ` Rex-BC Chen
-1 siblings, 0 replies; 42+ messages in thread
From: Rex-BC Chen @ 2022-04-06 7:08 UTC (permalink / raw)
To: CK Hu, xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel,
robh+dt, matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
jitao.shi
On Wed, 2022-04-06 at 14:38 +0800, CK Hu wrote:
> Hi,
>
> On Fri, 2022-04-01 at 09:38 +0800, Rex-BC Chen wrote:
> > On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > > From: Xinlei Lee <xinlei.lee@mediatek.com>
> > >
> > > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> > >
> > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > > ---
> > > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> > > |
> > > 1
> > > +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > index dd2896a40ff0..a73044c50b5f 100644
> > > ---
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > +++
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > @@ -22,6 +22,7 @@ properties:
> > > - mediatek,mt7623-dpi
> > > - mediatek,mt8173-dpi
> > > - mediatek,mt8183-dpi
> > > + - mediatek,mt8186-dpi
> > > - mediatek,mt8192-dpi
> > >
> > > reg:
> >
> > Hello Xinlei,
> >
> > From the dts we use, the dpi node needs other properties for
> > MT8186.
> > Please send another patch and add these properties to binding.
> >
> > assigned-clocks = <&topckgen CLK_TOP_DPI>;
> > assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
>
> According to [1], the assigned-clocks is initial value. Without this
> initial value, I think driver would set this clock again, wouldn't
> it?
>
> [1]
>
https://www.kernel.org/doc/Documentation/devicetree/bindings/clock/clock-bindings.txt
>
> Regards,
> CK
>
Hello CK,
OK, Thanks for your explanation.
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
BRs,
Rex
> >
> > Thanks
> >
> > BRs,
> > Rex
> >
> >
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@lists.infradead.org
> >
>
>
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!wtF15QZZTCzWfRpxNLjZ1VQQ54i40D8STuOo0h18dtz3es-ksLfYQGTEFlb7lg$
> >
>
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-06 7:08 ` Rex-BC Chen
0 siblings, 0 replies; 42+ messages in thread
From: Rex-BC Chen @ 2022-04-06 7:08 UTC (permalink / raw)
To: CK Hu, xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel,
robh+dt, matthias.bgg
Cc: devicetree, jitao.shi, linux-kernel, dri-devel,
Project_Global_Chrome_Upstream_Group, linux-mediatek,
linux-arm-kernel
On Wed, 2022-04-06 at 14:38 +0800, CK Hu wrote:
> Hi,
>
> On Fri, 2022-04-01 at 09:38 +0800, Rex-BC Chen wrote:
> > On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > > From: Xinlei Lee <xinlei.lee@mediatek.com>
> > >
> > > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> > >
> > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > > ---
> > > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> > > |
> > > 1
> > > +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > index dd2896a40ff0..a73044c50b5f 100644
> > > ---
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > +++
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > @@ -22,6 +22,7 @@ properties:
> > > - mediatek,mt7623-dpi
> > > - mediatek,mt8173-dpi
> > > - mediatek,mt8183-dpi
> > > + - mediatek,mt8186-dpi
> > > - mediatek,mt8192-dpi
> > >
> > > reg:
> >
> > Hello Xinlei,
> >
> > From the dts we use, the dpi node needs other properties for
> > MT8186.
> > Please send another patch and add these properties to binding.
> >
> > assigned-clocks = <&topckgen CLK_TOP_DPI>;
> > assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
>
> According to [1], the assigned-clocks is initial value. Without this
> initial value, I think driver would set this clock again, wouldn't
> it?
>
> [1]
>
https://www.kernel.org/doc/Documentation/devicetree/bindings/clock/clock-bindings.txt
>
> Regards,
> CK
>
Hello CK,
OK, Thanks for your explanation.
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
BRs,
Rex
> >
> > Thanks
> >
> > BRs,
> > Rex
> >
> >
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@lists.infradead.org
> >
>
>
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!wtF15QZZTCzWfRpxNLjZ1VQQ54i40D8STuOo0h18dtz3es-ksLfYQGTEFlb7lg$
> >
>
>
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-06 7:08 ` Rex-BC Chen
0 siblings, 0 replies; 42+ messages in thread
From: Rex-BC Chen @ 2022-04-06 7:08 UTC (permalink / raw)
To: CK Hu, xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel,
robh+dt, matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
jitao.shi
On Wed, 2022-04-06 at 14:38 +0800, CK Hu wrote:
> Hi,
>
> On Fri, 2022-04-01 at 09:38 +0800, Rex-BC Chen wrote:
> > On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > > From: Xinlei Lee <xinlei.lee@mediatek.com>
> > >
> > > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> > >
> > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > > ---
> > > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> > > |
> > > 1
> > > +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > index dd2896a40ff0..a73044c50b5f 100644
> > > ---
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > +++
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > @@ -22,6 +22,7 @@ properties:
> > > - mediatek,mt7623-dpi
> > > - mediatek,mt8173-dpi
> > > - mediatek,mt8183-dpi
> > > + - mediatek,mt8186-dpi
> > > - mediatek,mt8192-dpi
> > >
> > > reg:
> >
> > Hello Xinlei,
> >
> > From the dts we use, the dpi node needs other properties for
> > MT8186.
> > Please send another patch and add these properties to binding.
> >
> > assigned-clocks = <&topckgen CLK_TOP_DPI>;
> > assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
>
> According to [1], the assigned-clocks is initial value. Without this
> initial value, I think driver would set this clock again, wouldn't
> it?
>
> [1]
>
https://www.kernel.org/doc/Documentation/devicetree/bindings/clock/clock-bindings.txt
>
> Regards,
> CK
>
Hello CK,
OK, Thanks for your explanation.
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
BRs,
Rex
> >
> > Thanks
> >
> > BRs,
> > Rex
> >
> >
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@lists.infradead.org
> >
>
>
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!wtF15QZZTCzWfRpxNLjZ1VQQ54i40D8STuOo0h18dtz3es-ksLfYQGTEFlb7lg$
> >
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-06 7:08 ` Rex-BC Chen
0 siblings, 0 replies; 42+ messages in thread
From: Rex-BC Chen @ 2022-04-06 7:08 UTC (permalink / raw)
To: CK Hu, xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel,
robh+dt, matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
jitao.shi
On Wed, 2022-04-06 at 14:38 +0800, CK Hu wrote:
> Hi,
>
> On Fri, 2022-04-01 at 09:38 +0800, Rex-BC Chen wrote:
> > On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > > From: Xinlei Lee <xinlei.lee@mediatek.com>
> > >
> > > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> > >
> > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > > ---
> > > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> > > |
> > > 1
> > > +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > index dd2896a40ff0..a73044c50b5f 100644
> > > ---
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > +++
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > @@ -22,6 +22,7 @@ properties:
> > > - mediatek,mt7623-dpi
> > > - mediatek,mt8173-dpi
> > > - mediatek,mt8183-dpi
> > > + - mediatek,mt8186-dpi
> > > - mediatek,mt8192-dpi
> > >
> > > reg:
> >
> > Hello Xinlei,
> >
> > From the dts we use, the dpi node needs other properties for
> > MT8186.
> > Please send another patch and add these properties to binding.
> >
> > assigned-clocks = <&topckgen CLK_TOP_DPI>;
> > assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
>
> According to [1], the assigned-clocks is initial value. Without this
> initial value, I think driver would set this clock again, wouldn't
> it?
>
> [1]
>
https://www.kernel.org/doc/Documentation/devicetree/bindings/clock/clock-bindings.txt
>
> Regards,
> CK
>
Hello CK,
OK, Thanks for your explanation.
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
BRs,
Rex
> >
> > Thanks
> >
> > BRs,
> > Rex
> >
> >
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@lists.infradead.org
> >
>
>
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!wtF15QZZTCzWfRpxNLjZ1VQQ54i40D8STuOo0h18dtz3es-ksLfYQGTEFlb7lg$
> >
>
>
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
2022-03-31 11:58 ` xinlei.lee
(?)
(?)
@ 2022-04-06 7:13 ` Rex-BC Chen
-1 siblings, 0 replies; 42+ messages in thread
From: Rex-BC Chen @ 2022-04-06 7:13 UTC (permalink / raw)
To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, robh+dt,
matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
jitao.shi
On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add the compatible because use different .data in mt8186.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index 4554e2de1430..6fac146cf1fb 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -823,6 +823,14 @@ static const struct mtk_dpi_conf mt8192_conf = {
> .num_output_fmts = ARRAY_SIZE(mt8173_output_fmts),
> };
>
> +static const struct mtk_dpi_conf mt8186_conf = {
> + .cal_factor = mt8183_calculate_factor,
> + .reg_h_fre_con = 0xe0,
> + .max_clock_khz = 150000,
> + .output_fmts = mt8183_output_fmts,
> + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> +};
> +
Hello Xinlei,
Could you move 8186 between 8183 and 8192?
> static int mtk_dpi_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> @@ -945,6 +953,9 @@ static const struct of_device_id mtk_dpi_of_ids[]
> = {
> { .compatible = "mediatek,mt8192-dpi",
> .data = &mt8192_conf,
> },
> + { .compatible = "mediatek,mt8186-dpi",
> + .data = &mt8186_conf,
> + },
ditto
BRs,
Rex
> { },
> };
> MODULE_DEVICE_TABLE(of, mtk_dpi_of_ids);
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
@ 2022-04-06 7:13 ` Rex-BC Chen
0 siblings, 0 replies; 42+ messages in thread
From: Rex-BC Chen @ 2022-04-06 7:13 UTC (permalink / raw)
To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, robh+dt,
matthias.bgg
Cc: devicetree, jitao.shi, linux-kernel, dri-devel,
Project_Global_Chrome_Upstream_Group, linux-mediatek,
linux-arm-kernel
On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add the compatible because use different .data in mt8186.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index 4554e2de1430..6fac146cf1fb 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -823,6 +823,14 @@ static const struct mtk_dpi_conf mt8192_conf = {
> .num_output_fmts = ARRAY_SIZE(mt8173_output_fmts),
> };
>
> +static const struct mtk_dpi_conf mt8186_conf = {
> + .cal_factor = mt8183_calculate_factor,
> + .reg_h_fre_con = 0xe0,
> + .max_clock_khz = 150000,
> + .output_fmts = mt8183_output_fmts,
> + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> +};
> +
Hello Xinlei,
Could you move 8186 between 8183 and 8192?
> static int mtk_dpi_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> @@ -945,6 +953,9 @@ static const struct of_device_id mtk_dpi_of_ids[]
> = {
> { .compatible = "mediatek,mt8192-dpi",
> .data = &mt8192_conf,
> },
> + { .compatible = "mediatek,mt8186-dpi",
> + .data = &mt8186_conf,
> + },
ditto
BRs,
Rex
> { },
> };
> MODULE_DEVICE_TABLE(of, mtk_dpi_of_ids);
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
@ 2022-04-06 7:13 ` Rex-BC Chen
0 siblings, 0 replies; 42+ messages in thread
From: Rex-BC Chen @ 2022-04-06 7:13 UTC (permalink / raw)
To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, robh+dt,
matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
jitao.shi
On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add the compatible because use different .data in mt8186.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index 4554e2de1430..6fac146cf1fb 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -823,6 +823,14 @@ static const struct mtk_dpi_conf mt8192_conf = {
> .num_output_fmts = ARRAY_SIZE(mt8173_output_fmts),
> };
>
> +static const struct mtk_dpi_conf mt8186_conf = {
> + .cal_factor = mt8183_calculate_factor,
> + .reg_h_fre_con = 0xe0,
> + .max_clock_khz = 150000,
> + .output_fmts = mt8183_output_fmts,
> + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> +};
> +
Hello Xinlei,
Could you move 8186 between 8183 and 8192?
> static int mtk_dpi_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> @@ -945,6 +953,9 @@ static const struct of_device_id mtk_dpi_of_ids[]
> = {
> { .compatible = "mediatek,mt8192-dpi",
> .data = &mt8192_conf,
> },
> + { .compatible = "mediatek,mt8186-dpi",
> + .data = &mt8186_conf,
> + },
ditto
BRs,
Rex
> { },
> };
> MODULE_DEVICE_TABLE(of, mtk_dpi_of_ids);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
@ 2022-04-06 7:13 ` Rex-BC Chen
0 siblings, 0 replies; 42+ messages in thread
From: Rex-BC Chen @ 2022-04-06 7:13 UTC (permalink / raw)
To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, robh+dt,
matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
jitao.shi
On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add the compatible because use different .data in mt8186.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index 4554e2de1430..6fac146cf1fb 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -823,6 +823,14 @@ static const struct mtk_dpi_conf mt8192_conf = {
> .num_output_fmts = ARRAY_SIZE(mt8173_output_fmts),
> };
>
> +static const struct mtk_dpi_conf mt8186_conf = {
> + .cal_factor = mt8183_calculate_factor,
> + .reg_h_fre_con = 0xe0,
> + .max_clock_khz = 150000,
> + .output_fmts = mt8183_output_fmts,
> + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> +};
> +
Hello Xinlei,
Could you move 8186 between 8183 and 8192?
> static int mtk_dpi_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> @@ -945,6 +953,9 @@ static const struct of_device_id mtk_dpi_of_ids[]
> = {
> { .compatible = "mediatek,mt8192-dpi",
> .data = &mt8192_conf,
> },
> + { .compatible = "mediatek,mt8186-dpi",
> + .data = &mt8186_conf,
> + },
ditto
BRs,
Rex
> { },
> };
> MODULE_DEVICE_TABLE(of, mtk_dpi_of_ids);
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
2022-04-06 7:13 ` Rex-BC Chen
(?)
@ 2022-04-06 13:44 ` xinlei.lee
-1 siblings, 0 replies; 42+ messages in thread
From: xinlei.lee @ 2022-04-06 13:44 UTC (permalink / raw)
To: Rex-BC Chen, chunkuang.hu, p.zabel, airlied, daniel, robh+dt,
matthias.bgg
Cc: devicetree, jitao.shi, linux-kernel, dri-devel,
Project_Global_Chrome_Upstream_Group, linux-mediatek,
linux-arm-kernel
On Wed, 2022-04-06 at 15:13 +0800, Rex-BC Chen wrote:
> On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > From: Xinlei Lee <xinlei.lee@mediatek.com>
> >
> > Add the compatible because use different .data in mt8186.
> >
> > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > ---
> > drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > index 4554e2de1430..6fac146cf1fb 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > @@ -823,6 +823,14 @@ static const struct mtk_dpi_conf mt8192_conf =
> > {
> > .num_output_fmts = ARRAY_SIZE(mt8173_output_fmts),
> > };
> >
> > +static const struct mtk_dpi_conf mt8186_conf = {
> > + .cal_factor = mt8183_calculate_factor,
> > + .reg_h_fre_con = 0xe0,
> > + .max_clock_khz = 150000,
> > + .output_fmts = mt8183_output_fmts,
> > + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> > +};
> > +
>
> Hello Xinlei,
>
> Could you move 8186 between 8183 and 8192?
>
> > static int mtk_dpi_probe(struct platform_device *pdev)
> > {
> > struct device *dev = &pdev->dev;
> > @@ -945,6 +953,9 @@ static const struct of_device_id
> > mtk_dpi_of_ids[]
> > = {
> > { .compatible = "mediatek,mt8192-dpi",
> > .data = &mt8192_conf,
> > },
> > + { .compatible = "mediatek,mt8186-dpi",
> > + .data = &mt8186_conf,
> > + },
>
> ditto
>
> BRs,
> Rex
> > { },
> > };
> > MODULE_DEVICE_TABLE(of, mtk_dpi_of_ids);
>
>
Hi Rex:
Thanks for your review.
I will put it between 8183 & 8192 in the next version.
In addition, I will add two properties assigned-clocks & assigned-
clock-parents to dtbing.
Best Regards!
xinlei
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
@ 2022-04-06 13:44 ` xinlei.lee
0 siblings, 0 replies; 42+ messages in thread
From: xinlei.lee @ 2022-04-06 13:44 UTC (permalink / raw)
To: Rex-BC Chen, chunkuang.hu, p.zabel, airlied, daniel, robh+dt,
matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
jitao.shi
On Wed, 2022-04-06 at 15:13 +0800, Rex-BC Chen wrote:
> On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > From: Xinlei Lee <xinlei.lee@mediatek.com>
> >
> > Add the compatible because use different .data in mt8186.
> >
> > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > ---
> > drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > index 4554e2de1430..6fac146cf1fb 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > @@ -823,6 +823,14 @@ static const struct mtk_dpi_conf mt8192_conf =
> > {
> > .num_output_fmts = ARRAY_SIZE(mt8173_output_fmts),
> > };
> >
> > +static const struct mtk_dpi_conf mt8186_conf = {
> > + .cal_factor = mt8183_calculate_factor,
> > + .reg_h_fre_con = 0xe0,
> > + .max_clock_khz = 150000,
> > + .output_fmts = mt8183_output_fmts,
> > + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> > +};
> > +
>
> Hello Xinlei,
>
> Could you move 8186 between 8183 and 8192?
>
> > static int mtk_dpi_probe(struct platform_device *pdev)
> > {
> > struct device *dev = &pdev->dev;
> > @@ -945,6 +953,9 @@ static const struct of_device_id
> > mtk_dpi_of_ids[]
> > = {
> > { .compatible = "mediatek,mt8192-dpi",
> > .data = &mt8192_conf,
> > },
> > + { .compatible = "mediatek,mt8186-dpi",
> > + .data = &mt8186_conf,
> > + },
>
> ditto
>
> BRs,
> Rex
> > { },
> > };
> > MODULE_DEVICE_TABLE(of, mtk_dpi_of_ids);
>
>
Hi Rex:
Thanks for your review.
I will put it between 8183 & 8192 in the next version.
In addition, I will add two properties assigned-clocks & assigned-
clock-parents to dtbing.
Best Regards!
xinlei
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c
@ 2022-04-06 13:44 ` xinlei.lee
0 siblings, 0 replies; 42+ messages in thread
From: xinlei.lee @ 2022-04-06 13:44 UTC (permalink / raw)
To: Rex-BC Chen, chunkuang.hu, p.zabel, airlied, daniel, robh+dt,
matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
jitao.shi
On Wed, 2022-04-06 at 15:13 +0800, Rex-BC Chen wrote:
> On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > From: Xinlei Lee <xinlei.lee@mediatek.com>
> >
> > Add the compatible because use different .data in mt8186.
> >
> > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > ---
> > drivers/gpu/drm/mediatek/mtk_dpi.c | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > index 4554e2de1430..6fac146cf1fb 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > @@ -823,6 +823,14 @@ static const struct mtk_dpi_conf mt8192_conf =
> > {
> > .num_output_fmts = ARRAY_SIZE(mt8173_output_fmts),
> > };
> >
> > +static const struct mtk_dpi_conf mt8186_conf = {
> > + .cal_factor = mt8183_calculate_factor,
> > + .reg_h_fre_con = 0xe0,
> > + .max_clock_khz = 150000,
> > + .output_fmts = mt8183_output_fmts,
> > + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts),
> > +};
> > +
>
> Hello Xinlei,
>
> Could you move 8186 between 8183 and 8192?
>
> > static int mtk_dpi_probe(struct platform_device *pdev)
> > {
> > struct device *dev = &pdev->dev;
> > @@ -945,6 +953,9 @@ static const struct of_device_id
> > mtk_dpi_of_ids[]
> > = {
> > { .compatible = "mediatek,mt8192-dpi",
> > .data = &mt8192_conf,
> > },
> > + { .compatible = "mediatek,mt8186-dpi",
> > + .data = &mt8186_conf,
> > + },
>
> ditto
>
> BRs,
> Rex
> > { },
> > };
> > MODULE_DEVICE_TABLE(of, mtk_dpi_of_ids);
>
>
Hi Rex:
Thanks for your review.
I will put it between 8183 & 8192 in the next version.
In addition, I will add two properties assigned-clocks & assigned-
clock-parents to dtbing.
Best Regards!
xinlei
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
2022-04-01 1:38 ` Rex-BC Chen
(?)
(?)
@ 2022-04-06 15:15 ` Rob Herring
-1 siblings, 0 replies; 42+ messages in thread
From: Rob Herring @ 2022-04-06 15:15 UTC (permalink / raw)
To: Rex-BC Chen
Cc: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg,
dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
jitao.shi
On Fri, Apr 01, 2022 at 09:38:20AM +0800, Rex-BC Chen wrote:
> On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > From: Xinlei Lee <xinlei.lee@mediatek.com>
> >
> > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> >
> > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1
> > +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > index dd2896a40ff0..a73044c50b5f 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > @@ -22,6 +22,7 @@ properties:
> > - mediatek,mt7623-dpi
> > - mediatek,mt8173-dpi
> > - mediatek,mt8183-dpi
> > + - mediatek,mt8186-dpi
> > - mediatek,mt8192-dpi
> >
> > reg:
>
> Hello Xinlei,
>
> From the dts we use, the dpi node needs other properties for MT8186.
> Please send another patch and add these properties to binding.
>
> assigned-clocks = <&topckgen CLK_TOP_DPI>;
> assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
Those are always allowed on any node with 'clocks', so no need to add
them here.
Rob
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-06 15:15 ` Rob Herring
0 siblings, 0 replies; 42+ messages in thread
From: Rob Herring @ 2022-04-06 15:15 UTC (permalink / raw)
To: Rex-BC Chen
Cc: chunkuang.hu, jitao.shi, xinlei.lee, devicetree, airlied,
linux-kernel, dri-devel, Project_Global_Chrome_Upstream_Group,
linux-mediatek, matthias.bgg, linux-arm-kernel
On Fri, Apr 01, 2022 at 09:38:20AM +0800, Rex-BC Chen wrote:
> On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > From: Xinlei Lee <xinlei.lee@mediatek.com>
> >
> > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> >
> > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1
> > +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > index dd2896a40ff0..a73044c50b5f 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > @@ -22,6 +22,7 @@ properties:
> > - mediatek,mt7623-dpi
> > - mediatek,mt8173-dpi
> > - mediatek,mt8183-dpi
> > + - mediatek,mt8186-dpi
> > - mediatek,mt8192-dpi
> >
> > reg:
>
> Hello Xinlei,
>
> From the dts we use, the dpi node needs other properties for MT8186.
> Please send another patch and add these properties to binding.
>
> assigned-clocks = <&topckgen CLK_TOP_DPI>;
> assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
Those are always allowed on any node with 'clocks', so no need to add
them here.
Rob
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-06 15:15 ` Rob Herring
0 siblings, 0 replies; 42+ messages in thread
From: Rob Herring @ 2022-04-06 15:15 UTC (permalink / raw)
To: Rex-BC Chen
Cc: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg,
dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
jitao.shi
On Fri, Apr 01, 2022 at 09:38:20AM +0800, Rex-BC Chen wrote:
> On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > From: Xinlei Lee <xinlei.lee@mediatek.com>
> >
> > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> >
> > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1
> > +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > index dd2896a40ff0..a73044c50b5f 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > @@ -22,6 +22,7 @@ properties:
> > - mediatek,mt7623-dpi
> > - mediatek,mt8173-dpi
> > - mediatek,mt8183-dpi
> > + - mediatek,mt8186-dpi
> > - mediatek,mt8192-dpi
> >
> > reg:
>
> Hello Xinlei,
>
> From the dts we use, the dpi node needs other properties for MT8186.
> Please send another patch and add these properties to binding.
>
> assigned-clocks = <&topckgen CLK_TOP_DPI>;
> assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
Those are always allowed on any node with 'clocks', so no need to add
them here.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-06 15:15 ` Rob Herring
0 siblings, 0 replies; 42+ messages in thread
From: Rob Herring @ 2022-04-06 15:15 UTC (permalink / raw)
To: Rex-BC Chen
Cc: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg,
dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
jitao.shi
On Fri, Apr 01, 2022 at 09:38:20AM +0800, Rex-BC Chen wrote:
> On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > From: Xinlei Lee <xinlei.lee@mediatek.com>
> >
> > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> >
> > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1
> > +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > index dd2896a40ff0..a73044c50b5f 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > @@ -22,6 +22,7 @@ properties:
> > - mediatek,mt7623-dpi
> > - mediatek,mt8173-dpi
> > - mediatek,mt8183-dpi
> > + - mediatek,mt8186-dpi
> > - mediatek,mt8192-dpi
> >
> > reg:
>
> Hello Xinlei,
>
> From the dts we use, the dpi node needs other properties for MT8186.
> Please send another patch and add these properties to binding.
>
> assigned-clocks = <&topckgen CLK_TOP_DPI>;
> assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
Those are always allowed on any node with 'clocks', so no need to add
them here.
Rob
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
2022-03-31 11:58 ` [PATCH v2,1/2] " xinlei.lee
(?)
(?)
@ 2022-04-06 15:15 ` Rob Herring
-1 siblings, 0 replies; 42+ messages in thread
From: Rob Herring @ 2022-04-06 15:15 UTC (permalink / raw)
To: xinlei.lee
Cc: matthias.bgg, devicetree, linux-kernel, airlied, p.zabel,
linux-mediatek, linux-arm-kernel, daniel, robh+dt, rex-bc.chen,
dri-devel, Project_Global_Chrome_Upstream_Group, chunkuang.hu,
jitao.shi
On Thu, 31 Mar 2022 19:58:36 +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-06 15:15 ` Rob Herring
0 siblings, 0 replies; 42+ messages in thread
From: Rob Herring @ 2022-04-06 15:15 UTC (permalink / raw)
To: xinlei.lee
Cc: devicetree, jitao.shi, chunkuang.hu, airlied, linux-kernel,
dri-devel, Project_Global_Chrome_Upstream_Group, rex-bc.chen,
robh+dt, linux-mediatek, matthias.bgg, linux-arm-kernel
On Thu, 31 Mar 2022 19:58:36 +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-06 15:15 ` Rob Herring
0 siblings, 0 replies; 42+ messages in thread
From: Rob Herring @ 2022-04-06 15:15 UTC (permalink / raw)
To: xinlei.lee
Cc: matthias.bgg, devicetree, linux-kernel, airlied, p.zabel,
linux-mediatek, linux-arm-kernel, daniel, robh+dt, rex-bc.chen,
dri-devel, Project_Global_Chrome_Upstream_Group, chunkuang.hu,
jitao.shi
On Thu, 31 Mar 2022 19:58:36 +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-06 15:15 ` Rob Herring
0 siblings, 0 replies; 42+ messages in thread
From: Rob Herring @ 2022-04-06 15:15 UTC (permalink / raw)
To: xinlei.lee
Cc: matthias.bgg, devicetree, linux-kernel, airlied, p.zabel,
linux-mediatek, linux-arm-kernel, daniel, robh+dt, rex-bc.chen,
dri-devel, Project_Global_Chrome_Upstream_Group, chunkuang.hu,
jitao.shi
On Thu, 31 Mar 2022 19:58:36 +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
2022-04-06 15:15 ` Rob Herring
(?)
@ 2022-04-07 2:12 ` xinlei.lee
-1 siblings, 0 replies; 42+ messages in thread
From: xinlei.lee @ 2022-04-07 2:12 UTC (permalink / raw)
To: Rob Herring, Rex-BC Chen
Cc: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg, dri-devel,
linux-mediatek, devicetree, linux-kernel, linux-arm-kernel,
Project_Global_Chrome_Upstream_Group, jitao.shi
On Wed, 2022-04-06 at 10:15 -0500, Rob Herring wrote:
> On Fri, Apr 01, 2022 at 09:38:20AM +0800, Rex-BC Chen wrote:
> > On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > > From: Xinlei Lee <xinlei.lee@mediatek.com>
> > >
> > > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> > >
> > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > > ---
> > > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> > > | 1
> > > +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .yam
> > > l
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .yam
> > > l
> > > index dd2896a40ff0..a73044c50b5f 100644
> > > ---
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .yam
> > > l
> > > +++
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .yam
> > > l
> > > @@ -22,6 +22,7 @@ properties:
> > > - mediatek,mt7623-dpi
> > > - mediatek,mt8173-dpi
> > > - mediatek,mt8183-dpi
> > > + - mediatek,mt8186-dpi
> > > - mediatek,mt8192-dpi
> > >
> > > reg:
> >
> > Hello Xinlei,
> >
> > From the dts we use, the dpi node needs other properties for
> > MT8186.
> > Please send another patch and add these properties to binding.
> >
> > assigned-clocks = <&topckgen CLK_TOP_DPI>;
> > assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
>
> Those are always allowed on any node with 'clocks', so no need to
> add
> them here.
>
> Rob
Hi Rob:
Thank you for your review.
I understand your suggestion, and the next version will be sent soon.
Best Regards!
xinlei
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-07 2:12 ` xinlei.lee
0 siblings, 0 replies; 42+ messages in thread
From: xinlei.lee @ 2022-04-07 2:12 UTC (permalink / raw)
To: Rob Herring, Rex-BC Chen
Cc: chunkuang.hu, jitao.shi, devicetree, airlied, linux-kernel,
dri-devel, Project_Global_Chrome_Upstream_Group, linux-mediatek,
matthias.bgg, linux-arm-kernel
On Wed, 2022-04-06 at 10:15 -0500, Rob Herring wrote:
> On Fri, Apr 01, 2022 at 09:38:20AM +0800, Rex-BC Chen wrote:
> > On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > > From: Xinlei Lee <xinlei.lee@mediatek.com>
> > >
> > > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> > >
> > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > > ---
> > > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> > > | 1
> > > +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .yam
> > > l
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .yam
> > > l
> > > index dd2896a40ff0..a73044c50b5f 100644
> > > ---
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .yam
> > > l
> > > +++
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .yam
> > > l
> > > @@ -22,6 +22,7 @@ properties:
> > > - mediatek,mt7623-dpi
> > > - mediatek,mt8173-dpi
> > > - mediatek,mt8183-dpi
> > > + - mediatek,mt8186-dpi
> > > - mediatek,mt8192-dpi
> > >
> > > reg:
> >
> > Hello Xinlei,
> >
> > From the dts we use, the dpi node needs other properties for
> > MT8186.
> > Please send another patch and add these properties to binding.
> >
> > assigned-clocks = <&topckgen CLK_TOP_DPI>;
> > assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
>
> Those are always allowed on any node with 'clocks', so no need to
> add
> them here.
>
> Rob
Hi Rob:
Thank you for your review.
I understand your suggestion, and the next version will be sent soon.
Best Regards!
xinlei
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-07 2:12 ` xinlei.lee
0 siblings, 0 replies; 42+ messages in thread
From: xinlei.lee @ 2022-04-07 2:12 UTC (permalink / raw)
To: Rob Herring, Rex-BC Chen
Cc: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg, dri-devel,
linux-mediatek, devicetree, linux-kernel, linux-arm-kernel,
Project_Global_Chrome_Upstream_Group, jitao.shi
On Wed, 2022-04-06 at 10:15 -0500, Rob Herring wrote:
> On Fri, Apr 01, 2022 at 09:38:20AM +0800, Rex-BC Chen wrote:
> > On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > > From: Xinlei Lee <xinlei.lee@mediatek.com>
> > >
> > > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> > >
> > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > > ---
> > > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> > > | 1
> > > +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .yam
> > > l
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .yam
> > > l
> > > index dd2896a40ff0..a73044c50b5f 100644
> > > ---
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .yam
> > > l
> > > +++
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .yam
> > > l
> > > @@ -22,6 +22,7 @@ properties:
> > > - mediatek,mt7623-dpi
> > > - mediatek,mt8173-dpi
> > > - mediatek,mt8183-dpi
> > > + - mediatek,mt8186-dpi
> > > - mediatek,mt8192-dpi
> > >
> > > reg:
> >
> > Hello Xinlei,
> >
> > From the dts we use, the dpi node needs other properties for
> > MT8186.
> > Please send another patch and add these properties to binding.
> >
> > assigned-clocks = <&topckgen CLK_TOP_DPI>;
> > assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
>
> Those are always allowed on any node with 'clocks', so no need to
> add
> them here.
>
> Rob
Hi Rob:
Thank you for your review.
I understand your suggestion, and the next version will be sent soon.
Best Regards!
xinlei
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 42+ messages in thread
end of thread, other threads:[~2022-04-07 2:13 UTC | newest]
Thread overview: 42+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-31 11:58 [PATCH v2,0/2] Add mt8186 dpi compatiable xinlei.lee
2022-03-31 11:58 ` xinlei.lee
2022-03-31 11:58 ` xinlei.lee
2022-03-31 11:58 ` xinlei.lee
2022-03-31 11:58 ` [PATCH v2, 1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186 xinlei.lee
2022-03-31 11:58 ` xinlei.lee
2022-03-31 11:58 ` xinlei.lee
2022-03-31 11:58 ` [PATCH v2,1/2] " xinlei.lee
2022-04-01 1:38 ` Rex-BC Chen
2022-04-01 1:38 ` Rex-BC Chen
2022-04-01 1:38 ` Rex-BC Chen
2022-04-01 1:38 ` Rex-BC Chen
2022-04-06 6:38 ` CK Hu
2022-04-06 6:38 ` CK Hu
2022-04-06 6:38 ` CK Hu
2022-04-06 6:38 ` CK Hu
2022-04-06 7:08 ` Rex-BC Chen
2022-04-06 7:08 ` Rex-BC Chen
2022-04-06 7:08 ` Rex-BC Chen
2022-04-06 7:08 ` Rex-BC Chen
2022-04-06 15:15 ` Rob Herring
2022-04-06 15:15 ` Rob Herring
2022-04-06 15:15 ` Rob Herring
2022-04-06 15:15 ` Rob Herring
2022-04-07 2:12 ` xinlei.lee
2022-04-07 2:12 ` xinlei.lee
2022-04-07 2:12 ` xinlei.lee
2022-04-06 15:15 ` Rob Herring
2022-04-06 15:15 ` Rob Herring
2022-04-06 15:15 ` Rob Herring
2022-04-06 15:15 ` Rob Herring
2022-03-31 11:58 ` [PATCH v2,2/2] drm/mediatek: Add mt8186 dpi compatible to mtk_dpi.c xinlei.lee
2022-03-31 11:58 ` xinlei.lee
2022-03-31 11:58 ` xinlei.lee
2022-03-31 11:58 ` xinlei.lee
2022-04-06 7:13 ` Rex-BC Chen
2022-04-06 7:13 ` Rex-BC Chen
2022-04-06 7:13 ` Rex-BC Chen
2022-04-06 7:13 ` Rex-BC Chen
2022-04-06 13:44 ` xinlei.lee
2022-04-06 13:44 ` xinlei.lee
2022-04-06 13:44 ` xinlei.lee
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.