* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-01 1:38 ` Rex-BC Chen
0 siblings, 0 replies; 42+ messages in thread
From: Rex-BC Chen @ 2022-04-01 1:38 UTC (permalink / raw)
To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, robh+dt,
matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
jitao.shi
On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1
> +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> l
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> l
> index dd2896a40ff0..a73044c50b5f 100644
> ---
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> l
> +++
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> l
> @@ -22,6 +22,7 @@ properties:
> - mediatek,mt7623-dpi
> - mediatek,mt8173-dpi
> - mediatek,mt8183-dpi
> + - mediatek,mt8186-dpi
> - mediatek,mt8192-dpi
>
> reg:
Hello Xinlei,
From the dts we use, the dpi node needs other properties for MT8186.
Please send another patch and add these properties to binding.
assigned-clocks = <&topckgen CLK_TOP_DPI>;
assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
Thanks
BRs,
Rex
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-01 1:38 ` Rex-BC Chen
0 siblings, 0 replies; 42+ messages in thread
From: Rex-BC Chen @ 2022-04-01 1:38 UTC (permalink / raw)
To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, robh+dt,
matthias.bgg
Cc: devicetree, jitao.shi, linux-kernel, dri-devel,
Project_Global_Chrome_Upstream_Group, linux-mediatek,
linux-arm-kernel
On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1
> +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> l
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> l
> index dd2896a40ff0..a73044c50b5f 100644
> ---
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> l
> +++
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> l
> @@ -22,6 +22,7 @@ properties:
> - mediatek,mt7623-dpi
> - mediatek,mt8173-dpi
> - mediatek,mt8183-dpi
> + - mediatek,mt8186-dpi
> - mediatek,mt8192-dpi
>
> reg:
Hello Xinlei,
From the dts we use, the dpi node needs other properties for MT8186.
Please send another patch and add these properties to binding.
assigned-clocks = <&topckgen CLK_TOP_DPI>;
assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
Thanks
BRs,
Rex
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-01 1:38 ` Rex-BC Chen
0 siblings, 0 replies; 42+ messages in thread
From: Rex-BC Chen @ 2022-04-01 1:38 UTC (permalink / raw)
To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, robh+dt,
matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
jitao.shi
On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1
> +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> l
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> l
> index dd2896a40ff0..a73044c50b5f 100644
> ---
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> l
> +++
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> l
> @@ -22,6 +22,7 @@ properties:
> - mediatek,mt7623-dpi
> - mediatek,mt8173-dpi
> - mediatek,mt8183-dpi
> + - mediatek,mt8186-dpi
> - mediatek,mt8192-dpi
>
> reg:
Hello Xinlei,
From the dts we use, the dpi node needs other properties for MT8186.
Please send another patch and add these properties to binding.
assigned-clocks = <&topckgen CLK_TOP_DPI>;
assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
Thanks
BRs,
Rex
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
2022-04-01 1:38 ` Rex-BC Chen
(?)
(?)
@ 2022-04-06 6:38 ` CK Hu
-1 siblings, 0 replies; 42+ messages in thread
From: CK Hu @ 2022-04-06 6:38 UTC (permalink / raw)
To: Rex-BC Chen, xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel,
robh+dt, matthias.bgg
Cc: devicetree, jitao.shi, linux-kernel, dri-devel,
Project_Global_Chrome_Upstream_Group, linux-mediatek,
linux-arm-kernel
Hi,
On Fri, 2022-04-01 at 09:38 +0800, Rex-BC Chen wrote:
> On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > From: Xinlei Lee <xinlei.lee@mediatek.com>
> >
> > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> >
> > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml |
> > 1
> > +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > index dd2896a40ff0..a73044c50b5f 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > @@ -22,6 +22,7 @@ properties:
> > - mediatek,mt7623-dpi
> > - mediatek,mt8173-dpi
> > - mediatek,mt8183-dpi
> > + - mediatek,mt8186-dpi
> > - mediatek,mt8192-dpi
> >
> > reg:
>
> Hello Xinlei,
>
> From the dts we use, the dpi node needs other properties for MT8186.
> Please send another patch and add these properties to binding.
>
> assigned-clocks = <&topckgen CLK_TOP_DPI>;
> assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
According to [1], the assigned-clocks is initial value. Without this
initial value, I think driver would set this clock again, wouldn't it?
[1]
https://www.kernel.org/doc/Documentation/devicetree/bindings/clock/clock-bindings.txt
Regards,
CK
>
> Thanks
>
> BRs,
> Rex
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
>
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!wtF15QZZTCzWfRpxNLjZ1VQQ54i40D8STuOo0h18dtz3es-ksLfYQGTEFlb7lg$
>
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-06 6:38 ` CK Hu
0 siblings, 0 replies; 42+ messages in thread
From: CK Hu @ 2022-04-06 6:38 UTC (permalink / raw)
To: Rex-BC Chen, xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel,
robh+dt, matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
jitao.shi
Hi,
On Fri, 2022-04-01 at 09:38 +0800, Rex-BC Chen wrote:
> On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > From: Xinlei Lee <xinlei.lee@mediatek.com>
> >
> > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> >
> > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml |
> > 1
> > +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > index dd2896a40ff0..a73044c50b5f 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > @@ -22,6 +22,7 @@ properties:
> > - mediatek,mt7623-dpi
> > - mediatek,mt8173-dpi
> > - mediatek,mt8183-dpi
> > + - mediatek,mt8186-dpi
> > - mediatek,mt8192-dpi
> >
> > reg:
>
> Hello Xinlei,
>
> From the dts we use, the dpi node needs other properties for MT8186.
> Please send another patch and add these properties to binding.
>
> assigned-clocks = <&topckgen CLK_TOP_DPI>;
> assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
According to [1], the assigned-clocks is initial value. Without this
initial value, I think driver would set this clock again, wouldn't it?
[1]
https://www.kernel.org/doc/Documentation/devicetree/bindings/clock/clock-bindings.txt
Regards,
CK
>
> Thanks
>
> BRs,
> Rex
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
>
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!wtF15QZZTCzWfRpxNLjZ1VQQ54i40D8STuOo0h18dtz3es-ksLfYQGTEFlb7lg$
>
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-06 6:38 ` CK Hu
0 siblings, 0 replies; 42+ messages in thread
From: CK Hu @ 2022-04-06 6:38 UTC (permalink / raw)
To: Rex-BC Chen, xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel,
robh+dt, matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
jitao.shi
Hi,
On Fri, 2022-04-01 at 09:38 +0800, Rex-BC Chen wrote:
> On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > From: Xinlei Lee <xinlei.lee@mediatek.com>
> >
> > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> >
> > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml |
> > 1
> > +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > index dd2896a40ff0..a73044c50b5f 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > @@ -22,6 +22,7 @@ properties:
> > - mediatek,mt7623-dpi
> > - mediatek,mt8173-dpi
> > - mediatek,mt8183-dpi
> > + - mediatek,mt8186-dpi
> > - mediatek,mt8192-dpi
> >
> > reg:
>
> Hello Xinlei,
>
> From the dts we use, the dpi node needs other properties for MT8186.
> Please send another patch and add these properties to binding.
>
> assigned-clocks = <&topckgen CLK_TOP_DPI>;
> assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
According to [1], the assigned-clocks is initial value. Without this
initial value, I think driver would set this clock again, wouldn't it?
[1]
https://www.kernel.org/doc/Documentation/devicetree/bindings/clock/clock-bindings.txt
Regards,
CK
>
> Thanks
>
> BRs,
> Rex
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
>
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!wtF15QZZTCzWfRpxNLjZ1VQQ54i40D8STuOo0h18dtz3es-ksLfYQGTEFlb7lg$
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-06 6:38 ` CK Hu
0 siblings, 0 replies; 42+ messages in thread
From: CK Hu @ 2022-04-06 6:38 UTC (permalink / raw)
To: Rex-BC Chen, xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel,
robh+dt, matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
jitao.shi
Hi,
On Fri, 2022-04-01 at 09:38 +0800, Rex-BC Chen wrote:
> On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > From: Xinlei Lee <xinlei.lee@mediatek.com>
> >
> > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> >
> > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml |
> > 1
> > +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > index dd2896a40ff0..a73044c50b5f 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.y
> > am
> > l
> > @@ -22,6 +22,7 @@ properties:
> > - mediatek,mt7623-dpi
> > - mediatek,mt8173-dpi
> > - mediatek,mt8183-dpi
> > + - mediatek,mt8186-dpi
> > - mediatek,mt8192-dpi
> >
> > reg:
>
> Hello Xinlei,
>
> From the dts we use, the dpi node needs other properties for MT8186.
> Please send another patch and add these properties to binding.
>
> assigned-clocks = <&topckgen CLK_TOP_DPI>;
> assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
According to [1], the assigned-clocks is initial value. Without this
initial value, I think driver would set this clock again, wouldn't it?
[1]
https://www.kernel.org/doc/Documentation/devicetree/bindings/clock/clock-bindings.txt
Regards,
CK
>
> Thanks
>
> BRs,
> Rex
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
>
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!wtF15QZZTCzWfRpxNLjZ1VQQ54i40D8STuOo0h18dtz3es-ksLfYQGTEFlb7lg$
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
2022-04-06 6:38 ` CK Hu
(?)
(?)
@ 2022-04-06 7:08 ` Rex-BC Chen
-1 siblings, 0 replies; 42+ messages in thread
From: Rex-BC Chen @ 2022-04-06 7:08 UTC (permalink / raw)
To: CK Hu, xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel,
robh+dt, matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
jitao.shi
On Wed, 2022-04-06 at 14:38 +0800, CK Hu wrote:
> Hi,
>
> On Fri, 2022-04-01 at 09:38 +0800, Rex-BC Chen wrote:
> > On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > > From: Xinlei Lee <xinlei.lee@mediatek.com>
> > >
> > > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> > >
> > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > > ---
> > > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> > > |
> > > 1
> > > +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > index dd2896a40ff0..a73044c50b5f 100644
> > > ---
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > +++
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > @@ -22,6 +22,7 @@ properties:
> > > - mediatek,mt7623-dpi
> > > - mediatek,mt8173-dpi
> > > - mediatek,mt8183-dpi
> > > + - mediatek,mt8186-dpi
> > > - mediatek,mt8192-dpi
> > >
> > > reg:
> >
> > Hello Xinlei,
> >
> > From the dts we use, the dpi node needs other properties for
> > MT8186.
> > Please send another patch and add these properties to binding.
> >
> > assigned-clocks = <&topckgen CLK_TOP_DPI>;
> > assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
>
> According to [1], the assigned-clocks is initial value. Without this
> initial value, I think driver would set this clock again, wouldn't
> it?
>
> [1]
>
https://www.kernel.org/doc/Documentation/devicetree/bindings/clock/clock-bindings.txt
>
> Regards,
> CK
>
Hello CK,
OK, Thanks for your explanation.
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
BRs,
Rex
> >
> > Thanks
> >
> > BRs,
> > Rex
> >
> >
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@lists.infradead.org
> >
>
>
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!wtF15QZZTCzWfRpxNLjZ1VQQ54i40D8STuOo0h18dtz3es-ksLfYQGTEFlb7lg$
> >
>
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-06 7:08 ` Rex-BC Chen
0 siblings, 0 replies; 42+ messages in thread
From: Rex-BC Chen @ 2022-04-06 7:08 UTC (permalink / raw)
To: CK Hu, xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel,
robh+dt, matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
jitao.shi
On Wed, 2022-04-06 at 14:38 +0800, CK Hu wrote:
> Hi,
>
> On Fri, 2022-04-01 at 09:38 +0800, Rex-BC Chen wrote:
> > On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > > From: Xinlei Lee <xinlei.lee@mediatek.com>
> > >
> > > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> > >
> > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > > ---
> > > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> > > |
> > > 1
> > > +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > index dd2896a40ff0..a73044c50b5f 100644
> > > ---
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > +++
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > @@ -22,6 +22,7 @@ properties:
> > > - mediatek,mt7623-dpi
> > > - mediatek,mt8173-dpi
> > > - mediatek,mt8183-dpi
> > > + - mediatek,mt8186-dpi
> > > - mediatek,mt8192-dpi
> > >
> > > reg:
> >
> > Hello Xinlei,
> >
> > From the dts we use, the dpi node needs other properties for
> > MT8186.
> > Please send another patch and add these properties to binding.
> >
> > assigned-clocks = <&topckgen CLK_TOP_DPI>;
> > assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
>
> According to [1], the assigned-clocks is initial value. Without this
> initial value, I think driver would set this clock again, wouldn't
> it?
>
> [1]
>
https://www.kernel.org/doc/Documentation/devicetree/bindings/clock/clock-bindings.txt
>
> Regards,
> CK
>
Hello CK,
OK, Thanks for your explanation.
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
BRs,
Rex
> >
> > Thanks
> >
> > BRs,
> > Rex
> >
> >
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@lists.infradead.org
> >
>
>
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!wtF15QZZTCzWfRpxNLjZ1VQQ54i40D8STuOo0h18dtz3es-ksLfYQGTEFlb7lg$
> >
>
>
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-06 7:08 ` Rex-BC Chen
0 siblings, 0 replies; 42+ messages in thread
From: Rex-BC Chen @ 2022-04-06 7:08 UTC (permalink / raw)
To: CK Hu, xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel,
robh+dt, matthias.bgg
Cc: dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
jitao.shi
On Wed, 2022-04-06 at 14:38 +0800, CK Hu wrote:
> Hi,
>
> On Fri, 2022-04-01 at 09:38 +0800, Rex-BC Chen wrote:
> > On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > > From: Xinlei Lee <xinlei.lee@mediatek.com>
> > >
> > > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> > >
> > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > > ---
> > > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> > > |
> > > 1
> > > +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > index dd2896a40ff0..a73044c50b5f 100644
> > > ---
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > +++
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > @@ -22,6 +22,7 @@ properties:
> > > - mediatek,mt7623-dpi
> > > - mediatek,mt8173-dpi
> > > - mediatek,mt8183-dpi
> > > + - mediatek,mt8186-dpi
> > > - mediatek,mt8192-dpi
> > >
> > > reg:
> >
> > Hello Xinlei,
> >
> > From the dts we use, the dpi node needs other properties for
> > MT8186.
> > Please send another patch and add these properties to binding.
> >
> > assigned-clocks = <&topckgen CLK_TOP_DPI>;
> > assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
>
> According to [1], the assigned-clocks is initial value. Without this
> initial value, I think driver would set this clock again, wouldn't
> it?
>
> [1]
>
https://www.kernel.org/doc/Documentation/devicetree/bindings/clock/clock-bindings.txt
>
> Regards,
> CK
>
Hello CK,
OK, Thanks for your explanation.
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
BRs,
Rex
> >
> > Thanks
> >
> > BRs,
> > Rex
> >
> >
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@lists.infradead.org
> >
>
>
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!wtF15QZZTCzWfRpxNLjZ1VQQ54i40D8STuOo0h18dtz3es-ksLfYQGTEFlb7lg$
> >
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-06 7:08 ` Rex-BC Chen
0 siblings, 0 replies; 42+ messages in thread
From: Rex-BC Chen @ 2022-04-06 7:08 UTC (permalink / raw)
To: CK Hu, xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel,
robh+dt, matthias.bgg
Cc: devicetree, jitao.shi, linux-kernel, dri-devel,
Project_Global_Chrome_Upstream_Group, linux-mediatek,
linux-arm-kernel
On Wed, 2022-04-06 at 14:38 +0800, CK Hu wrote:
> Hi,
>
> On Fri, 2022-04-01 at 09:38 +0800, Rex-BC Chen wrote:
> > On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > > From: Xinlei Lee <xinlei.lee@mediatek.com>
> > >
> > > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> > >
> > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > > ---
> > > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> > > |
> > > 1
> > > +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > index dd2896a40ff0..a73044c50b5f 100644
> > > ---
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > +++
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > @@ -22,6 +22,7 @@ properties:
> > > - mediatek,mt7623-dpi
> > > - mediatek,mt8173-dpi
> > > - mediatek,mt8183-dpi
> > > + - mediatek,mt8186-dpi
> > > - mediatek,mt8192-dpi
> > >
> > > reg:
> >
> > Hello Xinlei,
> >
> > From the dts we use, the dpi node needs other properties for
> > MT8186.
> > Please send another patch and add these properties to binding.
> >
> > assigned-clocks = <&topckgen CLK_TOP_DPI>;
> > assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
>
> According to [1], the assigned-clocks is initial value. Without this
> initial value, I think driver would set this clock again, wouldn't
> it?
>
> [1]
>
https://www.kernel.org/doc/Documentation/devicetree/bindings/clock/clock-bindings.txt
>
> Regards,
> CK
>
Hello CK,
OK, Thanks for your explanation.
Reviewed-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
BRs,
Rex
> >
> > Thanks
> >
> > BRs,
> > Rex
> >
> >
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@lists.infradead.org
> >
>
>
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!wtF15QZZTCzWfRpxNLjZ1VQQ54i40D8STuOo0h18dtz3es-ksLfYQGTEFlb7lg$
> >
>
>
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
2022-04-01 1:38 ` Rex-BC Chen
(?)
(?)
@ 2022-04-06 15:15 ` Rob Herring
-1 siblings, 0 replies; 42+ messages in thread
From: Rob Herring @ 2022-04-06 15:15 UTC (permalink / raw)
To: Rex-BC Chen
Cc: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg,
dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
jitao.shi
On Fri, Apr 01, 2022 at 09:38:20AM +0800, Rex-BC Chen wrote:
> On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > From: Xinlei Lee <xinlei.lee@mediatek.com>
> >
> > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> >
> > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1
> > +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > index dd2896a40ff0..a73044c50b5f 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > @@ -22,6 +22,7 @@ properties:
> > - mediatek,mt7623-dpi
> > - mediatek,mt8173-dpi
> > - mediatek,mt8183-dpi
> > + - mediatek,mt8186-dpi
> > - mediatek,mt8192-dpi
> >
> > reg:
>
> Hello Xinlei,
>
> From the dts we use, the dpi node needs other properties for MT8186.
> Please send another patch and add these properties to binding.
>
> assigned-clocks = <&topckgen CLK_TOP_DPI>;
> assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
Those are always allowed on any node with 'clocks', so no need to add
them here.
Rob
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-06 15:15 ` Rob Herring
0 siblings, 0 replies; 42+ messages in thread
From: Rob Herring @ 2022-04-06 15:15 UTC (permalink / raw)
To: Rex-BC Chen
Cc: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg,
dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
jitao.shi
On Fri, Apr 01, 2022 at 09:38:20AM +0800, Rex-BC Chen wrote:
> On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > From: Xinlei Lee <xinlei.lee@mediatek.com>
> >
> > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> >
> > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1
> > +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > index dd2896a40ff0..a73044c50b5f 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > @@ -22,6 +22,7 @@ properties:
> > - mediatek,mt7623-dpi
> > - mediatek,mt8173-dpi
> > - mediatek,mt8183-dpi
> > + - mediatek,mt8186-dpi
> > - mediatek,mt8192-dpi
> >
> > reg:
>
> Hello Xinlei,
>
> From the dts we use, the dpi node needs other properties for MT8186.
> Please send another patch and add these properties to binding.
>
> assigned-clocks = <&topckgen CLK_TOP_DPI>;
> assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
Those are always allowed on any node with 'clocks', so no need to add
them here.
Rob
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-06 15:15 ` Rob Herring
0 siblings, 0 replies; 42+ messages in thread
From: Rob Herring @ 2022-04-06 15:15 UTC (permalink / raw)
To: Rex-BC Chen
Cc: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg,
dri-devel, linux-mediatek, devicetree, linux-kernel,
linux-arm-kernel, Project_Global_Chrome_Upstream_Group,
jitao.shi
On Fri, Apr 01, 2022 at 09:38:20AM +0800, Rex-BC Chen wrote:
> On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > From: Xinlei Lee <xinlei.lee@mediatek.com>
> >
> > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> >
> > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1
> > +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > index dd2896a40ff0..a73044c50b5f 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > @@ -22,6 +22,7 @@ properties:
> > - mediatek,mt7623-dpi
> > - mediatek,mt8173-dpi
> > - mediatek,mt8183-dpi
> > + - mediatek,mt8186-dpi
> > - mediatek,mt8192-dpi
> >
> > reg:
>
> Hello Xinlei,
>
> From the dts we use, the dpi node needs other properties for MT8186.
> Please send another patch and add these properties to binding.
>
> assigned-clocks = <&topckgen CLK_TOP_DPI>;
> assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
Those are always allowed on any node with 'clocks', so no need to add
them here.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-06 15:15 ` Rob Herring
0 siblings, 0 replies; 42+ messages in thread
From: Rob Herring @ 2022-04-06 15:15 UTC (permalink / raw)
To: Rex-BC Chen
Cc: chunkuang.hu, jitao.shi, xinlei.lee, devicetree, airlied,
linux-kernel, dri-devel, Project_Global_Chrome_Upstream_Group,
linux-mediatek, matthias.bgg, linux-arm-kernel
On Fri, Apr 01, 2022 at 09:38:20AM +0800, Rex-BC Chen wrote:
> On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > From: Xinlei Lee <xinlei.lee@mediatek.com>
> >
> > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> >
> > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml | 1
> > +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > index dd2896a40ff0..a73044c50b5f 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yam
> > l
> > @@ -22,6 +22,7 @@ properties:
> > - mediatek,mt7623-dpi
> > - mediatek,mt8173-dpi
> > - mediatek,mt8183-dpi
> > + - mediatek,mt8186-dpi
> > - mediatek,mt8192-dpi
> >
> > reg:
>
> Hello Xinlei,
>
> From the dts we use, the dpi node needs other properties for MT8186.
> Please send another patch and add these properties to binding.
>
> assigned-clocks = <&topckgen CLK_TOP_DPI>;
> assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
Those are always allowed on any node with 'clocks', so no need to add
them here.
Rob
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
2022-04-06 15:15 ` Rob Herring
(?)
@ 2022-04-07 2:12 ` xinlei.lee
-1 siblings, 0 replies; 42+ messages in thread
From: xinlei.lee @ 2022-04-07 2:12 UTC (permalink / raw)
To: Rob Herring, Rex-BC Chen
Cc: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg, dri-devel,
linux-mediatek, devicetree, linux-kernel, linux-arm-kernel,
Project_Global_Chrome_Upstream_Group, jitao.shi
On Wed, 2022-04-06 at 10:15 -0500, Rob Herring wrote:
> On Fri, Apr 01, 2022 at 09:38:20AM +0800, Rex-BC Chen wrote:
> > On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > > From: Xinlei Lee <xinlei.lee@mediatek.com>
> > >
> > > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> > >
> > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > > ---
> > > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> > > | 1
> > > +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .yam
> > > l
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .yam
> > > l
> > > index dd2896a40ff0..a73044c50b5f 100644
> > > ---
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .yam
> > > l
> > > +++
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .yam
> > > l
> > > @@ -22,6 +22,7 @@ properties:
> > > - mediatek,mt7623-dpi
> > > - mediatek,mt8173-dpi
> > > - mediatek,mt8183-dpi
> > > + - mediatek,mt8186-dpi
> > > - mediatek,mt8192-dpi
> > >
> > > reg:
> >
> > Hello Xinlei,
> >
> > From the dts we use, the dpi node needs other properties for
> > MT8186.
> > Please send another patch and add these properties to binding.
> >
> > assigned-clocks = <&topckgen CLK_TOP_DPI>;
> > assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
>
> Those are always allowed on any node with 'clocks', so no need to
> add
> them here.
>
> Rob
Hi Rob:
Thank you for your review.
I understand your suggestion, and the next version will be sent soon.
Best Regards!
xinlei
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-07 2:12 ` xinlei.lee
0 siblings, 0 replies; 42+ messages in thread
From: xinlei.lee @ 2022-04-07 2:12 UTC (permalink / raw)
To: Rob Herring, Rex-BC Chen
Cc: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg, dri-devel,
linux-mediatek, devicetree, linux-kernel, linux-arm-kernel,
Project_Global_Chrome_Upstream_Group, jitao.shi
On Wed, 2022-04-06 at 10:15 -0500, Rob Herring wrote:
> On Fri, Apr 01, 2022 at 09:38:20AM +0800, Rex-BC Chen wrote:
> > On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > > From: Xinlei Lee <xinlei.lee@mediatek.com>
> > >
> > > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> > >
> > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > > ---
> > > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> > > | 1
> > > +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .yam
> > > l
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .yam
> > > l
> > > index dd2896a40ff0..a73044c50b5f 100644
> > > ---
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .yam
> > > l
> > > +++
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .yam
> > > l
> > > @@ -22,6 +22,7 @@ properties:
> > > - mediatek,mt7623-dpi
> > > - mediatek,mt8173-dpi
> > > - mediatek,mt8183-dpi
> > > + - mediatek,mt8186-dpi
> > > - mediatek,mt8192-dpi
> > >
> > > reg:
> >
> > Hello Xinlei,
> >
> > From the dts we use, the dpi node needs other properties for
> > MT8186.
> > Please send another patch and add these properties to binding.
> >
> > assigned-clocks = <&topckgen CLK_TOP_DPI>;
> > assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
>
> Those are always allowed on any node with 'clocks', so no need to
> add
> them here.
>
> Rob
Hi Rob:
Thank you for your review.
I understand your suggestion, and the next version will be sent soon.
Best Regards!
xinlei
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH v2,1/2] dt-bindings: display: mediatek: dpi: Add compatible for MediaTek MT8186
@ 2022-04-07 2:12 ` xinlei.lee
0 siblings, 0 replies; 42+ messages in thread
From: xinlei.lee @ 2022-04-07 2:12 UTC (permalink / raw)
To: Rob Herring, Rex-BC Chen
Cc: chunkuang.hu, jitao.shi, devicetree, airlied, linux-kernel,
dri-devel, Project_Global_Chrome_Upstream_Group, linux-mediatek,
matthias.bgg, linux-arm-kernel
On Wed, 2022-04-06 at 10:15 -0500, Rob Herring wrote:
> On Fri, Apr 01, 2022 at 09:38:20AM +0800, Rex-BC Chen wrote:
> > On Thu, 2022-03-31 at 19:58 +0800, xinlei.lee@mediatek.com wrote:
> > > From: Xinlei Lee <xinlei.lee@mediatek.com>
> > >
> > > Add dt-binding documentation of dpi for MediaTek MT8186 SoC.
> > >
> > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> > > ---
> > > .../devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> > > | 1
> > > +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .yam
> > > l
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .yam
> > > l
> > > index dd2896a40ff0..a73044c50b5f 100644
> > > ---
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .yam
> > > l
> > > +++
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .yam
> > > l
> > > @@ -22,6 +22,7 @@ properties:
> > > - mediatek,mt7623-dpi
> > > - mediatek,mt8173-dpi
> > > - mediatek,mt8183-dpi
> > > + - mediatek,mt8186-dpi
> > > - mediatek,mt8192-dpi
> > >
> > > reg:
> >
> > Hello Xinlei,
> >
> > From the dts we use, the dpi node needs other properties for
> > MT8186.
> > Please send another patch and add these properties to binding.
> >
> > assigned-clocks = <&topckgen CLK_TOP_DPI>;
> > assigned-clock-parents = <&topckgen CLK_TOP_TVDPLL_D2>;
>
> Those are always allowed on any node with 'clocks', so no need to
> add
> them here.
>
> Rob
Hi Rob:
Thank you for your review.
I understand your suggestion, and the next version will be sent soon.
Best Regards!
xinlei
^ permalink raw reply [flat|nested] 42+ messages in thread