* [linuxtv-media:master 167/207] drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c:319:2: error: implicit declaration of function 'omapdss_unregister_display'
@ 2018-05-04 17:30 kbuild test robot
2018-05-04 20:49 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 16+ messages in thread
From: kbuild test robot @ 2018-05-04 17:30 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: kbuild-all, linux-media
[-- Attachment #1: Type: text/plain, Size: 32280 bytes --]
tree: git://linuxtv.org/media_tree.git master
head: 53dcd70eb710607b2d4085ca91a433cd9feb7b41
commit: 771f7be87ff921e9a3d744febd606af39a150e14 [167/207] media: omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP
config: openrisc-allmodconfig (attached as .config)
compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental)
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 771f7be87ff921e9a3d744febd606af39a150e14
# save the attached .config to linux build tree
make.cross ARCH=openrisc
All errors (new ones prefixed by >>):
drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_init_connections':
>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:8: error: implicit declaration of function 'omapdss_find_mgr_from_display' [-Werror=implicit-function-declaration]
mgr = omapdss_find_mgr_from_display(def_dssdev);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
mgr = omapdss_find_mgr_from_display(def_dssdev);
^
drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_find_default_display':
>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:13: error: implicit declaration of function 'omapdss_get_default_display_name' [-Werror=implicit-function-declaration]
def_name = omapdss_get_default_display_name();
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:11: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
def_name = omapdss_get_default_display_name();
^
cc1: some warnings being treated as errors
--
drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c: In function 'opa362_connect':
drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:45:6: error: implicit declaration of function 'omapdss_device_is_connected' [-Werror=implicit-function-declaration]
if (omapdss_device_is_connected(dssdev))
^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c: In function 'opa362_enable':
>> drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:91:6: error: implicit declaration of function 'omapdss_device_is_enabled' [-Werror=implicit-function-declaration]
if (omapdss_device_is_enabled(dssdev))
^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c: In function 'opa362_probe':
drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:210:7: error: implicit declaration of function 'omapdss_of_find_source_for_first_ep' [-Werror=implicit-function-declaration]
in = omapdss_of_find_source_for_first_ep(node);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:210:5: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
in = omapdss_of_find_source_for_first_ep(node);
^
>> drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:225:6: error: implicit declaration of function 'omapdss_register_output' [-Werror=implicit-function-declaration]
r = omapdss_register_output(dssdev);
^~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c: In function 'opa362_remove':
>> drivers/video/fbdev/omap2/omapfb/displays/encoder-opa362.c:243:2: error: implicit declaration of function 'omapdss_unregister_output' [-Werror=implicit-function-declaration]
omapdss_unregister_output(&ddata->dssdev);
^~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c: In function 'tfp410_connect':
drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c:39:6: error: implicit declaration of function 'omapdss_device_is_connected' [-Werror=implicit-function-declaration]
if (omapdss_device_is_connected(dssdev))
^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c: In function 'tfp410_enable':
>> drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c:81:6: error: implicit declaration of function 'omapdss_device_is_enabled' [-Werror=implicit-function-declaration]
if (omapdss_device_is_enabled(dssdev))
^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c: In function 'tfp410_probe_of':
drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c:184:7: error: implicit declaration of function 'omapdss_of_find_source_for_first_ep' [-Werror=implicit-function-declaration]
in = omapdss_of_find_source_for_first_ep(node);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c:184:5: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
in = omapdss_of_find_source_for_first_ep(node);
^
drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c: In function 'tfp410_probe':
>> drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c:233:6: error: implicit declaration of function 'omapdss_register_output' [-Werror=implicit-function-declaration]
r = omapdss_register_output(dssdev);
^~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c: In function 'tfp410_remove':
>> drivers/video/fbdev/omap2/omapfb/displays/encoder-tfp410.c:252:2: error: implicit declaration of function 'omapdss_unregister_output' [-Werror=implicit-function-declaration]
omapdss_unregister_output(&ddata->dssdev);
^~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
drivers/video/fbdev/omap2/omapfb/displays/encoder-tpd12s015.c: In function 'tpd_probe_of':
drivers/video/fbdev/omap2/omapfb/displays/encoder-tpd12s015.c:208:7: error: implicit declaration of function 'omapdss_of_find_source_for_first_ep' [-Werror=implicit-function-declaration]
in = omapdss_of_find_source_for_first_ep(node);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/encoder-tpd12s015.c:208:5: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
in = omapdss_of_find_source_for_first_ep(node);
^
drivers/video/fbdev/omap2/omapfb/displays/encoder-tpd12s015.c: In function 'tpd_probe':
>> drivers/video/fbdev/omap2/omapfb/displays/encoder-tpd12s015.c:272:6: error: implicit declaration of function 'omapdss_register_output' [-Werror=implicit-function-declaration]
r = omapdss_register_output(dssdev);
^~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/encoder-tpd12s015.c: In function 'tpd_remove':
>> drivers/video/fbdev/omap2/omapfb/displays/encoder-tpd12s015.c:291:2: error: implicit declaration of function 'omapdss_unregister_output' [-Werror=implicit-function-declaration]
omapdss_unregister_output(&ddata->dssdev);
^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ./arch/openrisc/include/generated/asm/bug.h:1:0,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/preempt.h:5,
from ./arch/openrisc/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:81,
from include/linux/spinlock.h:51,
from include/linux/wait.h:9,
from include/linux/completion.h:12,
from drivers/video/fbdev/omap2/omapfb/displays/encoder-tpd12s015.c:12:
>> drivers/video/fbdev/omap2/omapfb/displays/encoder-tpd12s015.c:293:10: error: implicit declaration of function 'omapdss_device_is_enabled' [-Werror=implicit-function-declaration]
WARN_ON(omapdss_device_is_enabled(dssdev));
^
include/asm-generic/bug.h:112:25: note: in definition of macro 'WARN_ON'
int __ret_warn_on = !!(condition); \
^~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/encoder-tpd12s015.c:297:10: error: implicit declaration of function 'omapdss_device_is_connected' [-Werror=implicit-function-declaration]
WARN_ON(omapdss_device_is_connected(dssdev));
^
include/asm-generic/bug.h:112:25: note: in definition of macro 'WARN_ON'
int __ret_warn_on = !!(condition); \
^~~~~~~~~
cc1: some warnings being treated as errors
--
drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c: In function 'dvic_connect':
drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c:59:6: error: implicit declaration of function 'omapdss_device_is_connected' [-Werror=implicit-function-declaration]
if (omapdss_device_is_connected(dssdev))
^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c: In function 'dvic_enable':
>> drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c:89:6: error: implicit declaration of function 'omapdss_device_is_enabled' [-Werror=implicit-function-declaration]
if (omapdss_device_is_enabled(dssdev))
^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c: At top level:
>> drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c:232:20: error: 'omapdss_default_get_resolution' undeclared here (not in a function)
.get_resolution = omapdss_default_get_resolution,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c: In function 'dvic_probe_of':
drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c:246:7: error: implicit declaration of function 'omapdss_of_find_source_for_first_ep' [-Werror=implicit-function-declaration]
in = omapdss_of_find_source_for_first_ep(node);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c:246:5: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
in = omapdss_of_find_source_for_first_ep(node);
^
drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c: In function 'dvic_probe':
>> drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c:297:6: error: implicit declaration of function 'omapdss_register_display' [-Werror=implicit-function-declaration]
r = omapdss_register_display(dssdev);
^~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c: In function 'dvic_remove':
>> drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c:319:2: error: implicit declaration of function 'omapdss_unregister_display' [-Werror=implicit-function-declaration]
omapdss_unregister_display(&ddata->dssdev);
^~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c: In function 'hdmic_connect':
drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c:60:6: error: implicit declaration of function 'omapdss_device_is_connected' [-Werror=implicit-function-declaration]
if (omapdss_device_is_connected(dssdev))
^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c: In function 'hdmic_enable':
>> drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c:94:6: error: implicit declaration of function 'omapdss_device_is_enabled' [-Werror=implicit-function-declaration]
if (omapdss_device_is_enabled(dssdev))
^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c: At top level:
>> drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c:200:21: error: 'omapdss_default_get_resolution' undeclared here (not in a function)
.get_resolution = omapdss_default_get_resolution,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c: In function 'hdmic_probe_of':
drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c:222:7: error: implicit declaration of function 'omapdss_of_find_source_for_first_ep' [-Werror=implicit-function-declaration]
in = omapdss_of_find_source_for_first_ep(node);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c:222:5: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
in = omapdss_of_find_source_for_first_ep(node);
^
drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c: In function 'hdmic_probe':
>> drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c:269:6: error: implicit declaration of function 'omapdss_register_display' [-Werror=implicit-function-declaration]
r = omapdss_register_display(dssdev);
^~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c: In function 'hdmic_remove':
>> drivers/video/fbdev/omap2/omapfb/displays/connector-hdmi.c:287:2: error: implicit declaration of function 'omapdss_unregister_display' [-Werror=implicit-function-declaration]
omapdss_unregister_display(&ddata->dssdev);
^~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c: In function 'tvc_connect':
drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c:57:6: error: implicit declaration of function 'omapdss_device_is_connected' [-Werror=implicit-function-declaration]
if (omapdss_device_is_connected(dssdev))
^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c: In function 'tvc_enable':
>> drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c:91:6: error: implicit declaration of function 'omapdss_device_is_enabled' [-Werror=implicit-function-declaration]
if (omapdss_device_is_enabled(dssdev))
^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c: At top level:
>> drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c:183:21: error: 'omapdss_default_get_resolution' undeclared here (not in a function)
.get_resolution = omapdss_default_get_resolution,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c: In function 'tvc_probe_pdata':
>> drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c:197:7: error: implicit declaration of function 'omap_dss_find_output' [-Werror=implicit-function-declaration]
in = omap_dss_find_output(pdata->source);
^~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c:197:5: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
in = omap_dss_find_output(pdata->source);
^
drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c: In function 'tvc_probe_of':
drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c:219:7: error: implicit declaration of function 'omapdss_of_find_source_for_first_ep' [-Werror=implicit-function-declaration]
in = omapdss_of_find_source_for_first_ep(node);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c:219:5: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
in = omapdss_of_find_source_for_first_ep(node);
^
drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c: In function 'tvc_probe':
>> drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c:264:6: error: implicit declaration of function 'omapdss_register_display' [-Werror=implicit-function-declaration]
r = omapdss_register_display(dssdev);
^~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c: In function 'tvc_remove':
>> drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c:282:2: error: implicit declaration of function 'omapdss_unregister_display' [-Werror=implicit-function-declaration]
omapdss_unregister_display(&ddata->dssdev);
^~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c: In function 'panel_dpi_connect':
drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c:45:6: error: implicit declaration of function 'omapdss_device_is_connected' [-Werror=implicit-function-declaration]
if (omapdss_device_is_connected(dssdev))
^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c: In function 'panel_dpi_enable':
>> drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c:75:6: error: implicit declaration of function 'omapdss_device_is_enabled' [-Werror=implicit-function-declaration]
if (omapdss_device_is_enabled(dssdev))
^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c: At top level:
>> drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c:154:20: error: 'omapdss_default_get_resolution' undeclared here (not in a function)
.get_resolution = omapdss_default_get_resolution,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c: In function 'panel_dpi_probe_pdata':
>> drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c:167:7: error: implicit declaration of function 'omap_dss_find_output' [-Werror=implicit-function-declaration]
in = omap_dss_find_output(pdata->source);
^~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c:167:5: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
in = omap_dss_find_output(pdata->source);
^
>> drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c:179:2: error: implicit declaration of function 'videomode_to_omap_video_timings' [-Werror=implicit-function-declaration]
videomode_to_omap_video_timings(&vm, &ddata->videomode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c: In function 'panel_dpi_probe_of':
drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c:227:7: error: implicit declaration of function 'omapdss_of_find_source_for_first_ep' [-Werror=implicit-function-declaration]
in = omapdss_of_find_source_for_first_ep(node);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c:227:5: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
in = omapdss_of_find_source_for_first_ep(node);
^
drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c: In function 'panel_dpi_probe':
>> drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c:277:6: error: implicit declaration of function 'omapdss_register_display' [-Werror=implicit-function-declaration]
r = omapdss_register_display(dssdev);
^~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c: In function 'panel_dpi_remove':
>> drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c:297:2: error: implicit declaration of function 'omapdss_unregister_display' [-Werror=implicit-function-declaration]
omapdss_unregister_display(dssdev);
^~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c: In function 'dsicm_connect':
drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c:715:6: error: implicit declaration of function 'omapdss_device_is_connected' [-Werror=implicit-function-declaration]
if (omapdss_device_is_connected(dssdev))
^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c: In function 'dsicm_enable':
>> drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c:772:6: error: implicit declaration of function 'omapdss_device_is_enabled' [-Werror=implicit-function-declaration]
if (omapdss_device_is_enabled(dssdev)) {
^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c: At top level:
drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c:1119:25: error: 'omapdss_default_get_recommended_bpp' undeclared here (not in a function)
.get_recommended_bpp = omapdss_default_get_recommended_bpp,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c: In function 'dsicm_probe_of':
drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c:1149:7: error: implicit declaration of function 'omapdss_of_find_source_for_first_ep' [-Werror=implicit-function-declaration]
in = omapdss_of_find_source_for_first_ep(node);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c:1149:5: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
in = omapdss_of_find_source_for_first_ep(node);
^
drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c: In function 'dsicm_probe':
>> drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c:1202:6: error: implicit declaration of function 'omapdss_register_display' [-Werror=implicit-function-declaration]
r = omapdss_register_display(dssdev);
^~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c: In function 'dsicm_remove':
>> drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c:1293:2: error: implicit declaration of function 'omapdss_unregister_display' [-Werror=implicit-function-declaration]
omapdss_unregister_display(dssdev);
^~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c: In function 'acx565akm_connect':
drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c:522:6: error: implicit declaration of function 'omapdss_device_is_connected' [-Werror=implicit-function-declaration]
if (omapdss_device_is_connected(dssdev))
^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c: In function 'acx565akm_enable':
>> drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c:634:6: error: implicit declaration of function 'omapdss_device_is_enabled' [-Werror=implicit-function-declaration]
if (omapdss_device_is_enabled(dssdev))
^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c: At top level:
>> drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c:704:20: error: 'omapdss_default_get_resolution' undeclared here (not in a function)
.get_resolution = omapdss_default_get_resolution,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c: In function 'acx565akm_probe_pdata':
>> drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c:717:7: error: implicit declaration of function 'omap_dss_find_output' [-Werror=implicit-function-declaration]
in = omap_dss_find_output(pdata->source);
^~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c:717:5: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
in = omap_dss_find_output(pdata->source);
^
drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c: In function 'acx565akm_probe_of':
drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c:740:14: error: implicit declaration of function 'omapdss_of_find_source_for_first_ep' [-Werror=implicit-function-declaration]
ddata->in = omapdss_of_find_source_for_first_ep(np);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c:740:12: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
ddata->in = omapdss_of_find_source_for_first_ep(np);
^
drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c: In function 'acx565akm_probe':
>> drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c:857:6: error: implicit declaration of function 'omapdss_register_display' [-Werror=implicit-function-declaration]
r = omapdss_register_display(dssdev);
^~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c: In function 'acx565akm_remove':
>> drivers/video/fbdev/omap2/omapfb/displays/panel-sony-acx565akm.c:887:2: error: implicit declaration of function 'omapdss_unregister_display' [-Werror=implicit-function-declaration]
omapdss_unregister_display(dssdev);
^~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
..
vim +/omapdss_unregister_display +319 drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c
f76ee892 Tomi Valkeinen 2015-12-09 220
f76ee892 Tomi Valkeinen 2015-12-09 221 static struct omap_dss_driver dvic_driver = {
f76ee892 Tomi Valkeinen 2015-12-09 222 .connect = dvic_connect,
f76ee892 Tomi Valkeinen 2015-12-09 223 .disconnect = dvic_disconnect,
f76ee892 Tomi Valkeinen 2015-12-09 224
f76ee892 Tomi Valkeinen 2015-12-09 225 .enable = dvic_enable,
f76ee892 Tomi Valkeinen 2015-12-09 226 .disable = dvic_disable,
f76ee892 Tomi Valkeinen 2015-12-09 227
f76ee892 Tomi Valkeinen 2015-12-09 228 .set_timings = dvic_set_timings,
f76ee892 Tomi Valkeinen 2015-12-09 229 .get_timings = dvic_get_timings,
f76ee892 Tomi Valkeinen 2015-12-09 230 .check_timings = dvic_check_timings,
f76ee892 Tomi Valkeinen 2015-12-09 231
f76ee892 Tomi Valkeinen 2015-12-09 @232 .get_resolution = omapdss_default_get_resolution,
f76ee892 Tomi Valkeinen 2015-12-09 233
f76ee892 Tomi Valkeinen 2015-12-09 234 .read_edid = dvic_read_edid,
f76ee892 Tomi Valkeinen 2015-12-09 235 .detect = dvic_detect,
f76ee892 Tomi Valkeinen 2015-12-09 236 };
f76ee892 Tomi Valkeinen 2015-12-09 237
f76ee892 Tomi Valkeinen 2015-12-09 238 static int dvic_probe_of(struct platform_device *pdev)
f76ee892 Tomi Valkeinen 2015-12-09 239 {
f76ee892 Tomi Valkeinen 2015-12-09 240 struct panel_drv_data *ddata = platform_get_drvdata(pdev);
f76ee892 Tomi Valkeinen 2015-12-09 241 struct device_node *node = pdev->dev.of_node;
f76ee892 Tomi Valkeinen 2015-12-09 242 struct omap_dss_device *in;
f76ee892 Tomi Valkeinen 2015-12-09 243 struct device_node *adapter_node;
f76ee892 Tomi Valkeinen 2015-12-09 244 struct i2c_adapter *adapter;
f76ee892 Tomi Valkeinen 2015-12-09 245
f76ee892 Tomi Valkeinen 2015-12-09 @246 in = omapdss_of_find_source_for_first_ep(node);
f76ee892 Tomi Valkeinen 2015-12-09 247 if (IS_ERR(in)) {
f76ee892 Tomi Valkeinen 2015-12-09 248 dev_err(&pdev->dev, "failed to find video source\n");
f76ee892 Tomi Valkeinen 2015-12-09 249 return PTR_ERR(in);
f76ee892 Tomi Valkeinen 2015-12-09 250 }
f76ee892 Tomi Valkeinen 2015-12-09 251
f76ee892 Tomi Valkeinen 2015-12-09 252 ddata->in = in;
f76ee892 Tomi Valkeinen 2015-12-09 253
f76ee892 Tomi Valkeinen 2015-12-09 254 adapter_node = of_parse_phandle(node, "ddc-i2c-bus", 0);
f76ee892 Tomi Valkeinen 2015-12-09 255 if (adapter_node) {
f76ee892 Tomi Valkeinen 2015-12-09 256 adapter = of_get_i2c_adapter_by_node(adapter_node);
f76ee892 Tomi Valkeinen 2015-12-09 257 if (adapter == NULL) {
f76ee892 Tomi Valkeinen 2015-12-09 258 dev_err(&pdev->dev, "failed to parse ddc-i2c-bus\n");
f76ee892 Tomi Valkeinen 2015-12-09 259 omap_dss_put_device(ddata->in);
f76ee892 Tomi Valkeinen 2015-12-09 260 return -EPROBE_DEFER;
f76ee892 Tomi Valkeinen 2015-12-09 261 }
f76ee892 Tomi Valkeinen 2015-12-09 262
f76ee892 Tomi Valkeinen 2015-12-09 263 ddata->i2c_adapter = adapter;
f76ee892 Tomi Valkeinen 2015-12-09 264 }
f76ee892 Tomi Valkeinen 2015-12-09 265
f76ee892 Tomi Valkeinen 2015-12-09 266 return 0;
f76ee892 Tomi Valkeinen 2015-12-09 267 }
f76ee892 Tomi Valkeinen 2015-12-09 268
f76ee892 Tomi Valkeinen 2015-12-09 269 static int dvic_probe(struct platform_device *pdev)
f76ee892 Tomi Valkeinen 2015-12-09 270 {
f76ee892 Tomi Valkeinen 2015-12-09 271 struct panel_drv_data *ddata;
f76ee892 Tomi Valkeinen 2015-12-09 272 struct omap_dss_device *dssdev;
f76ee892 Tomi Valkeinen 2015-12-09 273 int r;
f76ee892 Tomi Valkeinen 2015-12-09 274
5996a5ae Peter Ujfalusi 2016-05-26 275 if (!pdev->dev.of_node)
5996a5ae Peter Ujfalusi 2016-05-26 276 return -ENODEV;
5996a5ae Peter Ujfalusi 2016-05-26 277
f76ee892 Tomi Valkeinen 2015-12-09 278 ddata = devm_kzalloc(&pdev->dev, sizeof(*ddata), GFP_KERNEL);
f76ee892 Tomi Valkeinen 2015-12-09 279 if (!ddata)
f76ee892 Tomi Valkeinen 2015-12-09 280 return -ENOMEM;
f76ee892 Tomi Valkeinen 2015-12-09 281
f76ee892 Tomi Valkeinen 2015-12-09 282 platform_set_drvdata(pdev, ddata);
f76ee892 Tomi Valkeinen 2015-12-09 283
f76ee892 Tomi Valkeinen 2015-12-09 284 r = dvic_probe_of(pdev);
f76ee892 Tomi Valkeinen 2015-12-09 285 if (r)
f76ee892 Tomi Valkeinen 2015-12-09 286 return r;
f76ee892 Tomi Valkeinen 2015-12-09 287
f76ee892 Tomi Valkeinen 2015-12-09 288 ddata->timings = dvic_default_timings;
f76ee892 Tomi Valkeinen 2015-12-09 289
f76ee892 Tomi Valkeinen 2015-12-09 290 dssdev = &ddata->dssdev;
f76ee892 Tomi Valkeinen 2015-12-09 291 dssdev->driver = &dvic_driver;
f76ee892 Tomi Valkeinen 2015-12-09 292 dssdev->dev = &pdev->dev;
f76ee892 Tomi Valkeinen 2015-12-09 293 dssdev->type = OMAP_DISPLAY_TYPE_DVI;
f76ee892 Tomi Valkeinen 2015-12-09 294 dssdev->owner = THIS_MODULE;
f76ee892 Tomi Valkeinen 2015-12-09 295 dssdev->panel.timings = dvic_default_timings;
f76ee892 Tomi Valkeinen 2015-12-09 296
f76ee892 Tomi Valkeinen 2015-12-09 @297 r = omapdss_register_display(dssdev);
f76ee892 Tomi Valkeinen 2015-12-09 298 if (r) {
f76ee892 Tomi Valkeinen 2015-12-09 299 dev_err(&pdev->dev, "Failed to register panel\n");
f76ee892 Tomi Valkeinen 2015-12-09 300 goto err_reg;
f76ee892 Tomi Valkeinen 2015-12-09 301 }
f76ee892 Tomi Valkeinen 2015-12-09 302
f76ee892 Tomi Valkeinen 2015-12-09 303 return 0;
f76ee892 Tomi Valkeinen 2015-12-09 304
f76ee892 Tomi Valkeinen 2015-12-09 305 err_reg:
f76ee892 Tomi Valkeinen 2015-12-09 306 omap_dss_put_device(ddata->in);
f76ee892 Tomi Valkeinen 2015-12-09 307
f76ee892 Tomi Valkeinen 2015-12-09 308 i2c_put_adapter(ddata->i2c_adapter);
f76ee892 Tomi Valkeinen 2015-12-09 309
f76ee892 Tomi Valkeinen 2015-12-09 310 return r;
f76ee892 Tomi Valkeinen 2015-12-09 311 }
f76ee892 Tomi Valkeinen 2015-12-09 312
f76ee892 Tomi Valkeinen 2015-12-09 313 static int __exit dvic_remove(struct platform_device *pdev)
f76ee892 Tomi Valkeinen 2015-12-09 314 {
f76ee892 Tomi Valkeinen 2015-12-09 315 struct panel_drv_data *ddata = platform_get_drvdata(pdev);
f76ee892 Tomi Valkeinen 2015-12-09 316 struct omap_dss_device *dssdev = &ddata->dssdev;
f76ee892 Tomi Valkeinen 2015-12-09 317 struct omap_dss_device *in = ddata->in;
f76ee892 Tomi Valkeinen 2015-12-09 318
f76ee892 Tomi Valkeinen 2015-12-09 @319 omapdss_unregister_display(&ddata->dssdev);
f76ee892 Tomi Valkeinen 2015-12-09 320
f76ee892 Tomi Valkeinen 2015-12-09 321 dvic_disable(dssdev);
f76ee892 Tomi Valkeinen 2015-12-09 322 dvic_disconnect(dssdev);
f76ee892 Tomi Valkeinen 2015-12-09 323
f76ee892 Tomi Valkeinen 2015-12-09 324 omap_dss_put_device(in);
f76ee892 Tomi Valkeinen 2015-12-09 325
f76ee892 Tomi Valkeinen 2015-12-09 326 i2c_put_adapter(ddata->i2c_adapter);
f76ee892 Tomi Valkeinen 2015-12-09 327
f76ee892 Tomi Valkeinen 2015-12-09 328 return 0;
f76ee892 Tomi Valkeinen 2015-12-09 329 }
f76ee892 Tomi Valkeinen 2015-12-09 330
:::::: The code at line 319 was first introduced by commit
:::::: f76ee892a99e68b55402b8d4b8aeffcae2aff34d omapfb: copy omapdss & displays for omapfb
:::::: TO: Tomi Valkeinen <tomi.valkeinen@ti.com>
:::::: CC: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 44890 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH] media: include/video/omapfb_dss.h: use IS_ENABLED()
2018-05-04 17:30 [linuxtv-media:master 167/207] drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c:319:2: error: implicit declaration of function 'omapdss_unregister_display' kbuild test robot
2018-05-04 20:49 ` Mauro Carvalho Chehab
@ 2018-05-04 20:49 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 16+ messages in thread
From: Mauro Carvalho Chehab @ 2018-05-04 20:49 UTC (permalink / raw)
Cc: Mauro Carvalho Chehab, Linux Media Mailing List,
Mauro Carvalho Chehab, Bartlomiej Zolnierkiewicz, dri-devel,
linux-fbdev, Randy Dunlap, tomi.valkeinen, linux-omap
Just checking for ifdefs cause build issues as reported by
kernel test:
config: openrisc-allmodconfig (attached as .config)
compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental)
All errors (new ones prefixed by >>):
drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_init_connections':
>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:8: error: implicit declaration of function 'omapdss_find_mgr_from_display' [-Werror=implicit-function-declaration]
mgr = omapdss_find_mgr_from_display(def_dssdev);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
mgr = omapdss_find_mgr_from_display(def_dssdev);
^
drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_find_default_display':
>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:13: error: implicit declaration of function 'omapdss_get_default_display_name' [-Werror=implicit-function-declaration]
def_name = omapdss_get_default_display_name();
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:11: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
def_name = omapdss_get_default_display_name();
^
So, use IS_ENABLED() instead.
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: tomi.valkeinen@ti.com
Cc: linux-omap@vger.kernel.org
Cc: linux-fbdev@vger.kernel.org
Fixes: 771f7be87ff9 ("media: omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP")
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
---
include/video/omapfb_dss.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/video/omapfb_dss.h b/include/video/omapfb_dss.h
index e9775144ff3b..12755d8d9b4f 100644
--- a/include/video/omapfb_dss.h
+++ b/include/video/omapfb_dss.h
@@ -778,7 +778,7 @@ struct omap_dss_driver {
typedef void (*omap_dispc_isr_t) (void *arg, u32 mask);
-#ifdef CONFIG_FB_OMAP2
+#if IS_ENABLED(CONFIG_FB_OMAP2)
enum omapdss_version omapdss_get_version(void);
bool omapdss_is_initialized(void);
--
2.17.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH] media: include/video/omapfb_dss.h: use IS_ENABLED()
@ 2018-05-04 20:49 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 16+ messages in thread
From: Mauro Carvalho Chehab @ 2018-05-04 20:49 UTC (permalink / raw)
Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, Randy Dunlap, dri-devel,
Mauro Carvalho Chehab, tomi.valkeinen, Mauro Carvalho Chehab,
linux-omap, Linux Media Mailing List
Just checking for ifdefs cause build issues as reported by
kernel test:
config: openrisc-allmodconfig (attached as .config)
compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental)
All errors (new ones prefixed by >>):
drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_init_connections':
>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:8: error: implicit declaration of function 'omapdss_find_mgr_from_display' [-Werror=implicit-function-declaration]
mgr = omapdss_find_mgr_from_display(def_dssdev);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
mgr = omapdss_find_mgr_from_display(def_dssdev);
^
drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_find_default_display':
>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:13: error: implicit declaration of function 'omapdss_get_default_display_name' [-Werror=implicit-function-declaration]
def_name = omapdss_get_default_display_name();
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:11: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
def_name = omapdss_get_default_display_name();
^
So, use IS_ENABLED() instead.
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: tomi.valkeinen@ti.com
Cc: linux-omap@vger.kernel.org
Cc: linux-fbdev@vger.kernel.org
Fixes: 771f7be87ff9 ("media: omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP")
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
---
include/video/omapfb_dss.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/video/omapfb_dss.h b/include/video/omapfb_dss.h
index e9775144ff3b..12755d8d9b4f 100644
--- a/include/video/omapfb_dss.h
+++ b/include/video/omapfb_dss.h
@@ -778,7 +778,7 @@ struct omap_dss_driver {
typedef void (*omap_dispc_isr_t) (void *arg, u32 mask);
-#ifdef CONFIG_FB_OMAP2
+#if IS_ENABLED(CONFIG_FB_OMAP2)
enum omapdss_version omapdss_get_version(void);
bool omapdss_is_initialized(void);
--
2.17.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH] media: include/video/omapfb_dss.h: use IS_ENABLED()
@ 2018-05-04 20:49 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 16+ messages in thread
From: Mauro Carvalho Chehab @ 2018-05-04 20:49 UTC (permalink / raw)
Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, Randy Dunlap, dri-devel,
Mauro Carvalho Chehab, tomi.valkeinen, Mauro Carvalho Chehab,
linux-omap, Linux Media Mailing List
Just checking for ifdefs cause build issues as reported by
kernel test:
config: openrisc-allmodconfig (attached as .config)
compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental)
All errors (new ones prefixed by >>):
drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_init_connections':
>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:8: error: implicit declaration of function 'omapdss_find_mgr_from_display' [-Werror=implicit-function-declaration]
mgr = omapdss_find_mgr_from_display(def_dssdev);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
mgr = omapdss_find_mgr_from_display(def_dssdev);
^
drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_find_default_display':
>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:13: error: implicit declaration of function 'omapdss_get_default_display_name' [-Werror=implicit-function-declaration]
def_name = omapdss_get_default_display_name();
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:11: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
def_name = omapdss_get_default_display_name();
^
So, use IS_ENABLED() instead.
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: tomi.valkeinen@ti.com
Cc: linux-omap@vger.kernel.org
Cc: linux-fbdev@vger.kernel.org
Fixes: 771f7be87ff9 ("media: omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP")
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
---
include/video/omapfb_dss.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/video/omapfb_dss.h b/include/video/omapfb_dss.h
index e9775144ff3b..12755d8d9b4f 100644
--- a/include/video/omapfb_dss.h
+++ b/include/video/omapfb_dss.h
@@ -778,7 +778,7 @@ struct omap_dss_driver {
typedef void (*omap_dispc_isr_t) (void *arg, u32 mask);
-#ifdef CONFIG_FB_OMAP2
+#if IS_ENABLED(CONFIG_FB_OMAP2)
enum omapdss_version omapdss_get_version(void);
bool omapdss_is_initialized(void);
--
2.17.0
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH] media: include/video/omapfb_dss.h: use IS_ENABLED()
2018-05-04 20:49 ` Mauro Carvalho Chehab
(?)
@ 2018-05-05 17:59 ` Randy Dunlap
-1 siblings, 0 replies; 16+ messages in thread
From: Randy Dunlap @ 2018-05-05 17:59 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Linux Media Mailing List, Mauro Carvalho Chehab,
Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev,
tomi.valkeinen, linux-omap
On 05/04/2018 01:49 PM, Mauro Carvalho Chehab wrote:
> Just checking for ifdefs cause build issues as reported by
> kernel test:
>
> config: openrisc-allmodconfig (attached as .config)
> compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental)
>
> All errors (new ones prefixed by >>):
>
> drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_init_connections':
>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:8: error: implicit declaration of function 'omapdss_find_mgr_from_display' [-Werror=implicit-function-declaration]
> mgr = omapdss_find_mgr_from_display(def_dssdev);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> mgr = omapdss_find_mgr_from_display(def_dssdev);
> ^
> drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_find_default_display':
>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:13: error: implicit declaration of function 'omapdss_get_default_display_name' [-Werror=implicit-function-declaration]
> def_name = omapdss_get_default_display_name();
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:11: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> def_name = omapdss_get_default_display_name();
> ^
>
> So, use IS_ENABLED() instead.
Hi,
I would like to test this (the change doesn't make much sense to me),
but I cannot find the kernel config file nor the kernel test robot's
email of this report.
Please include an lkml.kernel.org/r/<message_id> reference to such emails
so that interested parties can join the party.
Does this patch apply only to your media tree? so hopefully I can see it in
linux-next on Monday.
Thanks.
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Cc: tomi.valkeinen@ti.com
> Cc: linux-omap@vger.kernel.org
> Cc: linux-fbdev@vger.kernel.org
> Fixes: 771f7be87ff9 ("media: omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP")
> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> ---
> include/video/omapfb_dss.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/video/omapfb_dss.h b/include/video/omapfb_dss.h
> index e9775144ff3b..12755d8d9b4f 100644
> --- a/include/video/omapfb_dss.h
> +++ b/include/video/omapfb_dss.h
> @@ -778,7 +778,7 @@ struct omap_dss_driver {
>
> typedef void (*omap_dispc_isr_t) (void *arg, u32 mask);
>
> -#ifdef CONFIG_FB_OMAP2
> +#if IS_ENABLED(CONFIG_FB_OMAP2)
>
> enum omapdss_version omapdss_get_version(void);
> bool omapdss_is_initialized(void);
>
--
~Randy
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH] media: include/video/omapfb_dss.h: use IS_ENABLED()
@ 2018-05-05 17:59 ` Randy Dunlap
0 siblings, 0 replies; 16+ messages in thread
From: Randy Dunlap @ 2018-05-05 17:59 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, dri-devel,
Mauro Carvalho Chehab, tomi.valkeinen, linux-omap,
Linux Media Mailing List
On 05/04/2018 01:49 PM, Mauro Carvalho Chehab wrote:
> Just checking for ifdefs cause build issues as reported by
> kernel test:
>
> config: openrisc-allmodconfig (attached as .config)
> compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental)
>
> All errors (new ones prefixed by >>):
>
> drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_init_connections':
>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:8: error: implicit declaration of function 'omapdss_find_mgr_from_display' [-Werror=implicit-function-declaration]
> mgr = omapdss_find_mgr_from_display(def_dssdev);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> mgr = omapdss_find_mgr_from_display(def_dssdev);
> ^
> drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_find_default_display':
>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:13: error: implicit declaration of function 'omapdss_get_default_display_name' [-Werror=implicit-function-declaration]
> def_name = omapdss_get_default_display_name();
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:11: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> def_name = omapdss_get_default_display_name();
> ^
>
> So, use IS_ENABLED() instead.
Hi,
I would like to test this (the change doesn't make much sense to me),
but I cannot find the kernel config file nor the kernel test robot's
email of this report.
Please include an lkml.kernel.org/r/<message_id> reference to such emails
so that interested parties can join the party.
Does this patch apply only to your media tree? so hopefully I can see it in
linux-next on Monday.
Thanks.
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Cc: tomi.valkeinen@ti.com
> Cc: linux-omap@vger.kernel.org
> Cc: linux-fbdev@vger.kernel.org
> Fixes: 771f7be87ff9 ("media: omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP")
> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> ---
> include/video/omapfb_dss.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/video/omapfb_dss.h b/include/video/omapfb_dss.h
> index e9775144ff3b..12755d8d9b4f 100644
> --- a/include/video/omapfb_dss.h
> +++ b/include/video/omapfb_dss.h
> @@ -778,7 +778,7 @@ struct omap_dss_driver {
>
> typedef void (*omap_dispc_isr_t) (void *arg, u32 mask);
>
> -#ifdef CONFIG_FB_OMAP2
> +#if IS_ENABLED(CONFIG_FB_OMAP2)
>
> enum omapdss_version omapdss_get_version(void);
> bool omapdss_is_initialized(void);
>
--
~Randy
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH] media: include/video/omapfb_dss.h: use IS_ENABLED()
@ 2018-05-05 17:59 ` Randy Dunlap
0 siblings, 0 replies; 16+ messages in thread
From: Randy Dunlap @ 2018-05-05 17:59 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, dri-devel,
Mauro Carvalho Chehab, tomi.valkeinen, linux-omap,
Linux Media Mailing List
On 05/04/2018 01:49 PM, Mauro Carvalho Chehab wrote:
> Just checking for ifdefs cause build issues as reported by
> kernel test:
>
> config: openrisc-allmodconfig (attached as .config)
> compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental)
>
> All errors (new ones prefixed by >>):
>
> drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_init_connections':
>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:8: error: implicit declaration of function 'omapdss_find_mgr_from_display' [-Werror=implicit-function-declaration]
> mgr = omapdss_find_mgr_from_display(def_dssdev);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> mgr = omapdss_find_mgr_from_display(def_dssdev);
> ^
> drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_find_default_display':
>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:13: error: implicit declaration of function 'omapdss_get_default_display_name' [-Werror=implicit-function-declaration]
> def_name = omapdss_get_default_display_name();
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:11: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> def_name = omapdss_get_default_display_name();
> ^
>
> So, use IS_ENABLED() instead.
Hi,
I would like to test this (the change doesn't make much sense to me),
but I cannot find the kernel config file nor the kernel test robot's
email of this report.
Please include an lkml.kernel.org/r/<message_id> reference to such emails
so that interested parties can join the party.
Does this patch apply only to your media tree? so hopefully I can see it in
linux-next on Monday.
Thanks.
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Cc: tomi.valkeinen@ti.com
> Cc: linux-omap@vger.kernel.org
> Cc: linux-fbdev@vger.kernel.org
> Fixes: 771f7be87ff9 ("media: omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP")
> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> ---
> include/video/omapfb_dss.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/video/omapfb_dss.h b/include/video/omapfb_dss.h
> index e9775144ff3b..12755d8d9b4f 100644
> --- a/include/video/omapfb_dss.h
> +++ b/include/video/omapfb_dss.h
> @@ -778,7 +778,7 @@ struct omap_dss_driver {
>
> typedef void (*omap_dispc_isr_t) (void *arg, u32 mask);
>
> -#ifdef CONFIG_FB_OMAP2
> +#if IS_ENABLED(CONFIG_FB_OMAP2)
>
> enum omapdss_version omapdss_get_version(void);
> bool omapdss_is_initialized(void);
>
--
~Randy
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH] media: include/video/omapfb_dss.h: use IS_ENABLED()
2018-05-05 17:59 ` Randy Dunlap
(?)
@ 2018-05-05 21:14 ` Mauro Carvalho Chehab
-1 siblings, 0 replies; 16+ messages in thread
From: Mauro Carvalho Chehab @ 2018-05-05 21:14 UTC (permalink / raw)
To: Randy Dunlap
Cc: Linux Media Mailing List, Mauro Carvalho Chehab,
Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev,
tomi.valkeinen, linux-omap
[-- Attachment #1: Type: text/plain, Size: 3364 bytes --]
Em Sat, 5 May 2018 10:59:23 -0700
Randy Dunlap <rdunlap@infradead.org> escreveu:
> On 05/04/2018 01:49 PM, Mauro Carvalho Chehab wrote:
> > Just checking for ifdefs cause build issues as reported by
> > kernel test:
> >
> > config: openrisc-allmodconfig (attached as .config)
> > compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental)
> >
> > All errors (new ones prefixed by >>):
> >
> > drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_init_connections':
> >>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:8: error: implicit declaration of function 'omapdss_find_mgr_from_display' [-Werror=implicit-function-declaration]
> > mgr = omapdss_find_mgr_from_display(def_dssdev);
> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> > mgr = omapdss_find_mgr_from_display(def_dssdev);
> > ^
> > drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_find_default_display':
> >>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:13: error: implicit declaration of function 'omapdss_get_default_display_name' [-Werror=implicit-function-declaration]
> > def_name = omapdss_get_default_display_name();
> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:11: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> > def_name = omapdss_get_default_display_name();
> > ^
> >
> > So, use IS_ENABLED() instead.
>
> Hi,
>
> I would like to test this (the change doesn't make much sense to me),
> but I cannot find the kernel config file nor the kernel test robot's
> email of this report.
>
> Please include an lkml.kernel.org/r/<message_id> reference to such emails
> so that interested parties can join the party.
The message was not c/c to lkml. You can see the original here:
https://www.mail-archive.com/linux-media@vger.kernel.org/msg130809.html
>
> Does this patch apply only to your media tree? so hopefully I can see it in
> linux-next on Monday.
Yes, as it is over another two patches applied there.
If you want to test it earlier, it is in the top of the master branch:
https://git.linuxtv.org/media_tree.git
>
> Thanks.
>
> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > Cc: Randy Dunlap <rdunlap@infradead.org>
> > Cc: tomi.valkeinen@ti.com
> > Cc: linux-omap@vger.kernel.org
> > Cc: linux-fbdev@vger.kernel.org
> > Fixes: 771f7be87ff9 ("media: omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP")
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> > ---
> > include/video/omapfb_dss.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/video/omapfb_dss.h b/include/video/omapfb_dss.h
> > index e9775144ff3b..12755d8d9b4f 100644
> > --- a/include/video/omapfb_dss.h
> > +++ b/include/video/omapfb_dss.h
> > @@ -778,7 +778,7 @@ struct omap_dss_driver {
> >
> > typedef void (*omap_dispc_isr_t) (void *arg, u32 mask);
> >
> > -#ifdef CONFIG_FB_OMAP2
> > +#if IS_ENABLED(CONFIG_FB_OMAP2)
> >
> > enum omapdss_version omapdss_get_version(void);
> > bool omapdss_is_initialized(void);
> >
>
>
Thanks,
Mauro
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 44890 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH] media: include/video/omapfb_dss.h: use IS_ENABLED()
@ 2018-05-05 21:14 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 16+ messages in thread
From: Mauro Carvalho Chehab @ 2018-05-05 21:14 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, dri-devel,
Mauro Carvalho Chehab, tomi.valkeinen, linux-omap,
Linux Media Mailing List
[-- Attachment #1: Type: text/plain, Size: 3364 bytes --]
Em Sat, 5 May 2018 10:59:23 -0700
Randy Dunlap <rdunlap@infradead.org> escreveu:
> On 05/04/2018 01:49 PM, Mauro Carvalho Chehab wrote:
> > Just checking for ifdefs cause build issues as reported by
> > kernel test:
> >
> > config: openrisc-allmodconfig (attached as .config)
> > compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental)
> >
> > All errors (new ones prefixed by >>):
> >
> > drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_init_connections':
> >>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:8: error: implicit declaration of function 'omapdss_find_mgr_from_display' [-Werror=implicit-function-declaration]
> > mgr = omapdss_find_mgr_from_display(def_dssdev);
> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> > mgr = omapdss_find_mgr_from_display(def_dssdev);
> > ^
> > drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_find_default_display':
> >>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:13: error: implicit declaration of function 'omapdss_get_default_display_name' [-Werror=implicit-function-declaration]
> > def_name = omapdss_get_default_display_name();
> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:11: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> > def_name = omapdss_get_default_display_name();
> > ^
> >
> > So, use IS_ENABLED() instead.
>
> Hi,
>
> I would like to test this (the change doesn't make much sense to me),
> but I cannot find the kernel config file nor the kernel test robot's
> email of this report.
>
> Please include an lkml.kernel.org/r/<message_id> reference to such emails
> so that interested parties can join the party.
The message was not c/c to lkml. You can see the original here:
https://www.mail-archive.com/linux-media@vger.kernel.org/msg130809.html
>
> Does this patch apply only to your media tree? so hopefully I can see it in
> linux-next on Monday.
Yes, as it is over another two patches applied there.
If you want to test it earlier, it is in the top of the master branch:
https://git.linuxtv.org/media_tree.git
>
> Thanks.
>
> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > Cc: Randy Dunlap <rdunlap@infradead.org>
> > Cc: tomi.valkeinen@ti.com
> > Cc: linux-omap@vger.kernel.org
> > Cc: linux-fbdev@vger.kernel.org
> > Fixes: 771f7be87ff9 ("media: omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP")
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> > ---
> > include/video/omapfb_dss.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/video/omapfb_dss.h b/include/video/omapfb_dss.h
> > index e9775144ff3b..12755d8d9b4f 100644
> > --- a/include/video/omapfb_dss.h
> > +++ b/include/video/omapfb_dss.h
> > @@ -778,7 +778,7 @@ struct omap_dss_driver {
> >
> > typedef void (*omap_dispc_isr_t) (void *arg, u32 mask);
> >
> > -#ifdef CONFIG_FB_OMAP2
> > +#if IS_ENABLED(CONFIG_FB_OMAP2)
> >
> > enum omapdss_version omapdss_get_version(void);
> > bool omapdss_is_initialized(void);
> >
>
>
Thanks,
Mauro
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 44890 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH] media: include/video/omapfb_dss.h: use IS_ENABLED()
@ 2018-05-05 21:14 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 16+ messages in thread
From: Mauro Carvalho Chehab @ 2018-05-05 21:14 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, dri-devel,
Mauro Carvalho Chehab, tomi.valkeinen, linux-omap,
Linux Media Mailing List
[-- Attachment #1: Type: text/plain, Size: 3364 bytes --]
Em Sat, 5 May 2018 10:59:23 -0700
Randy Dunlap <rdunlap@infradead.org> escreveu:
> On 05/04/2018 01:49 PM, Mauro Carvalho Chehab wrote:
> > Just checking for ifdefs cause build issues as reported by
> > kernel test:
> >
> > config: openrisc-allmodconfig (attached as .config)
> > compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental)
> >
> > All errors (new ones prefixed by >>):
> >
> > drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_init_connections':
> >>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:8: error: implicit declaration of function 'omapdss_find_mgr_from_display' [-Werror=implicit-function-declaration]
> > mgr = omapdss_find_mgr_from_display(def_dssdev);
> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> > mgr = omapdss_find_mgr_from_display(def_dssdev);
> > ^
> > drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_find_default_display':
> >>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:13: error: implicit declaration of function 'omapdss_get_default_display_name' [-Werror=implicit-function-declaration]
> > def_name = omapdss_get_default_display_name();
> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:11: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> > def_name = omapdss_get_default_display_name();
> > ^
> >
> > So, use IS_ENABLED() instead.
>
> Hi,
>
> I would like to test this (the change doesn't make much sense to me),
> but I cannot find the kernel config file nor the kernel test robot's
> email of this report.
>
> Please include an lkml.kernel.org/r/<message_id> reference to such emails
> so that interested parties can join the party.
The message was not c/c to lkml. You can see the original here:
https://www.mail-archive.com/linux-media@vger.kernel.org/msg130809.html
>
> Does this patch apply only to your media tree? so hopefully I can see it in
> linux-next on Monday.
Yes, as it is over another two patches applied there.
If you want to test it earlier, it is in the top of the master branch:
https://git.linuxtv.org/media_tree.git
>
> Thanks.
>
> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> > Cc: Randy Dunlap <rdunlap@infradead.org>
> > Cc: tomi.valkeinen@ti.com
> > Cc: linux-omap@vger.kernel.org
> > Cc: linux-fbdev@vger.kernel.org
> > Fixes: 771f7be87ff9 ("media: omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP")
> > Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> > ---
> > include/video/omapfb_dss.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/video/omapfb_dss.h b/include/video/omapfb_dss.h
> > index e9775144ff3b..12755d8d9b4f 100644
> > --- a/include/video/omapfb_dss.h
> > +++ b/include/video/omapfb_dss.h
> > @@ -778,7 +778,7 @@ struct omap_dss_driver {
> >
> > typedef void (*omap_dispc_isr_t) (void *arg, u32 mask);
> >
> > -#ifdef CONFIG_FB_OMAP2
> > +#if IS_ENABLED(CONFIG_FB_OMAP2)
> >
> > enum omapdss_version omapdss_get_version(void);
> > bool omapdss_is_initialized(void);
> >
>
>
Thanks,
Mauro
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 44890 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH] media: include/video/omapfb_dss.h: use IS_ENABLED()
2018-05-05 21:14 ` Mauro Carvalho Chehab
(?)
@ 2018-05-08 22:56 ` Randy Dunlap
-1 siblings, 0 replies; 16+ messages in thread
From: Randy Dunlap @ 2018-05-08 22:56 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Linux Media Mailing List, Mauro Carvalho Chehab,
Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev,
tomi.valkeinen, linux-omap
On 05/05/2018 02:14 PM, Mauro Carvalho Chehab wrote:
> Em Sat, 5 May 2018 10:59:23 -0700
> Randy Dunlap <rdunlap@infradead.org> escreveu:
>
>> On 05/04/2018 01:49 PM, Mauro Carvalho Chehab wrote:
>>> Just checking for ifdefs cause build issues as reported by
>>> kernel test:
>>>
>>> config: openrisc-allmodconfig (attached as .config)
>>> compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental)
>>>
>>> All errors (new ones prefixed by >>):
>>>
>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_init_connections':
>>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:8: error: implicit declaration of function 'omapdss_find_mgr_from_display' [-Werror=implicit-function-declaration]
>>> mgr = omapdss_find_mgr_from_display(def_dssdev);
>>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>>> mgr = omapdss_find_mgr_from_display(def_dssdev);
>>> ^
>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_find_default_display':
>>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:13: error: implicit declaration of function 'omapdss_get_default_display_name' [-Werror=implicit-function-declaration]
>>> def_name = omapdss_get_default_display_name();
>>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:11: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>>> def_name = omapdss_get_default_display_name();
>>> ^
>>>
>>> So, use IS_ENABLED() instead.
>>
>> Hi,
>>
>> I would like to test this (the change doesn't make much sense to me),
>> but I cannot find the kernel config file nor the kernel test robot's
>> email of this report.
>>
>> Please include an lkml.kernel.org/r/<message_id> reference to such emails
>> so that interested parties can join the party.
>
> The message was not c/c to lkml. You can see the original here:
>
> https://www.mail-archive.com/linux-media@vger.kernel.org/msg130809.html
>
>
>>
>> Does this patch apply only to your media tree? so hopefully I can see it in
>> linux-next on Monday.
>
> Yes, as it is over another two patches applied there.
>
> If you want to test it earlier, it is in the top of the master branch:
> https://git.linuxtv.org/media_tree.git
>
>>
>> Thanks.
>>
>>> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>>> Cc: Randy Dunlap <rdunlap@infradead.org>
>>> Cc: tomi.valkeinen@ti.com
>>> Cc: linux-omap@vger.kernel.org
>>> Cc: linux-fbdev@vger.kernel.org
>>> Fixes: 771f7be87ff9 ("media: omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP")
>>> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
>>> ---
>>> include/video/omapfb_dss.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/video/omapfb_dss.h b/include/video/omapfb_dss.h
>>> index e9775144ff3b..12755d8d9b4f 100644
>>> --- a/include/video/omapfb_dss.h
>>> +++ b/include/video/omapfb_dss.h
>>> @@ -778,7 +778,7 @@ struct omap_dss_driver {
>>>
>>> typedef void (*omap_dispc_isr_t) (void *arg, u32 mask);
>>>
>>> -#ifdef CONFIG_FB_OMAP2
>>> +#if IS_ENABLED(CONFIG_FB_OMAP2)
>>>
>>> enum omapdss_version omapdss_get_version(void);
>>> bool omapdss_is_initialized(void);
The patch doesn't make any sense to me. I would like to see an
explanation of why this is needed, other than "it fixes the build." ;)
But it does fix the build, so:
Tested-by: Randy Dunlap <rdunlap@infradead.org>
thanks,
--
~Randy
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH] media: include/video/omapfb_dss.h: use IS_ENABLED()
@ 2018-05-08 22:56 ` Randy Dunlap
0 siblings, 0 replies; 16+ messages in thread
From: Randy Dunlap @ 2018-05-08 22:56 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, dri-devel,
Mauro Carvalho Chehab, tomi.valkeinen, linux-omap,
Linux Media Mailing List
On 05/05/2018 02:14 PM, Mauro Carvalho Chehab wrote:
> Em Sat, 5 May 2018 10:59:23 -0700
> Randy Dunlap <rdunlap@infradead.org> escreveu:
>
>> On 05/04/2018 01:49 PM, Mauro Carvalho Chehab wrote:
>>> Just checking for ifdefs cause build issues as reported by
>>> kernel test:
>>>
>>> config: openrisc-allmodconfig (attached as .config)
>>> compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental)
>>>
>>> All errors (new ones prefixed by >>):
>>>
>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_init_connections':
>>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:8: error: implicit declaration of function 'omapdss_find_mgr_from_display' [-Werror=implicit-function-declaration]
>>> mgr = omapdss_find_mgr_from_display(def_dssdev);
>>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>>> mgr = omapdss_find_mgr_from_display(def_dssdev);
>>> ^
>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_find_default_display':
>>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:13: error: implicit declaration of function 'omapdss_get_default_display_name' [-Werror=implicit-function-declaration]
>>> def_name = omapdss_get_default_display_name();
>>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:11: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>>> def_name = omapdss_get_default_display_name();
>>> ^
>>>
>>> So, use IS_ENABLED() instead.
>>
>> Hi,
>>
>> I would like to test this (the change doesn't make much sense to me),
>> but I cannot find the kernel config file nor the kernel test robot's
>> email of this report.
>>
>> Please include an lkml.kernel.org/r/<message_id> reference to such emails
>> so that interested parties can join the party.
>
> The message was not c/c to lkml. You can see the original here:
>
> https://www.mail-archive.com/linux-media@vger.kernel.org/msg130809.html
>
>
>>
>> Does this patch apply only to your media tree? so hopefully I can see it in
>> linux-next on Monday.
>
> Yes, as it is over another two patches applied there.
>
> If you want to test it earlier, it is in the top of the master branch:
> https://git.linuxtv.org/media_tree.git
>
>>
>> Thanks.
>>
>>> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>>> Cc: Randy Dunlap <rdunlap@infradead.org>
>>> Cc: tomi.valkeinen@ti.com
>>> Cc: linux-omap@vger.kernel.org
>>> Cc: linux-fbdev@vger.kernel.org
>>> Fixes: 771f7be87ff9 ("media: omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP")
>>> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
>>> ---
>>> include/video/omapfb_dss.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/video/omapfb_dss.h b/include/video/omapfb_dss.h
>>> index e9775144ff3b..12755d8d9b4f 100644
>>> --- a/include/video/omapfb_dss.h
>>> +++ b/include/video/omapfb_dss.h
>>> @@ -778,7 +778,7 @@ struct omap_dss_driver {
>>>
>>> typedef void (*omap_dispc_isr_t) (void *arg, u32 mask);
>>>
>>> -#ifdef CONFIG_FB_OMAP2
>>> +#if IS_ENABLED(CONFIG_FB_OMAP2)
>>>
>>> enum omapdss_version omapdss_get_version(void);
>>> bool omapdss_is_initialized(void);
The patch doesn't make any sense to me. I would like to see an
explanation of why this is needed, other than "it fixes the build." ;)
But it does fix the build, so:
Tested-by: Randy Dunlap <rdunlap@infradead.org>
thanks,
--
~Randy
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH] media: include/video/omapfb_dss.h: use IS_ENABLED()
@ 2018-05-08 22:56 ` Randy Dunlap
0 siblings, 0 replies; 16+ messages in thread
From: Randy Dunlap @ 2018-05-08 22:56 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, dri-devel,
Mauro Carvalho Chehab, tomi.valkeinen, linux-omap,
Linux Media Mailing List
On 05/05/2018 02:14 PM, Mauro Carvalho Chehab wrote:
> Em Sat, 5 May 2018 10:59:23 -0700
> Randy Dunlap <rdunlap@infradead.org> escreveu:
>
>> On 05/04/2018 01:49 PM, Mauro Carvalho Chehab wrote:
>>> Just checking for ifdefs cause build issues as reported by
>>> kernel test:
>>>
>>> config: openrisc-allmodconfig (attached as .config)
>>> compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental)
>>>
>>> All errors (new ones prefixed by >>):
>>>
>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_init_connections':
>>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:8: error: implicit declaration of function 'omapdss_find_mgr_from_display' [-Werror=implicit-function-declaration]
>>> mgr = omapdss_find_mgr_from_display(def_dssdev);
>>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>>> mgr = omapdss_find_mgr_from_display(def_dssdev);
>>> ^
>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_find_default_display':
>>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:13: error: implicit declaration of function 'omapdss_get_default_display_name' [-Werror=implicit-function-declaration]
>>> def_name = omapdss_get_default_display_name();
>>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:11: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>>> def_name = omapdss_get_default_display_name();
>>> ^
>>>
>>> So, use IS_ENABLED() instead.
>>
>> Hi,
>>
>> I would like to test this (the change doesn't make much sense to me),
>> but I cannot find the kernel config file nor the kernel test robot's
>> email of this report.
>>
>> Please include an lkml.kernel.org/r/<message_id> reference to such emails
>> so that interested parties can join the party.
>
> The message was not c/c to lkml. You can see the original here:
>
> https://www.mail-archive.com/linux-media@vger.kernel.org/msg130809.html
>
>
>>
>> Does this patch apply only to your media tree? so hopefully I can see it in
>> linux-next on Monday.
>
> Yes, as it is over another two patches applied there.
>
> If you want to test it earlier, it is in the top of the master branch:
> https://git.linuxtv.org/media_tree.git
>
>>
>> Thanks.
>>
>>> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>>> Cc: Randy Dunlap <rdunlap@infradead.org>
>>> Cc: tomi.valkeinen@ti.com
>>> Cc: linux-omap@vger.kernel.org
>>> Cc: linux-fbdev@vger.kernel.org
>>> Fixes: 771f7be87ff9 ("media: omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP")
>>> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
>>> ---
>>> include/video/omapfb_dss.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/video/omapfb_dss.h b/include/video/omapfb_dss.h
>>> index e9775144ff3b..12755d8d9b4f 100644
>>> --- a/include/video/omapfb_dss.h
>>> +++ b/include/video/omapfb_dss.h
>>> @@ -778,7 +778,7 @@ struct omap_dss_driver {
>>>
>>> typedef void (*omap_dispc_isr_t) (void *arg, u32 mask);
>>>
>>> -#ifdef CONFIG_FB_OMAP2
>>> +#if IS_ENABLED(CONFIG_FB_OMAP2)
>>>
>>> enum omapdss_version omapdss_get_version(void);
>>> bool omapdss_is_initialized(void);
The patch doesn't make any sense to me. I would like to see an
explanation of why this is needed, other than "it fixes the build." ;)
But it does fix the build, so:
Tested-by: Randy Dunlap <rdunlap@infradead.org>
thanks,
--
~Randy
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH] media: include/video/omapfb_dss.h: use IS_ENABLED()
2018-05-08 22:56 ` Randy Dunlap
(?)
@ 2018-05-09 5:53 ` Randy Dunlap
-1 siblings, 0 replies; 16+ messages in thread
From: Randy Dunlap @ 2018-05-09 5:53 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Linux Media Mailing List, Mauro Carvalho Chehab,
Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev,
tomi.valkeinen, linux-omap
On 05/08/2018 03:56 PM, Randy Dunlap wrote:
> On 05/05/2018 02:14 PM, Mauro Carvalho Chehab wrote:
>> Em Sat, 5 May 2018 10:59:23 -0700
>> Randy Dunlap <rdunlap@infradead.org> escreveu:
>>
>>> On 05/04/2018 01:49 PM, Mauro Carvalho Chehab wrote:
>>>> Just checking for ifdefs cause build issues as reported by
>>>> kernel test:
>>>>
>>>> config: openrisc-allmodconfig (attached as .config)
>>>> compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental)
>>>>
>>>> All errors (new ones prefixed by >>):
>>>>
>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_init_connections':
>>>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:8: error: implicit declaration of function 'omapdss_find_mgr_from_display' [-Werror=implicit-function-declaration]
>>>> mgr = omapdss_find_mgr_from_display(def_dssdev);
>>>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>>>> mgr = omapdss_find_mgr_from_display(def_dssdev);
>>>> ^
>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_find_default_display':
>>>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:13: error: implicit declaration of function 'omapdss_get_default_display_name' [-Werror=implicit-function-declaration]
>>>> def_name = omapdss_get_default_display_name();
>>>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:11: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>>>> def_name = omapdss_get_default_display_name();
>>>> ^
>>>>
>>>> So, use IS_ENABLED() instead.
>>>
>>> Hi,
>>>
>>> I would like to test this (the change doesn't make much sense to me),
>>> but I cannot find the kernel config file nor the kernel test robot's
>>> email of this report.
>>>
>>> Please include an lkml.kernel.org/r/<message_id> reference to such emails
>>> so that interested parties can join the party.
>>
>> The message was not c/c to lkml. You can see the original here:
>>
>> https://www.mail-archive.com/linux-media@vger.kernel.org/msg130809.html
>>
>>
>>>
>>> Does this patch apply only to your media tree? so hopefully I can see it in
>>> linux-next on Monday.
>>
>> Yes, as it is over another two patches applied there.
>>
>> If you want to test it earlier, it is in the top of the master branch:
>> https://git.linuxtv.org/media_tree.git
>>
>>>
>>> Thanks.
>>>
>>>> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>>>> Cc: Randy Dunlap <rdunlap@infradead.org>
>>>> Cc: tomi.valkeinen@ti.com
>>>> Cc: linux-omap@vger.kernel.org
>>>> Cc: linux-fbdev@vger.kernel.org
>>>> Fixes: 771f7be87ff9 ("media: omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP")
>>>> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
>>>> ---
>>>> include/video/omapfb_dss.h | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/include/video/omapfb_dss.h b/include/video/omapfb_dss.h
>>>> index e9775144ff3b..12755d8d9b4f 100644
>>>> --- a/include/video/omapfb_dss.h
>>>> +++ b/include/video/omapfb_dss.h
>>>> @@ -778,7 +778,7 @@ struct omap_dss_driver {
>>>>
>>>> typedef void (*omap_dispc_isr_t) (void *arg, u32 mask);
>>>>
>>>> -#ifdef CONFIG_FB_OMAP2
>>>> +#if IS_ENABLED(CONFIG_FB_OMAP2)
>>>>
>>>> enum omapdss_version omapdss_get_version(void);
>>>> bool omapdss_is_initialized(void);
>
> The patch doesn't make any sense to me. I would like to see an
> explanation of why this is needed, other than "it fixes the build." ;)
I get it now. Using
#if IS_ENABLED(CONFIG_FB_OMAP2)
is just the "modern" way of saying
#if defined(CONFIG_FB_OMAP2) || defined(CONFIG_FB_OMAP2_MODULE)
which also builds without errors.
> But it does fix the build, so:
> Tested-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
--
~Randy
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH] media: include/video/omapfb_dss.h: use IS_ENABLED()
@ 2018-05-09 5:53 ` Randy Dunlap
0 siblings, 0 replies; 16+ messages in thread
From: Randy Dunlap @ 2018-05-09 5:53 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, dri-devel,
Mauro Carvalho Chehab, tomi.valkeinen, linux-omap,
Linux Media Mailing List
On 05/08/2018 03:56 PM, Randy Dunlap wrote:
> On 05/05/2018 02:14 PM, Mauro Carvalho Chehab wrote:
>> Em Sat, 5 May 2018 10:59:23 -0700
>> Randy Dunlap <rdunlap@infradead.org> escreveu:
>>
>>> On 05/04/2018 01:49 PM, Mauro Carvalho Chehab wrote:
>>>> Just checking for ifdefs cause build issues as reported by
>>>> kernel test:
>>>>
>>>> config: openrisc-allmodconfig (attached as .config)
>>>> compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental)
>>>>
>>>> All errors (new ones prefixed by >>):
>>>>
>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_init_connections':
>>>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:8: error: implicit declaration of function 'omapdss_find_mgr_from_display' [-Werror=implicit-function-declaration]
>>>> mgr = omapdss_find_mgr_from_display(def_dssdev);
>>>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>>>> mgr = omapdss_find_mgr_from_display(def_dssdev);
>>>> ^
>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_find_default_display':
>>>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:13: error: implicit declaration of function 'omapdss_get_default_display_name' [-Werror=implicit-function-declaration]
>>>> def_name = omapdss_get_default_display_name();
>>>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:11: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>>>> def_name = omapdss_get_default_display_name();
>>>> ^
>>>>
>>>> So, use IS_ENABLED() instead.
>>>
>>> Hi,
>>>
>>> I would like to test this (the change doesn't make much sense to me),
>>> but I cannot find the kernel config file nor the kernel test robot's
>>> email of this report.
>>>
>>> Please include an lkml.kernel.org/r/<message_id> reference to such emails
>>> so that interested parties can join the party.
>>
>> The message was not c/c to lkml. You can see the original here:
>>
>> https://www.mail-archive.com/linux-media@vger.kernel.org/msg130809.html
>>
>>
>>>
>>> Does this patch apply only to your media tree? so hopefully I can see it in
>>> linux-next on Monday.
>>
>> Yes, as it is over another two patches applied there.
>>
>> If you want to test it earlier, it is in the top of the master branch:
>> https://git.linuxtv.org/media_tree.git
>>
>>>
>>> Thanks.
>>>
>>>> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>>>> Cc: Randy Dunlap <rdunlap@infradead.org>
>>>> Cc: tomi.valkeinen@ti.com
>>>> Cc: linux-omap@vger.kernel.org
>>>> Cc: linux-fbdev@vger.kernel.org
>>>> Fixes: 771f7be87ff9 ("media: omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP")
>>>> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
>>>> ---
>>>> include/video/omapfb_dss.h | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/include/video/omapfb_dss.h b/include/video/omapfb_dss.h
>>>> index e9775144ff3b..12755d8d9b4f 100644
>>>> --- a/include/video/omapfb_dss.h
>>>> +++ b/include/video/omapfb_dss.h
>>>> @@ -778,7 +778,7 @@ struct omap_dss_driver {
>>>>
>>>> typedef void (*omap_dispc_isr_t) (void *arg, u32 mask);
>>>>
>>>> -#ifdef CONFIG_FB_OMAP2
>>>> +#if IS_ENABLED(CONFIG_FB_OMAP2)
>>>>
>>>> enum omapdss_version omapdss_get_version(void);
>>>> bool omapdss_is_initialized(void);
>
> The patch doesn't make any sense to me. I would like to see an
> explanation of why this is needed, other than "it fixes the build." ;)
I get it now. Using
#if IS_ENABLED(CONFIG_FB_OMAP2)
is just the "modern" way of saying
#if defined(CONFIG_FB_OMAP2) || defined(CONFIG_FB_OMAP2_MODULE)
which also builds without errors.
> But it does fix the build, so:
> Tested-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
--
~Randy
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH] media: include/video/omapfb_dss.h: use IS_ENABLED()
@ 2018-05-09 5:53 ` Randy Dunlap
0 siblings, 0 replies; 16+ messages in thread
From: Randy Dunlap @ 2018-05-09 5:53 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: linux-fbdev, Bartlomiej Zolnierkiewicz, dri-devel,
Mauro Carvalho Chehab, tomi.valkeinen, linux-omap,
Linux Media Mailing List
On 05/08/2018 03:56 PM, Randy Dunlap wrote:
> On 05/05/2018 02:14 PM, Mauro Carvalho Chehab wrote:
>> Em Sat, 5 May 2018 10:59:23 -0700
>> Randy Dunlap <rdunlap@infradead.org> escreveu:
>>
>>> On 05/04/2018 01:49 PM, Mauro Carvalho Chehab wrote:
>>>> Just checking for ifdefs cause build issues as reported by
>>>> kernel test:
>>>>
>>>> config: openrisc-allmodconfig (attached as .config)
>>>> compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental)
>>>>
>>>> All errors (new ones prefixed by >>):
>>>>
>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_init_connections':
>>>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:8: error: implicit declaration of function 'omapdss_find_mgr_from_display' [-Werror=implicit-function-declaration]
>>>> mgr = omapdss_find_mgr_from_display(def_dssdev);
>>>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2396:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>>>> mgr = omapdss_find_mgr_from_display(def_dssdev);
>>>> ^
>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c: In function 'omapfb_find_default_display':
>>>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:13: error: implicit declaration of function 'omapdss_get_default_display_name' [-Werror=implicit-function-declaration]
>>>> def_name = omapdss_get_default_display_name();
>>>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:2430:11: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>>>> def_name = omapdss_get_default_display_name();
>>>> ^
>>>>
>>>> So, use IS_ENABLED() instead.
>>>
>>> Hi,
>>>
>>> I would like to test this (the change doesn't make much sense to me),
>>> but I cannot find the kernel config file nor the kernel test robot's
>>> email of this report.
>>>
>>> Please include an lkml.kernel.org/r/<message_id> reference to such emails
>>> so that interested parties can join the party.
>>
>> The message was not c/c to lkml. You can see the original here:
>>
>> https://www.mail-archive.com/linux-media@vger.kernel.org/msg130809.html
>>
>>
>>>
>>> Does this patch apply only to your media tree? so hopefully I can see it in
>>> linux-next on Monday.
>>
>> Yes, as it is over another two patches applied there.
>>
>> If you want to test it earlier, it is in the top of the master branch:
>> https://git.linuxtv.org/media_tree.git
>>
>>>
>>> Thanks.
>>>
>>>> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
>>>> Cc: Randy Dunlap <rdunlap@infradead.org>
>>>> Cc: tomi.valkeinen@ti.com
>>>> Cc: linux-omap@vger.kernel.org
>>>> Cc: linux-fbdev@vger.kernel.org
>>>> Fixes: 771f7be87ff9 ("media: omapfb: omapfb_dss.h: add stubs to build with COMPILE_TEST && DRM_OMAP")
>>>> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
>>>> ---
>>>> include/video/omapfb_dss.h | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/include/video/omapfb_dss.h b/include/video/omapfb_dss.h
>>>> index e9775144ff3b..12755d8d9b4f 100644
>>>> --- a/include/video/omapfb_dss.h
>>>> +++ b/include/video/omapfb_dss.h
>>>> @@ -778,7 +778,7 @@ struct omap_dss_driver {
>>>>
>>>> typedef void (*omap_dispc_isr_t) (void *arg, u32 mask);
>>>>
>>>> -#ifdef CONFIG_FB_OMAP2
>>>> +#if IS_ENABLED(CONFIG_FB_OMAP2)
>>>>
>>>> enum omapdss_version omapdss_get_version(void);
>>>> bool omapdss_is_initialized(void);
>
> The patch doesn't make any sense to me. I would like to see an
> explanation of why this is needed, other than "it fixes the build." ;)
I get it now. Using
#if IS_ENABLED(CONFIG_FB_OMAP2)
is just the "modern" way of saying
#if defined(CONFIG_FB_OMAP2) || defined(CONFIG_FB_OMAP2_MODULE)
which also builds without errors.
> But it does fix the build, so:
> Tested-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
--
~Randy
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2018-05-09 5:53 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-04 17:30 [linuxtv-media:master 167/207] drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c:319:2: error: implicit declaration of function 'omapdss_unregister_display' kbuild test robot
2018-05-04 20:49 ` [PATCH] media: include/video/omapfb_dss.h: use IS_ENABLED() Mauro Carvalho Chehab
2018-05-04 20:49 ` Mauro Carvalho Chehab
2018-05-04 20:49 ` Mauro Carvalho Chehab
2018-05-05 17:59 ` Randy Dunlap
2018-05-05 17:59 ` Randy Dunlap
2018-05-05 17:59 ` Randy Dunlap
2018-05-05 21:14 ` Mauro Carvalho Chehab
2018-05-05 21:14 ` Mauro Carvalho Chehab
2018-05-05 21:14 ` Mauro Carvalho Chehab
2018-05-08 22:56 ` Randy Dunlap
2018-05-08 22:56 ` Randy Dunlap
2018-05-08 22:56 ` Randy Dunlap
2018-05-09 5:53 ` Randy Dunlap
2018-05-09 5:53 ` Randy Dunlap
2018-05-09 5:53 ` Randy Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.