* [PATCH] remote/memory: Replace share parameter with ram_flags
@ 2021-07-08 7:12 Yang Zhong
2021-07-08 7:26 ` David Hildenbrand
2021-07-08 18:48 ` Peter Xu
0 siblings, 2 replies; 4+ messages in thread
From: Yang Zhong @ 2021-07-08 7:12 UTC (permalink / raw)
To: qemu-devel; +Cc: yang.zhong, pbonzini, philmd, peterx, david
The commit(d5015b80) missed the ram_flags to memory_region_init_ram_from_fd()
in the hw/remote/memory.c.
Signed-off-by: Yang Zhong <yang.zhong@intel.com>
---
hw/remote/memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/remote/memory.c b/hw/remote/memory.c
index 472ed2a272..6e21ab1a45 100644
--- a/hw/remote/memory.c
+++ b/hw/remote/memory.c
@@ -46,7 +46,7 @@ void remote_sysmem_reconfig(MPQemuMsg *msg, Error **errp)
subregion = g_new(MemoryRegion, 1);
memory_region_init_ram_from_fd(subregion, NULL,
name, sysmem_info->sizes[region],
- true, msg->fds[region],
+ RAM_SHARED, msg->fds[region],
sysmem_info->offsets[region],
errp);
--
2.29.2.334.gfaefdd61ec
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] remote/memory: Replace share parameter with ram_flags
2021-07-08 7:12 [PATCH] remote/memory: Replace share parameter with ram_flags Yang Zhong
@ 2021-07-08 7:26 ` David Hildenbrand
2021-07-08 7:34 ` Yang Zhong
2021-07-08 18:48 ` Peter Xu
1 sibling, 1 reply; 4+ messages in thread
From: David Hildenbrand @ 2021-07-08 7:26 UTC (permalink / raw)
To: Yang Zhong, qemu-devel; +Cc: pbonzini, philmd, peterx
On 08.07.21 09:12, Yang Zhong wrote:
> The commit(d5015b80) missed the ram_flags to memory_region_init_ram_from_fd()
> in the hw/remote/memory.c.
Yes, seems like that call was added just after I crafted my patches:
Fixes: d5015b801340 ("softmmu/memory: Pass ram_flags to
qemu_ram_alloc_from_fd()")
Reviewed-by: David Hildenbrand <david@redhat.com>
Thanks!
>
> Signed-off-by: Yang Zhong <yang.zhong@intel.com>
> ---
> hw/remote/memory.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/remote/memory.c b/hw/remote/memory.c
> index 472ed2a272..6e21ab1a45 100644
> --- a/hw/remote/memory.c
> +++ b/hw/remote/memory.c
> @@ -46,7 +46,7 @@ void remote_sysmem_reconfig(MPQemuMsg *msg, Error **errp)
> subregion = g_new(MemoryRegion, 1);
> memory_region_init_ram_from_fd(subregion, NULL,
> name, sysmem_info->sizes[region],
> - true, msg->fds[region],
> + RAM_SHARED, msg->fds[region],
> sysmem_info->offsets[region],
> errp);
>
>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] remote/memory: Replace share parameter with ram_flags
2021-07-08 7:26 ` David Hildenbrand
@ 2021-07-08 7:34 ` Yang Zhong
0 siblings, 0 replies; 4+ messages in thread
From: Yang Zhong @ 2021-07-08 7:34 UTC (permalink / raw)
To: David Hildenbrand; +Cc: yang.zhong, pbonzini, philmd, qemu-devel, peterx
On Thu, Jul 08, 2021 at 09:26:17AM +0200, David Hildenbrand wrote:
> On 08.07.21 09:12, Yang Zhong wrote:
> >The commit(d5015b80) missed the ram_flags to memory_region_init_ram_from_fd()
> >in the hw/remote/memory.c.
>
> Yes, seems like that call was added just after I crafted my patches:
>
> Fixes: d5015b801340 ("softmmu/memory: Pass ram_flags to
> qemu_ram_alloc_from_fd()")
> Reviewed-by: David Hildenbrand <david@redhat.com>
>
Thanks David, if there is not any other comments, i will send the new
version according to your commit info. thanks!
Yang
> Thanks!
>
> >
> >Signed-off-by: Yang Zhong <yang.zhong@intel.com>
> >---
> > hw/remote/memory.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/hw/remote/memory.c b/hw/remote/memory.c
> >index 472ed2a272..6e21ab1a45 100644
> >--- a/hw/remote/memory.c
> >+++ b/hw/remote/memory.c
> >@@ -46,7 +46,7 @@ void remote_sysmem_reconfig(MPQemuMsg *msg, Error **errp)
> > subregion = g_new(MemoryRegion, 1);
> > memory_region_init_ram_from_fd(subregion, NULL,
> > name, sysmem_info->sizes[region],
> >- true, msg->fds[region],
> >+ RAM_SHARED, msg->fds[region],
> > sysmem_info->offsets[region],
> > errp);
> >
>
>
> --
> Thanks,
>
> David / dhildenb
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] remote/memory: Replace share parameter with ram_flags
2021-07-08 7:12 [PATCH] remote/memory: Replace share parameter with ram_flags Yang Zhong
2021-07-08 7:26 ` David Hildenbrand
@ 2021-07-08 18:48 ` Peter Xu
1 sibling, 0 replies; 4+ messages in thread
From: Peter Xu @ 2021-07-08 18:48 UTC (permalink / raw)
To: Yang Zhong; +Cc: pbonzini, philmd, qemu-devel, david
On Thu, Jul 08, 2021 at 03:12:16PM +0800, Yang Zhong wrote:
> The commit(d5015b80) missed the ram_flags to memory_region_init_ram_from_fd()
> in the hw/remote/memory.c.
>
> Signed-off-by: Yang Zhong <yang.zhong@intel.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-08 18:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-08 7:12 [PATCH] remote/memory: Replace share parameter with ram_flags Yang Zhong
2021-07-08 7:26 ` David Hildenbrand
2021-07-08 7:34 ` Yang Zhong
2021-07-08 18:48 ` Peter Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.