* [PATCH] arm: dts: zynq: Add support for Z-turn board
@ 2018-03-06 21:30 tossel
2018-03-07 7:25 ` Michal Simek
2018-03-28 14:17 ` [PATCHv3] " Anton Gerasimov
0 siblings, 2 replies; 9+ messages in thread
From: tossel @ 2018-03-06 21:30 UTC (permalink / raw)
To: devicetree; +Cc: robh+dt, mark.rutland, linux, michal.simek, Anton Gerasimov
From: Anton Gerasimov <tossel@gmail.com>
Add a DTS for MYIR Z-turn board and the respective target in the
Makefile.
Signed-off-by: Anton Gerasimov <tossel@gmail.com>
---
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/zynq-zturn-myir.dts | 151 ++++++++++++++++++++++++++++++++++
2 files changed, 152 insertions(+)
create mode 100644 arch/arm/boot/dts/zynq-zturn-myir.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index ade7a38543dc..db20a4266936 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -1067,6 +1067,7 @@ dtb-$(CONFIG_ARCH_ZYNQ) += \
zynq-zc702.dtb \
zynq-zc706.dtb \
zynq-zed.dtb \
+ zynq-zynq-myir.dtb \
zynq-zybo.dtb
dtb-$(CONFIG_MACH_ARMADA_370) += \
armada-370-db.dtb \
diff --git a/arch/arm/boot/dts/zynq-zturn-myir.dts b/arch/arm/boot/dts/zynq-zturn-myir.dts
new file mode 100644
index 000000000000..427248d70e05
--- /dev/null
+++ b/arch/arm/boot/dts/zynq-zturn-myir.dts
@@ -0,0 +1,151 @@
+/*
+ * Copyright (C) 2015 Andrea Merello <adnrea.merello@gmail.com>
+ *
+ * Based on zynq-zed.dts which is:
+ * Copyright (C) 2011 - 2014 Xilinx
+ * Copyright (C) 2012 National Instruments Corp.
+ *
+ * This software is licensed under the terms of the GNU General Public
+ * License version 2, as published by the Free Software Foundation, and
+ * may be copied, distributed, and modified under those terms.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+/dts-v1/;
+/include/ "zynq-7000.dtsi"
+
+/ {
+ model = "Zynq Z-Turn MYIR Board";
+ compatible = "xlnx,zynq-7000";
+
+ aliases {
+ ethernet0 = &gem0;
+ serial0 = &uart1;
+ serial1 = &uart0;
+ };
+
+ memory {
+ device_type = "memory";
+ reg = <0x0 0x40000000>;
+ };
+
+ chosen {
+ bootargs = "console=ttyPS0,115200 earlyprintk root=/dev/mmcblk0p2 rootwait";
+ };
+
+ gpio-leds {
+ compatible = "gpio-leds";
+ led_r {
+ label = "led_r";
+ gpios = <&gpio0 0x72 0x1>;
+ default-state = "on";
+ linux,default-trigger = "heartbeat";
+ };
+
+ led_g {
+ label = "led_g";
+ gpios = <&gpio0 0x73 0x1>;
+ default-state = "on";
+ linux,default-trigger = "heartbeat";
+ };
+
+ led_b {
+ label = "led_b";
+ gpios = <&gpio0 0x74 0x1>;
+ default-state = "on";
+ linux,default-trigger = "heartbeat";
+ };
+
+ usr_led1 {
+ label = "usr_led1";
+ gpios = <&gpio0 0x0 0x1>;
+ default-state = "off";
+ linux,default-trigger = "none";
+ };
+
+ usr_led2 {
+ label = "usr_led2";
+ gpios = <&gpio0 0x9 0x1>;
+ default-state = "off";
+ linux,default-trigger = "none";
+ };
+ };
+
+ gpio-beep {
+ compatible = "gpio-beeper";
+ label = "pl-beep";
+ gpios = <&gpio0 0x75 0x0>;
+ };
+
+ gpio-keys {
+ compatible = "gpio-keys";
+ #address-cells = <0x1>;
+ #size-cells = <0x0>;
+ autorepeat;
+ K1 {
+ label = "K1";
+ gpios = <&gpio0 0x32 0x1>;
+ linux,code = <0x66>;
+ gpio-key,wakeup;
+ autorepeat;
+ };
+ };
+};
+
+&clkc {
+ ps-clk-frequency = <33333333>;
+ fclk-enable = <0xf>;
+};
+
+&gem0 {
+ status = "okay";
+ phy-mode = "rgmii-id";
+ phy-handle = <ðernet_phy>;
+
+ ethernet_phy: ethernet-phy@0 {
+ reg = <0x0>;
+ };
+};
+
+&sdhci0 {
+ status = "okay";
+};
+
+&uart0 {
+ status = "okay";
+};
+
+&uart1 {
+ status = "okay";
+};
+
+&usb0 {
+ status = "okay";
+ dr_mode = "host";
+};
+
+&can0 {
+ status = "okay";
+};
+
+&i2c0 {
+ status = "okay";
+ clock-frequency = <400000>;
+
+ stlm75@49 {
+ status = "okay";
+ compatible = "lm75";
+ reg = <0x49>;
+ };
+
+ adxl345@53 {
+ compatible = "adi,adxl345", "adxl345";
+ reg = <0x53>;
+ interrupt-parent = <&intc>;
+ interrupts = <0x0 0x1e 0x4>;
+ };
+};
+
--
2.16.2
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] arm: dts: zynq: Add support for Z-turn board
2018-03-06 21:30 [PATCH] arm: dts: zynq: Add support for Z-turn board tossel
@ 2018-03-07 7:25 ` Michal Simek
2018-03-07 19:50 ` Anton Gerasimov
2018-03-12 20:05 ` [PATCHv2] " tossel
2018-03-28 14:17 ` [PATCHv3] " Anton Gerasimov
1 sibling, 2 replies; 9+ messages in thread
From: Michal Simek @ 2018-03-07 7:25 UTC (permalink / raw)
To: tossel, devicetree; +Cc: robh+dt, mark.rutland, linux, michal.simek
Hi,
On 6.3.2018 22:30, tossel@gmail.com wrote:
> From: Anton Gerasimov <tossel@gmail.com>
>
> Add a DTS for MYIR Z-turn board and the respective target in the
> Makefile.
>
> Signed-off-by: Anton Gerasimov <tossel@gmail.com>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/zynq-zturn-myir.dts | 151 ++++++++++++++++++++++++++++++++++
> 2 files changed, 152 insertions(+)
> create mode 100644 arch/arm/boot/dts/zynq-zturn-myir.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index ade7a38543dc..db20a4266936 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1067,6 +1067,7 @@ dtb-$(CONFIG_ARCH_ZYNQ) += \
> zynq-zc702.dtb \
> zynq-zc706.dtb \
> zynq-zed.dtb \
> + zynq-zynq-myir.dtb \
> zynq-zybo.dtb
> dtb-$(CONFIG_MACH_ARMADA_370) += \
> armada-370-db.dtb \
> diff --git a/arch/arm/boot/dts/zynq-zturn-myir.dts b/arch/arm/boot/dts/zynq-zturn-myir.dts
> new file mode 100644
> index 000000000000..427248d70e05
> --- /dev/null
> +++ b/arch/arm/boot/dts/zynq-zturn-myir.dts
> @@ -0,0 +1,151 @@
> +/*
> + * Copyright (C) 2015 Andrea Merello <adnrea.merello@gmail.com>
> + *
> + * Based on zynq-zed.dts which is:
> + * Copyright (C) 2011 - 2014 Xilinx
> + * Copyright (C) 2012 National Instruments Corp.
> + *
> + * This software is licensed under the terms of the GNU General Public
> + * License version 2, as published by the Free Software Foundation, and
> + * may be copied, distributed, and modified under those terms.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
SPDX header please.
> + */
> +/dts-v1/;
> +/include/ "zynq-7000.dtsi"
> +
> +/ {
> + model = "Zynq Z-Turn MYIR Board";
> + compatible = "xlnx,zynq-7000";
You should consider to create your compatible string just for your board
and record it.
Look at:
arm: dts: zynq: Add Digilent Zybo Z7 board
patch.
Also make sense to record vendor prefix and use it as part of compatible
string.
> +
> + aliases {
> + ethernet0 = &gem0;
> + serial0 = &uart1;
> + serial1 = &uart0;
> + };
> +
> + memory {
run it with make W=1 dtbs
And this should be memory@0
> + device_type = "memory";
> + reg = <0x0 0x40000000>;
> + };
> +
> + chosen {
> + bootargs = "console=ttyPS0,115200 earlyprintk root=/dev/mmcblk0p2 rootwait";
> + };
> +
> + gpio-leds {
> + compatible = "gpio-leds";
> + led_r {
> + label = "led_r";
> + gpios = <&gpio0 0x72 0x1>;
> + default-state = "on";
> + linux,default-trigger = "heartbeat";
> + };
> +
> + led_g {
> + label = "led_g";
> + gpios = <&gpio0 0x73 0x1>;
> + default-state = "on";
> + linux,default-trigger = "heartbeat";
> + };
> +
> + led_b {
> + label = "led_b";
> + gpios = <&gpio0 0x74 0x1>;
> + default-state = "on";
> + linux,default-trigger = "heartbeat";
Do you really wants to have 3 leds doing heartbeat?
> + };
> +
> + usr_led1 {
> + label = "usr_led1";
> + gpios = <&gpio0 0x0 0x1>;
> + default-state = "off";
> + linux,default-trigger = "none";
This is not the part of binding and I think it is useless anyway.
> + };
> +
> + usr_led2 {
> + label = "usr_led2";
> + gpios = <&gpio0 0x9 0x1>;
> + default-state = "off";
> + linux,default-trigger = "none";
ditto
> + };
> + };
> +
> + gpio-beep {
> + compatible = "gpio-beeper";
> + label = "pl-beep";
> + gpios = <&gpio0 0x75 0x0>;
IIRC this is EMIO it means wire over programmable logic.
In past we agreed that only PS will be described that's why this
shouldn't be here.
> + };
> +
> + gpio-keys {
> + compatible = "gpio-keys";
> + #address-cells = <0x1>;
only 1
> + #size-cells = <0x0>;
only 0
> + autorepeat;
> + K1 {
> + label = "K1";
> + gpios = <&gpio0 0x32 0x1>;
> + linux,code = <0x66>;
> + gpio-key,wakeup;
> + autorepeat;
> + };
> + };
> +};
> +
> +&clkc {
> + ps-clk-frequency = <33333333>;
> + fclk-enable = <0xf>;
PL related fclk-enable - shouldn't be here.
> +};
> +
> +&gem0 {
> + status = "okay";
> + phy-mode = "rgmii-id";
> + phy-handle = <ðernet_phy>;
> +
> + ethernet_phy: ethernet-phy@0 {
> + reg = <0x0>;
> + };
> +};
> +
> +&sdhci0 {
> + status = "okay";
> +};
> +
> +&uart0 {
> + status = "okay";
> +};
> +
> +&uart1 {
> + status = "okay";
> +};
> +
> +&usb0 {
> + status = "okay";
> + dr_mode = "host";
> +};
> +
> +&can0 {
> + status = "okay";
> +};
> +
> +&i2c0 {
> + status = "okay";
> + clock-frequency = <400000>;
> +
> + stlm75@49 {
> + status = "okay";
> + compatible = "lm75";
> + reg = <0x49>;
> + };
> +
> + adxl345@53 {
based on binding doc this should be
accelerometer@53
> + compatible = "adi,adxl345", "adxl345";
> + reg = <0x53>;
> + interrupt-parent = <&intc>;
> + interrupts = <0x0 0x1e 0x4>;
> + };
> +};
> +
>
Thanks,
Michal
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] arm: dts: zynq: Add support for Z-turn board
2018-03-07 7:25 ` Michal Simek
@ 2018-03-07 19:50 ` Anton Gerasimov
2018-03-08 6:47 ` Michal Simek
2018-03-12 20:05 ` [PATCHv2] " tossel
1 sibling, 1 reply; 9+ messages in thread
From: Anton Gerasimov @ 2018-03-07 19:50 UTC (permalink / raw)
To: Michal Simek, devicetree; +Cc: robh+dt, mark.rutland, linux
Hi Michal,
thank you for the detailed review. I'm fixing most of the issues, I've
just got one note and one question.
> Do you really wants to have 3 leds doing heartbeat?
Actually it is one RGB package. But it's controlled through programmable
logic, so I'll just remove it, my bad.
>> + };
>> +
>> + usr_led1 {
>> + label = "usr_led1";
>> + gpios = <&gpio0 0x0 0x1>;
>> + default-state = "off";
>> + linux,default-trigger = "none";
> This is not the part of binding and I think it is useless anyway.
>
>> + };
>> +
>> + usr_led2 {
>> + label = "usr_led2";
>> + gpios = <&gpio0 0x9 0x1>;
>> + default-state = "off";
>> + linux,default-trigger = "none";
> ditto
These two are on the contrary real LEDs that are controlled by hardware
GPIO. You mean they don't belong here because user can control them with
GPIO interface?
Thanks,
Anton
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] arm: dts: zynq: Add support for Z-turn board
2018-03-07 19:50 ` Anton Gerasimov
@ 2018-03-08 6:47 ` Michal Simek
0 siblings, 0 replies; 9+ messages in thread
From: Michal Simek @ 2018-03-08 6:47 UTC (permalink / raw)
To: Anton Gerasimov, Michal Simek, devicetree; +Cc: robh+dt, mark.rutland, linux
On 7.3.2018 20:50, Anton Gerasimov wrote:
> Hi Michal,
>
> thank you for the detailed review. I'm fixing most of the issues, I've
> just got one note and one question.
>
>> Do you really wants to have 3 leds doing heartbeat?
>
> Actually it is one RGB package. But it's controlled through programmable
> logic, so I'll just remove it, my bad.
>
>>> + };
>>> +
>>> + usr_led1 {
>>> + label = "usr_led1";
>>> + gpios = <&gpio0 0x0 0x1>;
>>> + default-state = "off";
>>> + linux,default-trigger = "none";
>> This is not the part of binding and I think it is useless anyway.
>>
>>> + };
>>> +
>>> + usr_led2 {
>>> + label = "usr_led2";
>>> + gpios = <&gpio0 0x9 0x1>;
>>> + default-state = "off";
>>> + linux,default-trigger = "none";
>> ditto
>
> These two are on the contrary real LEDs that are controlled by hardware
> GPIO. You mean they don't belong here because user can control them with
> GPIO interface?
I really meant that linux,default-trigger = "none" shouldn't be there.
user led description is fine.
Also I just spot that you should use dashes instead of underscores in
node name. It means usr-led2 here.
Thanks,
Michal
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCHv2] arm: dts: zynq: Add support for Z-turn board
2018-03-07 7:25 ` Michal Simek
2018-03-07 19:50 ` Anton Gerasimov
@ 2018-03-12 20:05 ` tossel
2018-03-13 12:47 ` Michal Simek
1 sibling, 1 reply; 9+ messages in thread
From: tossel @ 2018-03-12 20:05 UTC (permalink / raw)
To: devicetree; +Cc: robh+dt, mark.rutland, linux, michal.simek, Anton Gerasimov
From: Anton Gerasimov <tossel@gmail.com>
Add a DTS for MYIR Z-turn board and the respective target in the
Makefile.
Signed-off-by: Anton Gerasimov <tossel@gmail.com>
---
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/zynq-zturn.dts | 115 +++++++++++++++++++++++++++++++++++++++
2 files changed, 116 insertions(+)
create mode 100644 arch/arm/boot/dts/zynq-zturn.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index ade7a38543dc..4daa7d5d4db4 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -1067,6 +1067,7 @@ dtb-$(CONFIG_ARCH_ZYNQ) += \
zynq-zc702.dtb \
zynq-zc706.dtb \
zynq-zed.dtb \
+ zynq-zturn.dtb \
zynq-zybo.dtb
dtb-$(CONFIG_MACH_ARMADA_370) += \
armada-370-db.dtb \
diff --git a/arch/arm/boot/dts/zynq-zturn.dts b/arch/arm/boot/dts/zynq-zturn.dts
new file mode 100644
index 000000000000..713d91fc3917
--- /dev/null
+++ b/arch/arm/boot/dts/zynq-zturn.dts
@@ -0,0 +1,115 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2015 Andrea Merello <adnrea.merello@gmail.com>
+ *
+ * Based on zynq-zed.dts which is:
+ * Copyright (C) 2011 - 2014 Xilinx
+ * Copyright (C) 2012 National Instruments Corp.
+ *
+ */
+
+/dts-v1/;
+/include/ "zynq-7000.dtsi"
+
+/ {
+ model = "Zynq Z-Turn MYIR Board";
+ compatible = "myir,zynq-zturn", "xlnx,zynq-7000";
+
+ aliases {
+ ethernet0 = &gem0;
+ serial0 = &uart1;
+ serial1 = &uart0;
+ };
+
+ memory@0 {
+ device_type = "memory";
+ reg = <0x0 0x40000000>;
+ };
+
+ chosen {
+ bootargs = "console=ttyPS0,115200 earlyprintk root=/dev/mmcblk0p2 rootwait";
+ };
+
+ gpio-leds {
+ compatible = "gpio-leds";
+ usr-led1 {
+ label = "usr-led1";
+ gpios = <&gpio0 0x0 0x1>;
+ default-state = "off";
+ };
+
+ usr-led2 {
+ label = "usr-led2";
+ gpios = <&gpio0 0x9 0x1>;
+ default-state = "off";
+ };
+ };
+
+ gpio-keys {
+ compatible = "gpio-keys";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ autorepeat;
+ K1 {
+ label = "K1";
+ gpios = <&gpio0 0x32 0x1>;
+ linux,code = <0x66>;
+ gpio-key,wakeup;
+ autorepeat;
+ };
+ };
+};
+
+&clkc {
+ ps-clk-frequency = <33333333>;
+};
+
+&gem0 {
+ status = "okay";
+ phy-mode = "rgmii-id";
+ phy-handle = <ðernet_phy>;
+
+ ethernet_phy: ethernet-phy@0 {
+ reg = <0x0>;
+ };
+};
+
+&sdhci0 {
+ status = "okay";
+};
+
+&uart0 {
+ status = "okay";
+};
+
+&uart1 {
+ status = "okay";
+};
+
+&usb0 {
+ status = "okay";
+ dr_mode = "host";
+};
+
+&can0 {
+ status = "okay";
+};
+
+&i2c0 {
+ status = "okay";
+ clock-frequency = <400000>;
+
+ stlm75@49 {
+ status = "okay";
+ compatible = "lm75";
+ reg = <0x49>;
+ };
+
+ accelerometer@53 {
+ compatible = "adi,adxl345", "adxl345";
+ reg = <0x53>;
+ interrupt-parent = <&intc>;
+ interrupts = <0x0 0x1e 0x4>;
+ };
+};
+
--
2.16.2
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCHv2] arm: dts: zynq: Add support for Z-turn board
2018-03-12 20:05 ` [PATCHv2] " tossel
@ 2018-03-13 12:47 ` Michal Simek
0 siblings, 0 replies; 9+ messages in thread
From: Michal Simek @ 2018-03-13 12:47 UTC (permalink / raw)
To: tossel, devicetree; +Cc: robh+dt, mark.rutland, linux, michal.simek
On 12.3.2018 21:05, tossel@gmail.com wrote:
> From: Anton Gerasimov <tossel@gmail.com>
>
> Add a DTS for MYIR Z-turn board and the respective target in the
> Makefile.
>
> Signed-off-by: Anton Gerasimov <tossel@gmail.com>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/zynq-zturn.dts | 115 +++++++++++++++++++++++++++++++++++++++
> 2 files changed, 116 insertions(+)
> create mode 100644 arch/arm/boot/dts/zynq-zturn.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index ade7a38543dc..4daa7d5d4db4 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1067,6 +1067,7 @@ dtb-$(CONFIG_ARCH_ZYNQ) += \
> zynq-zc702.dtb \
> zynq-zc706.dtb \
> zynq-zed.dtb \
> + zynq-zturn.dtb \
> zynq-zybo.dtb
> dtb-$(CONFIG_MACH_ARMADA_370) += \
> armada-370-db.dtb \
> diff --git a/arch/arm/boot/dts/zynq-zturn.dts b/arch/arm/boot/dts/zynq-zturn.dts
> new file mode 100644
> index 000000000000..713d91fc3917
> --- /dev/null
> +++ b/arch/arm/boot/dts/zynq-zturn.dts
> @@ -0,0 +1,115 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2015 Andrea Merello <adnrea.merello@gmail.com>
> + *
> + * Based on zynq-zed.dts which is:
> + * Copyright (C) 2011 - 2014 Xilinx
> + * Copyright (C) 2012 National Instruments Corp.
> + *
> + */
> +
> +/dts-v1/;
> +/include/ "zynq-7000.dtsi"
> +
> +/ {
> + model = "Zynq Z-Turn MYIR Board";
> + compatible = "myir,zynq-zturn", "xlnx,zynq-7000";
> +
> + aliases {
> + ethernet0 = &gem0;
> + serial0 = &uart1;
> + serial1 = &uart0;
> + };
> +
> + memory@0 {
> + device_type = "memory";
> + reg = <0x0 0x40000000>;
> + };
> +
> + chosen {
> + bootargs = "console=ttyPS0,115200 earlyprintk root=/dev/mmcblk0p2 rootwait";
> + };
> +
> + gpio-leds {
> + compatible = "gpio-leds";
> + usr-led1 {
> + label = "usr-led1";
> + gpios = <&gpio0 0x0 0x1>;
> + default-state = "off";
> + };
> +
> + usr-led2 {
> + label = "usr-led2";
> + gpios = <&gpio0 0x9 0x1>;
> + default-state = "off";
> + };
> + };
> +
> + gpio-keys {
> + compatible = "gpio-keys";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + autorepeat;
> + K1 {
> + label = "K1";
> + gpios = <&gpio0 0x32 0x1>;
> + linux,code = <0x66>;
> + gpio-key,wakeup;
> + autorepeat;
> + };
> + };
> +};
> +
> +&clkc {
> + ps-clk-frequency = <33333333>;
> +};
> +
> +&gem0 {
> + status = "okay";
> + phy-mode = "rgmii-id";
> + phy-handle = <ðernet_phy>;
> +
> + ethernet_phy: ethernet-phy@0 {
> + reg = <0x0>;
> + };
> +};
> +
> +&sdhci0 {
> + status = "okay";
> +};
> +
> +&uart0 {
> + status = "okay";
> +};
> +
> +&uart1 {
> + status = "okay";
> +};
> +
> +&usb0 {
> + status = "okay";
> + dr_mode = "host";
> +};
> +
> +&can0 {
> + status = "okay";
> +};
> +
> +&i2c0 {
> + status = "okay";
> + clock-frequency = <400000>;
> +
> + stlm75@49 {
> + status = "okay";
> + compatible = "lm75";
> + reg = <0x49>;
> + };
> +
> + accelerometer@53 {
> + compatible = "adi,adxl345", "adxl345";
> + reg = <0x53>;
> + interrupt-parent = <&intc>;
> + interrupts = <0x0 0x1e 0x4>;
> + };
> +};
> +
>
Nit: Here is empty line at the end of file which I have removed.
I can't see any issue with this dts file.
Rob: I have added it to my zynq/dts branch. If you see any issue please
let us know.
https://github.com/Xilinx/linux-xlnx/tree/zynq/dt
Anton: Will be also good to update u-boot dts file with this one.
Thanks,
Michal
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCHv3] arm: dts: zynq: Add support for Z-turn board
2018-03-06 21:30 [PATCH] arm: dts: zynq: Add support for Z-turn board tossel
2018-03-07 7:25 ` Michal Simek
@ 2018-03-28 14:17 ` Anton Gerasimov
2018-04-04 6:56 ` Michal Simek
1 sibling, 1 reply; 9+ messages in thread
From: Anton Gerasimov @ 2018-03-28 14:17 UTC (permalink / raw)
To: devicetree; +Cc: michal.simek, robh+dt, mark.rutland, linux, Anton Gerasimov
Add a dts for MYIR Z-turn board and respective target in Makefile.
Signed-off-by: Anton Gerasimov <tossel@gmail.com>
---
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/zynq-zturn.dts | 124 +++++++++++++++++++++++++++++++++++++++
2 files changed, 125 insertions(+)
create mode 100644 arch/arm/boot/dts/zynq-zturn.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index ade7a38543dc..4daa7d5d4db4 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -1067,6 +1067,7 @@ dtb-$(CONFIG_ARCH_ZYNQ) += \
zynq-zc702.dtb \
zynq-zc706.dtb \
zynq-zed.dtb \
+ zynq-zturn.dtb \
zynq-zybo.dtb
dtb-$(CONFIG_MACH_ARMADA_370) += \
armada-370-db.dtb \
diff --git a/arch/arm/boot/dts/zynq-zturn.dts b/arch/arm/boot/dts/zynq-zturn.dts
new file mode 100644
index 000000000000..8aa384b59b7f
--- /dev/null
+++ b/arch/arm/boot/dts/zynq-zturn.dts
@@ -0,0 +1,124 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2015 Andrea Merello <adnrea.merello@gmail.com>
+ * Copyright (C) 2017 Alexander Graf <agraf@suse.de>
+ *
+ * Based on zynq-zed.dts which is:
+ * Copyright (C) 2011 - 2014 Xilinx
+ * Copyright (C) 2012 National Instruments Corp.
+ *
+ */
+
+/dts-v1/;
+/include/ "zynq-7000.dtsi"
+
+/ {
+ model = "Zynq Z-Turn MYIR Board";
+ compatible = "myir,zynq-zturn", "xlnx,zynq-7000";
+
+ aliases {
+ ethernet0 = &gem0;
+ serial0 = &uart1;
+ serial1 = &uart0;
+ mmc0 = &sdhci0;
+ };
+
+ memory@0 {
+ device_type = "memory";
+ reg = <0x0 0x40000000>;
+ };
+
+ chosen {
+ stdout-path = "serial0:115200n8";
+ };
+
+ gpio-leds {
+ compatible = "gpio-leds";
+ usr-led1 {
+ label = "usr-led1";
+ gpios = <&gpio0 0x0 0x1>;
+ default-state = "off";
+ };
+
+ usr-led2 {
+ label = "usr-led2";
+ gpios = <&gpio0 0x9 0x1>;
+ default-state = "off";
+ };
+ };
+
+ gpio-keys {
+ compatible = "gpio-keys";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ autorepeat;
+ K1 {
+ label = "K1";
+ gpios = <&gpio0 0x32 0x1>;
+ linux,code = <0x66>;
+ gpio-key,wakeup;
+ autorepeat;
+ };
+ };
+};
+
+&clkc {
+ ps-clk-frequency = <33333333>;
+};
+
+&qspi {
+ u-boot,dm-pre-reloc;
+ status = "okay";
+};
+
+&gem0 {
+ status = "okay";
+ phy-mode = "rgmii-id";
+ phy-handle = <ðernet_phy>;
+
+ ethernet_phy: ethernet-phy@0 {
+ reg = <0x0>;
+ };
+};
+
+&sdhci0 {
+ u-boot,dm-pre-reloc;
+ status = "okay";
+};
+
+&uart0 {
+ u-boot,dm-pre-reloc;
+ status = "okay";
+};
+
+&uart1 {
+ u-boot,dm-pre-reloc;
+ status = "okay";
+};
+
+&usb0 {
+ status = "okay";
+ dr_mode = "host";
+};
+
+&can0 {
+ status = "okay";
+};
+
+&i2c0 {
+ status = "okay";
+ clock-frequency = <400000>;
+
+ stlm75@49 {
+ status = "okay";
+ compatible = "lm75";
+ reg = <0x49>;
+ };
+
+ accelerometer@53 {
+ compatible = "adi,adxl345", "adxl345", "adi,adxl34x", "adxl34x";
+ reg = <0x53>;
+ interrupt-parent = <&intc>;
+ interrupts = <0x0 0x1e 0x4>;
+ };
+};
--
2.16.2
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCHv3] arm: dts: zynq: Add support for Z-turn board
2018-03-28 14:17 ` [PATCHv3] " Anton Gerasimov
@ 2018-04-04 6:56 ` Michal Simek
2018-07-17 13:49 ` Michal Simek
0 siblings, 1 reply; 9+ messages in thread
From: Michal Simek @ 2018-04-04 6:56 UTC (permalink / raw)
To: Anton Gerasimov, devicetree; +Cc: michal.simek, robh+dt, mark.rutland, linux
On 28.3.2018 16:17, Anton Gerasimov wrote:
> Add a dts for MYIR Z-turn board and respective target in Makefile.
>
> Signed-off-by: Anton Gerasimov <tossel@gmail.com>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/zynq-zturn.dts | 124 +++++++++++++++++++++++++++++++++++++++
> 2 files changed, 125 insertions(+)
> create mode 100644 arch/arm/boot/dts/zynq-zturn.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index ade7a38543dc..4daa7d5d4db4 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1067,6 +1067,7 @@ dtb-$(CONFIG_ARCH_ZYNQ) += \
> zynq-zc702.dtb \
> zynq-zc706.dtb \
> zynq-zed.dtb \
> + zynq-zturn.dtb \
> zynq-zybo.dtb
> dtb-$(CONFIG_MACH_ARMADA_370) += \
> armada-370-db.dtb \
> diff --git a/arch/arm/boot/dts/zynq-zturn.dts b/arch/arm/boot/dts/zynq-zturn.dts
> new file mode 100644
> index 000000000000..8aa384b59b7f
> --- /dev/null
> +++ b/arch/arm/boot/dts/zynq-zturn.dts
> @@ -0,0 +1,124 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2015 Andrea Merello <adnrea.merello@gmail.com>
> + * Copyright (C) 2017 Alexander Graf <agraf@suse.de>
> + *
> + * Based on zynq-zed.dts which is:
> + * Copyright (C) 2011 - 2014 Xilinx
> + * Copyright (C) 2012 National Instruments Corp.
> + *
> + */
> +
> +/dts-v1/;
> +/include/ "zynq-7000.dtsi"
> +
> +/ {
> + model = "Zynq Z-Turn MYIR Board";
> + compatible = "myir,zynq-zturn", "xlnx,zynq-7000";
> +
> + aliases {
> + ethernet0 = &gem0;
> + serial0 = &uart1;
> + serial1 = &uart0;
> + mmc0 = &sdhci0;
> + };
> +
> + memory@0 {
> + device_type = "memory";
> + reg = <0x0 0x40000000>;
> + };
> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> + };
> +
> + gpio-leds {
> + compatible = "gpio-leds";
> + usr-led1 {
> + label = "usr-led1";
> + gpios = <&gpio0 0x0 0x1>;
> + default-state = "off";
> + };
> +
> + usr-led2 {
> + label = "usr-led2";
> + gpios = <&gpio0 0x9 0x1>;
> + default-state = "off";
> + };
> + };
> +
> + gpio-keys {
> + compatible = "gpio-keys";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + autorepeat;
> + K1 {
> + label = "K1";
> + gpios = <&gpio0 0x32 0x1>;
> + linux,code = <0x66>;
> + gpio-key,wakeup;
> + autorepeat;
> + };
> + };
> +};
> +
> +&clkc {
> + ps-clk-frequency = <33333333>;
> +};
> +
> +&qspi {
> + u-boot,dm-pre-reloc;
> + status = "okay";
> +};
> +
> +&gem0 {
> + status = "okay";
> + phy-mode = "rgmii-id";
> + phy-handle = <ðernet_phy>;
> +
> + ethernet_phy: ethernet-phy@0 {
> + reg = <0x0>;
> + };
> +};
> +
> +&sdhci0 {
> + u-boot,dm-pre-reloc;
> + status = "okay";
> +};
> +
> +&uart0 {
> + u-boot,dm-pre-reloc;
> + status = "okay";
> +};
> +
> +&uart1 {
> + u-boot,dm-pre-reloc;
> + status = "okay";
> +};
> +
> +&usb0 {
> + status = "okay";
> + dr_mode = "host";
> +};
> +
> +&can0 {
> + status = "okay";
> +};
> +
> +&i2c0 {
> + status = "okay";
> + clock-frequency = <400000>;
> +
> + stlm75@49 {
> + status = "okay";
> + compatible = "lm75";
> + reg = <0x49>;
> + };
> +
> + accelerometer@53 {
> + compatible = "adi,adxl345", "adxl345", "adi,adxl34x", "adxl34x";
> + reg = <0x53>;
> + interrupt-parent = <&intc>;
> + interrupts = <0x0 0x1e 0x4>;
> + };
> +};
>
Thanks for v3 and sync with U-Boot.
Applied.
Thanks,
Michal
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCHv3] arm: dts: zynq: Add support for Z-turn board
2018-04-04 6:56 ` Michal Simek
@ 2018-07-17 13:49 ` Michal Simek
0 siblings, 0 replies; 9+ messages in thread
From: Michal Simek @ 2018-07-17 13:49 UTC (permalink / raw)
To: Michal Simek, Anton Gerasimov, devicetree
Cc: michal.simek, robh+dt, mark.rutland, linux
[-- Attachment #1.1: Type: text/plain, Size: 4139 bytes --]
On 4.4.2018 08:56, Michal Simek wrote:
> On 28.3.2018 16:17, Anton Gerasimov wrote:
>> Add a dts for MYIR Z-turn board and respective target in Makefile.
>>
>> Signed-off-by: Anton Gerasimov <tossel@gmail.com>
>> ---
>> arch/arm/boot/dts/Makefile | 1 +
>> arch/arm/boot/dts/zynq-zturn.dts | 124 +++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 125 insertions(+)
>> create mode 100644 arch/arm/boot/dts/zynq-zturn.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index ade7a38543dc..4daa7d5d4db4 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -1067,6 +1067,7 @@ dtb-$(CONFIG_ARCH_ZYNQ) += \
>> zynq-zc702.dtb \
>> zynq-zc706.dtb \
>> zynq-zed.dtb \
>> + zynq-zturn.dtb \
>> zynq-zybo.dtb
>> dtb-$(CONFIG_MACH_ARMADA_370) += \
>> armada-370-db.dtb \
>> diff --git a/arch/arm/boot/dts/zynq-zturn.dts b/arch/arm/boot/dts/zynq-zturn.dts
>> new file mode 100644
>> index 000000000000..8aa384b59b7f
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/zynq-zturn.dts
>> @@ -0,0 +1,124 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Copyright (C) 2015 Andrea Merello <adnrea.merello@gmail.com>
>> + * Copyright (C) 2017 Alexander Graf <agraf@suse.de>
>> + *
>> + * Based on zynq-zed.dts which is:
>> + * Copyright (C) 2011 - 2014 Xilinx
>> + * Copyright (C) 2012 National Instruments Corp.
>> + *
>> + */
>> +
>> +/dts-v1/;
>> +/include/ "zynq-7000.dtsi"
>> +
>> +/ {
>> + model = "Zynq Z-Turn MYIR Board";
>> + compatible = "myir,zynq-zturn", "xlnx,zynq-7000";
>> +
>> + aliases {
>> + ethernet0 = &gem0;
>> + serial0 = &uart1;
>> + serial1 = &uart0;
>> + mmc0 = &sdhci0;
>> + };
>> +
>> + memory@0 {
>> + device_type = "memory";
>> + reg = <0x0 0x40000000>;
>> + };
>> +
>> + chosen {
>> + stdout-path = "serial0:115200n8";
>> + };
>> +
>> + gpio-leds {
>> + compatible = "gpio-leds";
>> + usr-led1 {
>> + label = "usr-led1";
>> + gpios = <&gpio0 0x0 0x1>;
>> + default-state = "off";
>> + };
>> +
>> + usr-led2 {
>> + label = "usr-led2";
>> + gpios = <&gpio0 0x9 0x1>;
>> + default-state = "off";
>> + };
>> + };
>> +
>> + gpio-keys {
>> + compatible = "gpio-keys";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + autorepeat;
>> + K1 {
>> + label = "K1";
>> + gpios = <&gpio0 0x32 0x1>;
>> + linux,code = <0x66>;
>> + gpio-key,wakeup;
>> + autorepeat;
>> + };
>> + };
>> +};
>> +
>> +&clkc {
>> + ps-clk-frequency = <33333333>;
>> +};
>> +
>> +&qspi {
>> + u-boot,dm-pre-reloc;
>> + status = "okay";
>> +};
>> +
>> +&gem0 {
>> + status = "okay";
>> + phy-mode = "rgmii-id";
>> + phy-handle = <ðernet_phy>;
>> +
>> + ethernet_phy: ethernet-phy@0 {
>> + reg = <0x0>;
>> + };
>> +};
>> +
>> +&sdhci0 {
>> + u-boot,dm-pre-reloc;
>> + status = "okay";
>> +};
>> +
>> +&uart0 {
>> + u-boot,dm-pre-reloc;
>> + status = "okay";
>> +};
>> +
>> +&uart1 {
>> + u-boot,dm-pre-reloc;
>> + status = "okay";
>> +};
>> +
>> +&usb0 {
>> + status = "okay";
>> + dr_mode = "host";
>> +};
>> +
>> +&can0 {
>> + status = "okay";
>> +};
>> +
>> +&i2c0 {
>> + status = "okay";
>> + clock-frequency = <400000>;
>> +
>> + stlm75@49 {
>> + status = "okay";
>> + compatible = "lm75";
>> + reg = <0x49>;
>> + };
>> +
>> + accelerometer@53 {
>> + compatible = "adi,adxl345", "adxl345", "adi,adxl34x", "adxl34x";
>> + reg = <0x53>;
>> + interrupt-parent = <&intc>;
>> + interrupts = <0x0 0x1e 0x4>;
>> + };
>> +};
>>
>
> Thanks for v3 and sync with U-Boot.
>
> Applied.
FYI: I just find out that qspi(mainline linux is missing driver) and
u-boot things shouldn't be here. I have updated this patch before
sending pull request to arm-soc guys.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP SoCs
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-07-17 13:49 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-06 21:30 [PATCH] arm: dts: zynq: Add support for Z-turn board tossel
2018-03-07 7:25 ` Michal Simek
2018-03-07 19:50 ` Anton Gerasimov
2018-03-08 6:47 ` Michal Simek
2018-03-12 20:05 ` [PATCHv2] " tossel
2018-03-13 12:47 ` Michal Simek
2018-03-28 14:17 ` [PATCHv3] " Anton Gerasimov
2018-04-04 6:56 ` Michal Simek
2018-07-17 13:49 ` Michal Simek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.