From: Jason-JH Lin <jason-jh.lin@mediatek.com> To: CK Hu <ck.hu@mediatek.com> Cc: <chunkuang.hu@kernel.org>, <matthias.bgg@gmail.com>, <linux-arm-kernel@lists.infradead.org>, <linux-mediatek@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <Project_Global_Chrome_Upstream_Group@mediatek.com>, <fshao@google.com>, <nancy.lin@mediatek.com>, <singo.chang@mediatek.com> Subject: Re: [PATCH v1 13/17] drm/mediatek: Add AAL support for MT8195 Date: Sat, 10 Jul 2021 15:35:19 +0800 [thread overview] Message-ID: <923a1be8698d23acdce2b988162da83745c9f3e9.camel@mediatek.com> (raw) In-Reply-To: <1625638499.7824.25.camel@mtksdaap41> On Wed, 2021-07-07 at 14:14 +0800, CK Hu wrote: > Hi, Jason: > > On Wed, 2021-07-07 at 12:12 +0800, jason-jh.lin wrote: > > 1. Add AAL support for MT8195. > > 2. Add AAL_OUTPUT_SIZE configuration. > > > > Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com> > > --- > > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 8 +++++++- > > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++ > > 2 files changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > index 75bc00e17fc4..f154f7c0cd11 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > @@ -34,6 +34,7 @@ > > > > #define DISP_AAL_EN 0x0000 > > #define DISP_AAL_SIZE 0x0030 > > +#define DISP_AAL_OUTPUT_SIZE 0x04d8 > > > > #define DISP_DITHER_EN 0x0000 > > #define DITHER_EN BIT(0) > > @@ -196,7 +197,12 @@ static void mtk_aal_config(struct device *dev, > > unsigned int w, > > { > > struct mtk_ddp_comp_dev *priv = dev_get_drvdata(dev); > > > > - mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv- > > >regs, DISP_AAL_SIZE); > > + mtk_ddp_write(cmdq_pkt, w << 16 | h, > > + &priv->cmdq_reg, priv->regs, > > + DISP_AAL_SIZE); > > Why do you change this? > > > + mtk_ddp_write(cmdq_pkt, w << 16 | h, > > + &priv->cmdq_reg, priv->regs, > > + DISP_AAL_OUTPUT_SIZE); > > This seems not related to mt8195, so move this modification to > another > patch. > > > } > > > > static void mtk_aal_gamma_set(struct device *dev, struct > > drm_crtc_state *state) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > index 058b50d0e64b..459bb1e53f2e 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > @@ -450,6 +450,8 @@ static const struct of_device_id > > mtk_ddp_comp_dt_ids[] = { > > .data = (void *)MTK_DISP_COLOR }, > > { .compatible = "mediatek,mt8173-disp-aal", > > .data = (void *)MTK_DISP_AAL}, > > + { .compatible = "mediatek,mt8195-disp-aal", > > + .data = (void *)MTK_DISP_AAL}, > > The same question for OVL, COLOR, CCORR. > > Regards, > CK > > Hi CK, To avoid the output height is incorrect, AAL_OUTPUT_SIZE configuration is necessary setting for every chips. > Other chips may set AAL_OUPUT_SIZE in boot loader or somewhere before kernel, so they didn't need this confiuration here. So I'll remove this patch at the next version. Regard, Jason-JH.Lin > > { .compatible = "mediatek,mt8173-disp-gamma", > > .data = (void *)MTK_DISP_GAMMA, }, > > { .compatible = "mediatek,mt8183-disp-gamma", > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Jason-JH Lin <jason-jh.lin@mediatek.com> To: CK Hu <ck.hu@mediatek.com> Cc: <chunkuang.hu@kernel.org>, <matthias.bgg@gmail.com>, <linux-arm-kernel@lists.infradead.org>, <linux-mediatek@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <Project_Global_Chrome_Upstream_Group@mediatek.com>, <fshao@google.com>, <nancy.lin@mediatek.com>, <singo.chang@mediatek.com> Subject: Re: [PATCH v1 13/17] drm/mediatek: Add AAL support for MT8195 Date: Sat, 10 Jul 2021 15:35:19 +0800 [thread overview] Message-ID: <923a1be8698d23acdce2b988162da83745c9f3e9.camel@mediatek.com> (raw) In-Reply-To: <1625638499.7824.25.camel@mtksdaap41> On Wed, 2021-07-07 at 14:14 +0800, CK Hu wrote: > Hi, Jason: > > On Wed, 2021-07-07 at 12:12 +0800, jason-jh.lin wrote: > > 1. Add AAL support for MT8195. > > 2. Add AAL_OUTPUT_SIZE configuration. > > > > Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com> > > --- > > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 8 +++++++- > > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 ++ > > 2 files changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > index 75bc00e17fc4..f154f7c0cd11 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c > > @@ -34,6 +34,7 @@ > > > > #define DISP_AAL_EN 0x0000 > > #define DISP_AAL_SIZE 0x0030 > > +#define DISP_AAL_OUTPUT_SIZE 0x04d8 > > > > #define DISP_DITHER_EN 0x0000 > > #define DITHER_EN BIT(0) > > @@ -196,7 +197,12 @@ static void mtk_aal_config(struct device *dev, > > unsigned int w, > > { > > struct mtk_ddp_comp_dev *priv = dev_get_drvdata(dev); > > > > - mtk_ddp_write(cmdq_pkt, w << 16 | h, &priv->cmdq_reg, priv- > > >regs, DISP_AAL_SIZE); > > + mtk_ddp_write(cmdq_pkt, w << 16 | h, > > + &priv->cmdq_reg, priv->regs, > > + DISP_AAL_SIZE); > > Why do you change this? > > > + mtk_ddp_write(cmdq_pkt, w << 16 | h, > > + &priv->cmdq_reg, priv->regs, > > + DISP_AAL_OUTPUT_SIZE); > > This seems not related to mt8195, so move this modification to > another > patch. > > > } > > > > static void mtk_aal_gamma_set(struct device *dev, struct > > drm_crtc_state *state) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > index 058b50d0e64b..459bb1e53f2e 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > @@ -450,6 +450,8 @@ static const struct of_device_id > > mtk_ddp_comp_dt_ids[] = { > > .data = (void *)MTK_DISP_COLOR }, > > { .compatible = "mediatek,mt8173-disp-aal", > > .data = (void *)MTK_DISP_AAL}, > > + { .compatible = "mediatek,mt8195-disp-aal", > > + .data = (void *)MTK_DISP_AAL}, > > The same question for OVL, COLOR, CCORR. > > Regards, > CK > > Hi CK, To avoid the output height is incorrect, AAL_OUTPUT_SIZE configuration is necessary setting for every chips. > Other chips may set AAL_OUPUT_SIZE in boot loader or somewhere before kernel, so they didn't need this confiuration here. So I'll remove this patch at the next version. Regard, Jason-JH.Lin > > { .compatible = "mediatek,mt8173-disp-gamma", > > .data = (void *)MTK_DISP_GAMMA, }, > > { .compatible = "mediatek,mt8183-disp-gamma", > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-10 7:46 UTC|newest] Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-07 4:12 [PATCH v1 00/17] Add MediaTek SoC DRM (vdosys0) support for mt8195 jason-jh.lin 2021-07-07 4:12 ` jason-jh.lin 2021-07-07 4:12 ` [PATCH v1 01/17] dt-bindings: mediatek: add definition for mt8195 display jason-jh.lin 2021-07-07 4:12 ` jason-jh.lin 2021-07-07 4:33 ` CK Hu 2021-07-07 4:33 ` CK Hu 2021-07-10 6:57 ` Jason-JH Lin 2021-07-10 6:57 ` Jason-JH Lin 2021-07-07 4:12 ` [PATCH v1 02/17] dt-bindings: arm: mediatek: add definition for mt8195 mmsys jason-jh.lin 2021-07-07 4:12 ` jason-jh.lin 2021-07-07 4:12 ` [PATCH v1 03/17] arm64: dts: mt8195: add display node for vdosys0 jason-jh.lin 2021-07-07 4:12 ` jason-jh.lin 2021-07-07 4:12 ` [PATCH v1 04/17] soc: mediatek: add mtk-mmsys support for mt8195 vdosys0 jason-jh.lin 2021-07-07 4:12 ` jason-jh.lin 2021-07-07 4:44 ` CK Hu 2021-07-07 4:44 ` CK Hu 2021-07-10 6:58 ` Jason-JH Lin 2021-07-10 6:58 ` Jason-JH Lin 2021-07-07 4:12 ` [PATCH v1 05/17] drm/mediatek: add mediatek-drm of vdosys0 support for MT8195 jason-jh.lin 2021-07-07 4:12 ` jason-jh.lin 2021-07-07 4:48 ` CK Hu 2021-07-07 4:48 ` CK Hu 2021-07-10 6:59 ` Jason-JH Lin 2021-07-10 6:59 ` Jason-JH Lin 2021-07-10 6:59 ` Jason-JH Lin 2021-07-07 4:12 ` [PATCH v1 06/17] soc: mediatek: add mtk-mutex support for mt8195 jason-jh.lin 2021-07-07 4:12 ` jason-jh.lin 2021-07-07 4:52 ` CK Hu 2021-07-07 4:52 ` CK Hu 2021-07-10 7:01 ` Jason-JH Lin 2021-07-10 7:01 ` Jason-JH Lin 2021-07-07 4:12 ` [PATCH v1 07/17] drm/mediatek: add OVL support for MT8195 jason-jh.lin 2021-07-07 4:12 ` jason-jh.lin 2021-07-07 5:03 ` CK Hu 2021-07-07 5:03 ` CK Hu 2021-07-10 7:05 ` Jason-JH Lin 2021-07-10 7:05 ` Jason-JH Lin 2021-07-10 7:05 ` Jason-JH Lin 2021-07-07 4:12 ` [PATCH v1 08/17] drm/mediatek: Add component_del in OVL remove function jason-jh.lin 2021-07-07 4:12 ` jason-jh.lin 2021-07-07 5:12 ` CK Hu 2021-07-07 5:12 ` CK Hu 2021-07-10 7:06 ` Jason-JH Lin 2021-07-10 7:06 ` Jason-JH Lin 2021-07-10 7:06 ` Jason-JH Lin 2021-07-07 4:12 ` [PATCH v1 09/17] drm/mediatek: add OVL support multi-layer jason-jh.lin 2021-07-07 4:12 ` jason-jh.lin 2021-07-07 5:43 ` CK Hu 2021-07-07 5:43 ` CK Hu 2021-07-10 7:17 ` Jason-JH Lin 2021-07-10 7:17 ` Jason-JH Lin 2021-07-10 7:17 ` Jason-JH Lin 2021-07-07 4:12 ` [PATCH v1 10/17] drm/mediatek: add RDMA support for MT8195 jason-jh.lin 2021-07-07 4:12 ` jason-jh.lin 2021-07-07 4:12 ` [PATCH v1 11/17] drm/mediatek: add COLOR " jason-jh.lin 2021-07-07 4:12 ` jason-jh.lin 2021-07-07 6:01 ` CK Hu 2021-07-07 6:01 ` CK Hu 2021-07-10 7:21 ` Jason-JH Lin 2021-07-10 7:21 ` Jason-JH Lin 2021-07-10 7:21 ` Jason-JH Lin 2021-07-07 4:12 ` [PATCH v1 12/17] drm/mediatek: add CCORR " jason-jh.lin 2021-07-07 4:12 ` jason-jh.lin 2021-07-07 6:02 ` CK Hu 2021-07-07 6:02 ` CK Hu 2021-07-10 7:22 ` Jason-JH Lin 2021-07-10 7:22 ` Jason-JH Lin 2021-07-10 7:22 ` Jason-JH Lin 2021-07-07 4:12 ` [PATCH v1 13/17] drm/mediatek: Add AAL " jason-jh.lin 2021-07-07 4:12 ` jason-jh.lin 2021-07-07 6:14 ` CK Hu 2021-07-07 6:14 ` CK Hu 2021-07-10 7:35 ` Jason-JH Lin [this message] 2021-07-10 7:35 ` Jason-JH Lin 2021-07-07 4:12 ` [PATCH v1 14/17] drm/mediatek: add GAMMA " jason-jh.lin 2021-07-07 4:12 ` jason-jh.lin 2021-07-07 4:12 ` [PATCH v1 15/17] drm/mediatek: add DITHER " jason-jh.lin 2021-07-07 4:12 ` jason-jh.lin 2021-07-07 4:12 ` [PATCH v1 16/17] drm/mediatek: add MERGE " jason-jh.lin 2021-07-07 4:12 ` jason-jh.lin 2021-07-07 7:02 ` CK Hu 2021-07-07 7:02 ` CK Hu 2021-07-10 7:52 ` Jason-JH Lin 2021-07-10 7:52 ` Jason-JH Lin 2021-07-07 4:12 ` [PATCH v1 17/17] drm/mediatek: add DSC " jason-jh.lin 2021-07-07 4:12 ` jason-jh.lin 2021-07-07 7:35 ` CK Hu 2021-07-07 7:35 ` CK Hu 2021-07-10 7:55 ` Jason-JH Lin 2021-07-10 7:55 ` Jason-JH Lin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=923a1be8698d23acdce2b988162da83745c9f3e9.camel@mediatek.com \ --to=jason-jh.lin@mediatek.com \ --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \ --cc=chunkuang.hu@kernel.org \ --cc=ck.hu@mediatek.com \ --cc=fshao@google.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=nancy.lin@mediatek.com \ --cc=singo.chang@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.