All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] Floppy: Remove Sense Interrupt Hack
@ 2008-12-18 21:14 Justin Chevrier
  2008-12-19 19:43 ` Blue Swirl
  0 siblings, 1 reply; 11+ messages in thread
From: Justin Chevrier @ 2008-12-18 21:14 UTC (permalink / raw)
  To: qemu-devel

Hey guys,

I'm tracking down the next issue(s) with the Openserver installation. The current issue is that during installation when the installer tries to link the BLTD (eg. SCSI drivers) drivers into the kernel it is unable to access the floppy drive. After reviewing the debug logs it turns out that the installer dosen't like the value being returned by Sense Interrupt. The cause of this is a hack in the Sense Interrupt code that always returns an OR'd value based on FD_SR0_SEEK instead of the actual Status0 regsiter. The hack identifies that the floppy code is broken with regard to Status0 and Read/Writes. Outside of setting particular values in case of CRC errors/etc I can't identify from datasheets what we should be doing. I've tracked down what I believe is the original mailing list post regarding this hack and it seems to be related to Windows 2000 and higher OS's recognizing the floppy drive. I applied the patch below and verified that
 detection/read/writes/formatting still work in Windows XP SP2.

Original post:
http://lists.gnu.org/archive/html/qemu-devel/2004-10/msg00076.html

SVN change:
http://svn.savannah.gnu.org/viewvc?view=rev&root=qemu&revision=1118

Having said the above does anyone know what the comment in the hack is referencing? Is it still needed? If so what needs to be done to eliminate it?

If it's no longer needed I propose the patch below.

Justin

Changelog:

Remove Sense Interrupt hack

Signed-off-by: Justin Chevrier <theburner1@yahoo.com>

--- hw/fdc.c    (revision 6082)
+++ hw/fdc.c    (working copy)
@@ -1601,16 +1601,9 @@
 {
     fdrive_t *cur_drv = get_cur_drv(fdctrl);

-#if 0
     fdctrl->fifo[0] =
         fdctrl->status0 | (cur_drv->head << 2) | GET_CUR_DRV(fdctrl);
-#else
-    /* XXX: status0 handling is broken for read/write
-       commands, so we do this hack. It should be suppressed
-       ASAP */
-    fdctrl->fifo[0] =
-        FD_SR0_SEEK | (cur_drv->head << 2) | GET_CUR_DRV(fdctrl);
-#endif
+
     fdctrl->fifo[1] = cur_drv->track;
     fdctrl_set_fifo(fdctrl, 2, 0);
     fdctrl_reset_irq(fdctrl);


      

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH] Floppy: Remove Sense Interrupt Hack
@ 2008-12-23 18:02 Justin Chevrier
  2008-12-23 18:13 ` Blue Swirl
  2008-12-23 18:30 ` Blue Swirl
  0 siblings, 2 replies; 11+ messages in thread
From: Justin Chevrier @ 2008-12-23 18:02 UTC (permalink / raw)
  To: Blue Swirl; +Cc: qemu-devel

--- On Sat, 12/20/08, Blue Swirl <blauwirbel@gmail.com> wrote:

> From: Blue Swirl <blauwirbel@gmail.com>
> Subject: Re: [Qemu-devel] [PATCH] Floppy: Remove Sense Interrupt Hack
> To: theburner1@yahoo.com
> Cc: qemu-devel@nongnu.org
> Date: Saturday, December 20, 2008, 5:54 AM
> On 12/19/08, Justin Chevrier <theburner1@yahoo.com>
> wrote:
> >
> >
> >
> >  --- On Fri, 12/19/08, Blue Swirl
> <blauwirbel@gmail.com> wrote:
> >
> >  > From: Blue Swirl <blauwirbel@gmail.com>
> >  > Subject: Re: [Qemu-devel] [PATCH] Floppy: Remove
> Sense Interrupt Hack
> >  > To: theburner1@yahoo.com, qemu-devel@nongnu.org
> >  > Date: Friday, December 19, 2008, 2:43 PM
> >
> > > On 12/18/08, Justin Chevrier
> <theburner1@yahoo.com>
> >  > wrote:
> >  > > Hey guys,
> >  > >
> >  > >  I'm tracking down the next issue(s)
> with the
> >  > Openserver installation. The current issue is
> that during
> >  > installation when the installer tries to link
> the BLTD (eg.
> >  > SCSI drivers) drivers into the kernel it is
> unable to access
> >  > the floppy drive. After reviewing the debug logs
> it turns
> >  > out that the installer dosen't like the
> value being
> >  > returned by Sense Interrupt. The cause of this
> is a hack in
> >  > the Sense Interrupt code that always returns an
> OR'd
> >  > value based on FD_SR0_SEEK instead of the actual
> Status0
> >  > regsiter. The hack identifies that the floppy
> code is broken
> >  > with regard to Status0 and Read/Writes. Outside
> of setting
> >  > particular values in case of CRC errors/etc I
> can't
> >  > identify from datasheets what we should be
> doing. I've
> >  > tracked down what I believe is the original
> mailing list
> >  > post regarding this hack and it seems to be
> related to
> >  > Windows 2000 and higher OS's recognizing the
> floppy
> >  > drive. I applied the patch below and verified
> that
> >  > >   detection/read/writes/formatting still
> work in
> >  > Windows XP SP2.
> >  > >
> >  > >  Original post:
> >  > >
> >  >
> http://lists.gnu.org/archive/html/qemu-devel/2004-10/msg00076.html
> >  > >
> >  > >  SVN change:
> >  > >
> >  >
> http://svn.savannah.gnu.org/viewvc?view=rev&root=qemu&revision=1118
> >  > >
> >  > >  Having said the above does anyone know
> what the
> >  > comment in the hack is referencing? Is it still
> needed? If
> >  > so what needs to be done to eliminate it?
> >  > >
> >  > >  If it's no longer needed I propose the
> patch
> >  > below.
> >  > >
> >  > >  Justin
> >  > >
> >  > >  Changelog:
> >  > >
> >  > >  Remove Sense Interrupt hack
> >  > >
> >  > >  Signed-off-by: Justin Chevrier
> >  > <theburner1@yahoo.com>
> >  >
> >  > It may be a hack, but if we remove it, Sparc64
> refuses to
> >  > boot and
> >  > prints endlessly:
> >  > SENSEI c0 00
> >  > SENSEI c0 00
> >  > SENSEI c0 00
> >  > SENSEI c0 00
> >
> >
> > Okay, thanks for the feedback!
> >
> >  I'll start looking into what SPARC64 expects
> here.
> 
> The message is printed here:
> http://tracker.coreboot.org/trac/openbios/browser/openbios-devel/drivers/floppy.c#L359

Thanks again!

Does the patch below work for you?

In this version we return 0xc0 (polling) for the first interrupt status after reset (Openserver appears to require this). After returning 0xc0 we set the Status0 register to 0x20 (seek complete). This should work as the spec says Sense Interrupt should be called up to 4 times to retrieve the queued status values. Tested successfully in both Windows 98 and XP SP2.

It also appears that the code referenced in the link loops infinitely due to a missing: "max_sensei--;" which is present in the Linux Kernel's equivalent code.

Justin

Index: fdc.c
===================================================================
--- fdc.c       (revision 6121)
+++ fdc.c       (working copy)
@@ -1601,20 +1601,13 @@
 {
     fdrive_t *cur_drv = get_cur_drv(fdctrl);

-#if 0
     fdctrl->fifo[0] =
         fdctrl->status0 | (cur_drv->head << 2) | GET_CUR_DRV(fdctrl);
-#else
-    /* XXX: status0 handling is broken for read/write
-       commands, so we do this hack. It should be suppressed
-       ASAP */
-    fdctrl->fifo[0] =
-        FD_SR0_SEEK | (cur_drv->head << 2) | GET_CUR_DRV(fdctrl);
-#endif
+
     fdctrl->fifo[1] = cur_drv->track;
     fdctrl_set_fifo(fdctrl, 2, 0);
     fdctrl_reset_irq(fdctrl);
-    fdctrl->status0 = FD_SR0_RDYCHG;
+    fdctrl->status0 = FD_SR0_SEEK;
 }

 static void fdctrl_handle_seek (fdctrl_t *fdctrl, int direction)




      

^ permalink raw reply	[flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH] Floppy: Remove Sense Interrupt Hack
@ 2008-12-23 18:13 Justin Chevrier
  0 siblings, 0 replies; 11+ messages in thread
From: Justin Chevrier @ 2008-12-23 18:13 UTC (permalink / raw)
  Cc: qemu-devel

--- On Tue, 12/23/08, Justin Chevrier <theburner1@yahoo.com> wrote:

> From: Justin Chevrier <theburner1@yahoo.com>
> Subject: Re: [Qemu-devel] [PATCH] Floppy: Remove Sense Interrupt Hack
> To: "Blue Swirl" <blauwirbel@gmail.com>
> Cc: qemu-devel@nongnu.org
> Date: Tuesday, December 23, 2008, 1:02 PM
> --- On Sat, 12/20/08, Blue Swirl
> <blauwirbel@gmail.com> wrote:
> 
> > From: Blue Swirl <blauwirbel@gmail.com>
> > Subject: Re: [Qemu-devel] [PATCH] Floppy: Remove Sense
> Interrupt Hack
> > To: theburner1@yahoo.com
> > Cc: qemu-devel@nongnu.org
> > Date: Saturday, December 20, 2008, 5:54 AM
> > On 12/19/08, Justin Chevrier
> <theburner1@yahoo.com>
> > wrote:
> > >
> > >
> > >
> > >  --- On Fri, 12/19/08, Blue Swirl
> > <blauwirbel@gmail.com> wrote:
> > >
> > >  > From: Blue Swirl
> <blauwirbel@gmail.com>
> > >  > Subject: Re: [Qemu-devel] [PATCH] Floppy:
> Remove
> > Sense Interrupt Hack
> > >  > To: theburner1@yahoo.com,
> qemu-devel@nongnu.org
> > >  > Date: Friday, December 19, 2008, 2:43 PM
> > >
> > > > On 12/18/08, Justin Chevrier
> > <theburner1@yahoo.com>
> > >  > wrote:
> > >  > > Hey guys,
> > >  > >
> > >  > >  I'm tracking down the next
> issue(s)
> > with the
> > >  > Openserver installation. The current issue
> is
> > that during
> > >  > installation when the installer tries to
> link
> > the BLTD (eg.
> > >  > SCSI drivers) drivers into the kernel it is
> > unable to access
> > >  > the floppy drive. After reviewing the debug
> logs
> > it turns
> > >  > out that the installer dosen't like the
> > value being
> > >  > returned by Sense Interrupt. The cause of
> this
> > is a hack in
> > >  > the Sense Interrupt code that always
> returns an
> > OR'd
> > >  > value based on FD_SR0_SEEK instead of the
> actual
> > Status0
> > >  > regsiter. The hack identifies that the
> floppy
> > code is broken
> > >  > with regard to Status0 and Read/Writes.
> Outside
> > of setting
> > >  > particular values in case of CRC errors/etc
> I
> > can't
> > >  > identify from datasheets what we should be
> > doing. I've
> > >  > tracked down what I believe is the original
> > mailing list
> > >  > post regarding this hack and it seems to be
> > related to
> > >  > Windows 2000 and higher OS's
> recognizing the
> > floppy
> > >  > drive. I applied the patch below and
> verified
> > that
> > >  > >   detection/read/writes/formatting
> still
> > work in
> > >  > Windows XP SP2.
> > >  > >
> > >  > >  Original post:
> > >  > >
> > >  >
> >
> http://lists.gnu.org/archive/html/qemu-devel/2004-10/msg00076.html
> > >  > >
> > >  > >  SVN change:
> > >  > >
> > >  >
> >
> http://svn.savannah.gnu.org/viewvc?view=rev&root=qemu&revision=1118
> > >  > >
> > >  > >  Having said the above does anyone
> know
> > what the
> > >  > comment in the hack is referencing? Is it
> still
> > needed? If
> > >  > so what needs to be done to eliminate it?
> > >  > >
> > >  > >  If it's no longer needed I
> propose the
> > patch
> > >  > below.
> > >  > >
> > >  > >  Justin
> > >  > >
> > >  > >  Changelog:
> > >  > >
> > >  > >  Remove Sense Interrupt hack
> > >  > >
> > >  > >  Signed-off-by: Justin Chevrier
> > >  > <theburner1@yahoo.com>
> > >  >
> > >  > It may be a hack, but if we remove it,
> Sparc64
> > refuses to
> > >  > boot and
> > >  > prints endlessly:
> > >  > SENSEI c0 00
> > >  > SENSEI c0 00
> > >  > SENSEI c0 00
> > >  > SENSEI c0 00
> > >
> > >
> > > Okay, thanks for the feedback!
> > >
> > >  I'll start looking into what SPARC64 expects
> > here.
> > 
> > The message is printed here:
> >
> http://tracker.coreboot.org/trac/openbios/browser/openbios-devel/drivers/floppy.c#L359
> 
> Thanks again!
> 
> Does the patch below work for you?
> 
> In this version we return 0xc0 (polling) for the first
> interrupt status after reset (Openserver appears to require
> this). After returning 0xc0 we set the Status0 register to
> 0x20 (seek complete). This should work as the spec says
> Sense Interrupt should be called up to 4 times to retrieve
> the queued status values. Tested successfully in both
> Windows 98 and XP SP2.
> 
> It also appears that the code referenced in the link loops
> infinitely due to a missing: "max_sensei--;" which
> is present in the Linux Kernel's equivalent code.
> 
> Justin

Sorry for the malformed patch. Corrected one:

--- hw/fdc.c    (revision 6125)
+++ hw/fdc.c    (working copy)
@@ -1601,20 +1601,13 @@
 {
     fdrive_t *cur_drv = get_cur_drv(fdctrl);

-#if 0
     fdctrl->fifo[0] =
         fdctrl->status0 | (cur_drv->head << 2) | GET_CUR_DRV(fdctrl);
-#else
-    /* XXX: status0 handling is broken for read/write
-       commands, so we do this hack. It should be suppressed
-       ASAP */
-    fdctrl->fifo[0] =
-        FD_SR0_SEEK | (cur_drv->head << 2) | GET_CUR_DRV(fdctrl);
-#endif
+
     fdctrl->fifo[1] = cur_drv->track;
     fdctrl_set_fifo(fdctrl, 2, 0);
     fdctrl_reset_irq(fdctrl);
-    fdctrl->status0 = FD_SR0_RDYCHG;
+    fdctrl->status0 = FD_SR0_SEEK;
 }

 static void fdctrl_handle_seek (fdctrl_t *fdctrl, int direction)


      

^ permalink raw reply	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2008-12-23 21:46 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-12-18 21:14 [Qemu-devel] [PATCH] Floppy: Remove Sense Interrupt Hack Justin Chevrier
2008-12-19 19:43 ` Blue Swirl
2008-12-19 21:41   ` Justin Chevrier
2008-12-20 10:54     ` Blue Swirl
2008-12-23 18:02 Justin Chevrier
2008-12-23 18:13 ` Blue Swirl
2008-12-23 18:30 ` Blue Swirl
2008-12-23 19:43   ` Carl-Daniel Hailfinger
2008-12-23 19:58     ` Blue Swirl
2008-12-23 21:46       ` Carl-Daniel Hailfinger
2008-12-23 18:13 Justin Chevrier

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.