From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Tomer Maimon <tmaimon77@gmail.com>, avifishman70@gmail.com, tali.perry1@gmail.com, joel@jms.id.au, venture@google.com, yuenn@google.com, benjaminfair@google.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, daniel.lezcano@linaro.org, tglx@linutronix.de, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, jirislaby@kernel.org, shawnguo@kernel.org, bjorn.andersson@linaro.org, geert+renesas@glider.be, marcel.ziswiler@toradex.com, vkoul@kernel.org, biju.das.jz@bp.renesas.com, nobuhiro1.iwamatsu@toshiba.co.jp, robert.hancock@calian.com, j.neuschaefer@gmx.net, lkundrak@v3.sk Cc: soc@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1 10/19] reset: npcm: using syscon instead of device data Date: Mon, 23 May 2022 10:54:46 +0200 [thread overview] Message-ID: <973d75b8-0eb6-ff5b-6cd2-9b7d7c5cbcaa@linaro.org> (raw) In-Reply-To: <20220522155046.260146-11-tmaimon77@gmail.com> On 22/05/2022 17:50, Tomer Maimon wrote: > Using syscon device tree property instead of > device data to handle the NPCM GCR registers. https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > --- > drivers/reset/reset-npcm.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/reset/reset-npcm.c b/drivers/reset/reset-npcm.c > index 2ea4d3136e15..0c963b21eddc 100644 > --- a/drivers/reset/reset-npcm.c > +++ b/drivers/reset/reset-npcm.c > @@ -138,8 +138,7 @@ static int npcm_reset_xlate(struct reset_controller_dev *rcdev, > } > > static const struct of_device_id npcm_rc_match[] = { > - { .compatible = "nuvoton,npcm750-reset", > - .data = (void *)"nuvoton,npcm750-gcr" }, > + { .compatible = "nuvoton,npcm750-reset"}, > { } > }; > > @@ -155,14 +154,10 @@ static int npcm_usb_reset(struct platform_device *pdev, struct npcm_rc_data *rc) > u32 ipsrst1_bits = 0; > u32 ipsrst2_bits = NPCM_IPSRST2_USB_HOST; > u32 ipsrst3_bits = 0; > - const char *gcr_dt; > > - gcr_dt = (const char *) > - of_match_device(dev->driver->of_match_table, dev)->data; > - > - gcr_regmap = syscon_regmap_lookup_by_compatible(gcr_dt); > + gcr_regmap = syscon_regmap_lookup_by_phandle(dev->of_node, "syscon"); I think this just broke all existing boards... Best regards, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Tomer Maimon <tmaimon77@gmail.com>, avifishman70@gmail.com, tali.perry1@gmail.com, joel@jms.id.au, venture@google.com, yuenn@google.com, benjaminfair@google.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, daniel.lezcano@linaro.org, tglx@linutronix.de, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, jirislaby@kernel.org, shawnguo@kernel.org, bjorn.andersson@linaro.org, geert+renesas@glider.be, marcel.ziswiler@toradex.com, vkoul@kernel.org, biju.das.jz@bp.renesas.com, nobuhiro1.iwamatsu@toshiba.co.jp, robert.hancock@calian.com, j.neuschaefer@gmx.net, lkundrak@v3.sk Cc: soc@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1 10/19] reset: npcm: using syscon instead of device data Date: Mon, 23 May 2022 10:54:46 +0200 [thread overview] Message-ID: <973d75b8-0eb6-ff5b-6cd2-9b7d7c5cbcaa@linaro.org> (raw) In-Reply-To: <20220522155046.260146-11-tmaimon77@gmail.com> On 22/05/2022 17:50, Tomer Maimon wrote: > Using syscon device tree property instead of > device data to handle the NPCM GCR registers. https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 > > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com> > --- > drivers/reset/reset-npcm.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/reset/reset-npcm.c b/drivers/reset/reset-npcm.c > index 2ea4d3136e15..0c963b21eddc 100644 > --- a/drivers/reset/reset-npcm.c > +++ b/drivers/reset/reset-npcm.c > @@ -138,8 +138,7 @@ static int npcm_reset_xlate(struct reset_controller_dev *rcdev, > } > > static const struct of_device_id npcm_rc_match[] = { > - { .compatible = "nuvoton,npcm750-reset", > - .data = (void *)"nuvoton,npcm750-gcr" }, > + { .compatible = "nuvoton,npcm750-reset"}, > { } > }; > > @@ -155,14 +154,10 @@ static int npcm_usb_reset(struct platform_device *pdev, struct npcm_rc_data *rc) > u32 ipsrst1_bits = 0; > u32 ipsrst2_bits = NPCM_IPSRST2_USB_HOST; > u32 ipsrst3_bits = 0; > - const char *gcr_dt; > > - gcr_dt = (const char *) > - of_match_device(dev->driver->of_match_table, dev)->data; > - > - gcr_regmap = syscon_regmap_lookup_by_compatible(gcr_dt); > + gcr_regmap = syscon_regmap_lookup_by_phandle(dev->of_node, "syscon"); I think this just broke all existing boards... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-23 8:54 UTC|newest] Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-22 15:50 [PATCH v1 00/19] Introduce Nuvoton Arbel NPCM8XX BMC SoC Tomer Maimon 2022-05-22 15:50 ` [PATCH v1 01/19] dt-bindings: timer: npcm: Add npcm845 compatible string Tomer Maimon 2022-05-23 7:31 ` Krzysztof Kozlowski 2022-05-23 7:31 ` Krzysztof Kozlowski 2022-05-22 15:50 ` [PATCH v1 02/19] clocksource: timer-npcm7xx: Add NPCM845 timer support Tomer Maimon 2022-05-22 15:50 ` [PATCH v1 03/19] dt-bindings: serial: 8250: Add npcm845 compatible string Tomer Maimon 2022-05-23 7:32 ` Krzysztof Kozlowski 2022-05-23 7:32 ` Krzysztof Kozlowski 2022-05-22 15:50 ` [PATCH v1 04/19] tty: serial: 8250: Add NPCM845 UART support Tomer Maimon 2022-05-23 9:56 ` Arnd Bergmann 2022-05-23 9:56 ` Arnd Bergmann 2022-05-23 12:58 ` Tomer Maimon 2022-05-23 13:06 ` Krzysztof Kozlowski 2022-05-23 13:06 ` Krzysztof Kozlowski 2022-05-23 13:14 ` Tomer Maimon 2022-05-22 15:50 ` [PATCH v1 05/19] dt-bindings: watchdog: npcm: Add npcm845 compatible string Tomer Maimon 2022-05-23 7:32 ` Krzysztof Kozlowski 2022-05-23 7:32 ` Krzysztof Kozlowski 2022-05-22 15:50 ` [PATCH v1 06/19] watchdog: npcm_wdt: Add NPCM845 watchdog support Tomer Maimon 2022-05-22 16:45 ` Guenter Roeck 2022-05-22 16:45 ` Guenter Roeck 2022-05-22 15:50 ` [PATCH v1 07/19] dt-binding: clk: npcm845: Add binding for Nuvoton NPCM8XX Clock Tomer Maimon 2022-05-23 7:35 ` Krzysztof Kozlowski 2022-05-23 7:35 ` Krzysztof Kozlowski 2022-05-23 13:35 ` Tomer Maimon 2022-05-26 19:24 ` Stephen Boyd 2022-05-26 19:24 ` Stephen Boyd 2022-05-30 14:39 ` Tomer Maimon 2022-05-30 14:39 ` Tomer Maimon 2022-05-22 15:50 ` [PATCH v1 08/19] clk: npcm8xx: add clock controller Tomer Maimon 2022-05-23 7:07 ` Ilpo Järvinen 2022-05-23 7:07 ` Ilpo Järvinen 2022-05-23 12:48 ` Tomer Maimon 2022-05-26 19:36 ` Stephen Boyd 2022-05-26 19:36 ` Stephen Boyd 2022-05-30 14:36 ` Tomer Maimon 2022-05-30 14:36 ` Tomer Maimon 2022-05-22 15:50 ` [PATCH v1 09/19] dt-bindings: reset: add syscon property Tomer Maimon 2022-05-23 7:39 ` Krzysztof Kozlowski 2022-05-23 7:39 ` Krzysztof Kozlowski 2022-05-23 13:44 ` Tomer Maimon 2022-05-23 13:45 ` Krzysztof Kozlowski 2022-05-23 13:45 ` Krzysztof Kozlowski 2022-05-22 15:50 ` [PATCH v1 10/19] reset: npcm: using syscon instead of device data Tomer Maimon 2022-05-23 8:54 ` Krzysztof Kozlowski [this message] 2022-05-23 8:54 ` Krzysztof Kozlowski 2022-05-23 13:53 ` Tomer Maimon 2022-05-22 15:50 ` [PATCH v1 11/19] dt-bindings: reset: npcm: Add support for NPCM8XX Tomer Maimon 2022-05-23 9:01 ` Krzysztof Kozlowski 2022-05-23 9:01 ` Krzysztof Kozlowski 2022-05-23 14:03 ` Tomer Maimon 2022-05-23 14:22 ` Geert Uytterhoeven 2022-05-23 14:22 ` Geert Uytterhoeven 2022-05-23 14:26 ` Krzysztof Kozlowski 2022-05-23 14:26 ` Krzysztof Kozlowski 2022-05-23 15:11 ` Geert Uytterhoeven 2022-05-23 15:11 ` Geert Uytterhoeven 2022-05-23 15:22 ` Krzysztof Kozlowski 2022-05-23 15:22 ` Krzysztof Kozlowski 2022-05-23 15:24 ` Krzysztof Kozlowski 2022-05-23 15:24 ` Krzysztof Kozlowski 2022-05-24 7:26 ` Tomer Maimon 2022-05-24 7:26 ` Tomer Maimon 2022-05-23 14:23 ` Krzysztof Kozlowski 2022-05-23 14:23 ` Krzysztof Kozlowski 2022-05-22 15:50 ` [PATCH v1 12/19] reset: npcm: Add NPCM8XX support Tomer Maimon 2022-05-23 10:44 ` Arnd Bergmann 2022-05-23 10:44 ` Arnd Bergmann 2022-05-22 15:50 ` [PATCH v1 13/19] dt-bindings: arm: npcm: Add maintainer Tomer Maimon 2022-06-02 12:58 ` Rob Herring 2022-06-02 12:58 ` Rob Herring 2022-05-22 15:50 ` [PATCH v1 14/19] dt-bindings: arm: npcm: Add nuvoton,npcm845 compatible string Tomer Maimon 2022-05-23 9:02 ` Krzysztof Kozlowski 2022-05-23 9:02 ` Krzysztof Kozlowski 2022-05-22 15:50 ` [PATCH v1 15/19] dt-bindings: arm: npcm: Add nuvoton,npcm845 GCR " Tomer Maimon 2022-05-23 9:02 ` Krzysztof Kozlowski 2022-05-23 9:02 ` [PATCH v1 15/19] dt-bindings: arm: npcm: Add nuvoton, npcm845 " Krzysztof Kozlowski 2022-05-23 9:02 ` [PATCH v1 15/19] dt-bindings: arm: npcm: Add nuvoton,npcm845 " Krzysztof Kozlowski 2022-05-23 9:02 ` [PATCH v1 15/19] dt-bindings: arm: npcm: Add nuvoton, npcm845 " Krzysztof Kozlowski 2022-05-22 15:50 ` [PATCH v1 16/19] arm64: npcm: Add support for Nuvoton NPCM8XX BMC SoC Tomer Maimon 2022-05-22 15:50 ` [PATCH v1 17/19] arm64: dts: nuvoton: Add initial NPCM8XX device tree Tomer Maimon 2022-05-23 9:08 ` Krzysztof Kozlowski 2022-05-23 9:08 ` Krzysztof Kozlowski 2022-05-23 13:58 ` Geert Uytterhoeven 2022-05-23 13:58 ` Geert Uytterhoeven 2022-05-23 14:16 ` Krzysztof Kozlowski 2022-05-23 14:16 ` Krzysztof Kozlowski 2022-05-22 15:50 ` [PATCH v1 18/19] arm64: dts: nuvoton: Add initial NPCM845 EVB " Tomer Maimon 2022-05-23 9:26 ` Krzysztof Kozlowski 2022-05-23 9:26 ` Krzysztof Kozlowski 2022-05-23 9:39 ` Arnd Bergmann 2022-05-23 9:39 ` Arnd Bergmann 2022-05-23 14:17 ` Tomer Maimon 2022-05-23 15:37 ` Krzysztof Kozlowski 2022-05-23 15:37 ` Krzysztof Kozlowski 2022-05-22 15:50 ` [PATCH v1 19/19] arm64: defconfig: Add Nuvoton NPCM family support Tomer Maimon 2022-05-23 9:52 ` [PATCH v1 00/19] Introduce Nuvoton Arbel NPCM8XX BMC SoC Arnd Bergmann 2022-05-23 9:52 ` Arnd Bergmann 2022-05-23 12:20 ` Tomer Maimon 2022-05-30 12:24 ` Andy Shevchenko 2022-05-30 12:24 ` Andy Shevchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=973d75b8-0eb6-ff5b-6cd2-9b7d7c5cbcaa@linaro.org \ --to=krzysztof.kozlowski@linaro.org \ --cc=arnd@arndb.de \ --cc=avifishman70@gmail.com \ --cc=benjaminfair@google.com \ --cc=biju.das.jz@bp.renesas.com \ --cc=bjorn.andersson@linaro.org \ --cc=catalin.marinas@arm.com \ --cc=daniel.lezcano@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=geert+renesas@glider.be \ --cc=gregkh@linuxfoundation.org \ --cc=j.neuschaefer@gmx.net \ --cc=jirislaby@kernel.org \ --cc=joel@jms.id.au \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=linux-watchdog@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=lkundrak@v3.sk \ --cc=marcel.ziswiler@toradex.com \ --cc=mturquette@baylibre.com \ --cc=nobuhiro1.iwamatsu@toshiba.co.jp \ --cc=olof@lixom.net \ --cc=p.zabel@pengutronix.de \ --cc=robert.hancock@calian.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ --cc=shawnguo@kernel.org \ --cc=soc@kernel.org \ --cc=tali.perry1@gmail.com \ --cc=tglx@linutronix.de \ --cc=tmaimon77@gmail.com \ --cc=venture@google.com \ --cc=vkoul@kernel.org \ --cc=will@kernel.org \ --cc=wim@linux-watchdog.org \ --cc=yuenn@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.