From: "Tian, Kevin" <kevin.tian@intel.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"airlied@linux.ie" <airlied@linux.ie>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Chen, Tiejun" <tiejun.chen@intel.com>,
"Kay, Allen M" <allen.m.kay@intel.com>
Subject: RE: [Xen-devel] [Intel-gfx] [RFC][PATCH] gpu:drm:i915:intel_detect_pch: back to check devfn instead of check class type
Date: Fri, 11 Jul 2014 20:30:59 +0000 [thread overview]
Message-ID: <AADFC41AFE54684AB9EE6CBC0274A5D125FCD743@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20140711194206.GI23257@laptop.dumpdata.com>
> From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@oracle.com]
> Sent: Friday, July 11, 2014 12:42 PM
>
> On Fri, Jul 11, 2014 at 08:29:56AM +0200, Daniel Vetter wrote:
> > On Thu, Jul 10, 2014 at 09:08:24PM +0000, Tian, Kevin wrote:
> > > actually I'm curious whether it's still necessary to __detect__ PCH. Could
> > > we assume a 1:1 mapping between GPU and PCH, e.g. BDW already hard
> > > code the knowledge:
> > >
> > > } else if (IS_BROADWELL(dev)) {
> > > dev_priv->pch_type = PCH_LPT;
> > > dev_priv->pch_id =
> > >
> INTEL_PCH_LPT_LP_DEVICE_ID_TYPE;
> > > DRM_DEBUG_KMS("This is Broadwell,
> assuming "
> > > "LynxPoint LP PCH\n");
> > >
> > > Or if there is real usage on non-fixed mapping (not majority), could it be a
> > > better option to have fixed mapping as a fallback instead of leaving as
> > > PCH_NONE? Then even when Qemu doesn't provide a special tweaked
> PCH,
> > > the majority case just works.
> >
> > I guess we can do it, at least I haven't seen any strange combinations in
> > the wild outside of Intel ...
>
> How big is the QA matrix for this? Would it make sense to just
> include the latest hardware (say going two generations back)
> and ignore the older one?
suppose minimal or no QA effort on bare metal, if we only conservatively
change the fallback path which is today not supposed to function with
PCH_NONE. so it's only same amount of QA effort as whatever else is
proposed in this passthru upstreaming task. I agree no need to cover
older model, possibly just snb, ivb and hsw, but will leave Tiejun to answer
the overall goal.
Thanks
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"airlied@linux.ie" <airlied@linux.ie>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Chen, Tiejun" <tiejun.chen@intel.com>,
"Kay, Allen M" <allen.m.kay@intel.com>
Subject: Re: [Qemu-devel] [Xen-devel] [Intel-gfx] [RFC][PATCH] gpu:drm:i915:intel_detect_pch: back to check devfn instead of check class type
Date: Fri, 11 Jul 2014 20:30:59 +0000 [thread overview]
Message-ID: <AADFC41AFE54684AB9EE6CBC0274A5D125FCD743@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20140711194206.GI23257@laptop.dumpdata.com>
> From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@oracle.com]
> Sent: Friday, July 11, 2014 12:42 PM
>
> On Fri, Jul 11, 2014 at 08:29:56AM +0200, Daniel Vetter wrote:
> > On Thu, Jul 10, 2014 at 09:08:24PM +0000, Tian, Kevin wrote:
> > > actually I'm curious whether it's still necessary to __detect__ PCH. Could
> > > we assume a 1:1 mapping between GPU and PCH, e.g. BDW already hard
> > > code the knowledge:
> > >
> > > } else if (IS_BROADWELL(dev)) {
> > > dev_priv->pch_type = PCH_LPT;
> > > dev_priv->pch_id =
> > >
> INTEL_PCH_LPT_LP_DEVICE_ID_TYPE;
> > > DRM_DEBUG_KMS("This is Broadwell,
> assuming "
> > > "LynxPoint LP PCH\n");
> > >
> > > Or if there is real usage on non-fixed mapping (not majority), could it be a
> > > better option to have fixed mapping as a fallback instead of leaving as
> > > PCH_NONE? Then even when Qemu doesn't provide a special tweaked
> PCH,
> > > the majority case just works.
> >
> > I guess we can do it, at least I haven't seen any strange combinations in
> > the wild outside of Intel ...
>
> How big is the QA matrix for this? Would it make sense to just
> include the latest hardware (say going two generations back)
> and ignore the older one?
suppose minimal or no QA effort on bare metal, if we only conservatively
change the fallback path which is today not supposed to function with
PCH_NONE. so it's only same amount of QA effort as whatever else is
proposed in this passthru upstreaming task. I agree no need to cover
older model, possibly just snb, ivb and hsw, but will leave Tiejun to answer
the overall goal.
Thanks
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"airlied@linux.ie" <airlied@linux.ie>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Chen, Tiejun" <tiejun.chen@intel.com>,
"Kay, Allen M" <allen.m.kay@intel.com>
Subject: Re: [Xen-devel] [RFC][PATCH] gpu:drm:i915:intel_detect_pch: back to check devfn instead of check class type
Date: Fri, 11 Jul 2014 20:30:59 +0000 [thread overview]
Message-ID: <AADFC41AFE54684AB9EE6CBC0274A5D125FCD743@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20140711194206.GI23257@laptop.dumpdata.com>
> From: Konrad Rzeszutek Wilk [mailto:konrad.wilk@oracle.com]
> Sent: Friday, July 11, 2014 12:42 PM
>
> On Fri, Jul 11, 2014 at 08:29:56AM +0200, Daniel Vetter wrote:
> > On Thu, Jul 10, 2014 at 09:08:24PM +0000, Tian, Kevin wrote:
> > > actually I'm curious whether it's still necessary to __detect__ PCH. Could
> > > we assume a 1:1 mapping between GPU and PCH, e.g. BDW already hard
> > > code the knowledge:
> > >
> > > } else if (IS_BROADWELL(dev)) {
> > > dev_priv->pch_type = PCH_LPT;
> > > dev_priv->pch_id =
> > >
> INTEL_PCH_LPT_LP_DEVICE_ID_TYPE;
> > > DRM_DEBUG_KMS("This is Broadwell,
> assuming "
> > > "LynxPoint LP PCH\n");
> > >
> > > Or if there is real usage on non-fixed mapping (not majority), could it be a
> > > better option to have fixed mapping as a fallback instead of leaving as
> > > PCH_NONE? Then even when Qemu doesn't provide a special tweaked
> PCH,
> > > the majority case just works.
> >
> > I guess we can do it, at least I haven't seen any strange combinations in
> > the wild outside of Intel ...
>
> How big is the QA matrix for this? Would it make sense to just
> include the latest hardware (say going two generations back)
> and ignore the older one?
suppose minimal or no QA effort on bare metal, if we only conservatively
change the fallback path which is today not supposed to function with
PCH_NONE. so it's only same amount of QA effort as whatever else is
proposed in this passthru upstreaming task. I agree no need to cover
older model, possibly just snb, ivb and hsw, but will leave Tiejun to answer
the overall goal.
Thanks
Kevin
next prev parent reply other threads:[~2014-07-11 20:36 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 9:53 [RFC][PATCH] gpu:drm:i915:intel_detect_pch: back to check devfn instead of check class type Tiejun Chen
2014-06-19 9:53 ` Tiejun Chen
2014-06-19 9:53 ` [Qemu-devel] " Tiejun Chen
2014-06-20 9:40 ` Chen, Tiejun
2014-06-20 9:40 ` Chen, Tiejun
2014-06-20 9:40 ` [Qemu-devel] " Chen, Tiejun
2014-06-20 12:32 ` Daniel Vetter
2014-06-20 12:32 ` Daniel Vetter
2014-06-20 12:32 ` [Qemu-devel] " Daniel Vetter
2014-06-22 8:00 ` Chen, Tiejun
2014-06-22 8:00 ` Chen, Tiejun
2014-06-22 8:00 ` [Qemu-devel] " Chen, Tiejun
2014-06-20 12:48 ` Paolo Bonzini
2014-06-20 12:48 ` [Qemu-devel] " Paolo Bonzini
2014-06-22 8:25 ` Chen, Tiejun
2014-06-22 8:25 ` [Qemu-devel] " Chen, Tiejun
2014-06-25 6:48 ` Paolo Bonzini
2014-06-25 6:48 ` [Qemu-devel] " Paolo Bonzini
2014-06-25 7:34 ` Chen, Tiejun
2014-06-25 7:34 ` [Qemu-devel] " Chen, Tiejun
2014-06-25 7:55 ` Paolo Bonzini
2014-06-25 7:55 ` [Qemu-devel] " Paolo Bonzini
2014-06-30 3:13 ` Chen, Tiejun
2014-06-30 3:13 ` [Qemu-devel] " Chen, Tiejun
2014-06-30 10:56 ` Paolo Bonzini
2014-06-30 10:56 ` [Qemu-devel] " Paolo Bonzini
2014-07-07 14:49 ` Daniel Vetter
2014-07-07 14:49 ` Daniel Vetter
2014-07-07 14:49 ` [Qemu-devel] " Daniel Vetter
2014-07-07 14:57 ` Paolo Bonzini
2014-07-07 14:57 ` [Qemu-devel] " Paolo Bonzini
2014-07-07 17:54 ` [Intel-gfx] " Daniel Vetter
2014-07-07 17:54 ` Daniel Vetter
2014-07-07 17:54 ` [Qemu-devel] " Daniel Vetter
2014-07-07 17:58 ` Paolo Bonzini
2014-07-07 17:58 ` [Qemu-devel] " Paolo Bonzini
2014-07-07 18:40 ` Daniel Vetter
2014-07-07 18:40 ` Daniel Vetter
2014-07-07 18:40 ` [Qemu-devel] [Intel-gfx] " Daniel Vetter
2014-07-10 21:08 ` Tian, Kevin
2014-07-10 21:08 ` Tian, Kevin
2014-07-10 21:08 ` [Qemu-devel] [Intel-gfx] " Tian, Kevin
2014-07-11 6:29 ` Daniel Vetter
2014-07-11 6:29 ` Daniel Vetter
2014-07-11 6:29 ` [Qemu-devel] " Daniel Vetter
2014-07-11 19:42 ` [Xen-devel] " Konrad Rzeszutek Wilk
2014-07-11 19:42 ` [Xen-devel] " Konrad Rzeszutek Wilk
2014-07-11 19:42 ` [Qemu-devel] [Xen-devel] [Intel-gfx] " Konrad Rzeszutek Wilk
2014-07-11 20:30 ` Tian, Kevin [this message]
2014-07-11 20:30 ` [Xen-devel] " Tian, Kevin
2014-07-11 20:30 ` [Qemu-devel] [Xen-devel] [Intel-gfx] " Tian, Kevin
2014-07-12 10:13 ` [Intel-gfx] [Xen-devel] " Daniel Vetter
2014-07-12 10:13 ` Daniel Vetter
2014-07-12 10:13 ` [Qemu-devel] [Intel-gfx] " Daniel Vetter
2014-06-24 2:59 ` [Intel-gfx] " Zhenyu Wang
2014-06-24 2:59 ` Zhenyu Wang
2014-06-24 2:59 ` [Qemu-devel] [Intel-gfx] " Zhenyu Wang
2014-06-25 2:28 ` Chen, Tiejun
2014-06-25 2:28 ` Chen, Tiejun
2014-06-25 2:28 ` [Qemu-devel] [Intel-gfx] " Chen, Tiejun
2014-07-07 14:51 ` Daniel Vetter
2014-07-07 14:51 ` Daniel Vetter
2014-07-07 14:51 ` [Qemu-devel] " Daniel Vetter
2014-06-30 11:18 ` Michael S. Tsirkin
2014-06-30 11:18 ` Michael S. Tsirkin
2014-06-30 11:18 ` [Qemu-devel] " Michael S. Tsirkin
2014-07-01 1:52 ` Chen, Tiejun
2014-07-01 1:52 ` Chen, Tiejun
2014-07-01 1:52 ` [Qemu-devel] " Chen, Tiejun
2014-07-02 6:21 ` Michael S. Tsirkin
2014-07-02 6:21 ` Michael S. Tsirkin
2014-07-02 6:21 ` [Qemu-devel] " Michael S. Tsirkin
2014-07-02 8:27 ` Chen, Tiejun
2014-07-02 8:27 ` Chen, Tiejun
2014-07-02 8:27 ` [Qemu-devel] " Chen, Tiejun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AADFC41AFE54684AB9EE6CBC0274A5D125FCD743@SHSMSX101.ccr.corp.intel.com \
--to=kevin.tian@intel.com \
--cc=airlied@linux.ie \
--cc=allen.m.kay@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tiejun.chen@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.