From: "Tian, Kevin" <kevin.tian@intel.com> To: Jacob Pan <jacob.jun.pan@linux.intel.com>, "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>, LKML <linux-kernel@vger.kernel.org>, Joerg Roedel <joro@8bytes.org>, "David Woodhouse" <dwmw2@infradead.org>, Alex Williamson <alex.williamson@redhat.com>, Jean-Philippe Brucker <jean-philippe@linaro.com> Cc: "Liu, Yi L" <yi.l.liu@intel.com>, "Raj, Ashok" <ashok.raj@intel.com>, Christoph Hellwig <hch@infradead.org>, Lu Baolu <baolu.lu@linux.intel.com>, Jonathan Cameron <jic23@kernel.org>, Eric Auger <eric.auger@redhat.com> Subject: RE: [PATCH v7 06/11] iommu/vt-d: Avoid duplicated code for PASID setup Date: Fri, 25 Oct 2019 06:42:54 +0000 [thread overview] Message-ID: <AADFC41AFE54684AB9EE6CBC0274A5D19D5CDCA0@SHSMSX104.ccr.corp.intel.com> (raw) In-Reply-To: <1571946904-86776-7-git-send-email-jacob.jun.pan@linux.intel.com> > From: Jacob Pan [mailto:jacob.jun.pan@linux.intel.com] > Sent: Friday, October 25, 2019 3:55 AM > > After each setup for PASID entry, related translation caches must be > flushed. > We can combine duplicated code into one function which is less error > prone. > > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com> similarly, it doesn't need to be in this series. > --- > drivers/iommu/intel-pasid.c | 48 +++++++++++++++++--------------------------- > - > 1 file changed, 18 insertions(+), 30 deletions(-) > > diff --git a/drivers/iommu/intel-pasid.c b/drivers/iommu/intel-pasid.c > index e79d680fe300..ffbd416ed3b8 100644 > --- a/drivers/iommu/intel-pasid.c > +++ b/drivers/iommu/intel-pasid.c > @@ -485,6 +485,21 @@ void intel_pasid_tear_down_entry(struct > intel_iommu *iommu, > devtlb_invalidation_with_pasid(iommu, dev, pasid); > } > > +static void pasid_flush_caches(struct intel_iommu *iommu, > + struct pasid_entry *pte, > + int pasid, u16 did) > +{ > + if (!ecap_coherent(iommu->ecap)) > + clflush_cache_range(pte, sizeof(*pte)); > + > + if (cap_caching_mode(iommu->cap)) { > + pasid_cache_invalidation_with_pasid(iommu, did, pasid); > + iotlb_invalidation_with_pasid(iommu, did, pasid); > + } else { > + iommu_flush_write_buffer(iommu); > + } > +} > + > /* > * Set up the scalable mode pasid table entry for first only > * translation type. > @@ -530,16 +545,7 @@ int intel_pasid_setup_first_level(struct > intel_iommu *iommu, > /* Setup Present and PASID Granular Transfer Type: */ > pasid_set_translation_type(pte, 1); > pasid_set_present(pte); > - > - if (!ecap_coherent(iommu->ecap)) > - clflush_cache_range(pte, sizeof(*pte)); > - > - if (cap_caching_mode(iommu->cap)) { > - pasid_cache_invalidation_with_pasid(iommu, did, pasid); > - iotlb_invalidation_with_pasid(iommu, did, pasid); > - } else { > - iommu_flush_write_buffer(iommu); > - } > + pasid_flush_caches(iommu, pte, pasid, did); > > return 0; > } > @@ -603,16 +609,7 @@ int intel_pasid_setup_second_level(struct > intel_iommu *iommu, > */ > pasid_set_sre(pte); > pasid_set_present(pte); > - > - if (!ecap_coherent(iommu->ecap)) > - clflush_cache_range(pte, sizeof(*pte)); > - > - if (cap_caching_mode(iommu->cap)) { > - pasid_cache_invalidation_with_pasid(iommu, did, pasid); > - iotlb_invalidation_with_pasid(iommu, did, pasid); > - } else { > - iommu_flush_write_buffer(iommu); > - } > + pasid_flush_caches(iommu, pte, pasid, did); > > return 0; > } > @@ -646,16 +643,7 @@ int intel_pasid_setup_pass_through(struct > intel_iommu *iommu, > */ > pasid_set_sre(pte); > pasid_set_present(pte); > - > - if (!ecap_coherent(iommu->ecap)) > - clflush_cache_range(pte, sizeof(*pte)); > - > - if (cap_caching_mode(iommu->cap)) { > - pasid_cache_invalidation_with_pasid(iommu, did, pasid); > - iotlb_invalidation_with_pasid(iommu, did, pasid); > - } else { > - iommu_flush_write_buffer(iommu); > - } > + pasid_flush_caches(iommu, pte, pasid, did); > > return 0; > } > -- > 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: "Tian, Kevin" <kevin.tian@intel.com> To: Jacob Pan <jacob.jun.pan@linux.intel.com>, "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>, LKML <linux-kernel@vger.kernel.org>, Joerg Roedel <joro@8bytes.org>, "David Woodhouse" <dwmw2@infradead.org>, Alex Williamson <alex.williamson@redhat.com>, Jean-Philippe Brucker <jean-philippe@linaro.com> Cc: "Raj, Ashok" <ashok.raj@intel.com>, Jonathan Cameron <jic23@kernel.org> Subject: RE: [PATCH v7 06/11] iommu/vt-d: Avoid duplicated code for PASID setup Date: Fri, 25 Oct 2019 06:42:54 +0000 [thread overview] Message-ID: <AADFC41AFE54684AB9EE6CBC0274A5D19D5CDCA0@SHSMSX104.ccr.corp.intel.com> (raw) In-Reply-To: <1571946904-86776-7-git-send-email-jacob.jun.pan@linux.intel.com> > From: Jacob Pan [mailto:jacob.jun.pan@linux.intel.com] > Sent: Friday, October 25, 2019 3:55 AM > > After each setup for PASID entry, related translation caches must be > flushed. > We can combine duplicated code into one function which is less error > prone. > > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com> similarly, it doesn't need to be in this series. > --- > drivers/iommu/intel-pasid.c | 48 +++++++++++++++++--------------------------- > - > 1 file changed, 18 insertions(+), 30 deletions(-) > > diff --git a/drivers/iommu/intel-pasid.c b/drivers/iommu/intel-pasid.c > index e79d680fe300..ffbd416ed3b8 100644 > --- a/drivers/iommu/intel-pasid.c > +++ b/drivers/iommu/intel-pasid.c > @@ -485,6 +485,21 @@ void intel_pasid_tear_down_entry(struct > intel_iommu *iommu, > devtlb_invalidation_with_pasid(iommu, dev, pasid); > } > > +static void pasid_flush_caches(struct intel_iommu *iommu, > + struct pasid_entry *pte, > + int pasid, u16 did) > +{ > + if (!ecap_coherent(iommu->ecap)) > + clflush_cache_range(pte, sizeof(*pte)); > + > + if (cap_caching_mode(iommu->cap)) { > + pasid_cache_invalidation_with_pasid(iommu, did, pasid); > + iotlb_invalidation_with_pasid(iommu, did, pasid); > + } else { > + iommu_flush_write_buffer(iommu); > + } > +} > + > /* > * Set up the scalable mode pasid table entry for first only > * translation type. > @@ -530,16 +545,7 @@ int intel_pasid_setup_first_level(struct > intel_iommu *iommu, > /* Setup Present and PASID Granular Transfer Type: */ > pasid_set_translation_type(pte, 1); > pasid_set_present(pte); > - > - if (!ecap_coherent(iommu->ecap)) > - clflush_cache_range(pte, sizeof(*pte)); > - > - if (cap_caching_mode(iommu->cap)) { > - pasid_cache_invalidation_with_pasid(iommu, did, pasid); > - iotlb_invalidation_with_pasid(iommu, did, pasid); > - } else { > - iommu_flush_write_buffer(iommu); > - } > + pasid_flush_caches(iommu, pte, pasid, did); > > return 0; > } > @@ -603,16 +609,7 @@ int intel_pasid_setup_second_level(struct > intel_iommu *iommu, > */ > pasid_set_sre(pte); > pasid_set_present(pte); > - > - if (!ecap_coherent(iommu->ecap)) > - clflush_cache_range(pte, sizeof(*pte)); > - > - if (cap_caching_mode(iommu->cap)) { > - pasid_cache_invalidation_with_pasid(iommu, did, pasid); > - iotlb_invalidation_with_pasid(iommu, did, pasid); > - } else { > - iommu_flush_write_buffer(iommu); > - } > + pasid_flush_caches(iommu, pte, pasid, did); > > return 0; > } > @@ -646,16 +643,7 @@ int intel_pasid_setup_pass_through(struct > intel_iommu *iommu, > */ > pasid_set_sre(pte); > pasid_set_present(pte); > - > - if (!ecap_coherent(iommu->ecap)) > - clflush_cache_range(pte, sizeof(*pte)); > - > - if (cap_caching_mode(iommu->cap)) { > - pasid_cache_invalidation_with_pasid(iommu, did, pasid); > - iotlb_invalidation_with_pasid(iommu, did, pasid); > - } else { > - iommu_flush_write_buffer(iommu); > - } > + pasid_flush_caches(iommu, pte, pasid, did); > > return 0; > } > -- > 2.7.4 _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2019-10-25 6:43 UTC|newest] Thread overview: 158+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-24 19:54 [PATCH v7 00/11] Nested Shared Virtual Address (SVA) VT-d support Jacob Pan 2019-10-24 19:54 ` Jacob Pan 2019-10-24 19:54 ` [PATCH v7 01/11] iommu/vt-d: Cache virtual command capability register Jacob Pan 2019-10-24 19:54 ` Jacob Pan 2019-10-25 2:53 ` Lu Baolu 2019-10-25 2:53 ` Lu Baolu 2019-10-25 6:06 ` Tian, Kevin 2019-10-25 6:06 ` Tian, Kevin 2019-11-08 10:32 ` Auger Eric 2019-11-08 10:32 ` Auger Eric 2019-10-24 19:54 ` [PATCH v7 02/11] iommu/vt-d: Enlightened PASID allocation Jacob Pan 2019-10-24 19:54 ` Jacob Pan 2019-10-25 6:19 ` Tian, Kevin 2019-10-25 6:19 ` Tian, Kevin 2019-10-29 17:14 ` Jacob Pan 2019-10-29 17:14 ` Jacob Pan 2019-10-29 18:16 ` Tian, Kevin 2019-10-29 18:16 ` Tian, Kevin 2019-11-08 10:33 ` Auger Eric 2019-11-08 10:33 ` Auger Eric 2019-11-08 22:22 ` Jacob Pan 2019-11-08 22:22 ` Jacob Pan 2019-10-24 19:54 ` [PATCH v7 03/11] iommu/vt-d: Add custom allocator for IOASID Jacob Pan 2019-10-24 19:54 ` Jacob Pan 2019-10-25 2:30 ` Lu Baolu 2019-10-25 2:30 ` Lu Baolu 2019-10-25 4:43 ` Jacob Pan 2019-10-25 4:43 ` Jacob Pan 2019-10-25 6:40 ` Tian, Kevin 2019-10-25 6:40 ` Tian, Kevin 2019-10-25 14:39 ` Lu Baolu 2019-10-25 14:39 ` Lu Baolu 2019-10-25 15:52 ` Tian, Kevin 2019-10-25 15:52 ` Tian, Kevin 2019-10-28 22:49 ` Jacob Pan 2019-10-28 22:49 ` Jacob Pan 2019-10-29 2:22 ` Lu Baolu 2019-10-29 2:22 ` Lu Baolu 2019-10-25 6:31 ` Tian, Kevin 2019-10-25 6:31 ` Tian, Kevin 2019-10-28 22:52 ` Jacob Pan 2019-10-28 22:52 ` Jacob Pan 2019-11-08 10:40 ` Auger Eric 2019-11-08 10:40 ` Auger Eric 2019-11-08 22:26 ` Jacob Pan 2019-11-08 22:26 ` Jacob Pan 2019-10-24 19:54 ` [PATCH v7 04/11] iommu/vt-d: Replace Intel specific PASID allocator with IOASID Jacob Pan 2019-10-24 19:54 ` Jacob Pan 2019-10-25 5:47 ` Lu Baolu 2019-10-25 5:47 ` Lu Baolu 2019-11-01 18:29 ` Jacob Pan 2019-11-01 18:29 ` Jacob Pan 2019-10-25 6:41 ` Tian, Kevin 2019-10-25 6:41 ` Tian, Kevin 2019-10-28 22:46 ` Jacob Pan 2019-10-28 22:46 ` Jacob Pan 2019-11-08 11:30 ` Auger Eric 2019-11-08 11:30 ` Auger Eric 2019-11-08 22:55 ` Jacob Pan 2019-11-08 22:55 ` Jacob Pan 2019-11-12 9:54 ` Auger Eric 2019-11-12 9:54 ` Auger Eric 2019-10-24 19:54 ` [PATCH v7 05/11] iommu/vt-d: Move domain helper to header Jacob Pan 2019-10-24 19:54 ` Jacob Pan 2019-10-25 5:26 ` Lu Baolu 2019-10-25 5:26 ` Lu Baolu 2019-10-24 19:54 ` [PATCH v7 06/11] iommu/vt-d: Avoid duplicated code for PASID setup Jacob Pan 2019-10-24 19:54 ` Jacob Pan 2019-10-25 5:32 ` Lu Baolu 2019-10-25 5:32 ` Lu Baolu 2019-10-25 6:42 ` Tian, Kevin [this message] 2019-10-25 6:42 ` Tian, Kevin 2019-10-28 22:41 ` Jacob Pan 2019-10-28 22:41 ` Jacob Pan 2019-11-12 9:54 ` Auger Eric 2019-11-12 9:54 ` Auger Eric 2019-10-24 19:55 ` [PATCH v7 07/11] iommu/vt-d: Add nested translation helper function Jacob Pan 2019-10-24 19:55 ` Jacob Pan 2019-10-25 7:04 ` Tian, Kevin 2019-10-25 7:04 ` Tian, Kevin 2019-11-01 21:10 ` Jacob Pan 2019-11-01 21:10 ` Jacob Pan 2019-10-25 15:04 ` Lu Baolu 2019-10-25 15:04 ` Lu Baolu 2019-10-25 16:06 ` Jacob Pan 2019-10-25 16:06 ` Jacob Pan 2019-11-08 13:55 ` Auger Eric 2019-11-08 13:55 ` Auger Eric 2019-10-24 19:55 ` [PATCH v7 08/11] iommu/vt-d: Misc macro clean up for SVM Jacob Pan 2019-10-24 19:55 ` Jacob Pan 2019-10-26 1:00 ` Lu Baolu 2019-10-26 1:00 ` Lu Baolu 2019-10-28 22:38 ` Jacob Pan 2019-10-28 22:38 ` Jacob Pan 2019-10-24 19:55 ` [PATCH v7 09/11] iommu/vt-d: Add bind guest PASID support Jacob Pan 2019-10-24 19:55 ` Jacob Pan 2019-10-25 7:19 ` Tian, Kevin 2019-10-25 7:19 ` Tian, Kevin 2019-10-25 17:33 ` Jacob Pan 2019-10-25 17:33 ` Jacob Pan 2019-10-28 6:03 ` Tian, Kevin 2019-10-28 6:03 ` Tian, Kevin 2019-10-28 16:02 ` Jacob Pan 2019-10-28 16:02 ` Jacob Pan 2019-10-29 7:57 ` Tian, Kevin 2019-10-29 7:57 ` Tian, Kevin 2019-10-29 16:11 ` Jacob Pan 2019-10-29 16:11 ` Jacob Pan 2019-10-29 18:04 ` Tian, Kevin 2019-10-29 18:04 ` Tian, Kevin 2019-10-29 2:33 ` Lu Baolu 2019-10-29 2:33 ` Lu Baolu 2019-10-26 2:01 ` Lu Baolu 2019-10-26 2:01 ` Lu Baolu 2019-10-28 22:29 ` Jacob Pan 2019-10-28 22:29 ` Jacob Pan 2019-10-29 2:54 ` Lu Baolu 2019-10-29 2:54 ` Lu Baolu 2019-10-29 4:11 ` Jacob Pan 2019-10-29 4:11 ` Jacob Pan 2019-10-29 5:04 ` Lu Baolu 2019-10-29 5:04 ` Lu Baolu 2019-10-24 19:55 ` [PATCH v7 10/11] iommu/vt-d: Support flushing more translation cache types Jacob Pan 2019-10-24 19:55 ` Jacob Pan 2019-10-25 7:21 ` Tian, Kevin 2019-10-25 7:21 ` Tian, Kevin 2019-11-01 21:30 ` Jacob Pan 2019-11-01 21:30 ` Jacob Pan 2019-10-26 2:22 ` Lu Baolu 2019-10-26 2:22 ` Lu Baolu 2019-11-01 21:28 ` Jacob Pan 2019-11-01 21:28 ` Jacob Pan 2019-11-08 16:18 ` Auger Eric 2019-11-08 16:18 ` Auger Eric 2019-11-08 23:05 ` Jacob Pan 2019-11-08 23:05 ` Jacob Pan 2019-10-24 19:55 ` [PATCH v7 11/11] iommu/vt-d: Add svm/sva invalidate function Jacob Pan 2019-10-24 19:55 ` Jacob Pan 2019-10-25 7:27 ` Tian, Kevin 2019-10-25 7:27 ` Tian, Kevin 2019-10-26 2:40 ` Lu Baolu 2019-10-26 2:40 ` Lu Baolu 2019-10-26 7:03 ` Lu Baolu 2019-10-26 7:03 ` Lu Baolu 2019-10-28 6:06 ` Tian, Kevin 2019-10-28 6:06 ` Tian, Kevin 2019-10-28 16:10 ` Jacob Pan 2019-10-28 16:10 ` Jacob Pan 2019-10-29 18:52 ` Tian, Kevin 2019-10-29 18:52 ` Tian, Kevin 2019-10-29 19:25 ` Jacob Pan 2019-10-29 19:25 ` Jacob Pan 2019-10-28 16:13 ` Jacob Pan 2019-10-28 16:13 ` Jacob Pan 2019-11-12 10:28 ` Auger Eric 2019-11-12 10:28 ` Auger Eric 2020-02-15 1:18 ` Jacob Pan 2020-02-15 1:18 ` Jacob Pan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AADFC41AFE54684AB9EE6CBC0274A5D19D5CDCA0@SHSMSX104.ccr.corp.intel.com \ --to=kevin.tian@intel.com \ --cc=alex.williamson@redhat.com \ --cc=ashok.raj@intel.com \ --cc=baolu.lu@linux.intel.com \ --cc=dwmw2@infradead.org \ --cc=eric.auger@redhat.com \ --cc=hch@infradead.org \ --cc=iommu@lists.linux-foundation.org \ --cc=jacob.jun.pan@linux.intel.com \ --cc=jean-philippe@linaro.com \ --cc=jic23@kernel.org \ --cc=joro@8bytes.org \ --cc=linux-kernel@vger.kernel.org \ --cc=yi.l.liu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.