From: Minchan Kim <minchan.kim@gmail.com>
To: ngupta@vflare.org
Cc: Dan Magenheimer <dan.magenheimer@oracle.com>,
chris.mason@oracle.com, viro@zeniv.linux.org.uk,
akpm@linux-foundation.org, adilger@sun.com, tytso@mit.edu,
mfasheh@suse.com, joel.becker@oracle.com, matthew@wil.cx,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
ocfs2-devel@oss.oracle.com, linux-mm@kvack.org, jeremy@goop.org,
JBeulich@novell.com, kurt.hackel@oracle.com, npiggin@suse.de,
dave.mccracken@oracle.com, riel@redhat.com, avi@redhat.com,
konrad.wilk@oracle.com
Subject: Re: [PATCH V3 0/8] Cleancache: overview
Date: Fri, 23 Jul 2010 17:17:49 +0900 [thread overview]
Message-ID: <AANLkTi=W4xpz1VP9oPbK3pNY-5aODydzsAhuAWv-1+Vt@mail.gmail.com> (raw)
In-Reply-To: <4C49468B.40307@vflare.org>
On Fri, Jul 23, 2010 at 4:36 PM, Nitin Gupta <ngupta@vflare.org> wrote:
>
> 2. I think change in btrfs can be avoided by moving cleancache_get_page()
> from do_mpage_reapage() to filemap_fault() and this should work for all
> filesystems. See:
>
> handle_pte_fault() -> do_(non)linear_fault() -> __do_fault()
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0 =A0 =A0 =A0 =A0-> vma->vm_ops->fault()
>
> which is defined as filemap_fault() for all filesystems. If some future
> filesystem uses its own custom function (why?) then it will have to arran=
ge for
> call to cleancache_get_page(), if it wants this feature.
filemap fault works only in case of file-backed page which is mapped
but don't work not-mapped cache page. So we could miss cache page by
read system call if we move it into filemap_fault.
--=20
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan.kim@gmail.com>
To: ngupta@vflare.org
Cc: Dan Magenheimer <dan.magenheimer@oracle.com>,
chris.mason@oracle.com, viro@zeniv.linux.org.uk,
akpm@linux-foundation.org, adilger@sun.com, tytso@mit.edu,
mfasheh@suse.com, joel.becker@oracle.com, matthew@wil.cx,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
ocfs2-devel@oss.oracle.com, linux-mm@kvack.org, jeremy@goop.org,
JBeulich@novell.com, kurt.hackel@oracle.com, npiggin@suse.de,
dave.mccracken@oracle.com, riel@redhat.com, avi@redhat.com,
konrad.wilk@oracle.com
Subject: Re: [PATCH V3 0/8] Cleancache: overview
Date: Fri, 23 Jul 2010 17:17:49 +0900 [thread overview]
Message-ID: <AANLkTi=W4xpz1VP9oPbK3pNY-5aODydzsAhuAWv-1+Vt@mail.gmail.com> (raw)
In-Reply-To: <4C49468B.40307@vflare.org>
On Fri, Jul 23, 2010 at 4:36 PM, Nitin Gupta <ngupta@vflare.org> wrote:
>
> 2. I think change in btrfs can be avoided by moving cleancache_get_page()
> from do_mpage_reapage() to filemap_fault() and this should work for all
> filesystems. See:
>
> handle_pte_fault() -> do_(non)linear_fault() -> __do_fault()
> -> vma->vm_ops->fault()
>
> which is defined as filemap_fault() for all filesystems. If some future
> filesystem uses its own custom function (why?) then it will have to arrange for
> call to cleancache_get_page(), if it wants this feature.
filemap fault works only in case of file-backed page which is mapped
but don't work not-mapped cache page. So we could miss cache page by
read system call if we move it into filemap_fault.
--
Kind regards,
Minchan Kim
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan.kim@gmail.com>
To: ngupta@vflare.org
Cc: Dan Magenheimer <dan.magenheimer@oracle.com>,
chris.mason@oracle.com, viro@zeniv.linux.org.uk,
akpm@linux-foundation.org, adilger@sun.com, tytso@mit.edu,
mfasheh@suse.com, joel.becker@oracle.com, matthew@wil.cx,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
ocfs2-devel@oss.oracle.com, linux-mm@kvack.org, jeremy@goop.org,
JBeulich@novell.com, kurt.hackel@oracle.com, npiggin@suse.de,
dave.mccracken@oracle.com, riel@redhat.com, avi@redhat.com,
konrad.wilk@oracle.com
Subject: Re: [PATCH V3 0/8] Cleancache: overview
Date: Fri, 23 Jul 2010 17:17:49 +0900 [thread overview]
Message-ID: <AANLkTi=W4xpz1VP9oPbK3pNY-5aODydzsAhuAWv-1+Vt@mail.gmail.com> (raw)
In-Reply-To: <4C49468B.40307@vflare.org>
On Fri, Jul 23, 2010 at 4:36 PM, Nitin Gupta <ngupta@vflare.org> wrote:
>
> 2. I think change in btrfs can be avoided by moving cleancache_get_page()
> from do_mpage_reapage() to filemap_fault() and this should work for all
> filesystems. See:
>
> handle_pte_fault() -> do_(non)linear_fault() -> __do_fault()
> -> vma->vm_ops->fault()
>
> which is defined as filemap_fault() for all filesystems. If some future
> filesystem uses its own custom function (why?) then it will have to arrange for
> call to cleancache_get_page(), if it wants this feature.
filemap fault works only in case of file-backed page which is mapped
but don't work not-mapped cache page. So we could miss cache page by
read system call if we move it into filemap_fault.
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan.kim@gmail.com>
To: ngupta@vflare.org
Cc: Dan Magenheimer <dan.magenheimer@oracle.com>,
chris.mason@oracle.com, viro@zeniv.linux.org.uk,
akpm@linux-foundation.org, adilger@sun.com, tytso@mit.edu,
mfasheh@suse.com, joel.becker@oracle.com, matthew@wil.cx,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
ocfs2-devel@oss.oracle.com, linux-mm@kvack.org, jeremy@goop.org,
JBeulich@novell.com, kurt.hackel@oracle.com, npiggin@suse.de,
dave.mccracken@oracle.com, riel@redhat.com, avi@redhat.com,
konrad.wilk@oracle.com
Subject: [Ocfs2-devel] [PATCH V3 0/8] Cleancache: overview
Date: Fri, 23 Jul 2010 17:17:49 +0900 [thread overview]
Message-ID: <AANLkTi=W4xpz1VP9oPbK3pNY-5aODydzsAhuAWv-1+Vt@mail.gmail.com> (raw)
In-Reply-To: <4C49468B.40307@vflare.org>
On Fri, Jul 23, 2010 at 4:36 PM, Nitin Gupta <ngupta@vflare.org> wrote:
>
> 2. I think change in btrfs can be avoided by moving cleancache_get_page()
> from do_mpage_reapage() to filemap_fault() and this should work for all
> filesystems. See:
>
> handle_pte_fault() -> do_(non)linear_fault() -> __do_fault()
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?-> vma->vm_ops->fault()
>
> which is defined as filemap_fault() for all filesystems. If some future
> filesystem uses its own custom function (why?) then it will have to arrange for
> call to cleancache_get_page(), if it wants this feature.
filemap fault works only in case of file-backed page which is mapped
but don't work not-mapped cache page. So we could miss cache page by
read system call if we move it into filemap_fault.
--
Kind regards,
Minchan Kim
next prev parent reply other threads:[~2010-07-23 8:17 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-21 23:18 [PATCH V3 0/8] Cleancache: overview Dan Magenheimer
2010-06-21 23:18 ` Dan Magenheimer
2010-06-21 23:18 ` [Ocfs2-devel] " Dan Magenheimer
2010-06-22 6:40 ` Christoph Hellwig
2010-06-22 6:40 ` Christoph Hellwig
2010-06-22 6:40 ` [Ocfs2-devel] " Christoph Hellwig
2010-07-06 20:58 ` Konrad Rzeszutek Wilk
2010-07-06 20:58 ` [Ocfs2-devel] " Konrad Rzeszutek Wilk
2010-07-06 20:58 ` Konrad Rzeszutek Wilk
2010-07-23 7:36 ` Nitin Gupta
2010-07-23 7:36 ` Nitin Gupta
2010-07-23 7:36 ` [Ocfs2-devel] " Nitin Gupta
2010-07-23 8:16 ` Minchan Kim
2010-07-23 8:16 ` [Ocfs2-devel] " Minchan Kim
2010-07-23 8:16 ` Minchan Kim
2010-07-23 8:16 ` Minchan Kim
2010-07-23 14:56 ` Nitin Gupta
2010-07-23 14:56 ` Nitin Gupta
2010-07-23 14:56 ` [Ocfs2-devel] " Nitin Gupta
2010-07-23 8:17 ` Minchan Kim [this message]
2010-07-23 8:17 ` Minchan Kim
2010-07-23 8:17 ` Minchan Kim
2010-07-23 8:17 ` Minchan Kim
2010-07-23 13:58 ` Dan Magenheimer
2010-07-23 13:58 ` [Ocfs2-devel] " Dan Magenheimer
2010-07-23 13:58 ` Dan Magenheimer
2010-07-23 14:04 ` Christoph Hellwig
2010-07-23 14:04 ` [Ocfs2-devel] " Christoph Hellwig
2010-07-23 14:04 ` Christoph Hellwig
2010-07-23 14:44 ` Dan Magenheimer
2010-07-23 14:44 ` [Ocfs2-devel] " Dan Magenheimer
2010-07-23 14:44 ` Dan Magenheimer
2010-07-23 14:44 ` Dan Magenheimer
2010-07-23 15:05 ` Nitin Gupta
2010-07-23 15:05 ` Nitin Gupta
2010-07-23 15:05 ` [Ocfs2-devel] " Nitin Gupta
2010-07-23 17:43 ` Dan Magenheimer
2010-07-23 17:43 ` [Ocfs2-devel] " Dan Magenheimer
2010-07-23 17:43 ` Dan Magenheimer
2010-07-23 17:43 ` Dan Magenheimer
2010-07-23 17:37 ` Dan Magenheimer
2010-07-23 17:37 ` [Ocfs2-devel] " Dan Magenheimer
2010-07-23 17:37 ` Dan Magenheimer
2010-07-23 17:37 ` Dan Magenheimer
2010-07-23 18:36 ` Nitin Gupta
2010-07-23 18:36 ` Nitin Gupta
2010-07-23 18:36 ` [Ocfs2-devel] " Nitin Gupta
2010-07-23 21:17 ` Dan Magenheimer
2010-07-23 21:17 ` [Ocfs2-devel] " Dan Magenheimer
2010-07-23 21:17 ` Dan Magenheimer
2010-07-23 21:17 ` Dan Magenheimer
2010-08-03 16:22 ` Boaz Harrosh
2010-08-03 16:22 ` [Ocfs2-devel] " Boaz Harrosh
2010-08-03 16:22 ` Boaz Harrosh
2010-08-03 17:35 ` Dan Magenheimer
2010-08-03 17:35 ` [Ocfs2-devel] " Dan Magenheimer
2010-08-03 17:35 ` Dan Magenheimer
2010-08-03 17:35 ` Dan Magenheimer
2010-08-03 18:34 ` Andreas Dilger
2010-08-03 18:34 ` [Ocfs2-devel] " Andreas Dilger
2010-08-03 18:34 ` Andreas Dilger
2010-08-03 18:34 ` Andreas Dilger
2010-08-03 19:09 ` Dan Magenheimer
2010-08-03 19:09 ` [Ocfs2-devel] " Dan Magenheimer
2010-08-03 19:09 ` Dan Magenheimer
2010-08-03 19:09 ` Dan Magenheimer
-- strict thread matches above, loose matches on Subject: below --
2010-06-21 23:18 Dan Magenheimer
2010-06-21 23:18 Dan Magenheimer
2010-06-21 23:18 Dan Magenheimer
[not found] <20100621231809.GA11111@ca-server1.us.oracle.com4C49468B.40307@vflare.org>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=W4xpz1VP9oPbK3pNY-5aODydzsAhuAWv-1+Vt@mail.gmail.com' \
--to=minchan.kim@gmail.com \
--cc=JBeulich@novell.com \
--cc=adilger@sun.com \
--cc=akpm@linux-foundation.org \
--cc=avi@redhat.com \
--cc=chris.mason@oracle.com \
--cc=dan.magenheimer@oracle.com \
--cc=dave.mccracken@oracle.com \
--cc=jeremy@goop.org \
--cc=joel.becker@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=kurt.hackel@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew@wil.cx \
--cc=mfasheh@suse.com \
--cc=ngupta@vflare.org \
--cc=npiggin@suse.de \
--cc=ocfs2-devel@oss.oracle.com \
--cc=riel@redhat.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.