2.6.37 intel driver crash on hibernate

2.6.37 intel driver crash on hibernate

[Pedro Ribeiro]

[-- Attachment #1.1: Type: text/plain, Size: 946 bytes --]

Hi,

I've been having unreliable operation when hibernating ever since 2.6.37-rc5
(the first 2.6.37 I tried).
With 2.6.36 I never had a problem.

It happens randomly, but every 10 or so hibernates. It hangs and spits out a
stack trace (I have kdb enabled).
I've taken a few screenshots which contain the stack traces.

I'm using TuxOnIce for hibernation, but according to the maintainer this
should not be a contributing factor.

Do you mind having a look and telling me your opinion?
Thank you very much for your help.

(I've sent this message previously but it was too big for the list. The
links for the images are below.)
http://imagenic.net/viewer.php?file=5n94qk83lpsq01e09lgi.jpg
http://imagenic.net/viewer.php?file=toephrymyyofi824hwbn.jpg
http://imagenic.net/viewer.php?file=8ortdzcpkci0di1tf04.jpg
http://imagenic.net/viewer.php?file=ynupu1laxzycvsm4mdf0.jpg
http://imagenic.net/viewer.php?file=9197x56j9yk6qlrzwnu8.jpg

Regards,
Pedro

[-- Attachment #1.2: Type: text/html, Size: 1492 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: 2.6.37 intel driver crash on hibernate

[Chris Wilson]

On Wed, 9 Feb 2011 00:27:52 +0000, Pedro Ribeiro <pedrib@gmail.com> wrote:
> Hi,
> 
> I've been having unreliable operation when hibernating ever since 2.6.37-rc5
> (the first 2.6.37 I tried).
> With 2.6.36 I never had a problem.

Wrong, you just never saw it.

commit 9334ef755f060e251f3f395caeda1a58b6834ea3
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Fri Jan 28 11:53:03 2011 +0000

    drm: Don't switch fb when disabling an output
    
    In drm_crtc_helper_set_config, we call drm_crtc_helper_set_mode which
    may return early and do no operation if the crtc is to be disabled. In
    this case we merrily swap to the new fb, discarding the old_fb believing
    that it has been cleaned up. However, due to the early return, the
    old_fb was not presented to the backend for correct reaping, and nor was
    the new one - which is about to be reaped via the
    drm_helper_disable_unused_functions(), leading to incorrect refcounting
    of the pinned objects.
    
    Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=27722
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=29857
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=29230
    Tested-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

-- 
Chris Wilson, Intel Open Source Technology Centre

Re: 2.6.37 intel driver crash on hibernate

[Pedro Ribeiro]

[-- Attachment #1.1: Type: text/plain, Size: 1597 bytes --]

On 9 February 2011 09:40, Chris Wilson <chris@chris-wilson.co.uk> wrote:

> On Wed, 9 Feb 2011 00:27:52 +0000, Pedro Ribeiro <pedrib@gmail.com> wrote:
> > Hi,
> >
> > I've been having unreliable operation when hibernating ever since
> 2.6.37-rc5
> > (the first 2.6.37 I tried).
> > With 2.6.36 I never had a problem.
>
> Wrong, you just never saw it.
>
> commit 9334ef755f060e251f3f395caeda1a58b6834ea3
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date:   Fri Jan 28 11:53:03 2011 +0000
>
>    drm: Don't switch fb when disabling an output
>
>    In drm_crtc_helper_set_config, we call drm_crtc_helper_set_mode which
>    may return early and do no operation if the crtc is to be disabled. In
>    this case we merrily swap to the new fb, discarding the old_fb believing
>    that it has been cleaned up. However, due to the early return, the
>    old_fb was not presented to the backend for correct reaping, and nor was
>    the new one - which is about to be reaped via the
>    drm_helper_disable_unused_functions(), leading to incorrect refcounting
>    of the pinned objects.
>
>    Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=27722
>    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=29857
>    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=29230
>    Tested-by: Takashi Iwai <tiwai@suse.de>
>    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> --
> Chris Wilson, Intel Open Source Technology Centre
>

Thanks for the prompt reply.

I assume this will be included in stable?

For the moment I'll just apply the patch to my build.

Regards,
Pedro

[-- Attachment #1.2: Type: text/html, Size: 2508 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: 2.6.37 intel driver crash on hibernate

[Chris Wilson]

On Wed, 9 Feb 2011 11:48:31 +0000, Pedro Ribeiro <pedrib@gmail.com> wrote:
> On 9 February 2011 09:40, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > commit 9334ef755f060e251f3f395caeda1a58b6834ea3
> > Author: Chris Wilson <chris@chris-wilson.co.uk>
> > Date:   Fri Jan 28 11:53:03 2011 +0000
> >
> >    drm: Don't switch fb when disabling an output
> >
> 
> I assume this will be included in stable?

If you test it and send a request to stable@kernel.org, it will be.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

Re: 2.6.37 intel driver crash on hibernate

[Pedro Ribeiro]

[-- Attachment #1.1: Type: text/plain, Size: 731 bytes --]

On 9 February 2011 11:56, Chris Wilson <chris@chris-wilson.co.uk> wrote:

> On Wed, 9 Feb 2011 11:48:31 +0000, Pedro Ribeiro <pedrib@gmail.com> wrote:
> > On 9 February 2011 09:40, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > > commit 9334ef755f060e251f3f395caeda1a58b6834ea3
> > > Author: Chris Wilson <chris@chris-wilson.co.uk>
> > > Date:   Fri Jan 28 11:53:03 2011 +0000
> > >
> > >    drm: Don't switch fb when disabling an output
> > >
> >
> > I assume this will be included in stable?
>
> If you test it and send a request to stable@kernel.org, it will be.
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
>

I'll test it for a couple of weeks and report back.
Thanks for your help.

Regards,
Pedro

[-- Attachment #1.2: Type: text/html, Size: 1451 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: 2.6.37 intel driver crash on hibernate

[Pedro Ribeiro]

[-- Attachment #1.1: Type: text/plain, Size: 1049 bytes --]

On 9 February 2011 18:52, Pedro Ribeiro <pedrib@gmail.com> wrote:

>
>
> On 9 February 2011 11:56, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
>> On Wed, 9 Feb 2011 11:48:31 +0000, Pedro Ribeiro <pedrib@gmail.com>
>> wrote:
>> > On 9 February 2011 09:40, Chris Wilson <chris@chris-wilson.co.uk>
>> wrote:
>> > > commit 9334ef755f060e251f3f395caeda1a58b6834ea3
>> > > Author: Chris Wilson <chris@chris-wilson.co.uk>
>> > > Date:   Fri Jan 28 11:53:03 2011 +0000
>> > >
>> > >    drm: Don't switch fb when disabling an output
>> > >
>> >
>> > I assume this will be included in stable?
>>
>> If you test it and send a request to stable@kernel.org, it will be.
>> -Chris
>>
>> --
>> Chris Wilson, Intel Open Source Technology Centre
>>
>
> I'll test it for a couple of weeks and report back.
> Thanks for your help.
>
> Regards,
> Pedro
>

Hi,

I have tested it extensively and believe it has solved my problem.

What the procedure now, I just email stable and ask them to include in .36
and .37, should I add a tested by line too?

Regards,
Pedro

[-- Attachment #1.2: Type: text/html, Size: 2134 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

2.6.37 intel driver crash on hibernate

[Pedro Ribeiro]

[-- Attachment #1.1: Type: text/plain, Size: 540 bytes --]

Hi,

I've been having unreliable operation when hibernating ever since 2.6.37-rc5
(the first 2.6.37 I tried).
With 2.6.36 I never had a problem.

It happens quite randomly, but every 10 or so hibernates, it hangs and spits
out a stack trace (I have kdb enabled).
I've attached 3 screenshots which contain the stack trace.

I'm using TuxOnIce for hibernation, but according to the maintainer this
should not be a contributing factor.

Do you mind having a look and telling me your opinion?
Thank you very much for your help.

Regards,
Pedro

[-- Attachment #1.2: Type: text/html, Size: 604 bytes --]

[-- Attachment #2: toi-xorg-crash.tar.bz2 --]
[-- Type: application/x-bzip2, Size: 1029688 bytes --]

[-- Attachment #3: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx