From: Hongxing Zhu <hongxing.zhu@nxp.com> To: Lucas Stach <l.stach@pengutronix.de>, "bhelgaas@google.com" <bhelgaas@google.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "broonie@kernel.org" <broonie@kernel.org>, "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>, "jingoohan1@gmail.com" <jingoohan1@gmail.com>, "festevam@gmail.com" <festevam@gmail.com>, "francesco.dolcini@toradex.com" <francesco.dolcini@toradex.com> Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "kernel@pengutronix.de" <kernel@pengutronix.de>, dl-linux-imx <linux-imx@nxp.com> Subject: RE: [PATCH v9 5/8] PCI: imx6: Refine the regulator usage Date: Thu, 9 Jun 2022 07:54:32 +0000 [thread overview] Message-ID: <AS8PR04MB8676A89DEDDD9EDECCC925208CA79@AS8PR04MB8676.eurprd04.prod.outlook.com> (raw) In-Reply-To: <ce3bf1e3ea155a45bd903c1506ed433fdc3026e3.camel@pengutronix.de> > -----Original Message----- > From: Lucas Stach <l.stach@pengutronix.de> > Sent: 2022年6月9日 15:47 > To: Hongxing Zhu <hongxing.zhu@nxp.com>; bhelgaas@google.com; > robh+dt@kernel.org; broonie@kernel.org; lorenzo.pieralisi@arm.com; > jingoohan1@gmail.com; festevam@gmail.com; > francesco.dolcini@toradex.com > Cc: linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; kernel@pengutronix.de; dl-linux-imx > <linux-imx@nxp.com> > Subject: Re: [PATCH v9 5/8] PCI: imx6: Refine the regulator usage > > Am Donnerstag, dem 09.06.2022 um 06:17 +0000 schrieb Hongxing Zhu: > > > -----Original Message----- > > > From: Lucas Stach <l.stach@pengutronix.de> > > > Sent: 2022年6月8日 15:27 > > > To: Hongxing Zhu <hongxing.zhu@nxp.com>; bhelgaas@google.com; > > > robh+dt@kernel.org; broonie@kernel.org; lorenzo.pieralisi@arm.com; > > > jingoohan1@gmail.com; festevam@gmail.com; > > > francesco.dolcini@toradex.com > > > Cc: linux-pci@vger.kernel.org; > > > linux-arm-kernel@lists.infradead.org; > > > linux-kernel@vger.kernel.org; kernel@pengutronix.de; dl-linux-imx > > > <linux-imx@nxp.com> > > > Subject: Re: [PATCH v9 5/8] PCI: imx6: Refine the regulator usage > > > > > > Am Freitag, dem 06.05.2022 um 09:47 +0800 schrieb Richard Zhu: > > > > The driver should undo any enables it did itself. The regulator > > > > disable shouldn't be basing decisions on regulator_is_enabled(). > > > > > > > > To keep the balance of the regulator usage counter, disable the > > > > regulator just behind of imx6_pcie_assert_core_reset() in resume > > > > and > > > shutdown. > > > > > > > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > > > > --- > > > > drivers/pci/controller/dwc/pci-imx6.c | 19 +++++++------------ > > > > 1 file changed, 7 insertions(+), 12 deletions(-) > > > > > > > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c > > > > b/drivers/pci/controller/dwc/pci-imx6.c > > > > index 7005a7910003..3ce3993d5797 100644 > > > > --- a/drivers/pci/controller/dwc/pci-imx6.c > > > > +++ b/drivers/pci/controller/dwc/pci-imx6.c > > > > @@ -369,8 +369,6 @@ static int imx6_pcie_attach_pd(struct device > > > > *dev) > > > > > > > > static void imx6_pcie_assert_core_reset(struct imx6_pcie > > > > *imx6_pcie) > > > > { > > > > - struct device *dev = imx6_pcie->pci->dev; > > > > - > > > > switch (imx6_pcie->drvdata->variant) { > > > > case IMX7D: > > > > case IMX8MQ: > > > > @@ -400,14 +398,6 @@ static void > > > > imx6_pcie_assert_core_reset(struct > > > imx6_pcie *imx6_pcie) > > > > IMX6Q_GPR1_PCIE_REF_CLK_EN, 0 << 16); > > > > break; > > > > } > > > > - > > > > - if (imx6_pcie->vpcie && regulator_is_enabled(imx6_pcie- > > > > >vpcie) > 0) { > > > > - int ret = regulator_disable(imx6_pcie->vpcie); > > > > - > > > > - if (ret) > > > > - dev_err(dev, "failed to disable vpcie > > > > regulator: %d\n", > > > > - ret); > > > > - } > > > > } > > > > > > > > static unsigned int imx6_pcie_grp_offset(const struct imx6_pcie > > > > *imx6_pcie) @@ -580,7 +570,7 @@ static int > > > imx6_pcie_deassert_core_reset(struct imx6_pcie *imx6_pcie) > > > > struct device *dev = pci->dev; > > > > int ret, err; > > > > > > > > - if (imx6_pcie->vpcie && !regulator_is_enabled(imx6_pcie- > > > > >vpcie)) { > > > > + if (imx6_pcie->vpcie) { > > > > ret = regulator_enable(imx6_pcie->vpcie); > > > > if (ret) { > > > > dev_err(dev, "failed to enable vpcie > > > > regulator: %d\n", @@ > > > -653,7 > > > > +643,7 @@ static int imx6_pcie_deassert_core_reset(struct > > > > imx6_pcie > > > *imx6_pcie) > > > > return 0; > > > > > > > > err_clks: > > > > - if (imx6_pcie->vpcie && regulator_is_enabled(imx6_pcie- > > > > >vpcie) > 0) { > > > > + if (imx6_pcie->vpcie) { > > > > ret = regulator_disable(imx6_pcie->vpcie); > > > > if (ret) > > > > dev_err(dev, "failed to disable vpcie > > > > regulator: %d\n", @@ > > > -1026,6 > > > > +1016,9 @@ static int imx6_pcie_resume_noirq(struct device *dev) > > > > return 0; > > > > > > > > imx6_pcie_assert_core_reset(imx6_pcie); > > > > + if (imx6_pcie->vpcie) > > > > + regulator_disable(imx6_pcie->vpcie); > > > > + > > > This one looks misplaced. Surely you want the regulator to be on > > > when resuming the PCIe subsystem. Isn't this just papering over a > > > wrong usage count here, because there is no regulator_disable in > > > imx6_pcie_suspend_noirq, where I would expect this to happen? > > > > > Hi Lucas: > > Thanks for your comments. > > There was one regulator_disable() operation at the end of the > > imx6_pcie_assert_core_reset() function before. > > When create the 5/8 patch, I follow the same behavior to disable the > > regulator just behind the imx6_pcie_assert_core_reset() function. > > > > Yes, it is. Imx6_pcie_suspend_noirq doesn't have the > > regulator_disable. > > The regulaor_enable is contained in imx6_pcie_deassert_core_reset(). > > Both of the regulator_disable and regulator_enabe are invoked once in > > imx6_pcie_resume_noirq. > > So, the regulator is on and has a balanced usage count after resume. > > > > Yea, my argument is that when we are moving around the regulator handling > anyways, we should move the regulator_disable into the suspend function. It's > the right thing to do: we don't want the bus to be powered when the system is > in suspend and while the use-count is correct, it's confusing to read the resume > function otherwise. > Thanks for your quick reply. Understand. I would move the regulator_disable at the end of the suspend function if you're fine with it. Best Regards Richard Zhu > Regards, > Lucas
WARNING: multiple messages have this Message-ID (diff)
From: Hongxing Zhu <hongxing.zhu@nxp.com> To: Lucas Stach <l.stach@pengutronix.de>, "bhelgaas@google.com" <bhelgaas@google.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "broonie@kernel.org" <broonie@kernel.org>, "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>, "jingoohan1@gmail.com" <jingoohan1@gmail.com>, "festevam@gmail.com" <festevam@gmail.com>, "francesco.dolcini@toradex.com" <francesco.dolcini@toradex.com> Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "kernel@pengutronix.de" <kernel@pengutronix.de>, dl-linux-imx <linux-imx@nxp.com> Subject: RE: [PATCH v9 5/8] PCI: imx6: Refine the regulator usage Date: Thu, 9 Jun 2022 07:54:32 +0000 [thread overview] Message-ID: <AS8PR04MB8676A89DEDDD9EDECCC925208CA79@AS8PR04MB8676.eurprd04.prod.outlook.com> (raw) In-Reply-To: <ce3bf1e3ea155a45bd903c1506ed433fdc3026e3.camel@pengutronix.de> > -----Original Message----- > From: Lucas Stach <l.stach@pengutronix.de> > Sent: 2022年6月9日 15:47 > To: Hongxing Zhu <hongxing.zhu@nxp.com>; bhelgaas@google.com; > robh+dt@kernel.org; broonie@kernel.org; lorenzo.pieralisi@arm.com; > jingoohan1@gmail.com; festevam@gmail.com; > francesco.dolcini@toradex.com > Cc: linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; kernel@pengutronix.de; dl-linux-imx > <linux-imx@nxp.com> > Subject: Re: [PATCH v9 5/8] PCI: imx6: Refine the regulator usage > > Am Donnerstag, dem 09.06.2022 um 06:17 +0000 schrieb Hongxing Zhu: > > > -----Original Message----- > > > From: Lucas Stach <l.stach@pengutronix.de> > > > Sent: 2022年6月8日 15:27 > > > To: Hongxing Zhu <hongxing.zhu@nxp.com>; bhelgaas@google.com; > > > robh+dt@kernel.org; broonie@kernel.org; lorenzo.pieralisi@arm.com; > > > jingoohan1@gmail.com; festevam@gmail.com; > > > francesco.dolcini@toradex.com > > > Cc: linux-pci@vger.kernel.org; > > > linux-arm-kernel@lists.infradead.org; > > > linux-kernel@vger.kernel.org; kernel@pengutronix.de; dl-linux-imx > > > <linux-imx@nxp.com> > > > Subject: Re: [PATCH v9 5/8] PCI: imx6: Refine the regulator usage > > > > > > Am Freitag, dem 06.05.2022 um 09:47 +0800 schrieb Richard Zhu: > > > > The driver should undo any enables it did itself. The regulator > > > > disable shouldn't be basing decisions on regulator_is_enabled(). > > > > > > > > To keep the balance of the regulator usage counter, disable the > > > > regulator just behind of imx6_pcie_assert_core_reset() in resume > > > > and > > > shutdown. > > > > > > > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > > > > --- > > > > drivers/pci/controller/dwc/pci-imx6.c | 19 +++++++------------ > > > > 1 file changed, 7 insertions(+), 12 deletions(-) > > > > > > > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c > > > > b/drivers/pci/controller/dwc/pci-imx6.c > > > > index 7005a7910003..3ce3993d5797 100644 > > > > --- a/drivers/pci/controller/dwc/pci-imx6.c > > > > +++ b/drivers/pci/controller/dwc/pci-imx6.c > > > > @@ -369,8 +369,6 @@ static int imx6_pcie_attach_pd(struct device > > > > *dev) > > > > > > > > static void imx6_pcie_assert_core_reset(struct imx6_pcie > > > > *imx6_pcie) > > > > { > > > > - struct device *dev = imx6_pcie->pci->dev; > > > > - > > > > switch (imx6_pcie->drvdata->variant) { > > > > case IMX7D: > > > > case IMX8MQ: > > > > @@ -400,14 +398,6 @@ static void > > > > imx6_pcie_assert_core_reset(struct > > > imx6_pcie *imx6_pcie) > > > > IMX6Q_GPR1_PCIE_REF_CLK_EN, 0 << 16); > > > > break; > > > > } > > > > - > > > > - if (imx6_pcie->vpcie && regulator_is_enabled(imx6_pcie- > > > > >vpcie) > 0) { > > > > - int ret = regulator_disable(imx6_pcie->vpcie); > > > > - > > > > - if (ret) > > > > - dev_err(dev, "failed to disable vpcie > > > > regulator: %d\n", > > > > - ret); > > > > - } > > > > } > > > > > > > > static unsigned int imx6_pcie_grp_offset(const struct imx6_pcie > > > > *imx6_pcie) @@ -580,7 +570,7 @@ static int > > > imx6_pcie_deassert_core_reset(struct imx6_pcie *imx6_pcie) > > > > struct device *dev = pci->dev; > > > > int ret, err; > > > > > > > > - if (imx6_pcie->vpcie && !regulator_is_enabled(imx6_pcie- > > > > >vpcie)) { > > > > + if (imx6_pcie->vpcie) { > > > > ret = regulator_enable(imx6_pcie->vpcie); > > > > if (ret) { > > > > dev_err(dev, "failed to enable vpcie > > > > regulator: %d\n", @@ > > > -653,7 > > > > +643,7 @@ static int imx6_pcie_deassert_core_reset(struct > > > > imx6_pcie > > > *imx6_pcie) > > > > return 0; > > > > > > > > err_clks: > > > > - if (imx6_pcie->vpcie && regulator_is_enabled(imx6_pcie- > > > > >vpcie) > 0) { > > > > + if (imx6_pcie->vpcie) { > > > > ret = regulator_disable(imx6_pcie->vpcie); > > > > if (ret) > > > > dev_err(dev, "failed to disable vpcie > > > > regulator: %d\n", @@ > > > -1026,6 > > > > +1016,9 @@ static int imx6_pcie_resume_noirq(struct device *dev) > > > > return 0; > > > > > > > > imx6_pcie_assert_core_reset(imx6_pcie); > > > > + if (imx6_pcie->vpcie) > > > > + regulator_disable(imx6_pcie->vpcie); > > > > + > > > This one looks misplaced. Surely you want the regulator to be on > > > when resuming the PCIe subsystem. Isn't this just papering over a > > > wrong usage count here, because there is no regulator_disable in > > > imx6_pcie_suspend_noirq, where I would expect this to happen? > > > > > Hi Lucas: > > Thanks for your comments. > > There was one regulator_disable() operation at the end of the > > imx6_pcie_assert_core_reset() function before. > > When create the 5/8 patch, I follow the same behavior to disable the > > regulator just behind the imx6_pcie_assert_core_reset() function. > > > > Yes, it is. Imx6_pcie_suspend_noirq doesn't have the > > regulator_disable. > > The regulaor_enable is contained in imx6_pcie_deassert_core_reset(). > > Both of the regulator_disable and regulator_enabe are invoked once in > > imx6_pcie_resume_noirq. > > So, the regulator is on and has a balanced usage count after resume. > > > > Yea, my argument is that when we are moving around the regulator handling > anyways, we should move the regulator_disable into the suspend function. It's > the right thing to do: we don't want the bus to be powered when the system is > in suspend and while the use-count is correct, it's confusing to read the resume > function otherwise. > Thanks for your quick reply. Understand. I would move the regulator_disable at the end of the suspend function if you're fine with it. Best Regards Richard Zhu > Regards, > Lucas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-09 7:54 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-06 1:47 [PATCH v9 0/8] PCI: imx6: refine codes and add compliance tests mode support Richard Zhu 2022-05-06 1:47 ` Richard Zhu 2022-05-06 1:47 ` [PATCH v9 1/8] PCI: imx6: Encapsulate the clock enable into one standalone function Richard Zhu 2022-05-06 1:47 ` Richard Zhu 2022-06-08 18:51 ` Bjorn Helgaas 2022-06-08 18:51 ` Bjorn Helgaas 2022-06-09 6:18 ` Hongxing Zhu 2022-06-09 6:18 ` Hongxing Zhu 2022-05-06 1:47 ` [PATCH v9 2/8] PCI: imx6: Add the error propagation from host_init Richard Zhu 2022-05-06 1:47 ` Richard Zhu 2022-06-08 18:53 ` Bjorn Helgaas 2022-06-08 18:53 ` Bjorn Helgaas 2022-06-09 6:19 ` Hongxing Zhu 2022-06-09 6:19 ` Hongxing Zhu 2022-05-06 1:47 ` [PATCH v9 3/8] PCI: imx6: Move imx6_pcie_clk_disable() earlier Richard Zhu 2022-05-06 1:47 ` Richard Zhu 2022-06-08 7:14 ` Lucas Stach 2022-06-08 7:14 ` Lucas Stach 2022-05-06 1:47 ` [PATCH v9 4/8] PCI: imx6: Disable iMX6QDL PCIe REF clock when disable PCIe clocks Richard Zhu 2022-05-06 1:47 ` Richard Zhu 2022-06-08 7:18 ` Lucas Stach 2022-06-08 7:18 ` Lucas Stach 2022-05-06 1:47 ` [PATCH v9 5/8] PCI: imx6: Refine the regulator usage Richard Zhu 2022-05-06 1:47 ` Richard Zhu 2022-06-08 7:26 ` Lucas Stach 2022-06-08 7:26 ` Lucas Stach 2022-06-09 6:17 ` Hongxing Zhu 2022-06-09 6:17 ` Hongxing Zhu 2022-06-09 7:47 ` Lucas Stach 2022-06-09 7:47 ` Lucas Stach 2022-06-09 7:54 ` Hongxing Zhu [this message] 2022-06-09 7:54 ` Hongxing Zhu 2022-06-08 18:54 ` Bjorn Helgaas 2022-06-08 18:54 ` Bjorn Helgaas 2022-06-09 6:19 ` Hongxing Zhu 2022-06-09 6:19 ` Hongxing Zhu 2022-06-09 17:20 ` Bjorn Helgaas 2022-06-09 17:20 ` Bjorn Helgaas 2022-06-10 7:09 ` Hongxing Zhu 2022-06-10 7:09 ` Hongxing Zhu 2022-05-06 1:47 ` [PATCH v9 6/8] PCI: imx6: Disable clocks and regulators after link is down Richard Zhu 2022-05-06 1:47 ` Richard Zhu 2022-06-08 7:35 ` Lucas Stach 2022-06-08 7:35 ` Lucas Stach 2022-06-09 6:17 ` Hongxing Zhu 2022-06-09 6:17 ` Hongxing Zhu 2022-06-09 7:53 ` Francesco Dolcini 2022-06-09 7:53 ` Francesco Dolcini 2022-06-09 8:36 ` Hongxing Zhu 2022-06-09 8:36 ` Hongxing Zhu 2022-06-09 7:55 ` Lucas Stach 2022-06-09 7:55 ` Lucas Stach 2022-06-09 8:30 ` Hongxing Zhu 2022-06-09 8:30 ` Hongxing Zhu 2022-05-06 1:47 ` [PATCH v9 7/8] PCI: imx6: Move the phy driver callbacks to the proper places Richard Zhu 2022-05-06 1:47 ` Richard Zhu 2022-06-08 7:44 ` Lucas Stach 2022-06-08 7:44 ` Lucas Stach 2022-06-09 6:18 ` Hongxing Zhu 2022-06-09 6:18 ` Hongxing Zhu 2022-06-08 18:57 ` Bjorn Helgaas 2022-06-08 18:57 ` Bjorn Helgaas 2022-06-09 6:20 ` Hongxing Zhu 2022-06-09 6:20 ` Hongxing Zhu 2022-06-09 16:25 ` Bjorn Helgaas 2022-06-09 16:25 ` Bjorn Helgaas 2022-06-10 6:51 ` Hongxing Zhu 2022-06-10 6:51 ` Hongxing Zhu 2022-05-06 1:47 ` [PATCH v9 8/8] PCI: imx6: Add compliance tests mode support Richard Zhu 2022-05-06 1:47 ` Richard Zhu 2022-06-08 7:48 ` Lucas Stach 2022-06-08 7:48 ` Lucas Stach 2022-06-09 6:18 ` Hongxing Zhu 2022-06-09 6:18 ` Hongxing Zhu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AS8PR04MB8676A89DEDDD9EDECCC925208CA79@AS8PR04MB8676.eurprd04.prod.outlook.com \ --to=hongxing.zhu@nxp.com \ --cc=bhelgaas@google.com \ --cc=broonie@kernel.org \ --cc=festevam@gmail.com \ --cc=francesco.dolcini@toradex.com \ --cc=jingoohan1@gmail.com \ --cc=kernel@pengutronix.de \ --cc=l.stach@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.