From: "Bedia, Vaibhav" <vaibhav.bedia@ti.com> To: Kevin Hilman <khilman@deeprootsystems.com> Cc: "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>, "paul@pwsan.com" <paul@pwsan.com>, "Cousson, Benoit" <b-cousson@ti.com>, "tony@atomide.com" <tony@atomide.com> Subject: RE: [PATCH 15/15] ARM: OMAP2+: AM33XX: Basic suspend resume support Date: Wed, 7 Nov 2012 13:25:56 +0000 [thread overview] Message-ID: <B5906170F1614E41A8A28DE3B8D121433EC085EE@DBDE01.ent.ti.com> (raw) In-Reply-To: <87r4o68bnl.fsf@deeprootsystems.com> Hi Kevin, On Wed, Nov 07, 2012 at 06:36:06, Kevin Hilman wrote: > "Bedia, Vaibhav" <vaibhav.bedia@ti.com> writes: > > > On Mon, Nov 05, 2012 at 23:10:27, Kevin Hilman wrote: > > [...] > > >> > >> Also, if there are drivers for these devices, won't this interfere? > >> > > > > Hmm, I can think of the following scenarios > > > > 1. Runtime PM adapted drivers are compiled in - We'll have to ensure that > > in their suspend callbacks they end up doing omap_hwmod_idle() via the > > runtime PM APIs. > > That already happens for all omap_devices. > > > In this case the omap_hwmod_enable() followed by omap_hwmod_idle() is > > not necessary in the PM code. > > Correct. > > > 2. The drivers are not compiled in - In this case, the hwmod code puts > > the IPs in standby during bootup so the first suspend-resume iteration > > will pass. During resuming, the SYSC configuration for forced standby will > > be lost, > > Please clarify how the SYSC is lost in this case. The register configuration of IPs in the PER domain is lost when we enter the suspend state. So the forced standby configuration from SYSC is lost and we need to do this for every successful suspend-resume cycle. > > > so in the subsequent iterations these IPs won't go standby and the > > hwmod code does not touch them since they never got enabled. In this case > > we do need the sequence that is there currently. > > > > 3. For some reason the respective drivers don't idle the IPs during suspend - > > (no_idle_on_suspend flag for the hwmod in DT?). In this scenario I think > > we should abort the suspend process since we know that the suspend is not > > going to work. > > Agreed. > > > Is there some other scenario that needs to be covered? > > You covered the ones I was thinking of. > > > How about adding some flag in hwmod code for handling this? Something > > similar to what was done for MMC [1]. I think the problem that we have > > is in some ways similar to the one addressed in [1]. > > Except that in the absence of drivers, no hwmod code is executed on the > suspend/resume path. > We could perhaps add a couple of APIs to check the SYSC values when coming out of suspend and take appropriate action if the sysc cache does not match? Regards, Vaibhav
WARNING: multiple messages have this Message-ID (diff)
From: vaibhav.bedia@ti.com (Bedia, Vaibhav) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 15/15] ARM: OMAP2+: AM33XX: Basic suspend resume support Date: Wed, 7 Nov 2012 13:25:56 +0000 [thread overview] Message-ID: <B5906170F1614E41A8A28DE3B8D121433EC085EE@DBDE01.ent.ti.com> (raw) In-Reply-To: <87r4o68bnl.fsf@deeprootsystems.com> Hi Kevin, On Wed, Nov 07, 2012 at 06:36:06, Kevin Hilman wrote: > "Bedia, Vaibhav" <vaibhav.bedia@ti.com> writes: > > > On Mon, Nov 05, 2012 at 23:10:27, Kevin Hilman wrote: > > [...] > > >> > >> Also, if there are drivers for these devices, won't this interfere? > >> > > > > Hmm, I can think of the following scenarios > > > > 1. Runtime PM adapted drivers are compiled in - We'll have to ensure that > > in their suspend callbacks they end up doing omap_hwmod_idle() via the > > runtime PM APIs. > > That already happens for all omap_devices. > > > In this case the omap_hwmod_enable() followed by omap_hwmod_idle() is > > not necessary in the PM code. > > Correct. > > > 2. The drivers are not compiled in - In this case, the hwmod code puts > > the IPs in standby during bootup so the first suspend-resume iteration > > will pass. During resuming, the SYSC configuration for forced standby will > > be lost, > > Please clarify how the SYSC is lost in this case. The register configuration of IPs in the PER domain is lost when we enter the suspend state. So the forced standby configuration from SYSC is lost and we need to do this for every successful suspend-resume cycle. > > > so in the subsequent iterations these IPs won't go standby and the > > hwmod code does not touch them since they never got enabled. In this case > > we do need the sequence that is there currently. > > > > 3. For some reason the respective drivers don't idle the IPs during suspend - > > (no_idle_on_suspend flag for the hwmod in DT?). In this scenario I think > > we should abort the suspend process since we know that the suspend is not > > going to work. > > Agreed. > > > Is there some other scenario that needs to be covered? > > You covered the ones I was thinking of. > > > How about adding some flag in hwmod code for handling this? Something > > similar to what was done for MMC [1]. I think the problem that we have > > is in some ways similar to the one addressed in [1]. > > Except that in the absence of drivers, no hwmod code is executed on the > suspend/resume path. > We could perhaps add a couple of APIs to check the SYSC values when coming out of suspend and take appropriate action if the sysc cache does not match? Regards, Vaibhav
next prev parent reply other threads:[~2012-11-07 13:26 UTC|newest] Thread overview: 218+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-11-02 12:32 [RFC 00/15] Add basic suspend-resume support for AM33XX Vaibhav Bedia 2012-11-02 12:32 ` Vaibhav Bedia 2012-11-02 12:32 ` [PATCH 01/15] ARM: OMAP2+: mailbox: Add an API for flushing the FIFO Vaibhav Bedia 2012-11-02 12:32 ` Vaibhav Bedia 2012-11-02 19:00 ` Tony Lindgren 2012-11-02 19:00 ` Tony Lindgren 2012-11-03 8:24 ` Bedia, Vaibhav 2012-11-03 8:24 ` Bedia, Vaibhav 2012-11-03 16:03 ` Santosh Shilimkar 2012-11-03 16:03 ` Santosh Shilimkar 2012-11-04 15:26 ` Bedia, Vaibhav 2012-11-04 15:26 ` Bedia, Vaibhav 2012-11-05 14:59 ` Santosh Shilimkar 2012-11-05 14:59 ` Santosh Shilimkar 2012-11-02 12:32 ` [PATCH 02/15] ARM: OMAP2+: mailbox: Add support for AM33XX Vaibhav Bedia 2012-11-02 12:32 ` Vaibhav Bedia 2012-11-03 0:14 ` Russ Dill 2012-11-03 0:14 ` Russ Dill 2012-11-03 8:39 ` Bedia, Vaibhav 2012-11-03 8:39 ` Bedia, Vaibhav 2012-11-03 13:48 ` Bedia, Vaibhav 2012-11-03 13:48 ` Bedia, Vaibhav 2012-11-03 16:10 ` Santosh Shilimkar 2012-11-03 16:10 ` Santosh Shilimkar 2012-11-04 15:26 ` Bedia, Vaibhav 2012-11-04 15:26 ` Bedia, Vaibhav 2012-11-05 15:00 ` Santosh Shilimkar 2012-11-05 15:00 ` Santosh Shilimkar 2012-11-02 12:32 ` [PATCH 03/15] ARM: OMAP: mailbox: Convert to device_initcall Vaibhav Bedia 2012-11-02 12:32 ` Vaibhav Bedia 2012-11-03 16:12 ` Santosh Shilimkar 2012-11-03 16:12 ` Santosh Shilimkar 2012-11-02 12:32 ` [PATCH 04/15] ARM: OMAP2+: hwmod: Update the reset API for AM33XX Vaibhav Bedia 2012-11-02 12:32 ` Vaibhav Bedia 2012-11-05 6:58 ` Vaibhav Hiremath 2012-11-05 6:58 ` Vaibhav Hiremath 2012-11-05 17:57 ` Bedia, Vaibhav 2012-11-05 17:57 ` Bedia, Vaibhav 2012-11-06 6:06 ` Hiremath, Vaibhav 2012-11-06 6:06 ` Hiremath, Vaibhav 2012-11-06 7:19 ` Bedia, Vaibhav 2012-11-06 7:19 ` Bedia, Vaibhav 2012-11-02 12:32 ` [PATCH 05/15] ARM: OMAP2+: AM33XX: Update WKUP_M3 hwmod entry for reset status Vaibhav Bedia 2012-11-02 12:32 ` Vaibhav Bedia 2012-11-03 16:15 ` Santosh Shilimkar 2012-11-03 16:15 ` Santosh Shilimkar 2012-11-04 15:26 ` Bedia, Vaibhav 2012-11-04 15:26 ` Bedia, Vaibhav 2012-11-05 6:59 ` Vaibhav Hiremath 2012-11-05 6:59 ` Vaibhav Hiremath 2012-11-02 12:32 ` [PATCH 06/15] ARM: OMAP2+: hwmod: Enable OCMCRAM registration in AM33XX Vaibhav Bedia 2012-11-02 12:32 ` Vaibhav Bedia 2012-11-03 16:16 ` Santosh Shilimkar 2012-11-03 16:16 ` Santosh Shilimkar 2012-11-04 15:26 ` Bedia, Vaibhav 2012-11-04 15:26 ` Bedia, Vaibhav 2012-11-05 7:23 ` Vaibhav Hiremath 2012-11-05 7:23 ` Vaibhav Hiremath 2012-11-05 17:57 ` Bedia, Vaibhav 2012-11-05 17:57 ` Bedia, Vaibhav 2012-11-06 6:07 ` Hiremath, Vaibhav 2012-11-06 6:07 ` Hiremath, Vaibhav 2012-11-02 12:32 ` [PATCH 07/15] ARM: OMAP2+: hwmod: Update the hwmod data for TPTCs " Vaibhav Bedia 2012-11-02 12:32 ` Vaibhav Bedia 2012-11-05 7:19 ` Vaibhav Hiremath 2012-11-05 7:19 ` Vaibhav Hiremath 2012-11-02 12:32 ` [PATCH 08/15] ARM: OMAP2+: hwmod: Fix the omap_hwmod_addr_space for CPGMAC0 Vaibhav Bedia 2012-11-02 12:32 ` Vaibhav Bedia 2012-11-03 16:18 ` Santosh Shilimkar 2012-11-03 16:18 ` Santosh Shilimkar 2012-11-04 15:26 ` Bedia, Vaibhav 2012-11-04 15:26 ` Bedia, Vaibhav 2012-11-05 9:10 ` Bedia, Vaibhav 2012-11-05 9:10 ` Bedia, Vaibhav 2012-11-06 9:29 ` Vaibhav Hiremath 2012-11-06 9:29 ` Vaibhav Hiremath 2012-11-06 10:09 ` Bedia, Vaibhav 2012-11-06 10:09 ` Bedia, Vaibhav 2012-11-06 13:08 ` Hiremath, Vaibhav 2012-11-06 13:08 ` Hiremath, Vaibhav 2012-11-06 13:46 ` Bedia, Vaibhav 2012-11-06 13:46 ` Bedia, Vaibhav 2012-11-06 13:50 ` Benoit Cousson 2012-11-06 13:50 ` Benoit Cousson 2012-11-06 13:56 ` Bedia, Vaibhav 2012-11-06 13:56 ` Bedia, Vaibhav 2012-11-02 12:32 ` [PATCH 09/15] ARM: OMAP: AM33XX: Remove unnecessary include and use __ASSEMBLER__ macros Vaibhav Bedia 2012-11-02 12:32 ` Vaibhav Bedia 2012-11-03 16:29 ` Santosh Shilimkar 2012-11-03 16:29 ` Santosh Shilimkar 2012-11-04 15:26 ` Bedia, Vaibhav 2012-11-04 15:26 ` Bedia, Vaibhav 2012-11-02 12:32 ` [PATCH 10/15] ARM: OMAP2+: control: Add some AM33XX Control module registers Vaibhav Bedia 2012-11-02 12:32 ` Vaibhav Bedia 2012-11-02 12:32 ` [PATCH 11/15] ARM: OMAP: timer: Interchange clksrc and clkevt for AM33XX Vaibhav Bedia 2012-11-02 12:32 ` Vaibhav Bedia 2012-11-03 11:43 ` Kevin Hilman 2012-11-03 11:43 ` Kevin Hilman 2012-11-03 12:47 ` Bedia, Vaibhav 2012-11-03 12:47 ` Bedia, Vaibhav 2012-11-03 13:04 ` Kevin Hilman 2012-11-03 13:04 ` Kevin Hilman 2012-11-03 13:48 ` Bedia, Vaibhav 2012-11-03 13:48 ` Bedia, Vaibhav 2012-11-05 18:03 ` Kevin Hilman 2012-11-05 18:03 ` Kevin Hilman 2012-11-05 21:59 ` Santosh Shilimkar 2012-11-05 21:59 ` Santosh Shilimkar 2012-11-06 14:38 ` Bedia, Vaibhav 2012-11-06 14:38 ` Bedia, Vaibhav 2012-11-08 13:15 ` Bedia, Vaibhav 2012-11-08 13:15 ` Bedia, Vaibhav 2012-11-06 14:33 ` Bedia, Vaibhav 2012-11-06 14:33 ` Bedia, Vaibhav 2012-11-03 16:22 ` Kevin Hilman 2012-11-03 16:22 ` Kevin Hilman 2012-11-05 4:40 ` Bedia, Vaibhav 2012-11-05 4:40 ` Bedia, Vaibhav 2012-11-03 16:31 ` Santosh Shilimkar 2012-11-03 16:31 ` Santosh Shilimkar 2012-11-04 15:26 ` Bedia, Vaibhav 2012-11-04 15:26 ` Bedia, Vaibhav 2012-11-08 20:41 ` Jon Hunter 2012-11-08 20:41 ` Jon Hunter 2012-11-12 22:54 ` Tony Lindgren 2012-11-12 22:54 ` Tony Lindgren 2012-11-02 12:32 ` [PATCH 12/15] ARM: OMAP: timer: Add suspend-resume callbacks for clockevent device Vaibhav Bedia 2012-11-02 12:32 ` Vaibhav Bedia 2012-11-03 12:15 ` Kevin Hilman 2012-11-03 12:15 ` Kevin Hilman 2012-11-03 13:17 ` Bedia, Vaibhav 2012-11-03 13:17 ` Bedia, Vaibhav 2012-11-03 13:41 ` Kevin Hilman 2012-11-03 13:41 ` Kevin Hilman 2012-11-03 14:03 ` Bedia, Vaibhav 2012-11-03 14:03 ` Bedia, Vaibhav 2012-11-05 21:20 ` Jon Hunter 2012-11-05 21:20 ` Jon Hunter 2012-11-06 9:38 ` Bedia, Vaibhav 2012-11-06 9:38 ` Bedia, Vaibhav 2012-11-06 16:02 ` Jon Hunter 2012-11-06 16:02 ` Jon Hunter 2012-11-03 15:52 ` Santosh Shilimkar 2012-11-03 15:52 ` Santosh Shilimkar 2012-11-04 15:25 ` Bedia, Vaibhav 2012-11-04 15:25 ` Bedia, Vaibhav 2012-11-05 14:55 ` Santosh Shilimkar 2012-11-05 14:55 ` Santosh Shilimkar 2012-11-05 21:04 ` Jon Hunter 2012-11-05 21:04 ` Jon Hunter 2012-11-06 7:32 ` Bedia, Vaibhav 2012-11-06 7:32 ` Bedia, Vaibhav 2012-11-06 16:00 ` Jon Hunter 2012-11-06 16:00 ` Jon Hunter 2012-11-02 12:32 ` [PATCH 13/15] ARM: DTS: AM33XX: Add nodes for OCMCRAM and Mailbox Vaibhav Bedia 2012-11-02 12:32 ` Vaibhav Bedia 2012-11-03 12:16 ` Kevin Hilman 2012-11-03 12:16 ` Kevin Hilman 2012-11-03 13:17 ` Bedia, Vaibhav 2012-11-03 13:17 ` Bedia, Vaibhav 2012-11-03 15:54 ` Santosh Shilimkar 2012-11-03 15:54 ` Santosh Shilimkar 2012-11-04 15:26 ` Bedia, Vaibhav 2012-11-04 15:26 ` Bedia, Vaibhav 2012-11-05 14:53 ` Santosh Shilimkar 2012-11-05 14:53 ` Santosh Shilimkar 2012-11-05 17:57 ` Bedia, Vaibhav 2012-11-05 17:57 ` Bedia, Vaibhav 2012-11-05 19:29 ` Kevin Hilman 2012-11-05 19:29 ` Kevin Hilman 2012-11-05 21:19 ` Santosh Shilimkar 2012-11-05 21:19 ` Santosh Shilimkar 2012-11-05 21:45 ` Santosh Shilimkar 2012-11-05 21:45 ` Santosh Shilimkar 2012-11-06 5:08 ` Bedia, Vaibhav 2012-11-06 5:08 ` Bedia, Vaibhav 2012-11-05 14:58 ` Santosh Shilimkar 2012-11-05 14:58 ` Santosh Shilimkar 2012-11-02 12:32 ` [PATCH 14/15] ARM: OMAP2+: omap2plus_defconfig: Enable Mailbox Vaibhav Bedia 2012-11-02 12:32 ` Vaibhav Bedia 2012-11-03 12:20 ` Kevin Hilman 2012-11-03 12:20 ` Kevin Hilman 2012-11-03 13:17 ` Bedia, Vaibhav 2012-11-03 13:17 ` Bedia, Vaibhav 2012-11-03 13:43 ` Kevin Hilman 2012-11-03 13:43 ` Kevin Hilman 2012-11-02 12:32 ` [PATCH 15/15] ARM: OMAP2+: AM33XX: Basic suspend resume support Vaibhav Bedia 2012-11-02 12:32 ` Vaibhav Bedia 2012-11-02 13:11 ` Bedia, Vaibhav 2012-11-02 13:11 ` Bedia, Vaibhav 2012-11-03 16:57 ` Santosh Shilimkar 2012-11-03 16:57 ` Santosh Shilimkar 2012-11-04 15:26 ` Bedia, Vaibhav 2012-11-04 15:26 ` Bedia, Vaibhav 2012-11-05 17:40 ` Kevin Hilman 2012-11-05 17:40 ` Kevin Hilman 2012-11-05 21:52 ` Santosh Shilimkar 2012-11-05 21:52 ` Santosh Shilimkar 2012-11-06 12:29 ` Bedia, Vaibhav 2012-11-06 12:29 ` Bedia, Vaibhav 2012-11-06 12:38 ` Santosh Shilimkar 2012-11-06 12:38 ` Santosh Shilimkar 2012-11-06 13:00 ` Bedia, Vaibhav 2012-11-06 13:00 ` Bedia, Vaibhav 2012-11-06 10:40 ` Bedia, Vaibhav 2012-11-06 10:40 ` Bedia, Vaibhav 2012-11-07 1:06 ` Kevin Hilman 2012-11-07 1:06 ` Kevin Hilman 2012-11-07 13:25 ` Bedia, Vaibhav [this message] 2012-11-07 13:25 ` Bedia, Vaibhav 2012-11-07 17:15 ` Kevin Hilman 2012-11-07 17:15 ` Kevin Hilman 2012-11-08 13:05 ` Bedia, Vaibhav 2012-11-08 13:05 ` Bedia, Vaibhav 2012-11-02 22:16 ` [RFC 00/15] Add basic suspend-resume support for AM33XX Daniel Mack 2012-11-02 22:16 ` Daniel Mack 2012-11-03 8:39 ` Bedia, Vaibhav 2012-11-03 8:39 ` Bedia, Vaibhav
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=B5906170F1614E41A8A28DE3B8D121433EC085EE@DBDE01.ent.ti.com \ --to=vaibhav.bedia@ti.com \ --cc=b-cousson@ti.com \ --cc=khilman@deeprootsystems.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ --cc=paul@pwsan.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.