All of lore.kernel.org
 help / color / mirror / Atom feed
From: Barry Song <21cnbao@gmail.com>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Linus Walleij <linus.walleij@linaro.org>,
	Lee Jones <lee.jones@linaro.org>,
	Jonas Aaberg <jonas.aberg@stericsson.com>
Subject: Re: [PATCH 02/10] mach-u300: rewrite gpio driver, move to drivers/gpio
Date: Thu, 19 May 2011 19:38:27 +0800	[thread overview]
Message-ID: <BANLkTindee6UMez8HyBUwd2H6mN-DknzPw@mail.gmail.com> (raw)
In-Reply-To: <BANLkTi=poU17RqAzp28CPjWHrN_+aFiyag@mail.gmail.com>

> -arch_initcall(u300_gpio_init);
> -module_exit(u300_gpio_exit);
>
looks like the driver can't be a real module, is the module_exit
suitable? it looks strange module_exit plays together with
arch_initcall.
guess symbol u300_gpio_exit will finally lose in the last vmlinux
since it is in exit section and built-in kernel.

another problem i see is after moving gpio/pinmux to drivers as
platform device, codes in arch/arm/plat(mach) can't  call gpio/pinmux
api before the related platform devices registerred. that will
required these platform devices enter system earlier.

WARNING: multiple messages have this Message-ID (diff)
From: 21cnbao@gmail.com (Barry Song)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/10] mach-u300: rewrite gpio driver, move to drivers/gpio
Date: Thu, 19 May 2011 19:38:27 +0800	[thread overview]
Message-ID: <BANLkTindee6UMez8HyBUwd2H6mN-DknzPw@mail.gmail.com> (raw)
In-Reply-To: <BANLkTi=poU17RqAzp28CPjWHrN_+aFiyag@mail.gmail.com>

> -arch_initcall(u300_gpio_init);
> -module_exit(u300_gpio_exit);
>
looks like the driver can't be a real module, is the module_exit
suitable? it looks strange module_exit plays together with
arch_initcall.
guess symbol u300_gpio_exit will finally lose in the last vmlinux
since it is in exit section and built-in kernel.

another problem i see is after moving gpio/pinmux to drivers as
platform device, codes in arch/arm/plat(mach) can't  call gpio/pinmux
api before the related platform devices registerred. that will
required these platform devices enter system earlier.

  reply	other threads:[~2011-05-19 11:38 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-27 13:13 [PATCH 02/10] mach-u300: rewrite gpio driver, move to drivers/gpio Linus Walleij
2011-04-27 13:13 ` Linus Walleij
2011-04-27 18:23 ` H Hartley Sweeten
2011-04-27 18:23   ` H Hartley Sweeten
2011-04-28  7:07   ` Linus Walleij
2011-04-28  7:07     ` Linus Walleij
2011-04-28  7:10     ` Linus Walleij
2011-04-28  7:10       ` Linus Walleij
2011-04-28 17:41     ` H Hartley Sweeten
2011-04-28 17:41       ` H Hartley Sweeten
2011-05-13 14:51       ` Linus Walleij
2011-05-13 14:51         ` Linus Walleij
2011-05-19  8:56 ` Shawn Guo
2011-05-19  8:56   ` Shawn Guo
2011-05-19 12:21   ` Linus Walleij
2011-05-19 12:21     ` Linus Walleij
2011-05-19 13:56     ` Shawn Guo
2011-05-19 13:56       ` Shawn Guo
2011-05-19 19:11       ` Sascha Hauer
2011-05-19 19:11         ` Sascha Hauer
2011-05-19 19:30         ` Nicolas Pitre
2011-05-19 19:30           ` Nicolas Pitre
2011-05-20  3:18           ` Shawn Guo
2011-05-20  3:18             ` Shawn Guo
2011-05-20  3:43             ` Kyungmin Park
2011-05-20  3:43               ` Kyungmin Park
2011-05-20  3:54               ` Nicolas Pitre
2011-05-20  3:54                 ` Nicolas Pitre
2011-05-19 21:18         ` H Hartley Sweeten
2011-05-19 21:18           ` H Hartley Sweeten
2011-05-20  1:50           ` Jamie Iles
2011-05-20  1:50             ` Jamie Iles
2011-05-20 22:07             ` H Hartley Sweeten
2011-05-20 22:07               ` H Hartley Sweeten
2011-05-21 13:03               ` Jamie Iles
2011-05-21 13:03                 ` Jamie Iles
2011-05-20  7:01         ` Grant Likely
2011-05-20  7:01           ` Grant Likely
2011-05-20  7:47           ` Linus Walleij
2011-05-20  7:47             ` Linus Walleij
2011-05-19 11:11 ` Barry Song
2011-05-19 11:38   ` Barry Song [this message]
2011-05-19 11:38     ` Barry Song
2011-05-19 12:25     ` Linus Walleij
2011-05-19 12:25       ` Linus Walleij
2011-05-19 12:35       ` Barry Song
2011-05-19 12:35         ` Barry Song
2011-05-19 13:17         ` Linus Walleij
2011-05-19 13:17           ` Linus Walleij
2011-05-19 14:05           ` Barry Song
2011-05-19 14:05             ` Barry Song
2011-05-20  6:58             ` Grant Likely
2011-05-20  6:58               ` Grant Likely
2011-05-20  6:52       ` Grant Likely
2011-05-20  6:52         ` Grant Likely
2011-05-20  7:46         ` Linus Walleij
2011-05-20  7:46           ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTindee6UMez8HyBUwd2H6mN-DknzPw@mail.gmail.com \
    --to=21cnbao@gmail.com \
    --cc=grant.likely@secretlab.ca \
    --cc=jonas.aberg@stericsson.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.