From: Andrey Konovalov <andreyknvl@google.com> To: Catalin Marinas <catalin.marinas@arm.com>, Evgeniy Stepanov <eugenis@google.com> Cc: Will Deacon <will.deacon@arm.com>, Mark Rutland <mark.rutland@arm.com>, Robin Murphy <robin.murphy@arm.com>, Linux ARM <linux-arm-kernel@lists.infradead.org>, LKML <linux-kernel@vger.kernel.org>, Arnd Bergmann <arnd@arndb.de>, linux-arch@vger.kernel.org, Dmitry Vyukov <dvyukov@google.com>, Kostya Serebryany <kcc@google.com>, Lee Smith <Lee.Smith@arm.com>, Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>, Jacob Bramley <Jacob.Bramley@arm.com>, Ruben Ayrapetyan <Ruben.Ayrapetyan@arm.com> Subject: Re: [RFC PATCH 3/6] mm, arm64: untag user addresses in memory syscalls Date: Fri, 9 Mar 2018 18:31:36 +0100 [thread overview] Message-ID: <CAAeHK+xF0X-SQuPVmZF--VnmvYrbpDkznSwYTh_3LHq1H2V=9Q@mail.gmail.com> (raw) In-Reply-To: <20180309155315.4x44sbp3darractt@armageddon.cambridge.arm.com> On Fri, Mar 9, 2018 at 4:53 PM, Catalin Marinas <catalin.marinas@arm.com> wrote: > On Fri, Mar 09, 2018 at 03:02:01PM +0100, Andrey Konovalov wrote: >> Memory subsystem syscalls accept user addresses as arguments, but don't use >> copy_from_user and other similar functions, so we need to handle this case >> separately. >> >> Untag user pointers passed to madvise, mbind, get_mempolicy, mincore, >> mlock, mlock2, brk, mmap_pgoff, old_mmap, munmap, remap_file_pages, >> mprotect, pkey_mprotect, mremap and msync. >> >> Signed-off-by: Andrey Konovalov <andreyknvl@google.com> > > Please keep the cc list small (maybe linux-arch, linux-arm-kernel) as > I'm sure some lists would consider this spam. OK. > >> mm/madvise.c | 2 ++ >> mm/mempolicy.c | 6 ++++++ >> mm/mincore.c | 2 ++ >> mm/mlock.c | 5 +++++ >> mm/mmap.c | 9 +++++++++ >> mm/mprotect.c | 2 ++ >> mm/mremap.c | 2 ++ >> mm/msync.c | 3 +++ > > I'm not yet convinced these functions need to allow tagged pointers. > They are not doing memory accesses but rather dealing with the memory > range, hence an untagged pointer is better suited. There is probably a > reason why the "start" argument is "unsigned long" vs "void __user *" > (in the kernel, not the man page). So that would make the user to untag pointers before passing to these syscalls. Evgeniy, would that be possible to untag pointers in HWASan before using memory subsystem syscalls? Is there a reason for untagging them in the kernel? > > -- > Catalin
WARNING: multiple messages have this Message-ID (diff)
From: andreyknvl@google.com (Andrey Konovalov) To: linux-arm-kernel@lists.infradead.org Subject: [RFC PATCH 3/6] mm, arm64: untag user addresses in memory syscalls Date: Fri, 9 Mar 2018 18:31:36 +0100 [thread overview] Message-ID: <CAAeHK+xF0X-SQuPVmZF--VnmvYrbpDkznSwYTh_3LHq1H2V=9Q@mail.gmail.com> (raw) In-Reply-To: <20180309155315.4x44sbp3darractt@armageddon.cambridge.arm.com> On Fri, Mar 9, 2018 at 4:53 PM, Catalin Marinas <catalin.marinas@arm.com> wrote: > On Fri, Mar 09, 2018 at 03:02:01PM +0100, Andrey Konovalov wrote: >> Memory subsystem syscalls accept user addresses as arguments, but don't use >> copy_from_user and other similar functions, so we need to handle this case >> separately. >> >> Untag user pointers passed to madvise, mbind, get_mempolicy, mincore, >> mlock, mlock2, brk, mmap_pgoff, old_mmap, munmap, remap_file_pages, >> mprotect, pkey_mprotect, mremap and msync. >> >> Signed-off-by: Andrey Konovalov <andreyknvl@google.com> > > Please keep the cc list small (maybe linux-arch, linux-arm-kernel) as > I'm sure some lists would consider this spam. OK. > >> mm/madvise.c | 2 ++ >> mm/mempolicy.c | 6 ++++++ >> mm/mincore.c | 2 ++ >> mm/mlock.c | 5 +++++ >> mm/mmap.c | 9 +++++++++ >> mm/mprotect.c | 2 ++ >> mm/mremap.c | 2 ++ >> mm/msync.c | 3 +++ > > I'm not yet convinced these functions need to allow tagged pointers. > They are not doing memory accesses but rather dealing with the memory > range, hence an untagged pointer is better suited. There is probably a > reason why the "start" argument is "unsigned long" vs "void __user *" > (in the kernel, not the man page). So that would make the user to untag pointers before passing to these syscalls. Evgeniy, would that be possible to untag pointers in HWASan before using memory subsystem syscalls? Is there a reason for untagging them in the kernel? > > -- > Catalin
next prev parent reply other threads:[~2018-03-09 17:31 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-09 14:01 [RFC PATCH 0/6] arm64: untag user pointers passed to the kernel Andrey Konovalov 2018-03-09 14:01 ` [OpenRISC] " Andrey Konovalov 2018-03-09 14:01 ` Andrey Konovalov 2018-03-09 14:01 ` Andrey Konovalov 2018-03-09 14:01 ` [RFC PATCH 1/6] arm64: add type casts to untagged_addr macro Andrey Konovalov 2018-03-09 14:01 ` [OpenRISC] " Andrey Konovalov 2018-03-09 14:01 ` Andrey Konovalov 2018-03-09 14:01 ` Andrey Konovalov 2018-03-09 14:02 ` [RFC PATCH 2/6] arm64: untag user addresses in copy_from_user and others Andrey Konovalov 2018-03-09 14:02 ` [OpenRISC] " Andrey Konovalov 2018-03-09 14:02 ` Andrey Konovalov 2018-03-09 14:02 ` Andrey Konovalov 2018-03-09 15:03 ` Mark Rutland 2018-03-09 15:03 ` Mark Rutland 2018-03-09 15:58 ` Catalin Marinas 2018-03-09 15:58 ` Catalin Marinas 2018-03-09 15:58 ` Catalin Marinas 2018-03-09 15:58 ` Catalin Marinas 2018-03-09 17:57 ` Andrey Konovalov 2018-03-09 17:57 ` Andrey Konovalov 2018-03-09 14:02 ` [RFC PATCH 3/6] mm, arm64: untag user addresses in memory syscalls Andrey Konovalov 2018-03-09 14:02 ` [OpenRISC] " Andrey Konovalov 2018-03-09 14:02 ` Andrey Konovalov 2018-03-09 14:02 ` Andrey Konovalov 2018-03-09 15:53 ` Catalin Marinas 2018-03-09 15:53 ` Catalin Marinas 2018-03-09 17:31 ` Andrey Konovalov [this message] 2018-03-09 17:31 ` Andrey Konovalov 2018-03-09 17:42 ` Evgenii Stepanov 2018-03-09 17:42 ` Evgenii Stepanov 2018-03-14 15:45 ` Andrey Konovalov 2018-03-14 15:45 ` Andrey Konovalov 2018-03-14 17:44 ` Catalin Marinas 2018-03-14 17:44 ` Catalin Marinas 2018-03-16 1:11 ` Evgenii Stepanov 2018-03-16 1:11 ` Evgenii Stepanov 2018-03-09 14:02 ` [RFC PATCH 4/6] mm, arm64: untag user addresses in mm/gup.c Andrey Konovalov 2018-03-09 14:02 ` [OpenRISC] " Andrey Konovalov 2018-03-09 14:02 ` Andrey Konovalov 2018-03-09 14:02 ` Andrey Konovalov 2018-03-09 14:02 ` [RFC PATCH 5/6] lib, arm64: untag addrs passed to strncpy_from_user and strnlen_user Andrey Konovalov 2018-03-09 14:02 ` [OpenRISC] " Andrey Konovalov 2018-03-09 14:02 ` Andrey Konovalov 2018-03-09 14:02 ` Andrey Konovalov 2018-03-09 14:02 ` [RFC PATCH 6/6] arch: add untagged_addr definition for other arches Andrey Konovalov 2018-03-09 14:02 ` [OpenRISC] " Andrey Konovalov 2018-03-09 14:02 ` Andrey Konovalov 2018-03-09 14:02 ` Andrey Konovalov 2018-03-09 14:11 ` Arnd Bergmann 2018-03-09 14:11 ` [OpenRISC] " Arnd Bergmann 2018-03-09 14:11 ` Arnd Bergmann 2018-03-09 14:11 ` Arnd Bergmann 2018-03-09 14:11 ` Arnd Bergmann 2018-03-09 14:11 ` Arnd Bergmann 2018-03-09 14:16 ` Robin Murphy 2018-03-09 14:16 ` [OpenRISC] " Robin Murphy 2018-03-09 14:16 ` Robin Murphy 2018-03-09 14:16 ` Robin Murphy 2018-03-09 15:47 ` Andrey Konovalov 2018-03-09 15:47 ` [OpenRISC] " Andrey Konovalov 2018-03-09 15:47 ` Andrey Konovalov 2018-03-09 15:47 ` Andrey Konovalov 2018-03-09 15:47 ` Andrey Konovalov 2018-03-09 15:47 ` Andrey Konovalov 2018-03-09 14:15 ` [RFC PATCH 0/6] arm64: untag user pointers passed to the kernel Robin Murphy 2018-03-09 14:15 ` [OpenRISC] " Robin Murphy 2018-03-09 14:15 ` Robin Murphy 2018-03-09 14:15 ` Robin Murphy 2018-03-09 17:58 ` Andrey Konovalov 2018-03-09 17:58 ` [OpenRISC] " Andrey Konovalov 2018-03-09 17:58 ` Andrey Konovalov 2018-03-09 17:58 ` Andrey Konovalov 2018-03-09 17:58 ` Andrey Konovalov 2018-03-09 17:58 ` Andrey Konovalov 2018-03-09 14:55 ` Mark Rutland 2018-03-09 14:55 ` Mark Rutland 2018-03-09 15:16 ` Geert Uytterhoeven 2018-03-09 15:16 ` Geert Uytterhoeven 2018-03-09 17:58 ` Andrey Konovalov 2018-03-09 17:58 ` Andrey Konovalov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAAeHK+xF0X-SQuPVmZF--VnmvYrbpDkznSwYTh_3LHq1H2V=9Q@mail.gmail.com' \ --to=andreyknvl@google.com \ --cc=Jacob.Bramley@arm.com \ --cc=Lee.Smith@arm.com \ --cc=Ramana.Radhakrishnan@arm.com \ --cc=Ruben.Ayrapetyan@arm.com \ --cc=arnd@arndb.de \ --cc=catalin.marinas@arm.com \ --cc=dvyukov@google.com \ --cc=eugenis@google.com \ --cc=kcc@google.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robin.murphy@arm.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.