[U-Boot] [PATCH v1 3/4] serial: add an of-platdata driver for "snps, dw-apb-uart"

From: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 3/4] serial: add an of-platdata driver for "snps, dw-apb-uart"
Date: Wed, 9 Jan 2019 12:33:54 +0100	[thread overview]
Message-ID: <CAAh8qszk7feuUb9s5FxmycOjyrcHDU-Pdp3E_1id_KWGCnFPkg@mail.gmail.com> (raw)
In-Reply-To: <4881796E12491D4BB15146FE0209CE64681C1E9A@DE02WEMBXB.internal.synopsys.com>

Hi Alexey,

On Wed, Jan 9, 2019 at 9:36 AM Alexey Brodkin
<alexey.brodkin@synopsys.com> wrote:
>
> Hi Simon,
>
> > -----Original Message-----
> > From: Simon Goldschmidt [mailto:simon.k.r.goldschmidt at gmail.com]
> > Sent: Tuesday, January 8, 2019 12:14 AM
> > To: Marek Vasut <marex@denx.de>
> > Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>; Patrice Chotard <patrice.chotard@st.com>;
> > Simon Glass <sjg@chromium.org>; Anup Patel <anup@brainfault.org>; Lokesh Vutla <lokeshvutla@ti.com>;
> > Alexey Brodkin <alexey.brodkin@synopsys.com>; Patrick Delaunay <patrick.delaunay@st.com>; Marek Vasut
> > <marek.vasut@gmail.com>; u-boot at lists.denx.de; Álvaro Fernández Rojas <noltari@gmail.com>; Ryder Lee
> > <ryder.lee@mediatek.com>; Vikas Manocha <vikas.manocha@st.com>; Alexander Graf <agraf@suse.de>; Weijie
> > Gao <weijie.gao@mediatek.com>
> > Subject: [PATCH v1 3/4] serial: add an of-platdata driver for "snps,dw-apb-uart"
> >
> > Add a driver for the "snps,dw-apb-uart" used in socfpga and others.
> >
> > This driver is required to get OF_PLATDATA to work for socfpga.
> > It uses the ns16550 driver, converting the platdata from of-platdata
> > go the ns16550 format.
> >
> > Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> > ---
> >
> >  drivers/serial/Kconfig         | 10 ++++++++
> >  drivers/serial/Makefile        |  1 +
> >  drivers/serial/serial_dw_apb.c | 42 ++++++++++++++++++++++++++++++++++
> >  3 files changed, 53 insertions(+)
> >  create mode 100644 drivers/serial/serial_dw_apb.c
> >
> > diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
> > index b7ff2960ab..10addd3309 100644
> > --- a/drivers/serial/Kconfig
> > +++ b/drivers/serial/Kconfig
> > @@ -511,6 +511,16 @@ config BCM283X_PL011_SERIAL
> >         that supports automatic disable, so that it only gets used when
> >         the UART is actually muxed.
> >
> > +config DESIGNWARE_SERIAL
> > +     bool "DesignWare UART support"
> > +     depends on DM_SERIAL && SPL_OF_PLATDATA
>
> Might be a bit naïve question but why depend on SPL_OF_PLATDATA only?

Because my focus has been to get OF_PLATDATA running on my socfpga board.
But since Marek seems to be opposed, I guess I'll drop this series and
try to find
a different way to squeeze out the bytes I need.

> What about CONFIG_OF_EMBED?
>
> I'd happily switch my ARC boards on this driver and get rid of all
> CONFIG_SYS_NS16550_xxx nonsense in include/configs/myboardname.h

You're right there, this would be a good idea for socfpga as well. Maybe I'll
continue that line some day, but I don't have immediate plans for this.

Regards,
Simon