All of lore.kernel.org
 help / color / mirror / Atom feed
From: Moritz Fischer <moritz.fischer@ettus.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: "Bhumika Goyal" <bhumirks@gmail.com>,
	julia.lawall@lip6.fr, "Alan Tull" <atull@kernel.org>,
	"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
	linux-fpga@vger.kernel.org,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fpga: make xlnx_pr_decoupler_br_ops const
Date: Tue, 29 Aug 2017 10:09:49 -0600	[thread overview]
Message-ID: <CAAtXAHcf1bjyFg9XPZRmJS4Pw7=+P_E4TB-euJBSrj6ZGBSAig@mail.gmail.com> (raw)
In-Reply-To: <78e2ed1d-ea20-eb68-b6b4-d993a98984a6@xilinx.com>

On Tue, Aug 29, 2017 at 12:00 AM, Michal Simek <michal.simek@xilinx.com> wrote:
> On 28.8.2017 19:32, Bhumika Goyal wrote:
>> Make this const as it is only passed to a const argument of the function
>> fpga_bridge_register.
>>
>> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Acked-by: Moritz Fischer <mdf@kernel.org>
>> ---
>>  drivers/fpga/xilinx-pr-decoupler.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
>> index e359930..0d77430 100644
>> --- a/drivers/fpga/xilinx-pr-decoupler.c
>> +++ b/drivers/fpga/xilinx-pr-decoupler.c
>> @@ -79,7 +79,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge)
>>       return !status;
>>  }
>>
>> -static struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
>> +static const struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
>>       .enable_set = xlnx_pr_decoupler_enable_set,
>>       .enable_show = xlnx_pr_decoupler_enable_show,
>>  };

Must've been a leftover from when I worked on integrating a simple
GPIO based one.
I'll have to rebase that and submit it.
>>
>
> Acked-by: Michal Simek <michal.simek@xilinx.com>
>
> Thanks,
> Michal
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Thanks,
Moritz

WARNING: multiple messages have this Message-ID (diff)
From: moritz.fischer@ettus.com (Moritz Fischer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] fpga: make xlnx_pr_decoupler_br_ops const
Date: Tue, 29 Aug 2017 10:09:49 -0600	[thread overview]
Message-ID: <CAAtXAHcf1bjyFg9XPZRmJS4Pw7=+P_E4TB-euJBSrj6ZGBSAig@mail.gmail.com> (raw)
In-Reply-To: <78e2ed1d-ea20-eb68-b6b4-d993a98984a6@xilinx.com>

On Tue, Aug 29, 2017 at 12:00 AM, Michal Simek <michal.simek@xilinx.com> wrote:
> On 28.8.2017 19:32, Bhumika Goyal wrote:
>> Make this const as it is only passed to a const argument of the function
>> fpga_bridge_register.
>>
>> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Acked-by: Moritz Fischer <mdf@kernel.org>
>> ---
>>  drivers/fpga/xilinx-pr-decoupler.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
>> index e359930..0d77430 100644
>> --- a/drivers/fpga/xilinx-pr-decoupler.c
>> +++ b/drivers/fpga/xilinx-pr-decoupler.c
>> @@ -79,7 +79,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge)
>>       return !status;
>>  }
>>
>> -static struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
>> +static const struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
>>       .enable_set = xlnx_pr_decoupler_enable_set,
>>       .enable_show = xlnx_pr_decoupler_enable_show,
>>  };

Must've been a leftover from when I worked on integrating a simple
GPIO based one.
I'll have to rebase that and submit it.
>>
>
> Acked-by: Michal Simek <michal.simek@xilinx.com>
>
> Thanks,
> Michal
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Thanks,
Moritz

  reply	other threads:[~2017-08-29 16:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-28 17:32 [PATCH] fpga: make xlnx_pr_decoupler_br_ops const Bhumika Goyal
2017-08-28 17:32 ` Bhumika Goyal
2017-08-29  6:00 ` Michal Simek
2017-08-29  6:00   ` Michal Simek
2017-08-29  6:00   ` Michal Simek
2017-08-29 16:09   ` Moritz Fischer [this message]
2017-08-29 16:09     ` Moritz Fischer
2017-09-21 14:42     ` Alan Tull
2017-09-21 14:42       ` Alan Tull

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAtXAHcf1bjyFg9XPZRmJS4Pw7=+P_E4TB-euJBSrj6ZGBSAig@mail.gmail.com' \
    --to=moritz.fischer@ettus.com \
    --cc=atull@kernel.org \
    --cc=bhumirks@gmail.com \
    --cc=julia.lawall@lip6.fr \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=soren.brinkmann@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.