From: Alan Tull <atull@kernel.org> To: Moritz Fischer <moritz.fischer@ettus.com> Cc: "Michal Simek" <michal.simek@xilinx.com>, "Bhumika Goyal" <bhumirks@gmail.com>, julia.lawall@lip6.fr, "Sören Brinkmann" <soren.brinkmann@xilinx.com>, linux-fpga@vger.kernel.org, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] fpga: make xlnx_pr_decoupler_br_ops const Date: Thu, 21 Sep 2017 09:42:46 -0500 [thread overview] Message-ID: <CANk1AXSdx1nJMqyvR1JNPEE5WMDuB0BrXLKw5bw5YcGMtpR_1A@mail.gmail.com> (raw) In-Reply-To: <CAAtXAHcf1bjyFg9XPZRmJS4Pw7=+P_E4TB-euJBSrj6ZGBSAig@mail.gmail.com> On Tue, Aug 29, 2017 at 11:09 AM, Moritz Fischer <moritz.fischer@ettus.com> wrote: > On Tue, Aug 29, 2017 at 12:00 AM, Michal Simek <michal.simek@xilinx.com> wrote: >> On 28.8.2017 19:32, Bhumika Goyal wrote: >>> Make this const as it is only passed to a const argument of the function >>> fpga_bridge_register. >>> >>> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> > > Acked-by: Moritz Fischer <mdf@kernel.org> >>> --- >>> drivers/fpga/xilinx-pr-decoupler.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c >>> index e359930..0d77430 100644 >>> --- a/drivers/fpga/xilinx-pr-decoupler.c >>> +++ b/drivers/fpga/xilinx-pr-decoupler.c >>> @@ -79,7 +79,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge) >>> return !status; >>> } >>> >>> -static struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = { >>> +static const struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = { >>> .enable_set = xlnx_pr_decoupler_enable_set, >>> .enable_show = xlnx_pr_decoupler_enable_show, >>> }; > > Must've been a leftover from when I worked on integrating a simple > GPIO based one. > I'll have to rebase that and submit it. >>> >> >> Acked-by: Michal Simek <michal.simek@xilinx.com> Signed-off-by: Alan Tull <atull@kernel.org> >> >> Thanks, >> Michal >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-fpga" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > Thanks, > Moritz
WARNING: multiple messages have this Message-ID (diff)
From: atull@kernel.org (Alan Tull) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] fpga: make xlnx_pr_decoupler_br_ops const Date: Thu, 21 Sep 2017 09:42:46 -0500 [thread overview] Message-ID: <CANk1AXSdx1nJMqyvR1JNPEE5WMDuB0BrXLKw5bw5YcGMtpR_1A@mail.gmail.com> (raw) In-Reply-To: <CAAtXAHcf1bjyFg9XPZRmJS4Pw7=+P_E4TB-euJBSrj6ZGBSAig@mail.gmail.com> On Tue, Aug 29, 2017 at 11:09 AM, Moritz Fischer <moritz.fischer@ettus.com> wrote: > On Tue, Aug 29, 2017 at 12:00 AM, Michal Simek <michal.simek@xilinx.com> wrote: >> On 28.8.2017 19:32, Bhumika Goyal wrote: >>> Make this const as it is only passed to a const argument of the function >>> fpga_bridge_register. >>> >>> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> > > Acked-by: Moritz Fischer <mdf@kernel.org> >>> --- >>> drivers/fpga/xilinx-pr-decoupler.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c >>> index e359930..0d77430 100644 >>> --- a/drivers/fpga/xilinx-pr-decoupler.c >>> +++ b/drivers/fpga/xilinx-pr-decoupler.c >>> @@ -79,7 +79,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge) >>> return !status; >>> } >>> >>> -static struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = { >>> +static const struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = { >>> .enable_set = xlnx_pr_decoupler_enable_set, >>> .enable_show = xlnx_pr_decoupler_enable_show, >>> }; > > Must've been a leftover from when I worked on integrating a simple > GPIO based one. > I'll have to rebase that and submit it. >>> >> >> Acked-by: Michal Simek <michal.simek@xilinx.com> Signed-off-by: Alan Tull <atull@kernel.org> >> >> Thanks, >> Michal >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-fpga" in >> the body of a message to majordomo at vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > Thanks, > Moritz
next prev parent reply other threads:[~2017-09-21 14:43 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-28 17:32 [PATCH] fpga: make xlnx_pr_decoupler_br_ops const Bhumika Goyal 2017-08-28 17:32 ` Bhumika Goyal 2017-08-29 6:00 ` Michal Simek 2017-08-29 6:00 ` Michal Simek 2017-08-29 6:00 ` Michal Simek 2017-08-29 16:09 ` Moritz Fischer 2017-08-29 16:09 ` Moritz Fischer 2017-09-21 14:42 ` Alan Tull [this message] 2017-09-21 14:42 ` Alan Tull
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CANk1AXSdx1nJMqyvR1JNPEE5WMDuB0BrXLKw5bw5YcGMtpR_1A@mail.gmail.com \ --to=atull@kernel.org \ --cc=bhumirks@gmail.com \ --cc=julia.lawall@lip6.fr \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-fpga@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=michal.simek@xilinx.com \ --cc=moritz.fischer@ettus.com \ --cc=soren.brinkmann@xilinx.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.