All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fpga: make xlnx_pr_decoupler_br_ops const
@ 2017-08-28 17:32 ` Bhumika Goyal
  0 siblings, 0 replies; 9+ messages in thread
From: Bhumika Goyal @ 2017-08-28 17:32 UTC (permalink / raw)
  To: julia.lawall, atull, mdf, michal.simek, soren.brinkmann,
	linux-fpga, linux-arm-kernel, linux-kernel
  Cc: Bhumika Goyal

Make this const as it is only passed to a const argument of the function
fpga_bridge_register.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 drivers/fpga/xilinx-pr-decoupler.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
index e359930..0d77430 100644
--- a/drivers/fpga/xilinx-pr-decoupler.c
+++ b/drivers/fpga/xilinx-pr-decoupler.c
@@ -79,7 +79,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge)
 	return !status;
 }
 
-static struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
+static const struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
 	.enable_set = xlnx_pr_decoupler_enable_set,
 	.enable_show = xlnx_pr_decoupler_enable_show,
 };
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH] fpga: make xlnx_pr_decoupler_br_ops const
@ 2017-08-28 17:32 ` Bhumika Goyal
  0 siblings, 0 replies; 9+ messages in thread
From: Bhumika Goyal @ 2017-08-28 17:32 UTC (permalink / raw)
  To: linux-arm-kernel

Make this const as it is only passed to a const argument of the function
fpga_bridge_register.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 drivers/fpga/xilinx-pr-decoupler.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
index e359930..0d77430 100644
--- a/drivers/fpga/xilinx-pr-decoupler.c
+++ b/drivers/fpga/xilinx-pr-decoupler.c
@@ -79,7 +79,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge)
 	return !status;
 }
 
-static struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
+static const struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
 	.enable_set = xlnx_pr_decoupler_enable_set,
 	.enable_show = xlnx_pr_decoupler_enable_show,
 };
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH] fpga: make xlnx_pr_decoupler_br_ops const
  2017-08-28 17:32 ` Bhumika Goyal
  (?)
@ 2017-08-29  6:00   ` Michal Simek
  -1 siblings, 0 replies; 9+ messages in thread
From: Michal Simek @ 2017-08-29  6:00 UTC (permalink / raw)
  To: Bhumika Goyal, julia.lawall, atull, mdf, michal.simek,
	soren.brinkmann, linux-fpga, linux-arm-kernel, linux-kernel

On 28.8.2017 19:32, Bhumika Goyal wrote:
> Make this const as it is only passed to a const argument of the function
> fpga_bridge_register.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
>  drivers/fpga/xilinx-pr-decoupler.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
> index e359930..0d77430 100644
> --- a/drivers/fpga/xilinx-pr-decoupler.c
> +++ b/drivers/fpga/xilinx-pr-decoupler.c
> @@ -79,7 +79,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge)
>  	return !status;
>  }
>  
> -static struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
> +static const struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
>  	.enable_set = xlnx_pr_decoupler_enable_set,
>  	.enable_show = xlnx_pr_decoupler_enable_show,
>  };
> 

Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] fpga: make xlnx_pr_decoupler_br_ops const
@ 2017-08-29  6:00   ` Michal Simek
  0 siblings, 0 replies; 9+ messages in thread
From: Michal Simek @ 2017-08-29  6:00 UTC (permalink / raw)
  To: Bhumika Goyal, julia.lawall, atull, mdf, michal.simek,
	soren.brinkmann, linux-fpga, linux-arm-kernel, linux-kernel

On 28.8.2017 19:32, Bhumika Goyal wrote:
> Make this const as it is only passed to a const argument of the function
> fpga_bridge_register.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
>  drivers/fpga/xilinx-pr-decoupler.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
> index e359930..0d77430 100644
> --- a/drivers/fpga/xilinx-pr-decoupler.c
> +++ b/drivers/fpga/xilinx-pr-decoupler.c
> @@ -79,7 +79,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge)
>  	return !status;
>  }
>  
> -static struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
> +static const struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
>  	.enable_set = xlnx_pr_decoupler_enable_set,
>  	.enable_show = xlnx_pr_decoupler_enable_show,
>  };
> 

Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH] fpga: make xlnx_pr_decoupler_br_ops const
@ 2017-08-29  6:00   ` Michal Simek
  0 siblings, 0 replies; 9+ messages in thread
From: Michal Simek @ 2017-08-29  6:00 UTC (permalink / raw)
  To: linux-arm-kernel

On 28.8.2017 19:32, Bhumika Goyal wrote:
> Make this const as it is only passed to a const argument of the function
> fpga_bridge_register.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
>  drivers/fpga/xilinx-pr-decoupler.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
> index e359930..0d77430 100644
> --- a/drivers/fpga/xilinx-pr-decoupler.c
> +++ b/drivers/fpga/xilinx-pr-decoupler.c
> @@ -79,7 +79,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge)
>  	return !status;
>  }
>  
> -static struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
> +static const struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
>  	.enable_set = xlnx_pr_decoupler_enable_set,
>  	.enable_show = xlnx_pr_decoupler_enable_show,
>  };
> 

Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] fpga: make xlnx_pr_decoupler_br_ops const
  2017-08-29  6:00   ` Michal Simek
@ 2017-08-29 16:09     ` Moritz Fischer
  -1 siblings, 0 replies; 9+ messages in thread
From: Moritz Fischer @ 2017-08-29 16:09 UTC (permalink / raw)
  To: Michal Simek
  Cc: Bhumika Goyal, julia.lawall, Alan Tull, Sören Brinkmann,
	linux-fpga, linux-arm-kernel, Linux Kernel Mailing List

On Tue, Aug 29, 2017 at 12:00 AM, Michal Simek <michal.simek@xilinx.com> wrote:
> On 28.8.2017 19:32, Bhumika Goyal wrote:
>> Make this const as it is only passed to a const argument of the function
>> fpga_bridge_register.
>>
>> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Acked-by: Moritz Fischer <mdf@kernel.org>
>> ---
>>  drivers/fpga/xilinx-pr-decoupler.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
>> index e359930..0d77430 100644
>> --- a/drivers/fpga/xilinx-pr-decoupler.c
>> +++ b/drivers/fpga/xilinx-pr-decoupler.c
>> @@ -79,7 +79,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge)
>>       return !status;
>>  }
>>
>> -static struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
>> +static const struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
>>       .enable_set = xlnx_pr_decoupler_enable_set,
>>       .enable_show = xlnx_pr_decoupler_enable_show,
>>  };

Must've been a leftover from when I worked on integrating a simple
GPIO based one.
I'll have to rebase that and submit it.
>>
>
> Acked-by: Michal Simek <michal.simek@xilinx.com>
>
> Thanks,
> Michal
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Thanks,
Moritz

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH] fpga: make xlnx_pr_decoupler_br_ops const
@ 2017-08-29 16:09     ` Moritz Fischer
  0 siblings, 0 replies; 9+ messages in thread
From: Moritz Fischer @ 2017-08-29 16:09 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Aug 29, 2017 at 12:00 AM, Michal Simek <michal.simek@xilinx.com> wrote:
> On 28.8.2017 19:32, Bhumika Goyal wrote:
>> Make this const as it is only passed to a const argument of the function
>> fpga_bridge_register.
>>
>> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Acked-by: Moritz Fischer <mdf@kernel.org>
>> ---
>>  drivers/fpga/xilinx-pr-decoupler.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
>> index e359930..0d77430 100644
>> --- a/drivers/fpga/xilinx-pr-decoupler.c
>> +++ b/drivers/fpga/xilinx-pr-decoupler.c
>> @@ -79,7 +79,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge)
>>       return !status;
>>  }
>>
>> -static struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
>> +static const struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
>>       .enable_set = xlnx_pr_decoupler_enable_set,
>>       .enable_show = xlnx_pr_decoupler_enable_show,
>>  };

Must've been a leftover from when I worked on integrating a simple
GPIO based one.
I'll have to rebase that and submit it.
>>
>
> Acked-by: Michal Simek <michal.simek@xilinx.com>
>
> Thanks,
> Michal
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Thanks,
Moritz

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH] fpga: make xlnx_pr_decoupler_br_ops const
  2017-08-29 16:09     ` Moritz Fischer
@ 2017-09-21 14:42       ` Alan Tull
  -1 siblings, 0 replies; 9+ messages in thread
From: Alan Tull @ 2017-09-21 14:42 UTC (permalink / raw)
  To: Moritz Fischer
  Cc: Michal Simek, Bhumika Goyal, julia.lawall, Sören Brinkmann,
	linux-fpga, linux-arm-kernel, Linux Kernel Mailing List

On Tue, Aug 29, 2017 at 11:09 AM, Moritz Fischer
<moritz.fischer@ettus.com> wrote:
> On Tue, Aug 29, 2017 at 12:00 AM, Michal Simek <michal.simek@xilinx.com> wrote:
>> On 28.8.2017 19:32, Bhumika Goyal wrote:
>>> Make this const as it is only passed to a const argument of the function
>>> fpga_bridge_register.
>>>
>>> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
>
> Acked-by: Moritz Fischer <mdf@kernel.org>
>>> ---
>>>  drivers/fpga/xilinx-pr-decoupler.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
>>> index e359930..0d77430 100644
>>> --- a/drivers/fpga/xilinx-pr-decoupler.c
>>> +++ b/drivers/fpga/xilinx-pr-decoupler.c
>>> @@ -79,7 +79,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge)
>>>       return !status;
>>>  }
>>>
>>> -static struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
>>> +static const struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
>>>       .enable_set = xlnx_pr_decoupler_enable_set,
>>>       .enable_show = xlnx_pr_decoupler_enable_show,
>>>  };
>
> Must've been a leftover from when I worked on integrating a simple
> GPIO based one.
> I'll have to rebase that and submit it.
>>>
>>
>> Acked-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Alan Tull <atull@kernel.org>
>>
>> Thanks,
>> Michal
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
> Thanks,
> Moritz

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [PATCH] fpga: make xlnx_pr_decoupler_br_ops const
@ 2017-09-21 14:42       ` Alan Tull
  0 siblings, 0 replies; 9+ messages in thread
From: Alan Tull @ 2017-09-21 14:42 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Aug 29, 2017 at 11:09 AM, Moritz Fischer
<moritz.fischer@ettus.com> wrote:
> On Tue, Aug 29, 2017 at 12:00 AM, Michal Simek <michal.simek@xilinx.com> wrote:
>> On 28.8.2017 19:32, Bhumika Goyal wrote:
>>> Make this const as it is only passed to a const argument of the function
>>> fpga_bridge_register.
>>>
>>> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
>
> Acked-by: Moritz Fischer <mdf@kernel.org>
>>> ---
>>>  drivers/fpga/xilinx-pr-decoupler.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
>>> index e359930..0d77430 100644
>>> --- a/drivers/fpga/xilinx-pr-decoupler.c
>>> +++ b/drivers/fpga/xilinx-pr-decoupler.c
>>> @@ -79,7 +79,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge)
>>>       return !status;
>>>  }
>>>
>>> -static struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
>>> +static const struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
>>>       .enable_set = xlnx_pr_decoupler_enable_set,
>>>       .enable_show = xlnx_pr_decoupler_enable_show,
>>>  };
>
> Must've been a leftover from when I worked on integrating a simple
> GPIO based one.
> I'll have to rebase that and submit it.
>>>
>>
>> Acked-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Alan Tull <atull@kernel.org>
>>
>> Thanks,
>> Michal
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
>> the body of a message to majordomo at vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
> Thanks,
> Moritz

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-09-21 14:43 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-28 17:32 [PATCH] fpga: make xlnx_pr_decoupler_br_ops const Bhumika Goyal
2017-08-28 17:32 ` Bhumika Goyal
2017-08-29  6:00 ` Michal Simek
2017-08-29  6:00   ` Michal Simek
2017-08-29  6:00   ` Michal Simek
2017-08-29 16:09   ` Moritz Fischer
2017-08-29 16:09     ` Moritz Fischer
2017-09-21 14:42     ` Alan Tull
2017-09-21 14:42       ` Alan Tull

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.