Re: [PATCH v10 0/5] can: bxcan: add support for ST bxCAN controller

From: Dario Binacchi <dario.binacchi@amarulasolutions.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-kernel@vger.kernel.org,
	Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
	Rob Herring <robh@kernel.org>,
	Amarula patchwork <linux-amarula@amarulasolutions.com>,
	michael@amarulasolutions.com,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Christophe Roullier <christophe.roullier@foss.st.com>,
	"David S. Miller" <davem@davemloft.net>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Mark Brown <broonie@kernel.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh+dt@kernel.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Wolfgang Grandegger <wg@grandegger.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-can@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org
Subject: Re: [PATCH v10 0/5] can: bxcan: add support for ST bxCAN controller
Date: Tue, 28 Mar 2023 11:28:59 +0200	[thread overview]
Message-ID: <CABGWkvq0gOMw2J9GpLS=w+qg-3xhAst6KN9kvCuZnV9bSBJ3CA@mail.gmail.com> (raw)
In-Reply-To: <20230328084710.jnrwvydewx3atxti@pengutronix.de>

Hi Marc,

On Tue, Mar 28, 2023 at 10:47 AM Marc Kleine-Budde <mkl@pengutronix.de> wrote:
>
> On 28.03.2023 09:33:23, Dario Binacchi wrote:
> > The series adds support for the basic extended CAN controller (bxCAN)
> > found in many low- to middle-end STM32 SoCs.
> >
> > The driver has been tested on the stm32f469i-discovery board with a
> > kernel version 5.19.0-rc2 in loopback + silent mode:
> >
> > ip link set can0 type can bitrate 125000 loopback on listen-only on
> > ip link set up can0
> > candump can0 -L &
> > cansend can0 300#AC.AB.AD.AE.75.49.AD.D1
> >
> > For uboot and kernel compilation, as well as for rootfs creation I used
> > buildroot:
> >
> > make stm32f469_disco_sd_defconfig
> > make
> >
> > but I had to patch can-utils and busybox as can-utils and iproute are
> > not compiled for MMU-less microcotrollers. In the case of can-utils,
> > replacing the calls to fork() with vfork(), I was able to compile the
> > package with working candump and cansend applications, while in the
> > case of iproute, I ran into more than one problem and finally I decided
> > to extend busybox's ip link command for CAN-type devices. I'm still
> > wondering if it was really necessary, but this way I was able to test
> > the driver.
>
> Applied to linux-can-next.

Just one last question:
To test this series, as described in the cover letter, I could not use
the iproute2
package since the microcontroller is without MMU. I then extended busybox for
the ip link command. I actually also added the rtnl-link-can.c
application to the
libmnl library. So now I find myself with two applications that have
been useful
to me for this type of use case.
Did I do useless work because I could use other tools? If instead the tools for
this use case are missing, what do you think is better to do?
Submit to their respective repos or add this functionality to another
project that
I haven't considered ?

Thanks and regards,
Dario

>
> Thanks,
> Marc
>
> --
> Pengutronix e.K.                 | Marc Kleine-Budde           |
> Embedded Linux                   | https://www.pengutronix.de  |
> Vertretung Nürnberg              | Phone: +49-5121-206917-129  |
> Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

-- 

Dario Binacchi

Senior Embedded Linux Developer

dario.binacchi@amarulasolutions.com

__________________________________

Amarula Solutions SRL

Via Le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 042 243 5310
info@amarulasolutions.com

www.amarulasolutions.com