Re: [PATCH v10 0/5] can: bxcan: add support for ST bxCAN controller - Marc Kleine-Budde

From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc: linux-kernel@vger.kernel.org,
	Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
	Rob Herring <robh@kernel.org>,
	Amarula patchwork <linux-amarula@amarulasolutions.com>,
	michael@amarulasolutions.com,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Christophe Roullier <christophe.roullier@foss.st.com>,
	"David S. Miller" <davem@davemloft.net>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Mark Brown <broonie@kernel.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh+dt@kernel.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Wolfgang Grandegger <wg@grandegger.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-can@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org
Subject: Re: [PATCH v10 0/5] can: bxcan: add support for ST bxCAN controller
Date: Tue, 4 Apr 2023 13:28:12 +0200	[thread overview]
Message-ID: <20230404-postage-handprint-efdb77646082@pengutronix.de> (raw)
In-Reply-To: <CABGWkvq0gOMw2J9GpLS=w+qg-3xhAst6KN9kvCuZnV9bSBJ3CA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]

On 28.03.2023 11:28:59, Dario Binacchi wrote:
> > Applied to linux-can-next.
> 
> Just one last question: To test this series, as described in the cover
> letter, I could not use the iproute2 package since the microcontroller
> is without MMU. I then extended busybox for the ip link command. I
> actually also added the rtnl-link-can.c application to the libmnl
> library. So now I find myself with two applications that have been
> useful to me for this type of use case.
> 
> Did I do useless work because I could use other tools?

systemd-networkd also supports CAN configuration, but I this will
probably not work on no-MMU systemd, too.

Then there is:

| https://git.pengutronix.de/cgit/tools/canutils
| https://git.pengutronix.de/cgit/tools/libsocketcan

that contains canconfig, but it lacks CAN-FD support.

> If instead the tools for this use case are missing, what do you think
> is better to do? Submit to their respective repos or add this
> functionality to another project that I haven't considered ?

Yes, go ahead and upstream your changes!

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]