* Re: [Fuego] Fuego URL/port configuration issues
@ 2017-04-13 1:15 Bird, Timothy
[not found] ` <CABehs3NW0ZaKwmGTH8J13NMDcB7tLZNC47xKMTWA=5EC3iW1Xg@mail.gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Bird, Timothy @ 2017-04-13 1:15 UTC (permalink / raw)
To: fuego; +Cc: dhinakar k
> From: Bird, Timothy on Wednesday, April 12, 2017 3:50 PM>
> I was poking around Fuego today and stumbled upon a problem related to
> the Jenkins URL configuration, including the port number.
>
> Basically, JENKINS_URL (which includes the current port number for Jenkins)
> does not show
> up in a job environment until after a user has been to the Jenkins
> configuration page and
> saved it (at least one time).
>
> Because of this behavior, abort_job in common.sh has a hardcoded URL for
> accessing Jenkins.
> (It should rely on BUILD_URL, but this also is missing sometimes).
>
> If we want to fully support allowing users to change the port number for
> Jenkins, we will have
> to come up with a solution for the abort_job() function. My guess is that
> we'll want to
> actually configure the jenkins URL at docker image creation time, or on first
> run of Jenkins
> inside the container. Apparently if the file
> /var/lib/jenkins/jenkins.model/JenkinsLocationConfiguration.xml
> exists, then Jenkins uses that to define the JENKINS_URL (and other _URL)
> environment variable.
> So maybe we just need to create one at provision time. I haven't tested this
> yet.
>
> Anyway I thought I should report this issue. I've made a Fuego issue for it at:
> http://bird.org/fuego/Issue_0039
>
> Dhinakar - in the short term you can, of course, edit fuego-
> core/engine/scripts/common.sh, function abort_job,
> and put the correct port in the URL used there. But we need to figure out a
> better long-term solution for this.
>
OK - I've fixed this item for Fuego 1.1 - a fix is now at the top of the 'master' branch for this.
It turns out that if you add a jenkins.model.JenkinsLocationConfiguration.xml file, Jenkins
will detect it and hand out correct URLs, without requiring special user action. I've modified abort_job
accordingly. Now, if someone wants to change the port they need to change it in the
Jenkins configuration, and in this file, which starts in fuego/frontend-install, and ends up
in the container in /var/lib/jenkins.
Enjoy!
-- Tim
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Fuego] Fuego URL/port configuration issues
[not found] ` <CABehs3MotGiFhf-u5LdupgOd=E0Q=QCsc1KRngDSPGx8sNvLxA@mail.gmail.com>
@ 2017-04-13 1:33 ` dhinakar k
0 siblings, 0 replies; 3+ messages in thread
From: dhinakar k @ 2017-04-13 1:33 UTC (permalink / raw)
To: Bird, Timothy; +Cc: fuego
[-- Attachment #1: Type: text/plain, Size: 2275 bytes --]
Hi Tim,
Thanks a lot for your effort and fix.
I will check out your fix by doing a 'git pull' after going to office today.
Regards,
Dhinakar
On Apr 13, 2017 6:45 AM, "Bird, Timothy" <Tim.Bird@sony.com> wrote:
> From: Bird, Timothy on Wednesday, April 12, 2017 3:50 PM>
> I was poking around Fuego today and stumbled upon a problem related to
> the Jenkins URL configuration, including the port number.
>
> Basically, JENKINS_URL (which includes the current port number for
Jenkins)
> does not show
> up in a job environment until after a user has been to the Jenkins
> configuration page and
> saved it (at least one time).
>
> Because of this behavior, abort_job in common.sh has a hardcoded URL for
> accessing Jenkins.
> (It should rely on BUILD_URL, but this also is missing sometimes).
>
> If we want to fully support allowing users to change the port number for
> Jenkins, we will have
> to come up with a solution for the abort_job() function. My guess is that
> we'll want to
> actually configure the jenkins URL at docker image creation time, or on
first
> run of Jenkins
> inside the container. Apparently if the file
> /var/lib/jenkins/jenkins.model/JenkinsLocationConfiguration.xml
> exists, then Jenkins uses that to define the JENKINS_URL (and other _URL)
> environment variable.
> So maybe we just need to create one at provision time. I haven't tested
this
> yet.
>
> Anyway I thought I should report this issue. I've made a Fuego issue for
it at:
> http://bird.org/fuego/Issue_0039
>
> Dhinakar - in the short term you can, of course, edit fuego-
> core/engine/scripts/common.sh, function abort_job,
> and put the correct port in the URL used there. But we need to figure
out a
> better long-term solution for this.
>
OK - I've fixed this item for Fuego 1.1 - a fix is now at the top of the
'master' branch for this.
It turns out that if you add a jenkins.model.JenkinsLocationConfiguration.xml
file, Jenkins
will detect it and hand out correct URLs, without requiring special user
action. I've modified abort_job
accordingly. Now, if someone wants to change the port they need to change
it in the
Jenkins configuration, and in this file, which starts in
fuego/frontend-install, and ends up
in the container in /var/lib/jenkins.
Enjoy!
-- Tim
[-- Attachment #2: Type: text/html, Size: 3205 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Fuego] Fuego URL/port configuration issues
@ 2017-04-12 22:50 Bird, Timothy
0 siblings, 0 replies; 3+ messages in thread
From: Bird, Timothy @ 2017-04-12 22:50 UTC (permalink / raw)
To: fuego; +Cc: dhinakar k
Hello all (especially Daniel and Dhinakar),
I was poking around Fuego today and stumbled upon a problem related to
the Jenkins URL configuration, including the port number.
Basically, JENKINS_URL (which includes the current port number for Jenkins) does not show
up in a job environment until after a user has been to the Jenkins configuration page and
saved it (at least one time).
Because of this behavior, abort_job in common.sh has a hardcoded URL for accessing Jenkins.
(It should rely on BUILD_URL, but this also is missing sometimes).
If we want to fully support allowing users to change the port number for Jenkins, we will have
to come up with a solution for the abort_job() function. My guess is that we'll want to
actually configure the jenkins URL at docker image creation time, or on first run of Jenkins
inside the container. Apparently if the file /var/lib/jenkins/jenkins.model/JenkinsLocationConfiguration.xml
exists, then Jenkins uses that to define the JENKINS_URL (and other _URL) environment variable.
So maybe we just need to create one at provision time. I haven't tested this yet.
Anyway I thought I should report this issue. I've made a Fuego issue for it at:
http://bird.org/fuego/Issue_0039
Dhinakar - in the short term you can, of course, edit fuego-core/engine/scripts/common.sh, function abort_job,
and put the correct port in the URL used there. But we need to figure out a better long-term solution for this.
-- Tim
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-13 1:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-13 1:15 [Fuego] Fuego URL/port configuration issues Bird, Timothy
[not found] ` <CABehs3NW0ZaKwmGTH8J13NMDcB7tLZNC47xKMTWA=5EC3iW1Xg@mail.gmail.com>
[not found] ` <CABehs3MotGiFhf-u5LdupgOd=E0Q=QCsc1KRngDSPGx8sNvLxA@mail.gmail.com>
2017-04-13 1:33 ` dhinakar k
-- strict thread matches above, loose matches on Subject: below --
2017-04-12 22:50 Bird, Timothy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.