* [PATCH] multipath-tools: use internal drd.h file
@ 2016-10-08 20:22 Xose Vazquez Perez
2016-10-10 20:01 ` Bart Van Assche
2016-10-16 10:26 ` Xose Vazquez Perez
0 siblings, 2 replies; 6+ messages in thread
From: Xose Vazquez Perez @ 2016-10-08 20:22 UTC (permalink / raw)
Cc: Bart Van Assche, device-mapper development, Xose Vazquez Perez
Cc: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
libmultipath/debug.c | 2 +-
multipathd/main.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/libmultipath/debug.c b/libmultipath/debug.c
index 295136c..fbe171a 100644
--- a/libmultipath/debug.c
+++ b/libmultipath/debug.c
@@ -8,7 +8,7 @@
#include "log_pthread.h"
#include <sys/types.h>
#include <time.h>
-#include <../third-party/valgrind/drd.h>
+#include "../third-party/valgrind/drd.h"
#include "vector.h"
#include "config.h"
diff --git a/multipathd/main.c b/multipathd/main.c
index cdfafe8..0998085 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -23,7 +23,6 @@
#endif
#include <semaphore.h>
#include <time.h>
-#include <valgrind/drd.h>
/*
* libmultipath
@@ -85,6 +84,7 @@ int uxsock_timeout;
#include "lock.h"
#include "waiter.h"
#include "wwids.h"
+#include "../third-party/valgrind/drd.h"
#define FILE_NAME_SIZE 256
#define CMDSIZE 160
--
2.10.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] multipath-tools: use internal drd.h file
2016-10-08 20:22 [PATCH] multipath-tools: use internal drd.h file Xose Vazquez Perez
@ 2016-10-10 20:01 ` Bart Van Assche
2016-10-16 10:26 ` Xose Vazquez Perez
1 sibling, 0 replies; 6+ messages in thread
From: Bart Van Assche @ 2016-10-10 20:01 UTC (permalink / raw)
To: Xose Vazquez Perez; +Cc: device-mapper development
On 10/08/2016 01:22 PM, Xose Vazquez Perez wrote:
> Cc: Bart Van Assche <bart.vanassche@sandisk.com>
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: device-mapper development <dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
> libmultipath/debug.c | 2 +-
> multipathd/main.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libmultipath/debug.c b/libmultipath/debug.c
> index 295136c..fbe171a 100644
> --- a/libmultipath/debug.c
> +++ b/libmultipath/debug.c
> @@ -8,7 +8,7 @@
> #include "log_pthread.h"
> #include <sys/types.h>
> #include <time.h>
> -#include <../third-party/valgrind/drd.h>
> +#include "../third-party/valgrind/drd.h"
> #include "vector.h"
> #include "config.h"
>
> diff --git a/multipathd/main.c b/multipathd/main.c
> index cdfafe8..0998085 100644
> --- a/multipathd/main.c
> +++ b/multipathd/main.c
> @@ -23,7 +23,6 @@
> #endif
> #include <semaphore.h>
> #include <time.h>
> -#include <valgrind/drd.h>
>
> /*
> * libmultipath
> @@ -85,6 +84,7 @@ int uxsock_timeout;
> #include "lock.h"
> #include "waiter.h"
> #include "wwids.h"
> +#include "../third-party/valgrind/drd.h"
>
> #define FILE_NAME_SIZE 256
> #define CMDSIZE 160
Hello Xose,
The patch description is slightly misleading. I don't think anyone has a
/usr/third-party directory on her or his system so #include
<../third-party/valgrind/drd.h> will select the internal drd.h header
file. However, that first change improves consistency:
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] multipath-tools: use internal drd.h file
2016-10-08 20:22 [PATCH] multipath-tools: use internal drd.h file Xose Vazquez Perez
2016-10-10 20:01 ` Bart Van Assche
@ 2016-10-16 10:26 ` Xose Vazquez Perez
2016-10-16 15:54 ` Christophe Varoqui
2016-10-16 16:59 ` Hannes Reinecke
1 sibling, 2 replies; 6+ messages in thread
From: Xose Vazquez Perez @ 2016-10-16 10:26 UTC (permalink / raw)
To: Christophe Varoqui; +Cc: Bart Van Assche, device-mapper development
On 10/08/2016 10:22 PM, Xose Vazquez Perez wrote:
> Cc: Bart Van Assche <bart.vanassche@sandisk.com>
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: device-mapper development <dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
> libmultipath/debug.c | 2 +-
> multipathd/main.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
This patch is missing.
Thank you.
> diff --git a/libmultipath/debug.c b/libmultipath/debug.c
> index 295136c..fbe171a 100644
> --- a/libmultipath/debug.c
> +++ b/libmultipath/debug.c
> @@ -8,7 +8,7 @@
> #include "log_pthread.h"
> #include <sys/types.h>
> #include <time.h>
> -#include <../third-party/valgrind/drd.h>
> +#include "../third-party/valgrind/drd.h"
> #include "vector.h"
> #include "config.h"
>
> diff --git a/multipathd/main.c b/multipathd/main.c
> index cdfafe8..0998085 100644
> --- a/multipathd/main.c
> +++ b/multipathd/main.c
> @@ -23,7 +23,6 @@
> #endif
> #include <semaphore.h>
> #include <time.h>
> -#include <valgrind/drd.h>
>
> /*
> * libmultipath
> @@ -85,6 +84,7 @@ int uxsock_timeout;
> #include "lock.h"
> #include "waiter.h"
> #include "wwids.h"
> +#include "../third-party/valgrind/drd.h"
>
> #define FILE_NAME_SIZE 256
> #define CMDSIZE 160
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] multipath-tools: use internal drd.h file
2016-10-16 10:26 ` Xose Vazquez Perez
@ 2016-10-16 15:54 ` Christophe Varoqui
2016-10-16 16:59 ` Hannes Reinecke
1 sibling, 0 replies; 6+ messages in thread
From: Christophe Varoqui @ 2016-10-16 15:54 UTC (permalink / raw)
To: Xose Vazquez Perez; +Cc: Bart Van Assche, device-mapper development
[-- Attachment #1.1: Type: text/plain, Size: 1489 bytes --]
Merged.
Thanks.
On Sun, Oct 16, 2016 at 12:26 PM, Xose Vazquez Perez <xose.vazquez@gmail.com
> wrote:
> On 10/08/2016 10:22 PM, Xose Vazquez Perez wrote:
>
> > Cc: Bart Van Assche <bart.vanassche@sandisk.com>
> > Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> > Cc: device-mapper development <dm-devel@redhat.com>
> > Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> > ---
> > libmultipath/debug.c | 2 +-
> > multipathd/main.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
>
> This patch is missing.
> Thank you.
>
>
> > diff --git a/libmultipath/debug.c b/libmultipath/debug.c
> > index 295136c..fbe171a 100644
> > --- a/libmultipath/debug.c
> > +++ b/libmultipath/debug.c
> > @@ -8,7 +8,7 @@
> > #include "log_pthread.h"
> > #include <sys/types.h>
> > #include <time.h>
> > -#include <../third-party/valgrind/drd.h>
> > +#include "../third-party/valgrind/drd.h"
> > #include "vector.h"
> > #include "config.h"
> >
> > diff --git a/multipathd/main.c b/multipathd/main.c
> > index cdfafe8..0998085 100644
> > --- a/multipathd/main.c
> > +++ b/multipathd/main.c
> > @@ -23,7 +23,6 @@
> > #endif
> > #include <semaphore.h>
> > #include <time.h>
> > -#include <valgrind/drd.h>
> >
> > /*
> > * libmultipath
> > @@ -85,6 +84,7 @@ int uxsock_timeout;
> > #include "lock.h"
> > #include "waiter.h"
> > #include "wwids.h"
> > +#include "../third-party/valgrind/drd.h"
> >
> > #define FILE_NAME_SIZE 256
> > #define CMDSIZE 160
> >
>
>
[-- Attachment #1.2: Type: text/html, Size: 2510 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] multipath-tools: use internal drd.h file
2016-10-16 10:26 ` Xose Vazquez Perez
2016-10-16 15:54 ` Christophe Varoqui
@ 2016-10-16 16:59 ` Hannes Reinecke
2016-10-16 17:34 ` Christophe Varoqui
1 sibling, 1 reply; 6+ messages in thread
From: Hannes Reinecke @ 2016-10-16 16:59 UTC (permalink / raw)
To: dm-devel
On 10/16/2016 12:26 PM, Xose Vazquez Perez wrote:
> On 10/08/2016 10:22 PM, Xose Vazquez Perez wrote:
>
>> Cc: Bart Van Assche <bart.vanassche@sandisk.com>
>> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
>> Cc: device-mapper development <dm-devel@redhat.com>
>> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
>> ---
>> libmultipath/debug.c | 2 +-
>> multipathd/main.c | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> This patch is missing.
> Thank you.
>
>
>> diff --git a/libmultipath/debug.c b/libmultipath/debug.c
>> index 295136c..fbe171a 100644
>> --- a/libmultipath/debug.c
>> +++ b/libmultipath/debug.c
>> @@ -8,7 +8,7 @@
>> #include "log_pthread.h"
>> #include <sys/types.h>
>> #include <time.h>
>> -#include <../third-party/valgrind/drd.h>
>> +#include "../third-party/valgrind/drd.h"
>> #include "vector.h"
>> #include "config.h"
>>
>> diff --git a/multipathd/main.c b/multipathd/main.c
>> index cdfafe8..0998085 100644
>> --- a/multipathd/main.c
>> +++ b/multipathd/main.c
>> @@ -23,7 +23,6 @@
>> #endif
>> #include <semaphore.h>
>> #include <time.h>
>> -#include <valgrind/drd.h>
>>
>> /*
>> * libmultipath
>> @@ -85,6 +84,7 @@ int uxsock_timeout;
>> #include "lock.h"
>> #include "waiter.h"
>> #include "wwids.h"
>> +#include "../third-party/valgrind/drd.h"
>>
>> #define FILE_NAME_SIZE 256
>> #define CMDSIZE 160
>>
>
Please don't.
We're trying to keep dependencies to each package as small as possible.
And requiring valgrind by default is not going to help here.
Please make this a compile-time option.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] multipath-tools: use internal drd.h file
2016-10-16 16:59 ` Hannes Reinecke
@ 2016-10-16 17:34 ` Christophe Varoqui
0 siblings, 0 replies; 6+ messages in thread
From: Christophe Varoqui @ 2016-10-16 17:34 UTC (permalink / raw)
To: Hannes Reinecke; +Cc: device-mapper development
[-- Attachment #1.1: Type: text/plain, Size: 2280 bytes --]
That's why we included a copy of the required valgrind header.
Does this solution eleviate your complain ?
On Sun, Oct 16, 2016 at 6:59 PM, Hannes Reinecke <hare@suse.de> wrote:
> On 10/16/2016 12:26 PM, Xose Vazquez Perez wrote:
>
>> On 10/08/2016 10:22 PM, Xose Vazquez Perez wrote:
>>
>> Cc: Bart Van Assche <bart.vanassche@sandisk.com>
>>> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
>>> Cc: device-mapper development <dm-devel@redhat.com>
>>> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
>>> ---
>>> libmultipath/debug.c | 2 +-
>>> multipathd/main.c | 2 +-
>>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>
>> This patch is missing.
>> Thank you.
>>
>>
>> diff --git a/libmultipath/debug.c b/libmultipath/debug.c
>>> index 295136c..fbe171a 100644
>>> --- a/libmultipath/debug.c
>>> +++ b/libmultipath/debug.c
>>> @@ -8,7 +8,7 @@
>>> #include "log_pthread.h"
>>> #include <sys/types.h>
>>> #include <time.h>
>>> -#include <../third-party/valgrind/drd.h>
>>> +#include "../third-party/valgrind/drd.h"
>>> #include "vector.h"
>>> #include "config.h"
>>>
>>> diff --git a/multipathd/main.c b/multipathd/main.c
>>> index cdfafe8..0998085 100644
>>> --- a/multipathd/main.c
>>> +++ b/multipathd/main.c
>>> @@ -23,7 +23,6 @@
>>> #endif
>>> #include <semaphore.h>
>>> #include <time.h>
>>> -#include <valgrind/drd.h>
>>>
>>> /*
>>> * libmultipath
>>> @@ -85,6 +84,7 @@ int uxsock_timeout;
>>> #include "lock.h"
>>> #include "waiter.h"
>>> #include "wwids.h"
>>> +#include "../third-party/valgrind/drd.h"
>>>
>>> #define FILE_NAME_SIZE 256
>>> #define CMDSIZE 160
>>>
>>>
>> Please don't.
> We're trying to keep dependencies to each package as small as possible.
> And requiring valgrind by default is not going to help here.
> Please make this a compile-time option.
>
> Cheers,
>
> Hannes
> --
> Dr. Hannes Reinecke zSeries & Storage
> hare@suse.de +49 911 74053 688
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
>
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
>
[-- Attachment #1.2: Type: text/html, Size: 3886 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-16 17:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-08 20:22 [PATCH] multipath-tools: use internal drd.h file Xose Vazquez Perez
2016-10-10 20:01 ` Bart Van Assche
2016-10-16 10:26 ` Xose Vazquez Perez
2016-10-16 15:54 ` Christophe Varoqui
2016-10-16 16:59 ` Hannes Reinecke
2016-10-16 17:34 ` Christophe Varoqui
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.