Checkpatch Patches

Checkpatch Patches

[nick]

I am attaching two check patch patches I wrote in the last few days as I am unable to get a reply 
from the maintainers. Would someone please send them off for me.
Thanks,
Nick 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-staging-Add-blank-line-below-declarations-in-hfa384x.patch
Type: text/x-patch
Size: 1516 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20140916/a07557f8/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-staging-netlogic-Fix-checkpatch-errors-in-xlr_net.c.patch
Type: text/x-patch
Size: 1419 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20140916/a07557f8/attachment-0001.bin 

Checkpatch Patches

[Kristofer Hallin]

I wouldn't touch those with a ten foot pole.
On 16 Sep 2014 14:46, "nick" <xerofoify@gmail.com> wrote:

> I am attaching two check patch patches I wrote in the last few days as I
> am unable to get a reply
> from the maintainers. Would someone please send them off for me.
> Thanks,
> Nick
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20140916/5e47471e/attachment.html 

Checkpatch Patches

[nick]

On 14-09-16 08:47 AM, Kristofer Hallin wrote:
> I wouldn't touch those with a ten foot pole.
> On 16 Sep 2014 14:46, "nick" <xerofoify@gmail.com> wrote:
> 
>> I am attaching two check patch patches I wrote in the last few days as I
>> am unable to get a reply
>> from the maintainers. Would someone please send them off for me.
>> Thanks,
>> Nick
>>
>> _______________________________________________
>> Kernelnewbies mailing list
>> Kernelnewbies at kernelnewbies.org
>> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>>
>>
> 
Kristofer,
I would appreciate if you look at them and see if there any good. I understand
based on my other patches so assumptions but it would be nice if you only too
a look for me.
Nick  

Checkpatch Patches

[Sudip Mukherjee]

On Tue, Sep 16, 2014 at 08:44:27AM -0400, nick wrote:
> I am attaching two check patch patches I wrote in the last few days as I am unable to get a reply 
> from the maintainers. Would someone please send them off for me.
> Thanks,
> Nick 

> >From 7bf4229fa2f9c4fcf3243bc738c74bfdc58a6594 Mon Sep 17 00:00:00 2001
> From: Nicholas Krause <xerofoify@gmail.com>
> Date: Sat, 13 Sep 2014 11:53:24 -0400
> Subject: [PATCH] staging wlan-ng: Add missing a blank line after declarations
> 
> Fixing trivial checkpatch warnings about missing line after
> declarations.
> 
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> Tested by compilation only.
>  drivers/staging/wlan-ng/hfa384x.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> index 1f2c78c..20d146b 100644
> --- a/drivers/staging/wlan-ng/hfa384x.h
> +++ b/drivers/staging/wlan-ng/hfa384x.h
> @@ -1376,6 +1376,7 @@ int hfa384x_drvr_setconfig(hfa384x_t *hw, u16 rid, void *buf, u16 len);
>  static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
>  {
>  	int result = 0;
> +
>  	result = hfa384x_drvr_getconfig(hw, rid, val, sizeof(u16));
>  	if (result == 0)
>  		*((u16 *) val) = le16_to_cpu(*((u16 *) val));
> @@ -1385,6 +1386,7 @@ static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
>  static inline int hfa384x_drvr_setconfig16(hfa384x_t *hw, u16 rid, u16 val)
>  {
>  	u16 value = cpu_to_le16(val);
> +
>  	return hfa384x_drvr_setconfig(hw, rid, &value, sizeof(value));
>  }
> @@ -1402,6 +1404,7 @@ static inline int
>  hfa384x_drvr_setconfig16_async(hfa384x_t *hw, u16 rid, u16 val)
>  {
>  	u16 value = cpu_to_le16(val);
> +
>  	return hfa384x_drvr_setconfig_async(hw, rid, &value, sizeof(value),
>  					    NULL, NULL);
>  }
> 1.9.1
> 

> >From 5eb3de22f0760ece1e838d48c8dd9148b4331cdc Mon Sep 17 00:00:00 2001
> From: Nicholas Krause <xerofoify@gmail.com>
> Date: Mon, 15 Sep 2014 17:07:24 -0400
> Subject: [PATCH] staging netlogic: Fix checkpatch errors in xlr_net.c
> 
> This removes the checkpatch errors related to a needed line below
> declaration of a struct and another about a non nessary printk
> message about a NULL allocated skb due to the function returning
> NULL to the caller of the function and the printk no longer being'
> used or needed by any callers.
> 

spelling mistakes  

> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  drivers/staging/netlogic/xlr_net.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c
> index 9bf407d..28a42831 100644
> --- a/drivers/staging/netlogic/xlr_net.c
> +++ b/drivers/staging/netlogic/xlr_net.c
> @@ -142,10 +142,8 @@ static inline struct sk_buff *xlr_alloc_skb(void)
>  
>  	/* skb->data is cache aligned */
>  	skb = alloc_skb(XLR_RX_BUF_SIZE, GFP_ATOMIC);
> -	if (!skb) {
> -		pr_err("SKB allocation failed\n");

why the error message was removed ? 
	

> +	if (!skb)
>  		return NULL;
> -	}
>  	mac_put_skb_back_ptr(skb);
>  	return skb;
>  }
> @@ -1104,6 +1102,7 @@ err_gmac:
>  static int xlr_net_remove(struct platform_device *pdev)
>  {
>  	struct xlr_net_priv *priv = platform_get_drvdata(pdev);
> +
>  	unregister_netdev(priv->ndev);
>  	mdiobus_unregister(priv->mii_bus);
>  	mdiobus_free(priv->mii_bus);
> -- 
> 1.9.1
> 

ohhh .. yeah .. and both the patch failed when i tried to apply them to next-20140916


why are we wasting our time for your patches , which are bound to have some problem ????

thanks
sudip


> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Checkpatch Patches

[Robert P. J. Day]

On Tue, 16 Sep 2014, nick wrote:

> I am attaching two check patch patches I wrote in the last few days
> as I am unable to get a reply from the maintainers. Would someone
> please send them off for me.

  hey, kids ... remember what i wrote recently about, at the very
least, having a grammatically correct subject line? well, there you
go. why nick has not been banned from this list is purely a mystery at
this point.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Checkpatch Patches

[nick]

On 14-09-16 09:06 AM, Sudip Mukherjee wrote:
> On Tue, Sep 16, 2014 at 08:44:27AM -0400, nick wrote:
>> I am attaching two check patch patches I wrote in the last few days as I am unable to get a reply 
>> from the maintainers. Would someone please send them off for me.
>> Thanks,
>> Nick 
> 
>> >From 7bf4229fa2f9c4fcf3243bc738c74bfdc58a6594 Mon Sep 17 00:00:00 2001
>> From: Nicholas Krause <xerofoify@gmail.com>
>> Date: Sat, 13 Sep 2014 11:53:24 -0400
>> Subject: [PATCH] staging wlan-ng: Add missing a blank line after declarations
>>
>> Fixing trivial checkpatch warnings about missing line after
>> declarations.
>>
>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>> ---
>> Tested by compilation only.
>>  drivers/staging/wlan-ng/hfa384x.h | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
>> index 1f2c78c..20d146b 100644
>> --- a/drivers/staging/wlan-ng/hfa384x.h
>> +++ b/drivers/staging/wlan-ng/hfa384x.h
>> @@ -1376,6 +1376,7 @@ int hfa384x_drvr_setconfig(hfa384x_t *hw, u16 rid, void *buf, u16 len);
>>  static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
>>  {
>>  	int result = 0;
>> +
>>  	result = hfa384x_drvr_getconfig(hw, rid, val, sizeof(u16));
>>  	if (result == 0)
>>  		*((u16 *) val) = le16_to_cpu(*((u16 *) val));
>> @@ -1385,6 +1386,7 @@ static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
>>  static inline int hfa384x_drvr_setconfig16(hfa384x_t *hw, u16 rid, u16 val)
>>  {
>>  	u16 value = cpu_to_le16(val);
>> +
>>  	return hfa384x_drvr_setconfig(hw, rid, &value, sizeof(value));
>>  }
>> @@ -1402,6 +1404,7 @@ static inline int
>>  hfa384x_drvr_setconfig16_async(hfa384x_t *hw, u16 rid, u16 val)
>>  {
>>  	u16 value = cpu_to_le16(val);
>> +
>>  	return hfa384x_drvr_setconfig_async(hw, rid, &value, sizeof(value),
>>  					    NULL, NULL);
>>  }
>> 1.9.1
>>
> 
>> >From 5eb3de22f0760ece1e838d48c8dd9148b4331cdc Mon Sep 17 00:00:00 2001
>> From: Nicholas Krause <xerofoify@gmail.com>
>> Date: Mon, 15 Sep 2014 17:07:24 -0400
>> Subject: [PATCH] staging netlogic: Fix checkpatch errors in xlr_net.c
>>
>> This removes the checkpatch errors related to a needed line below
>> declaration of a struct and another about a non nessary printk
>> message about a NULL allocated skb due to the function returning
>> NULL to the caller of the function and the printk no longer being'
>> used or needed by any callers.
>>
> 
> spelling mistakes  
> 
>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>> ---
>>  drivers/staging/netlogic/xlr_net.c | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c
>> index 9bf407d..28a42831 100644
>> --- a/drivers/staging/netlogic/xlr_net.c
>> +++ b/drivers/staging/netlogic/xlr_net.c
>> @@ -142,10 +142,8 @@ static inline struct sk_buff *xlr_alloc_skb(void)
>>  
>>  	/* skb->data is cache aligned */
>>  	skb = alloc_skb(XLR_RX_BUF_SIZE, GFP_ATOMIC);
>> -	if (!skb) {
>> -		pr_err("SKB allocation failed\n");
> 
> why the error message was removed ? 
> 	
> 
>> +	if (!skb)
>>  		return NULL;
>> -	}
>>  	mac_put_skb_back_ptr(skb);
>>  	return skb;
>>  }
>> @@ -1104,6 +1102,7 @@ err_gmac:
>>  static int xlr_net_remove(struct platform_device *pdev)
>>  {
>>  	struct xlr_net_priv *priv = platform_get_drvdata(pdev);
>> +
>>  	unregister_netdev(priv->ndev);
>>  	mdiobus_unregister(priv->mii_bus);
>>  	mdiobus_free(priv->mii_bus);
>> -- 
>> 1.9.1
>>
> 
> ohhh .. yeah .. and both the patch failed when i tried to apply them to next-20140916
> 
> 
> why are we wasting our time for your patches , which are bound to have some problem ????
> 
> thanks
> sudip
> 
> 
>> _______________________________________________
>> Kernelnewbies mailing list
>> Kernelnewbies at kernelnewbies.org
>> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
> 
I tried these on Greg's tree of staging-next and they worked for me.
Nick

Checkpatch Patches

[Robert P. J. Day]

On Tue, 16 Sep 2014, nick wrote:

> I am attaching two check patch patches I wrote in the last few days
> as I am unable to get a reply from the maintainers. Would someone
> please send them off for me.

  oh, and remember how i wrote *explicitly* that the patch message
should match the properties of the patch, and that one should not
claim to be fixing an "error" if what is being rectified is merely a
*warning*?  remember i wrote that?

  take a wild guess as to what nick did in his second patch. go ahead,
guess. you'll never guess.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Checkpatch Patches

[Sudip Mukherjee]

On Tue, Sep 16, 2014 at 6:41 PM, nick <xerofoify@gmail.com> wrote:
>
>
> On 14-09-16 09:06 AM, Sudip Mukherjee wrote:
>> On Tue, Sep 16, 2014 at 08:44:27AM -0400, nick wrote:
>>> I am attaching two check patch patches I wrote in the last few days as I am unable to get a reply
>>> from the maintainers. Would someone please send them off for me.
>>> Thanks,
>>> Nick
>>
>>> >From 7bf4229fa2f9c4fcf3243bc738c74bfdc58a6594 Mon Sep 17 00:00:00 2001
>>> From: Nicholas Krause <xerofoify@gmail.com>
>>> Date: Sat, 13 Sep 2014 11:53:24 -0400
>>> Subject: [PATCH] staging wlan-ng: Add missing a blank line after declarations
>>>
>>> Fixing trivial checkpatch warnings about missing line after
>>> declarations.
>>>
>>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>>> ---
>>> Tested by compilation only.
>>>  drivers/staging/wlan-ng/hfa384x.h | 3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
>>> index 1f2c78c..20d146b 100644
>>> --- a/drivers/staging/wlan-ng/hfa384x.h
>>> +++ b/drivers/staging/wlan-ng/hfa384x.h
>>> @@ -1376,6 +1376,7 @@ int hfa384x_drvr_setconfig(hfa384x_t *hw, u16 rid, void *buf, u16 len);
>>>  static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
>>>  {
>>>      int result = 0;
>>> +
>>>      result = hfa384x_drvr_getconfig(hw, rid, val, sizeof(u16));
>>>      if (result == 0)
>>>              *((u16 *) val) = le16_to_cpu(*((u16 *) val));
>>> @@ -1385,6 +1386,7 @@ static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
>>>  static inline int hfa384x_drvr_setconfig16(hfa384x_t *hw, u16 rid, u16 val)
>>>  {
>>>      u16 value = cpu_to_le16(val);
>>> +
>>>      return hfa384x_drvr_setconfig(hw, rid, &value, sizeof(value));
>>>  }
>>> @@ -1402,6 +1404,7 @@ static inline int
>>>  hfa384x_drvr_setconfig16_async(hfa384x_t *hw, u16 rid, u16 val)
>>>  {
>>>      u16 value = cpu_to_le16(val);
>>> +
>>>      return hfa384x_drvr_setconfig_async(hw, rid, &value, sizeof(value),
>>>                                          NULL, NULL);
>>>  }
>>> 1.9.1
>>>
>>
>>> >From 5eb3de22f0760ece1e838d48c8dd9148b4331cdc Mon Sep 17 00:00:00 2001
>>> From: Nicholas Krause <xerofoify@gmail.com>
>>> Date: Mon, 15 Sep 2014 17:07:24 -0400
>>> Subject: [PATCH] staging netlogic: Fix checkpatch errors in xlr_net.c
>>>
>>> This removes the checkpatch errors related to a needed line below
>>> declaration of a struct and another about a non nessary printk
>>> message about a NULL allocated skb due to the function returning
>>> NULL to the caller of the function and the printk no longer being'
>>> used or needed by any callers.
>>>
>>
>> spelling mistakes
>>
>>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>>> ---
>>>  drivers/staging/netlogic/xlr_net.c | 5 ++---
>>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c
>>> index 9bf407d..28a42831 100644
>>> --- a/drivers/staging/netlogic/xlr_net.c
>>> +++ b/drivers/staging/netlogic/xlr_net.c
>>> @@ -142,10 +142,8 @@ static inline struct sk_buff *xlr_alloc_skb(void)
>>>
>>>      /* skb->data is cache aligned */
>>>      skb = alloc_skb(XLR_RX_BUF_SIZE, GFP_ATOMIC);
>>> -    if (!skb) {
>>> -            pr_err("SKB allocation failed\n");
>>
>> why the error message was removed ?
>>
>>
>>> +    if (!skb)
>>>              return NULL;
>>> -    }
>>>      mac_put_skb_back_ptr(skb);
>>>      return skb;
>>>  }
>>> @@ -1104,6 +1102,7 @@ err_gmac:
>>>  static int xlr_net_remove(struct platform_device *pdev)
>>>  {
>>>      struct xlr_net_priv *priv = platform_get_drvdata(pdev);
>>> +
>>>      unregister_netdev(priv->ndev);
>>>      mdiobus_unregister(priv->mii_bus);
>>>      mdiobus_free(priv->mii_bus);
>>> --
>>> 1.9.1
>>>
>>
>> ohhh .. yeah .. and both the patch failed when i tried to apply them to next-20140916
>>
>>
>> why are we wasting our time for your patches , which are bound to have some problem ????
>>
>> thanks
>> sudip
>>
>>
>>> _______________________________________________
>>> Kernelnewbies mailing list
>>> Kernelnewbies at kernelnewbies.org
>>> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>>
> I tried these on Greg's tree of staging-next and they worked for me.
> Nick

in drivers/staging/netlogic/xlr_net.c file of next-20140916

1) in line 142 we just have an "} else {"  (doesnot match your patch)
2) in the same file , there is only one instance of "pr_err("SKB
allocation failed\n");" , and that is at line 208 , and that is
followed by a "return -ENOMEM;" , but your patch is showing that there
is a return NULL ....

thanks
sudip

Checkpatch Patches

[nick]

On 14-09-16 09:21 AM, Sudip Mukherjee wrote:
> On Tue, Sep 16, 2014 at 6:41 PM, nick <xerofoify@gmail.com> wrote:
>>
>>
>> On 14-09-16 09:06 AM, Sudip Mukherjee wrote:
>>> On Tue, Sep 16, 2014 at 08:44:27AM -0400, nick wrote:
>>>> I am attaching two check patch patches I wrote in the last few days as I am unable to get a reply
>>>> from the maintainers. Would someone please send them off for me.
>>>> Thanks,
>>>> Nick
>>>
>>>> >From 7bf4229fa2f9c4fcf3243bc738c74bfdc58a6594 Mon Sep 17 00:00:00 2001
>>>> From: Nicholas Krause <xerofoify@gmail.com>
>>>> Date: Sat, 13 Sep 2014 11:53:24 -0400
>>>> Subject: [PATCH] staging wlan-ng: Add missing a blank line after declarations
>>>>
>>>> Fixing trivial checkpatch warnings about missing line after
>>>> declarations.
>>>>
>>>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>>>> ---
>>>> Tested by compilation only.
>>>>  drivers/staging/wlan-ng/hfa384x.h | 3 +++
>>>>  1 file changed, 3 insertions(+)
>>>>
>>>> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
>>>> index 1f2c78c..20d146b 100644
>>>> --- a/drivers/staging/wlan-ng/hfa384x.h
>>>> +++ b/drivers/staging/wlan-ng/hfa384x.h
>>>> @@ -1376,6 +1376,7 @@ int hfa384x_drvr_setconfig(hfa384x_t *hw, u16 rid, void *buf, u16 len);
>>>>  static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
>>>>  {
>>>>      int result = 0;
>>>> +
>>>>      result = hfa384x_drvr_getconfig(hw, rid, val, sizeof(u16));
>>>>      if (result == 0)
>>>>              *((u16 *) val) = le16_to_cpu(*((u16 *) val));
>>>> @@ -1385,6 +1386,7 @@ static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
>>>>  static inline int hfa384x_drvr_setconfig16(hfa384x_t *hw, u16 rid, u16 val)
>>>>  {
>>>>      u16 value = cpu_to_le16(val);
>>>> +
>>>>      return hfa384x_drvr_setconfig(hw, rid, &value, sizeof(value));
>>>>  }
>>>> @@ -1402,6 +1404,7 @@ static inline int
>>>>  hfa384x_drvr_setconfig16_async(hfa384x_t *hw, u16 rid, u16 val)
>>>>  {
>>>>      u16 value = cpu_to_le16(val);
>>>> +
>>>>      return hfa384x_drvr_setconfig_async(hw, rid, &value, sizeof(value),
>>>>                                          NULL, NULL);
>>>>  }
>>>> 1.9.1
>>>>
>>>
>>>> >From 5eb3de22f0760ece1e838d48c8dd9148b4331cdc Mon Sep 17 00:00:00 2001
>>>> From: Nicholas Krause <xerofoify@gmail.com>
>>>> Date: Mon, 15 Sep 2014 17:07:24 -0400
>>>> Subject: [PATCH] staging netlogic: Fix checkpatch errors in xlr_net.c
>>>>
>>>> This removes the checkpatch errors related to a needed line below
>>>> declaration of a struct and another about a non nessary printk
>>>> message about a NULL allocated skb due to the function returning
>>>> NULL to the caller of the function and the printk no longer being'
>>>> used or needed by any callers.
>>>>
>>>
>>> spelling mistakes
>>>
>>>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>>>> ---
>>>>  drivers/staging/netlogic/xlr_net.c | 5 ++---
>>>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c
>>>> index 9bf407d..28a42831 100644
>>>> --- a/drivers/staging/netlogic/xlr_net.c
>>>> +++ b/drivers/staging/netlogic/xlr_net.c
>>>> @@ -142,10 +142,8 @@ static inline struct sk_buff *xlr_alloc_skb(void)
>>>>
>>>>      /* skb->data is cache aligned */
>>>>      skb = alloc_skb(XLR_RX_BUF_SIZE, GFP_ATOMIC);
>>>> -    if (!skb) {
>>>> -            pr_err("SKB allocation failed\n");
>>>
>>> why the error message was removed ?
>>>
>>>
>>>> +    if (!skb)
>>>>              return NULL;
>>>> -    }
>>>>      mac_put_skb_back_ptr(skb);
>>>>      return skb;
>>>>  }
>>>> @@ -1104,6 +1102,7 @@ err_gmac:
>>>>  static int xlr_net_remove(struct platform_device *pdev)
>>>>  {
>>>>      struct xlr_net_priv *priv = platform_get_drvdata(pdev);
>>>> +
>>>>      unregister_netdev(priv->ndev);
>>>>      mdiobus_unregister(priv->mii_bus);
>>>>      mdiobus_free(priv->mii_bus);
>>>> --
>>>> 1.9.1
>>>>
>>>
>>> ohhh .. yeah .. and both the patch failed when i tried to apply them to next-20140916
>>>
>>>
>>> why are we wasting our time for your patches , which are bound to have some problem ????
>>>
>>> thanks
>>> sudip
>>>
>>>
>>>> _______________________________________________
>>>> Kernelnewbies mailing list
>>>> Kernelnewbies at kernelnewbies.org
>>>> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>>>
>> I tried these on Greg's tree of staging-next and they worked for me.
>> Nick
> 
> in drivers/staging/netlogic/xlr_net.c file of next-20140916
> 
> 1) in line 142 we just have an "} else {"  (doesnot match your patch)
> 2) in the same file , there is only one instance of "pr_err("SKB
> allocation failed\n");" , and that is at line 208 , and that is
> followed by a "return -ENOMEM;" , but your patch is showing that there
> is a return NULL ....
> 
> thanks
> sudip
> 
Thanks Sudip,
I will fix the patch later if you want. In addition is my other patch OK or do I need to fix it still?
Nick

Checkpatch Patches

[Sudip Mukherjee]

On Tue, Sep 16, 2014 at 7:16 PM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> On Tue, Sep 16, 2014 at 7:02 PM, nick <xerofoify@gmail.com> wrote:
>>
>>
>> On 14-09-16 09:28 AM, Sudip Mukherjee wrote:
>>> On Tue, Sep 16, 2014 at 6:56 PM, nick <xerofoify@gmail.com> wrote:
>>>>
>>>>
>>>> On 14-09-16 09:21 AM, Sudip Mukherjee wrote:
>>>>> On Tue, Sep 16, 2014 at 6:41 PM, nick <xerofoify@gmail.com> wrote:
>>>>>>
>>>>>>
>>>>>> On 14-09-16 09:06 AM, Sudip Mukherjee wrote:
>>>>>>> On Tue, Sep 16, 2014 at 08:44:27AM -0400, nick wrote:
>>>>>>>> I am attaching two check patch patches I wrote in the last few days as I am unable to get a reply
>>>>>>>> from the maintainers. Would someone please send them off for me.
>>>>>>>> Thanks,
>>>>>>>> Nick
>>>>>>>
>>>>>>>> >From 7bf4229fa2f9c4fcf3243bc738c74bfdc58a6594 Mon Sep 17 00:00:00 2001
>>>>>>>> From: Nicholas Krause <xerofoify@gmail.com>
>>>>>>>> Date: Sat, 13 Sep 2014 11:53:24 -0400
>>>>>>>> Subject: [PATCH] staging wlan-ng: Add missing a blank line after declarations
>>>>>>>>
>>>>>>>> Fixing trivial checkpatch warnings about missing line after
>>>>>>>> declarations.
>>>>>>>>
>>>>>>>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>>>>>>>> ---
>>>>>>>> Tested by compilation only.
>>>>>>>>  drivers/staging/wlan-ng/hfa384x.h | 3 +++
>>>>>>>>  1 file changed, 3 insertions(+)
>>>>>>>>
>>>>>>>> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
>>>>>>>> index 1f2c78c..20d146b 100644
>>>>>>>> --- a/drivers/staging/wlan-ng/hfa384x.h
>>>>>>>> +++ b/drivers/staging/wlan-ng/hfa384x.h
>>>>>>>> @@ -1376,6 +1376,7 @@ int hfa384x_drvr_setconfig(hfa384x_t *hw, u16 rid, void *buf, u16 len);
>>>>>>>>  static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
>>>>>>>>  {
>>>>>>>>      int result = 0;
>>>>>>>> +
>>>>>>>>      result = hfa384x_drvr_getconfig(hw, rid, val, sizeof(u16));
>>>>>>>>      if (result == 0)
>>>>>>>>              *((u16 *) val) = le16_to_cpu(*((u16 *) val));
>>>>>>>> @@ -1385,6 +1386,7 @@ static inline int hfa384x_drvr_getconfig16(hfa384x_t *hw, u16 rid, void *val)
>>>>>>>>  static inline int hfa384x_drvr_setconfig16(hfa384x_t *hw, u16 rid, u16 val)
>>>>>>>>  {
>>>>>>>>      u16 value = cpu_to_le16(val);
>>>>>>>> +
>>>>>>>>      return hfa384x_drvr_setconfig(hw, rid, &value, sizeof(value));
>>>>>>>>  }
>>>>>>>> @@ -1402,6 +1404,7 @@ static inline int
>>>>>>>>  hfa384x_drvr_setconfig16_async(hfa384x_t *hw, u16 rid, u16 val)
>>>>>>>>  {
>>>>>>>>      u16 value = cpu_to_le16(val);
>>>>>>>> +
>>>>>>>>      return hfa384x_drvr_setconfig_async(hw, rid, &value, sizeof(value),
>>>>>>>>                                          NULL, NULL);
>>>>>>>>  }
>>>>>>>> 1.9.1
>>>>>>>>
>>>>>>>
>>>>>>>> >From 5eb3de22f0760ece1e838d48c8dd9148b4331cdc Mon Sep 17 00:00:00 2001
>>>>>>>> From: Nicholas Krause <xerofoify@gmail.com>
>>>>>>>> Date: Mon, 15 Sep 2014 17:07:24 -0400
>>>>>>>> Subject: [PATCH] staging netlogic: Fix checkpatch errors in xlr_net.c
>>>>>>>>
>>>>>>>> This removes the checkpatch errors related to a needed line below
>>>>>>>> declaration of a struct and another about a non nessary printk
>>>>>>>> message about a NULL allocated skb due to the function returning
>>>>>>>> NULL to the caller of the function and the printk no longer being'
>>>>>>>> used or needed by any callers.
>>>>>>>>
>>>>>>>
>>>>>>> spelling mistakes
>>>>>>>
>>>>>>>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>>>>>>>> ---
>>>>>>>>  drivers/staging/netlogic/xlr_net.c | 5 ++---
>>>>>>>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>>>>>>>
>>>>>>>> diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c
>>>>>>>> index 9bf407d..28a42831 100644
>>>>>>>> --- a/drivers/staging/netlogic/xlr_net.c
>>>>>>>> +++ b/drivers/staging/netlogic/xlr_net.c
>>>>>>>> @@ -142,10 +142,8 @@ static inline struct sk_buff *xlr_alloc_skb(void)
>>>>>>>>
>>>>>>>>      /* skb->data is cache aligned */
>>>>>>>>      skb = alloc_skb(XLR_RX_BUF_SIZE, GFP_ATOMIC);
>>>>>>>> -    if (!skb) {
>>>>>>>> -            pr_err("SKB allocation failed\n");
>>>>>>>
>>>>>>> why the error message was removed ?
>>>>>>>
>>>>>>>
>>>>>>>> +    if (!skb)
>>>>>>>>              return NULL;
>>>>>>>> -    }
>>>>>>>>      mac_put_skb_back_ptr(skb);
>>>>>>>>      return skb;
>>>>>>>>  }
>>>>>>>> @@ -1104,6 +1102,7 @@ err_gmac:
>>>>>>>>  static int xlr_net_remove(struct platform_device *pdev)
>>>>>>>>  {
>>>>>>>>      struct xlr_net_priv *priv = platform_get_drvdata(pdev);
>>>>>>>> +
>>>>>>>>      unregister_netdev(priv->ndev);
>>>>>>>>      mdiobus_unregister(priv->mii_bus);
>>>>>>>>      mdiobus_free(priv->mii_bus);
>>>>>>>> --
>>>>>>>> 1.9.1
>>>>>>>>
>>>>>>>
>>>>>>> ohhh .. yeah .. and both the patch failed when i tried to apply them to next-20140916
>>>>>>>
>>>>>>>
>>>>>>> why are we wasting our time for your patches , which are bound to have some problem ????
>>>>>>>
>>>>>>> thanks
>>>>>>> sudip
>>>>>>>
>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> Kernelnewbies mailing list
>>>>>>>> Kernelnewbies at kernelnewbies.org
>>>>>>>> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>>>>>>>
>>>>>> I tried these on Greg's tree of staging-next and they worked for me.
>>>>>> Nick
>>>>>
>>>>> in drivers/staging/netlogic/xlr_net.c file of next-20140916
>>>>>
>>>>> 1) in line 142 we just have an "} else {"  (doesnot match your patch)
>>>>> 2) in the same file , there is only one instance of "pr_err("SKB
>>>>> allocation failed\n");" , and that is at line 208 , and that is
>>>>> followed by a "return -ENOMEM;" , but your patch is showing that there
>>>>> is a return NULL ....
>>>>>
>>>>> thanks
>>>>> sudip
>>>>>
>>>> Thanks Sudip,
>>>> I will fix the patch later if you want. In addition is my other patch OK or do I need to fix it still?
>>>> Nick
>>>
>>> allow me to quote from my mail :  "ohhh .. yeah .. and both the patch
>>> failed when i tried to apply them to next-20140916 "
>>>
>>> i mentioned both ...
>>>
>> Thanks for the Help, I really do appreciate it and I do understand how much I have screwed up. My concern now is
>> now to make it right.
>> Nick
>
> and your are screwing up even more by sending these patches.

and your are screwing up even more by sending these patches.

Checkpatch Patches

[Valdis.Kletnieks at vt.edu]

On Tue, 16 Sep 2014 08:44:27 -0400, nick said:

> I am attaching two check patch patches I wrote in the last few days as I am unable to get a reply
> from the maintainers. Would someone please send them off for me.

"I am attaching".  Fail 3 words in.

That's why you aren't getting a reply from the maintainers. They don't bother
reading patches they know will probably *never* be correct.

And yes, at least one of the two patches is incorrect.

>> Thanks for the Help, I really do appreciate it and I do understand how much I have screwed up. My concern now is
>> now to make it right.

You don't make it right by posting more wrong patches. Now do us
all a favor and *stop* being either an idiot, or a troll, or whatever
your problem is.  We have *zero* desire to see *any* more patches from
somebody who is either unable or unwilling to post a *single* correct
patch after *two months* of trying.

So please do us a favor and go piss off some other open source project.

THE KERNEL DOES NOT WANT YOUR BULLSHIT.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 848 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20140916/14e5f1b2/attachment.bin 

Checkpatch Patches

[Nick Krause]

On Tue, Sep 16, 2014 at 10:19 AM,  <Valdis.Kletnieks@vt.edu> wrote:
> On Tue, 16 Sep 2014 08:44:27 -0400, nick said:
>
>> I am attaching two check patch patches I wrote in the last few days as I am unable to get a reply
>> from the maintainers. Would someone please send them off for me.
>
> "I am attaching".  Fail 3 words in.
>
> That's why you aren't getting a reply from the maintainers. They don't bother
> reading patches they know will probably *never* be correct.
>
> And yes, at least one of the two patches is incorrect.
>
>>> Thanks for the Help, I really do appreciate it and I do understand how much I have screwed up. My concern now is
>>> now to make it right.
>
> You don't make it right by posting more wrong patches. Now do us
> all a favor and *stop* being either an idiot, or a troll, or whatever
> your problem is.  We have *zero* desire to see *any* more patches from
> somebody who is either unable or unwilling to post a *single* correct
> patch after *two months* of trying.
>
> So please do us a favor and go piss off some other open source project.
>
> THE KERNEL DOES NOT WANT YOUR BULLSHIT.
>
>
>
I am going to attach it again and I understand Valdis. I am going to
talk to Sudip about reading and checking
my patches first.
Nick

Checkpatch Patches

[Carlo Caione]

On Tue, Sep 16, 2014 at 5:44 PM, Nick Krause <xerofoify@gmail.com> wrote:
> On Tue, Sep 16, 2014 at 10:19 AM,  <Valdis.Kletnieks@vt.edu> wrote:
>> On Tue, 16 Sep 2014 08:44:27 -0400, nick said:
>>
>>> I am attaching two check patch patches I wrote in the last few days as I am unable to get a reply
>>> from the maintainers. Would someone please send them off for me.
>>
>> "I am attaching".  Fail 3 words in.
>>
>> That's why you aren't getting a reply from the maintainers. They don't bother
>> reading patches they know will probably *never* be correct.
>>
>> And yes, at least one of the two patches is incorrect.
>>
>>>> Thanks for the Help, I really do appreciate it and I do understand how much I have screwed up. My concern now is
>>>> now to make it right.
>>
>> You don't make it right by posting more wrong patches. Now do us
>> all a favor and *stop* being either an idiot, or a troll, or whatever
>> your problem is.  We have *zero* desire to see *any* more patches from
>> somebody who is either unable or unwilling to post a *single* correct
>> patch after *two months* of trying.
>>
>> So please do us a favor and go piss off some other open source project.
>>
>> THE KERNEL DOES NOT WANT YOUR BULLSHIT.
>>
>>
>>
> I am going to attach it again and I understand Valdis. I am going to
> talk to Sudip about reading and checking
> my patches first.

Rik,
probably it's time to ban Nick also from this ml.

-- 
Carlo Caione

Checkpatch Patches

[Lidza Louina]

Nick,

Use this guide: http://kernelnewbies.org/OPWfirstpatch

It's a tutorial that shows you how to setup and send patches.


And memorize these references:
http://lxr.free-electrons.com/source/Documentation/SubmitChecklist
http://lxr.free-electrons.com/source/Documentation/development-process/

Lidza

On Tue, Sep 16, 2014 at 11:50 AM, Carlo Caione <carlo@caione.org> wrote:
> On Tue, Sep 16, 2014 at 5:44 PM, Nick Krause <xerofoify@gmail.com> wrote:
>> On Tue, Sep 16, 2014 at 10:19 AM,  <Valdis.Kletnieks@vt.edu> wrote:
>>> On Tue, 16 Sep 2014 08:44:27 -0400, nick said:
>>>
>>>> I am attaching two check patch patches I wrote in the last few days as I am unable to get a reply
>>>> from the maintainers. Would someone please send them off for me.
>>>
>>> "I am attaching".  Fail 3 words in.
>>>
>>> That's why you aren't getting a reply from the maintainers. They don't bother
>>> reading patches they know will probably *never* be correct.
>>>
>>> And yes, at least one of the two patches is incorrect.
>>>
>>>>> Thanks for the Help, I really do appreciate it and I do understand how much I have screwed up. My concern now is
>>>>> now to make it right.
>>>
>>> You don't make it right by posting more wrong patches. Now do us
>>> all a favor and *stop* being either an idiot, or a troll, or whatever
>>> your problem is.  We have *zero* desire to see *any* more patches from
>>> somebody who is either unable or unwilling to post a *single* correct
>>> patch after *two months* of trying.
>>>
>>> So please do us a favor and go piss off some other open source project.
>>>
>>> THE KERNEL DOES NOT WANT YOUR BULLSHIT.
>>>
>>>
>>>
>> I am going to attach it again and I understand Valdis. I am going to
>> talk to Sudip about reading and checking
>> my patches first.
>
> Rik,
> probably it's time to ban Nick also from this ml.
>
> --
> Carlo Caione
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Checkpatch Patches

[Valdis.Kletnieks at vt.edu]

On Tue, 16 Sep 2014 11:57:35 -0400, Lidza Louina said:

> Use this guide: http://kernelnewbies.org/OPWfirstpatch
>
> It's a tutorial that shows you how to setup and send patches.

Don't bother.

He's been pointed at that at least once a week for the past two months,
and everybody from me to Greg KH to Ted T'so and at least a half dozen other
experienced kernel people have told him *repeatedly* what to do and not do,
and he has *yet* to post a correct patch - and he keeps making the same
mistakes that he was told not to.  For instance, I didn't even *bother*
looking at his last two patches, because they were attachments, even *after*
Robert PJ Day told him *yesterday* to not do that.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 848 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20140916/35516a94/attachment.bin 

Checkpatch Patches

[Hugo Mills]

On Tue, Sep 16, 2014 at 11:44:59AM -0400, Nick Krause wrote:
> On Tue, Sep 16, 2014 at 10:19 AM,  <Valdis.Kletnieks@vt.edu> wrote:
> > On Tue, 16 Sep 2014 08:44:27 -0400, nick said:
> >
> >> I am attaching two check patch patches I wrote in the last few days as I am unable to get a reply
> >> from the maintainers. Would someone please send them off for me.
> >
> > "I am attaching".  Fail 3 words in.
[snip]
> I am going to attach it again and I understand Valdis. I am going to
> talk to Sudip about reading and checking
> my patches first.

    The email that you are replying to repeats the statement that
attaching the patches is the wrong thing to be doing. And yet, in the
reply, you talk about attaching patches.

   Can you please explain what's going on here?

   Did you forget about it while you were writing the three line
response? Did you simply ignore the words? Did you assume that it
didn't apply to you? Did you merely think it wasn't important? Do you
have short-term memory problems? Is there something else I don't know
about?

   I understand that you're a student (or will shortly be one), and so
far you're showing *major* learning difficulties, without any apparent
self-identification of the fact. If you do actually have some kind of
learning difficulty, you're going to have to take charge of it
yourself, seek professional advice, use that to work out how you can
learn, and start doing it, because if you behave like this in any
institution of higher learning, you're going to have big problems,
probably very quickly. 

   You've spent two months, with *lots* of explicit recommendations on
how you should be modifying your behaviour (i.e. learning), and so far
you've utterly failed to do so. It's up to you to seek help in
identifying the difficulties you have in learning, and to use the
results of that to work out how you can do so. This kernel development
environment is *absolutely* the wrong one for you to be doing that
exercise in. I doubt that there are many (if any) people on this
mailing list who have the knowledge or skills to help you. I am
certain that if there are any, none of them would be willing to start
the process via email.

   Hugo.

-- 
=== Hugo Mills: hugo at ... carfax.org.uk | darksatanic.net | lug.org.uk ===
  PGP key: 65E74AC0 from wwwkeys.eu.pgp.net or http://www.carfax.org.uk
      --- "Big data" doesn't just mean increasing the font size ---      
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: Digital signature
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20140916/c98cfc1c/attachment.bin 

Checkpatch Patches

[Robert P. J. Day]

On Tue, 16 Sep 2014, Lidza Louina wrote:

> Nick,
>
> Use this guide: http://kernelnewbies.org/OPWfirstpatch
>
> It's a tutorial that shows you how to setup and send patches.
>
>
> And memorize these references:
> http://lxr.free-electrons.com/source/Documentation/SubmitChecklist
> http://lxr.free-electrons.com/source/Documentation/development-process/
>
> Lidza

  i'm going to back up carlo ... time to ban nick as i suggested a
while back. giving nick more references is not going to help -- he is
simply unteachable.

  in a nutshell, nick brings no value to this mailing list. quite the
opposite -- he devalues it significantly by wasting bandwidth and just
plain pissing people off. all by himself, nick makes this mailing list
a worse place.

  if nick showed any sign of progress whatsoever, that would be
different. but he doesn't. so, please, pull the plug on him.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Checkpatch Patches

[Robert P. J. Day]

On Tue, 16 Sep 2014, Valdis.Kletnieks at vt.edu wrote:

> On Tue, 16 Sep 2014 11:57:35 -0400, Lidza Louina said:
>
> > Use this guide: http://kernelnewbies.org/OPWfirstpatch
> >
> > It's a tutorial that shows you how to setup and send patches.
>
> Don't bother.
>
> He's been pointed at that at least once a week for the past two months,
> and everybody from me to Greg KH to Ted T'so and at least a half dozen other
> experienced kernel people have told him *repeatedly* what to do and not do,
> and he has *yet* to post a correct patch - and he keeps making the same
> mistakes that he was told not to.  For instance, I didn't even *bother*
> looking at his last two patches, because they were attachments, even *after*
> Robert PJ Day told him *yesterday* to not do that.

  i posted three simple pieces of advice yesterday:

  * proper grammar, at the very least in the subject line
  * make sure the commit description matches the patch
  * no attachments

nick promptly violated all of the above.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Checkpatch Patches

[Sudip Mukherjee]

On 9/16/14, Nick Krause <xerofoify@gmail.com> wrote:
> On Tue, Sep 16, 2014 at 10:19 AM,  <Valdis.Kletnieks@vt.edu> wrote:
>> On Tue, 16 Sep 2014 08:44:27 -0400, nick said:
>>
>>> I am attaching two check patch patches I wrote in the last few days as I
>>> am unable to get a reply
>>> from the maintainers. Would someone please send them off for me.
>>
>> "I am attaching".  Fail 3 words in.
>>
>> That's why you aren't getting a reply from the maintainers. They don't
>> bother
>> reading patches they know will probably *never* be correct.
>>
>> And yes, at least one of the two patches is incorrect.
>>
>>>> Thanks for the Help, I really do appreciate it and I do understand how
>>>> much I have screwed up. My concern now is
>>>> now to make it right.
>>
>> You don't make it right by posting more wrong patches. Now do us
>> all a favor and *stop* being either an idiot, or a troll, or whatever
>> your problem is.  We have *zero* desire to see *any* more patches from
>> somebody who is either unable or unwilling to post a *single* correct
>> patch after *two months* of trying.
>>
>> So please do us a favor and go piss off some other open source project.
>>
>> THE KERNEL DOES NOT WANT YOUR BULLSHIT.
>>
>>
>>
> I am going to attach it again and I understand Valdis. I am going to
> talk to Sudip about reading and checking
> my patches first.
> Nick
>

plzzz .. NO ...
today i checked your patches just to take a break from what i was doing..
and besides , i am also a newbie , i also make mistakes when
submitting patches, but i try to learn from my mistakes and see to it
that they are never repeated.
apart from the numerous advises you got from the LKML , i think just
yesterday Robert P. J. Day has pointed out something, day before
yesterday Valdis , before that ( sorry i lost track)  ... and you have
not cared to listen to any of that ..



> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>

Checkpatch Patches

[Nick Krause]

On Tue, Sep 16, 2014 at 12:57 PM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> On 9/16/14, Nick Krause <xerofoify@gmail.com> wrote:
>> On Tue, Sep 16, 2014 at 10:19 AM,  <Valdis.Kletnieks@vt.edu> wrote:
>>> On Tue, 16 Sep 2014 08:44:27 -0400, nick said:
>>>
>>>> I am attaching two check patch patches I wrote in the last few days as I
>>>> am unable to get a reply
>>>> from the maintainers. Would someone please send them off for me.
>>>
>>> "I am attaching".  Fail 3 words in.
>>>
>>> That's why you aren't getting a reply from the maintainers. They don't
>>> bother
>>> reading patches they know will probably *never* be correct.
>>>
>>> And yes, at least one of the two patches is incorrect.
>>>
>>>>> Thanks for the Help, I really do appreciate it and I do understand how
>>>>> much I have screwed up. My concern now is
>>>>> now to make it right.
>>>
>>> You don't make it right by posting more wrong patches. Now do us
>>> all a favor and *stop* being either an idiot, or a troll, or whatever
>>> your problem is.  We have *zero* desire to see *any* more patches from
>>> somebody who is either unable or unwilling to post a *single* correct
>>> patch after *two months* of trying.
>>>
>>> So please do us a favor and go piss off some other open source project.
>>>
>>> THE KERNEL DOES NOT WANT YOUR BULLSHIT.
>>>
>>>
>>>
>> I am going to attach it again and I understand Valdis. I am going to
>> talk to Sudip about reading and checking
>> my patches first.
>> Nick
>>
>
> plzzz .. NO ...
> today i checked your patches just to take a break from what i was doing..
> and besides , i am also a newbie , i also make mistakes when
> submitting patches, but i try to learn from my mistakes and see to it
> that they are never repeated.
> apart from the numerous advises you got from the LKML , i think just
> yesterday Robert P. J. Day has pointed out something, day before
> yesterday Valdis , before that ( sorry i lost track)  ... and you have
> not cared to listen to any of that ..
>
>
>
>> _______________________________________________
>> Kernelnewbies mailing list
>> Kernelnewbies at kernelnewbies.org
>> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>>
I am going to resend my patch and see if it's good and if not I am
going to leave for a while.
Nick

Checkpatch Patches

[Robert P. J. Day]

On Tue, 16 Sep 2014, Nick Krause wrote:

> I am going to resend my patch and see if it's good ...

  because, of course, that's the correct order of events -- send the
patch, *then* validate its correctness.

  ban. for the love of mutt, please, ban. there is no excuse for this
anymore.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Checkpatch Patches

[Valdis.Kletnieks at vt.edu]

On Tue, 16 Sep 2014 13:12:32 -0400, Nick Krause said:
> I am going to resend my patch and see if it's good

Why bother? We already *know* it won't be.

You could amaze and astound us all by seeing if it's good *before* you hit send.
But I'm not holding my breath.

> and if not I am going to leave for a while.

Actions. Not words.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 848 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20140916/4649e626/attachment.bin 

Checkpatch Patches

[Rik van Riel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/16/2014 01:12 PM, Nick Krause wrote:

> I am going to resend my patch and see if it's good and if not I am 
> going to leave for a while.

You may want to consider fixing them, by applying the advice
provided by many people, before resending them.

- -- 
All rights reversed.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUGHMmAAoJEM553pKExN6Dvw4IAKi2no5OpH9TUgcCd5zRHTsb
oqFsZ2xR21bgnIyfM93V+h9QtG+Fuc+WOScCL1Ofk4OWVXWV6gIgHHSGBOb0cEBf
zGTxhMyRdPUl7WHAn7KHWAEqhCGQlIp0QyyRiXjnNLmSmGYt/9yv3TrvmZE0xuJw
/jrq+H93AxTXXVzIjfpnziXMD5w3/Zt9+FPlyuNjyVh2Hnlf2CbwfSqsgsJETZOx
ML+CNsl/2CAXkJ1++CUQ94iC4plAPekVrpXAea4xqWqargD8Hcm0jqWuD9vns0ZA
VDJU669ocBlZRVCdZI6axGm4JAdtceQLLMMVZtzre8IAELB9JPiUC/C6g7e60Cg=
=oeV3
-----END PGP SIGNATURE-----

Checkpatch Patches

[Valdis.Kletnieks at vt.edu]

On Tue, 16 Sep 2014 13:28:06 -0400, Rik van Riel said:
> -----BEGIN PGP SIGNED MESSAGE-----

> On 09/16/2014 01:12 PM, Nick Krause wrote:
>
> > I am going to resend my patch and see if it's good and if not I am
> > going to leave for a while.
>
> You may want to consider fixing them, by applying the advice
> provided by many people, before resending them.

That's just crazy talk.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 848 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20140916/88fb3e88/attachment.bin 

Checkpatch Patches

[Nick Krause]

On Tue, Sep 16, 2014 at 1:39 PM,  <Valdis.Kletnieks@vt.edu> wrote:
> On Tue, 16 Sep 2014 13:28:06 -0400, Rik van Riel said:
>> -----BEGIN PGP SIGNED MESSAGE-----
>
>> On 09/16/2014 01:12 PM, Nick Krause wrote:
>>
>> > I am going to resend my patch and see if it's good and if not I am
>> > going to leave for a while.
>>
>> You may want to consider fixing them, by applying the advice
>> provided by many people, before resending them.
>
> That's just crazy talk.
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>
I am fixing them first and them sending them out. I am going to listen now and
only do them correctly.
Nick

Checkpatch Patches

[Kristofer Hallin]

On Tue, Sep 16, 2014 at 8:29 PM, Nick Krause <xerofoify@gmail.com> wrote:
> On Tue, Sep 16, 2014 at 1:39 PM,  <Valdis.Kletnieks@vt.edu> wrote:
>> On Tue, 16 Sep 2014 13:28:06 -0400, Rik van Riel said:
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>
>>> On 09/16/2014 01:12 PM, Nick Krause wrote:
>>>
>>> > I am going to resend my patch and see if it's good and if not I am
>>> > going to leave for a while.
>>>
>>> You may want to consider fixing them, by applying the advice
>>> provided by many people, before resending them.
>>
>> That's just crazy talk.
>>
>> _______________________________________________
>> Kernelnewbies mailing list
>> Kernelnewbies at kernelnewbies.org
>> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
>>
> I am fixing them first and them sending them out. I am going to listen now and
> only do them correctly.
> Nick
>

No, you won't.

> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Checkpatch Patches

[Rik van Riel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/16/2014 02:36 PM, Kristofer Hallin wrote:
> On Tue, Sep 16, 2014 at 8:29 PM, Nick Krause <xerofoify@gmail.com>
> wrote:
>> On Tue, Sep 16, 2014 at 1:39 PM,  <Valdis.Kletnieks@vt.edu>
>> wrote:
>>> On Tue, 16 Sep 2014 13:28:06 -0400, Rik van Riel said:
>>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> 
>>>> On 09/16/2014 01:12 PM, Nick Krause wrote:
>>>> 
>>>>> I am going to resend my patch and see if it's good and if
>>>>> not I am going to leave for a while.
>>>> 
>>>> You may want to consider fixing them, by applying the advice 
>>>> provided by many people, before resending them.
>>> 
>>> That's just crazy talk.
>> 
>> I am fixing them first and them sending them out. I am going to
>> listen now and only do them correctly. Nick
> 
> No, you won't.

Nick,

this is a chance for you to prove the nay-sayers wrong (or right).

When re-posting your patch, you can include information on what tips
you got on how to improve the patch, and how you applied that
information in the new version of the patch.

This is a good idea for anybody resubmitting a changed patch, because
it tells other reviewers what changes were made, why, and who pointed
out the idea for the change.

- -- 
All rights reversed.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUGIUeAAoJEM553pKExN6DEt8H/36FILPmG4wOK3TZFpQEVJHv
Lxq4DLq7GBUS37PhL/wjdYnLD4RJmOhpGk+FlZBhJ0StnCvS38Su7wwyZTzgCPIS
ir3EYOKhiFgEEuoB4iVaDc2FNv9jKKRVy/QK3jwkdt5oTBvr/I6YZzj2XAFJaUp9
0/RvdSNZU6kcvhTkd5xdDaaX1iOpxrggccRl+Pv2GBapeIEKvO6zk9U2GuLw+r6q
OLfJ5BElpEReoqFJNUXxzT+UyTmMel21REdfyu9UxAEONrQ2A3UHx/7upy71YpyR
a/IADIuBSXTdb31b+uuoFPfSUp4cs7WMyIDK2/tlL8wF28GLoL39X2xhWE3gkUU=
=7mL1
-----END PGP SIGNATURE-----

Checkpatch Patches

[Mandeep Sandhu]

> I am fixing them first and them sending them out. I am going to listen now and
> only do them correctly.

Nick, you're very close to being banned from kernelnewbies too, so
please give some thought to other people's advise or else this might
be your last email to kernelnewbies.

As a first step, DON'T send patches as attachments, send them INLINE
in PLAIN TEXT. You need to demonstrate an understanding of this basic
instruction or else nobody will be able to help you. And frankly, you
need to stop fixing anything in the kernel till you get some level of
proficiency in basic programming and working collaboratively in
opensource projects.

> Nick
>
> _______________________________________________
> Kernelnewbies mailing list
> Kernelnewbies at kernelnewbies.org
> http://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Checkpatch Patches

[Robert P. J. Day]

On Tue, 16 Sep 2014, Rik van Riel wrote:

> Nick,
>
> this is a chance for you to prove the nay-sayers wrong (or right).
>
> When re-posting your patch, you can include information on what tips
> you got on how to improve the patch, and how you applied that
> information in the new version of the patch.
>
> This is a good idea for anybody resubmitting a changed patch,
> because it tells other reviewers what changes were made, why, and
> who pointed out the idea for the change.

  my god, rik, you're adorable. :-) i predict that, despite what i've
posted *twice*, nick will describe as an "error" what is simply a
checkpatch coding style *warning*. let's watch ...

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================