From: Linus Walleij <linus.walleij@linaro.org> To: Leo Yan <leo.yan@linaro.org> Cc: Guodong Xu <guodong.xu@linaro.org>, Xu Wei <xuwei5@hisilicon.com>, Mark Rutland <mark.rutland@arm.com>, Rob Herring <robh@kernel.org>, Grant Likely <grant.likely@secretlab.ca>, Arnd Bergmann <arnd.bergmann@linaro.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, XinWei Kong <kong.kongxinwei@hisilicon.com> Subject: Re: [PATCH v2 02/16] arm64: dts: add sp804 timer node for Hi6220 Date: Mon, 4 Apr 2016 13:21:00 +0200 [thread overview] Message-ID: <CACRpkdZ=_86Rhc+ei+3uE0dda9+onC8pQwosheMfEj4tOqmcDA@mail.gmail.com> (raw) In-Reply-To: <20160404014359.GA15178@leoy-linaro> On Mon, Apr 4, 2016 at 3:43 AM, Leo Yan <leo.yan@linaro.org> wrote: > On Sun, Apr 03, 2016 at 09:23:42PM +0200, Linus Walleij wrote: >> On Sat, Apr 2, 2016 at 11:29 AM, Guodong Xu <guodong.xu@linaro.org> wrote: >> By chance the code in the driver will allow just one clock and >> will then assume that both the bus to the timer and the timer >> itself is clocked from the same clock. But I highly doubt that this >> is the case. > > This patch has been sent out for review previously [1]; So I refered > other platforms and changed to only enable apb bus clock due I have > not found timer enabling bits in Hi6220's spec. This is not about enabling/disabling the clock(s) to the timer. It doesn't matter if these clocks are always on. It is about determining the *frequency* of the timers. It is vital that the timer driver get the right frequency of the clock to the block from the clock implementation, and I do not think it is the same as the "apb_pclk". The thing is that of course "any frequency" will work but what you will notice is that the timer runs very weirdly compared to wall-clock time unless the right clock yielding the right frequency has been specified here. Yours, Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 02/16] arm64: dts: add sp804 timer node for Hi6220 Date: Mon, 4 Apr 2016 13:21:00 +0200 [thread overview] Message-ID: <CACRpkdZ=_86Rhc+ei+3uE0dda9+onC8pQwosheMfEj4tOqmcDA@mail.gmail.com> (raw) In-Reply-To: <20160404014359.GA15178@leoy-linaro> On Mon, Apr 4, 2016 at 3:43 AM, Leo Yan <leo.yan@linaro.org> wrote: > On Sun, Apr 03, 2016 at 09:23:42PM +0200, Linus Walleij wrote: >> On Sat, Apr 2, 2016 at 11:29 AM, Guodong Xu <guodong.xu@linaro.org> wrote: >> By chance the code in the driver will allow just one clock and >> will then assume that both the bus to the timer and the timer >> itself is clocked from the same clock. But I highly doubt that this >> is the case. > > This patch has been sent out for review previously [1]; So I refered > other platforms and changed to only enable apb bus clock due I have > not found timer enabling bits in Hi6220's spec. This is not about enabling/disabling the clock(s) to the timer. It doesn't matter if these clocks are always on. It is about determining the *frequency* of the timers. It is vital that the timer driver get the right frequency of the clock to the block from the clock implementation, and I do not think it is the same as the "apb_pclk". The thing is that of course "any frequency" will work but what you will notice is that the timer runs very weirdly compared to wall-clock time unless the right clock yielding the right frequency has been specified here. Yours, Linus Walleij
next prev parent reply other threads:[~2016-04-04 11:21 UTC|newest] Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-02 9:29 [PATCH v2 00/16] DTS for hi6220 and HiKey Guodong Xu 2016-04-02 9:29 ` Guodong Xu 2016-04-02 9:29 ` [PATCH v2 01/16] arm64: dts: Reserve memory regions for hi6220 Guodong Xu 2016-04-02 9:29 ` Guodong Xu 2016-04-02 9:29 ` [PATCH v2 02/16] arm64: dts: add sp804 timer node for Hi6220 Guodong Xu 2016-04-02 9:29 ` Guodong Xu 2016-04-03 19:23 ` Linus Walleij 2016-04-03 19:23 ` Linus Walleij 2016-04-03 19:23 ` Linus Walleij 2016-04-04 1:43 ` Leo Yan 2016-04-04 1:43 ` Leo Yan 2016-04-04 1:43 ` Leo Yan 2016-04-04 11:21 ` Linus Walleij [this message] 2016-04-04 11:21 ` Linus Walleij 2016-04-04 11:21 ` Linus Walleij 2016-04-04 13:42 ` Leo Yan 2016-04-04 13:42 ` Leo Yan 2016-04-04 13:42 ` Leo Yan 2016-04-04 13:53 ` Linus Walleij 2016-04-04 13:53 ` Linus Walleij 2016-04-04 13:53 ` Linus Walleij 2016-04-04 14:03 ` Leo Yan 2016-04-04 14:03 ` Leo Yan 2016-04-04 14:03 ` Leo Yan 2016-04-04 5:16 ` Rob Herring 2016-04-04 5:16 ` Rob Herring 2016-04-04 5:16 ` Rob Herring 2016-04-02 9:29 ` [PATCH v2 03/16] arm64: dts: enable idle states " Guodong Xu 2016-04-02 9:29 ` Guodong Xu 2016-04-02 9:29 ` Guodong Xu 2016-04-02 9:29 ` [PATCH v2 04/16] arm64: dts: Add Hi6220 gpio configuration nodes Guodong Xu 2016-04-02 9:29 ` Guodong Xu 2016-04-03 19:28 ` Linus Walleij 2016-04-03 19:28 ` Linus Walleij 2016-04-03 19:28 ` Linus Walleij 2016-04-12 9:18 ` Guodong Xu 2016-04-12 9:18 ` Guodong Xu 2016-04-12 9:18 ` Guodong Xu 2016-04-02 9:29 ` [PATCH v2 05/16] arm64: dts: add Hi6220 pinctrl " Guodong Xu 2016-04-02 9:29 ` Guodong Xu 2016-04-03 19:31 ` Linus Walleij 2016-04-03 19:31 ` Linus Walleij 2016-04-03 19:31 ` Linus Walleij 2016-04-04 22:54 ` Tony Lindgren 2016-04-04 22:54 ` Tony Lindgren 2016-04-04 22:54 ` Tony Lindgren 2016-04-12 8:28 ` Guodong Xu 2016-04-02 9:29 ` [PATCH v2 06/16] arm64: dts: add Hi6220 spi " Guodong Xu 2016-04-02 9:29 ` Guodong Xu 2016-04-04 5:16 ` Rob Herring 2016-04-04 5:16 ` Rob Herring 2016-04-12 9:40 ` Guodong Xu 2016-04-12 9:40 ` Guodong Xu 2016-04-12 9:40 ` Guodong Xu 2016-04-02 9:29 ` [PATCH v2 07/16] arm64: dts: add all hi6220 i2c nodes Guodong Xu 2016-04-02 9:29 ` Guodong Xu 2016-04-02 9:29 ` [PATCH v2 08/16] arm64: dts: hikey: enable i2c0 and i2c1 for working with mezzanine boards Guodong Xu 2016-04-02 9:29 ` Guodong Xu 2016-04-04 5:16 ` Rob Herring 2016-04-04 5:16 ` Rob Herring 2016-04-02 9:29 ` [PATCH v2 09/16] arm64: dts: add hi6220 usb node Guodong Xu 2016-04-02 9:29 ` Guodong Xu 2016-04-02 9:29 ` Guodong Xu 2016-04-02 9:29 ` [PATCH v2 10/16] arm64: dts: add mailbox node for Hi6220 Guodong Xu 2016-04-02 9:29 ` Guodong Xu 2016-04-02 9:29 ` [PATCH v2 11/16] arm64: dts: add Hi6220's stub clock node Guodong Xu 2016-04-02 9:29 ` Guodong Xu 2016-04-02 9:29 ` [PATCH v2 12/16] arm64: dts: hi6220: add pinctrl for uarts and enable them Guodong Xu 2016-04-02 9:29 ` Guodong Xu 2016-04-02 9:29 ` Guodong Xu 2016-04-02 9:29 ` [PATCH v2 13/16] arm64: dts: add LED nodes for hi6220-hikey Guodong Xu 2016-04-02 9:29 ` Guodong Xu 2016-04-04 5:16 ` Rob Herring 2016-04-04 5:16 ` Rob Herring 2016-04-02 9:29 ` [PATCH v2 14/16] arm64: dts: hikey: Add hi655x pmic dts node Guodong Xu 2016-04-02 9:29 ` Guodong Xu 2016-04-04 5:16 ` Rob Herring 2016-04-04 5:16 ` Rob Herring 2016-04-12 13:14 ` Guodong Xu 2016-04-12 13:14 ` Guodong Xu 2016-04-12 13:14 ` Guodong Xu 2016-04-02 9:29 ` [PATCH v2 15/16] arm64: dts: add dwmmc nodes for hi6220 Guodong Xu 2016-04-02 9:29 ` Guodong Xu 2016-04-02 9:29 ` [PATCH v2 16/16] arm64: dts: add wifi nodes support for hi6220-hikey Guodong Xu 2016-04-02 9:29 ` Guodong Xu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CACRpkdZ=_86Rhc+ei+3uE0dda9+onC8pQwosheMfEj4tOqmcDA@mail.gmail.com' \ --to=linus.walleij@linaro.org \ --cc=arnd.bergmann@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=grant.likely@secretlab.ca \ --cc=guodong.xu@linaro.org \ --cc=kong.kongxinwei@hisilicon.com \ --cc=leo.yan@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh@kernel.org \ --cc=xuwei5@hisilicon.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.